ab_panel 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67ea749f4f2e80710669492d90f163ace7311dd0
-  data.tar.gz: e6f8ffea1418b0c80754c011160a09accaeb8a3e
+  metadata.gz: 144fbca692f2d9614fadb10c5c45553461634bd4
+  data.tar.gz: b530647a28d261a8166fccf482a993f860de7e52
 SHA512:
-  metadata.gz: ec2cffaf2212c588187af99829e85450cb82396229fa9cdeaa40d8c0b467b8f98068206b1720ed927ae48d7950a328c351161f2cce61f320e22dd63478a1fb2a
-  data.tar.gz: 351f325f654bd72fd5993cff00ea767873f7ba211091a4e718243a1fc7c7a66942477c5cc5b5b66bfa193b9133d8647dbad73a5ebfb4b5b1bbf0b1b8bc5701f1
+  metadata.gz: 23054af6d145e67ddddc1a07948d58e9a5b1036e75ee48c8a63c08621f7ffb81ed2ad9aa7c600e5f2bbfa5b80f7f83b696aa2cfc7c0eb04c8e50da51e2253888
+  data.tar.gz: 6f4d8f61cb18b5843d3dc3effbceeff712cc389a68f493822823ca34a048916afff1e3d8e13c33c7bf6535bb9364a9e0ec60ec1e6824dbd4ba79ea5ca48b8f3c

data/example/app/controllers/posts_controller.rb

@@ -11,12 +11,12 @@ class PostsController < ApplicationController
   def show
     @post = Post.find(params[:id])
 
+    track_action '[visits] post', post_id: @post.id
+
     respond_to do |format|
       format.html
       format.json { render json: @post }
     end
-
-    track_action '[visits] post', :post => :id
   end
 
   def new
@@ -69,4 +69,11 @@ class PostsController < ApplicationController
       format.json { head :no_content }
     end
   end
+
+  # Useful for testing if every event gets tracked when using persist: true.
+  def redirect
+    @post = Post.find(params[:id])
+    track_action '[redirects] post', post_id: @post.id
+    redirect_to @post
+  end
 end

data/example/config/routes.rb

@@ -1,5 +1,7 @@
 Example::Application.routes.draw do
-  resources :posts
+  resources :posts do
+    get :redirect, on: :member
+  end
 
   # The priority is based upon order of creation:
   # first created -> highest priority.

data/lib/ab_panel/controller_additions.rb

@@ -55,7 +55,7 @@ module AbPanel
 
       {
         'distinct_id' => distinct_id,
-        'rack.session' => request['rack.session'],
+        'rack.session' => request.env['rack.session'],
         'ip' => request.remote_ip
       }.each do |key, value|
         AbPanel.set_env(key, value)
@@ -70,13 +70,11 @@ module AbPanel
     # Example:
     #
     #   def show
-    #     track_action '[visits] Course', { :course => :id }
+    #     track_action '[visits] Course', { :course_id => @course.id }
     #   end
     #
     # This will track the event with the given name on CoursesController#show
-    # and assign an options hash:
-    #
-    #   { 'course_id' => @course.id }
+    # with the passed in attributes.
     def track_action(name, properties = {})
       AbPanel.add_funnel(properties.delete(:funnel))
 
@@ -84,7 +82,7 @@ module AbPanel
         distinct_id: distinct_id,
         ip:          request.remote_ip,
         time:        Time.now.utc,
-      }
+      }.merge(properties)
 
       AbPanel.funnels.each do |funnel|
         options["funnel_#{funnel}"] = true
@@ -94,27 +92,11 @@ module AbPanel
         options[exp] = AbPanel.conditions.send(exp).condition rescue nil
       end
 
-      properties.each do |key, val|
-        if respond_to?(key)
-          inst = send(key)
-        elsif instance_variable_defined?("@#{key}")
-          inst = instance_variable_get("@#{key}")
-        else
-          options[key] = val
-          next
-        end
-
-        val = *val
-
-        val.each do |m|
-          options["#{key}_#{m}"] = inst.send(m)
-        end
-      end
+      options.merge!(ab_panel_options)
+      AbPanel.set_env(:properties, options)
 
       AbPanel.identify(distinct_id)
       AbPanel.track(name, options.merge(ab_panel_options))
-
-      session['mixpanel_events'] ||= AbPanel.env['rack.session']['mixpanel_events'] rescue []
     end
   end
 end

data/lib/ab_panel/javascript.rb

@@ -1,11 +1,14 @@
 module AbPanel
   class Javascript
     def self.environment
-      props = { distinct_id: AbPanel.env["distinct_id"] }
+      props = {
+        distinct_id: AbPanel.env["distinct_id"]
+      }.merge(AbPanel.env[:properties])
 
       AbPanel.funnels.each { |f| props["funnel_#{f}"] = true }
 
       AbPanel.experiments.each { |exp| props[exp] = AbPanel.conditions.send(exp).condition }
+
       props.to_json
     end
   end

data/lib/ab_panel/version.rb

@@ -1,3 +1,3 @@
 module AbPanel
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ab_panel
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Wouter de Vos
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-18 00:00:00.000000000 Z
+date: 2013-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler