ab_panel 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ca41b9170ae4617dee1623e58c77c4964d71caa
-  data.tar.gz: b0a191f70c30e6efd7521cfbfde7b0acf79872ca
+  metadata.gz: 67ea749f4f2e80710669492d90f163ace7311dd0
+  data.tar.gz: e6f8ffea1418b0c80754c011160a09accaeb8a3e
 SHA512:
-  metadata.gz: bb555a360068bcbda0cd7242c97d93e58f2e81f55bf2752454bd5cd65a69bb8f92359e31e3807441e894a2bdcddb775aca292cc0ea5a9f9298c382536816baf7
-  data.tar.gz: 05a0bc19937ba1266539051a49ec892369cdebd2b20c37fd19af6eb4bcd13f7367d87f424ce18352789e58814e1d76662fccdfa900409da77b4524ab561aa8e1
+  metadata.gz: ec2cffaf2212c588187af99829e85450cb82396229fa9cdeaa40d8c0b467b8f98068206b1720ed927ae48d7950a328c351161f2cce61f320e22dd63478a1fb2a
+  data.tar.gz: 351f325f654bd72fd5993cff00ea767873f7ba211091a4e718243a1fc7c7a66942477c5cc5b5b66bfa193b9133d8647dbad73a5ebfb4b5b1bbf0b1b8bc5701f1

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
+script: 'bundle exec rspec spec'
 rvm:
   - 1.9.3
   - 2.0.0

data/lib/ab_panel/controller_additions.rb

@@ -50,6 +50,8 @@ module AbPanel
       AbPanel.reset!
       AbPanel.conditions = session['ab_panel_conditions']
       session['ab_panel_conditions'] = AbPanel.conditions
+      AbPanel.funnels = session['ab_panel_funnels']
+      session['ab_panel_funnels'] = AbPanel.funnels
 
       {
         'distinct_id' => distinct_id,
@@ -76,8 +78,7 @@ module AbPanel
     #
     #   { 'course_id' => @course.id }
     def track_action(name, properties = {})
-      funnel = properties.delete(:funnel)
-      AbPanel.funnels << funnel if funnel.present?
+      AbPanel.add_funnel(properties.delete(:funnel))
 
       options = {
         distinct_id: distinct_id,

data/lib/ab_panel/version.rb

@@ -1,3 +1,3 @@
 module AbPanel
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/ab_panel.rb

@@ -1,3 +1,4 @@
+require 'set'
 Dir[File.expand_path(File.join(
   File.dirname(__FILE__),'ab_panel','**','*.rb'))]
     .each {|f| require f}
@@ -52,7 +53,15 @@ module AbPanel
     end
 
     def funnels
-      env['funnels'] ||= []
+      env['funnels'] ||= Set.new
+    end
+
+    def funnels=(funnels)
+      env['funnels'] = funnels
+    end
+
+    def add_funnel(funnel)
+      funnels.add(funnel) if funnel.present?
     end
 
     private # ----------------------------------------------------------------------------

data/spec/ab_panel/controller_additions_spec.rb

@@ -11,8 +11,8 @@ end
 describe AbPanel::ControllerAdditions do
   let(:controller) { Controller.new }
 
-  describe "#ab_panel_id" do
-    subject { controller.ab_panel_id }
+  describe "#distinct_id" do
+    subject { controller.distinct_id }
 
     it { should match /^([A-Z]|[0-9])([A-Z]|[0-9])([A-Z]|[0-9])([A-Z]|[0-9])([A-Z]|[0-9])$/ }
   end

data/spec/ab_panel_spec.rb

@@ -45,4 +45,32 @@ describe AbPanel do
       it { conditions.reject{|c| c}.size.should be 3 }
     end
   end
+
+  describe ".funnels" do
+    after do
+      AbPanel.funnels = nil
+    end
+
+    it 'adds a funnel' do
+      AbPanel.add_funnel('search')
+      AbPanel.funnels.to_a.should == ['search']
+    end
+
+    it 'only adds a funnel when present' do
+      AbPanel.add_funnel(nil)
+      AbPanel.funnels.to_a.should == []
+    end
+
+    it 'does not add a funnel twice' do
+      AbPanel.add_funnel('search')
+      AbPanel.add_funnel('search')
+      AbPanel.funnels.to_a.should == ['search']
+    end
+
+    it 'sets funnels' do
+      funnels = Set.new ['search', 'cta']
+      AbPanel.funnels = funnels
+      AbPanel.funnels.to_a.should == funnels.to_a
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ab_panel
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Wouter de Vos
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-10 00:00:00.000000000 Z
+date: 2013-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler