aasm 5.2.0 → 5.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e3ec7032fd9c8368ddfb4bed4e931edc5f9d96c02a69f89f7ee26913f7d8698
-  data.tar.gz: ddb4ef39501440da1869426eda3b4359e37eeef67b464c9e0d660e9f353510f6
+  metadata.gz: 442f7c145e97a545e9dd1cd5ecab268177b93deb0b258ab381107f1207fe9654
+  data.tar.gz: 1d32640b0bfab501acc40b10f7d21be342944ed133086d44ccb924f03485f3b8
 SHA512:
-  metadata.gz: c294de071cad6569f855af1455c9d0281622ca5c9a3df0466baacaca569d8974718eb46d4c06e674f54629a77e2634d69829ee2910612ba146b4aaf786891544
-  data.tar.gz: a7b0c176cec262ad9d89538fe43e6df484f4d79328f85e853dcc9fe6b6ce9a9629f802e7de14659e5c91135a3a4df09a6066011983b1936eff06b17657c24cc5
+  metadata.gz: be33b17c558b289c012f25ccbed984cd3b2859e14a5120bf240020eb2d83c2645834784e5bc50dac0e5a3f161f13f3d85c2a29dcefcce694be395b604676ef32
+  data.tar.gz: 87668c8a48a9cf0335a4359970e868758a25398e2af8fb025ab9dd39db2a89147f0fad25fee9c11e1da9522fbeca6595f5363318b8baf2b7625ee1b88f3d8b80

data/.github/workflows/build.yml

@@ -0,0 +1,100 @@
+name: Tests
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  build:
+    if: "contains(github.event.commits[0].message, '[ci skip]') == false"
+    continue-on-error: ${{ matrix.allow_failure || false }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-20.04]
+        ruby: ['3.0', 2.7, 2.6, jruby-9.1.17.0, truffleruby]
+        gemfile: [norails, rails_4.2, rails_4.2_mongoid_5, rails_5.2, rails_6.1]
+        redis-version: [6]
+        mongodb-version: [5]
+        include:
+          - ruby: '3.0'
+            gemfile: rails_6.1
+            os: ubuntu-20.04
+            redis-version: 6
+            mongodb-version: 5
+          - ruby: 3.1
+            gemfile: rails_7.0
+            os: ubuntu-20.04
+            redis-version: 6
+            mongodb-version: 5
+        exclude:
+        - ruby: '3.0'
+          gemfile: rails_5.2
+        - ruby: '3.0'
+          gemfile: rails_4.2
+        - ruby: '3.0'
+          gemfile: rails_4.2_mongoid_5
+        - ruby: 2.7
+          gemfile: rails_5.2
+        - ruby: 2.7
+          gemfile: rails_4.2
+        - ruby: 2.7
+          gemfile: rails_4.2_mongoid_5
+        - ruby: 2.6
+          gemfile: rails_4.2_mongoid_5
+        - ruby: 2.6
+          gemfile: rails_4.2
+        - ruby: jruby-9.1.17.0
+          gemfile: norails
+        - ruby: jruby-9.1.17.0
+          gemfile: rails_5.2
+        - ruby: jruby-9.1.17.0
+          gemfile: rails_6.1
+        - ruby: truffleruby
+          gemfile: rails_4.2
+        - ruby: truffleruby
+          gemfile: rails_4.2_mongoid_5
+        - ruby: truffleruby
+          gemfile: rails_5.2
+        allow_failures:
+          - false
+    env:
+      BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
+      ALLOW_FAILURES: "${{ matrix.allow_failures }}"
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install dependencies
+        run: |
+          mkdir /tmp/dynamodb
+          wget -O - https://s3-ap-southeast-1.amazonaws.com/dynamodb-local-singapore/dynamodb_local_latest.tar.gz | tar xz --directory /tmp/dynamodb
+          java -Djava.library.path=/tmp/dynamodb/DynamoDBLocal_lib -jar /tmp/dynamodb/DynamoDBLocal.jar -inMemory -delayTransientStatuses -port 30180 &
+          mongod --version
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Setup project
+        run: bundle install
+      - name: Start Redis
+        uses: supercharge/redis-github-action@1.2.0
+        with:
+          redis-version: ${{ matrix.redis-version }}
+      - name: Start MongoDB
+        uses: supercharge/mongodb-github-action@1.6.0
+        with:
+          mongodb-version: ${{ matrix.mongodb-version }}
+      #  - name: Setup DynamoDB Local
+      #    uses: rrainn/dynamodb-action@v2.0.0
+      #    with:
+      #      port: 8000
+      #      cors: '*'
+      - name: Run specs
+        run: bundle exec rspec spec
+      - name: Run test
+        run: bundle exec rake test
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v2
+        with:
+          fail_ci_if_error: false

data/Appraisals

@@ -1,7 +1,8 @@
 appraise 'rails_4.2' do
   gem 'nokogiri', '1.6.8.1', platforms: %i[ruby_19]
   gem 'mime-types', '~> 2', platforms: %i[ruby_19 jruby]
-  gem 'rails', '4.2.5'
+  gem 'sqlite3', '~> 1.3.5', platforms: :ruby
+  gem 'rails', '~> 4.2.11'
   gem 'mongoid', '~> 4.0'
   gem 'sequel'
   gem 'dynamoid', '~> 1', platforms: :ruby
@@ -11,50 +12,32 @@ appraise 'rails_4.2' do
   gem "after_commit_everywhere", "~> 1.0"
 end
 
-appraise 'rails_4.2_nobrainer' do
-  gem 'rails', '4.2.5'
-  gem 'nobrainer', '~> 0.33.0'
-end
-
 appraise 'rails_4.2_mongoid_5' do
+  gem 'sqlite3', '~> 1.3.5', platforms: :ruby
   gem 'mime-types', '~> 2', platforms: %i[ruby_19 jruby]
-  gem 'rails', '4.2.5'
+  gem 'rails', '~> 4.2.11'
   gem 'mongoid', '~> 5.0'
   gem 'activerecord-jdbcsqlite3-adapter', '1.3.24', platforms: :jruby
   gem "after_commit_everywhere", "~> 1.0"
 end
 
-appraise 'rails_5.0' do
-  gem 'rails', '5.0.0'
-  gem 'mongoid', '~> 6.0'
-  gem 'sequel'
-  gem 'dynamoid', '~> 1.3', platforms: :ruby
-  gem 'aws-sdk', '~> 2', platforms: :ruby
-  gem 'redis-objects'
-  gem "after_commit_everywhere", "~> 1.0"
-end
-
-appraise 'rails_5.0_nobrainer' do
-  gem 'rails', '5.0.0'
-  gem 'nobrainer', '~> 0.33.0'
-end
-
-appraise 'rails_5.1' do
-  gem 'rails', '5.1'
+appraise 'rails_5.2' do
+  gem 'sqlite3', '~> 1.3.5', platforms: :ruby
+  gem 'rails', '~> 5.2.4'
   gem 'mongoid', '~>6.0'
   gem 'sequel'
-  gem 'dynamoid', '~> 1.3', platforms: :ruby
+  gem 'dynamoid', '~>2.2', platforms: :ruby
   gem 'aws-sdk', '~>2', platforms: :ruby
   gem 'redis-objects'
   gem "after_commit_everywhere", "~> 1.0"
 end
 
-appraise 'rails_5.2' do
-  gem 'rails', '5.2'
-  gem 'mongoid', '~>6.0'
+appraise 'rails_6.1' do
+  gem 'rails', '~> 6.1.4'
+  gem 'mongoid', '~>7.0', '>= 7.0.5'
   gem 'sequel'
-  gem 'dynamoid', '~>2.2', platforms: :ruby
-  gem 'aws-sdk', '~>2', platforms: :ruby
+  gem 'dynamoid', '~>3.3', platforms: :ruby
+  gem 'aws-sdk-dynamodb', '~> 1'
   gem 'redis-objects'
   gem "after_commit_everywhere", "~> 1.0"
 end
@@ -64,4 +47,5 @@ appraise 'norails' do
   gem 'rails', install_if: false
   gem 'sequel'
   gem 'redis-objects'
+  gem "after_commit_everywhere", install_if: false
 end

data/CHANGELOG.md

@@ -1,6 +1,17 @@
 # CHANGELOG
 
 ## unreleased
+
+## 5.3.0
+
+* Add Ruby 3.1 and Rails 7 to the CI matrix [#775](https://github.com/aasm/aasm/pull/775), thanks to [petergoldstein](https://github.com/petergoldstein)
+* Fixed an error in Ruby 3 when specifying a method that takes keyword arguments, such as event's before hook [#777](https://github.com/aasm/aasm/pull/777), thanks to [pocari](https://github.com/pocari)
+* Fix multi-threading bug not firing success callbacks [#778](https://github.com/aasm/aasm/pull/778), thanks to [guewen](https://github.com/guewen)
+* Raise AASM::UndefinedState when calling fire or fire! with undefined event names [#753](https://github.com/aasm/aasm/pull/753), thanks to [danielvdao](https://github.com/danielvdao)
+* Fixing Readme typos [#745](https://github.com/aasm/aasm/pull/745) [#772](https://github.com/aasm/aasm/pull/772) [#774](https://github.com/aasm/aasm/pull/774) [#781](https://github.com/aasm/aasm/pull/781), thanks to [jaredsmithse](https://github.com/jaredsmithse) [jcat4](https://github.com/jcat4) [ChandanChainani](https://github.com/ChandanChainani) [TessHuelskamp](https://github.com/TessHuelskamp)
+* Add github actions config [#750](https://github.com/aasm/aasm/pull/750), thanks to [aka47](https://github.com/aka47)
+* Test against for Rails 6.0 and improve ci [#719](https://github.com/aasm/aasm/pull/719), thanks to [yujideveloper](https://github.com/yujideveloper)
+* Fix migration class name to work with zeitwerk [#720](https://github.com/aasm/aasm/pull/720), thanks to [rwegrzyniak](https://github.com/rwegrzyniak)
 ## 5.2.0
 
 * fix: timestamp will work with named machine [#739](https://github.com/aasm/aasm/pull/739), thanks to [RolandStuder](https://github.com/RolandStuder)

data/Gemfile

@@ -2,5 +2,6 @@ source "https://rubygems.org"
 
 gemspec
 
-gem 'sqlite3', '~> 1.3.5', :platforms => :ruby
-gem 'rails', '5.1.4'
+gem 'sqlite3', '~> 1.4', :platforms => :ruby
+gem 'rails', '~> 6.1.4'
+gem 'after_commit_everywhere', '~> 1.0'

data/README.md

@@ -221,18 +221,18 @@ You can pass parameters to events:
   job.run(:defragmentation)
 ```
 
-All guards and after callbacks will receive these parameters. In this case `set_process` would be called with 
+All guards and after callbacks will receive these parameters. In this case `set_process` would be called with
 `:defragmentation` argument.
 
-If the first argument to the event is a state (e.g. `:running` or `:finished`), the first argument is consumed and 
-the state machine will attempt to transition to that state. Add comma separated parameter for gaurds and callbacks
+If the first argument to the event is a state (e.g. `:running` or `:finished`), the first argument is consumed and
+the state machine will attempt to transition to that state. Add comma separated parameter for guards and callbacks
 
 ```ruby
   job = Job.new
   job.run(:running, :defragmentation)
 ```
-In this case `set_process` won't be called, job will transition to running state and callback will receive 
-:defragmentation as parameter
+In this case `set_process` won't be called, job will transition to running state and callback will receive
+`:defragmentation` as parameter
 
 #### Error Handling
 In case of an error during the event processing the error is rescued and passed to `:error`
@@ -321,7 +321,7 @@ and then
 Let's assume you want to allow particular transitions only if a defined condition is
 given. For this you can set up a guard per transition, which will run before actually
 running the transition. If the guard returns `false` the transition will be
-denied (raising `AASM::InvalidTransition` or returning `false` itself):
+denied (raising `AASM::InvalidTransition`):
 
 ```ruby
 class Cleaner
@@ -364,7 +364,7 @@ job.clean                 # => raises AASM::InvalidTransition
 job.may_clean_if_needed?  # => true
 job.clean_if_needed!      # idle
 
-job.clean_if_dirty(:clean) # => false
+job.clean_if_dirty(:clean) # => raises AASM::InvalidTransition
 job.clean_if_dirty(:dirty) # => true
 ```
 
@@ -400,7 +400,7 @@ If you prefer a more Ruby-like guard syntax, you can use `if` and `unless` as we
   end
 ```
 
-You can invoke a Class instead a method since this Class responds to `call`
+You can invoke a Class instead of a method if the Class responds to `call`
 
 ```ruby
     event :sleep do
@@ -758,7 +758,7 @@ job.aasm.fire!(:run) # saved
 
 Saving includes running all validations on the `Job` class. If
 `whiny_persistence` flag is set to `true`, exception is raised in case of
-failure. If `whiny_persistence` flag is set to false, methods with a bang return
+failure. If `whiny_persistence` flag is set to `false`, methods with a bang return
 `true` if the state transition is successful or `false` if an error occurs.
 
 If you want make sure the state gets saved without running validations (and
@@ -786,7 +786,7 @@ class Job < ActiveRecord::Base
 end
 ```
 
-Also You can skip the validation at instance level with `some_event_name_without_validation!` method.
+Also, you can skip the validation at instance level with `some_event_name_without_validation!` method.
 With this you have the flexibility of having validation for all your transitions by default and then skip it wherever required.
 Please note that only state column will be updated as mentioned in the above example.
 
@@ -1084,7 +1084,7 @@ end
 
 which then leads to `transaction(requires_new: false)`, the Rails default.
 
-Additionally, if you do not want any of your active record actions to be
+Additionally, if you do not want any of your ActiveRecord actions to be
 wrapped in a transaction, you can specify the `use_transactions` flag. This can
 be useful if you want want to persist things to the database that happen as a
 result of a transaction or callback, even when some error occurs. The
@@ -1104,7 +1104,7 @@ end
 
 ### Pessimistic Locking
 
-AASM supports [Active Record pessimistic locking via `with_lock`](http://api.rubyonrails.org/classes/ActiveRecord/Locking/Pessimistic.html#method-i-with_lock) for database persistence layers.
+AASM supports [ActiveRecord pessimistic locking via `with_lock`](http://api.rubyonrails.org/classes/ActiveRecord/Locking/Pessimistic.html#method-i-with_lock) for database persistence layers.
 
 | Option | Purpose |
 | ------ | ------- |
@@ -1160,7 +1160,7 @@ end
 Whatever column name is used, make sure to add a migration to provide this column
 (of type `string`).
 Do not add default value for column at the database level. If you add default
-value in database then AASM callbacks on the initial state will not be fired upon 
+value in database then AASM callbacks on the initial state will not be fired upon
 instantiation of the model.
 
 ```ruby
@@ -1461,7 +1461,7 @@ After installing AASM you can run generator:
 ```
 Replace NAME with the Model name, COLUMN_NAME is optional(default is 'aasm_state').
 This will create a model (if one does not exist) and configure it with aasm block.
-For Active record orm a migration file is added to add aasm state column to table.
+For ActiveRecord orm a migration file is added to add aasm state column to table.
 
 ### Docker
 
@@ -1491,6 +1491,12 @@ Feel free to
 * [Anil Maurya](http://github.com/anilmaurya) (since 2016)
 
 
+
+## Stargazers over time
+
+[![Stargazers over time](https://starchart.cc/aasm/aasm.svg)](https://starchart.cc/aasm/aasm)
+
+
 ## [Contributing](CONTRIBUTING.md)
 
 ## Warranty ##

data/gemfiles/norails.gemfile

@@ -4,6 +4,7 @@ source "https://rubygems.org"
 
 gem "sqlite3", "~> 1.3", ">= 1.3.5", platforms: :ruby
 gem "rails", install_if: false
+gem "after_commit_everywhere", install_if: false
 gem "sequel"
 gem "redis-objects"
 

data/gemfiles/rails_4.2.gemfile

@@ -3,7 +3,8 @@
 source "https://rubygems.org"
 
 gem "sqlite3", "~> 1.3.5", platforms: :ruby
-gem "rails", "4.2.5"
+gem "rails", "~> 4.2.11"
+gem "after_commit_everywhere", "~> 1.0"
 gem "nokogiri", "1.6.8.1", platforms: [:ruby_19]
 gem "mime-types", "~> 2", platforms: [:ruby_19, :jruby]
 gem "mongoid", "~> 4.0"
@@ -12,6 +13,5 @@ gem "dynamoid", "~> 1", platforms: :ruby
 gem "aws-sdk", "~> 2", platforms: :ruby
 gem "redis-objects"
 gem "activerecord-jdbcsqlite3-adapter", "1.3.24", platforms: :jruby
-gem "after_commit_everywhere", "~> 1.0"
 
 gemspec path: "../"

data/gemfiles/rails_4.2_mongoid_5.gemfile

@@ -3,10 +3,10 @@
 source "https://rubygems.org"
 
 gem "sqlite3", "~> 1.3.5", platforms: :ruby
-gem "rails", "4.2.5"
+gem "rails", "~> 4.2.11"
+gem "after_commit_everywhere", "~> 1.0"
 gem "mime-types", "~> 2", platforms: [:ruby_19, :jruby]
 gem "mongoid", "~> 5.0"
 gem "activerecord-jdbcsqlite3-adapter", "1.3.24", platforms: :jruby
-gem "after_commit_everywhere", "~> 1.0"
 
 gemspec path: "../"

data/gemfiles/rails_4.2_nobrainer.gemfile

@@ -3,7 +3,8 @@
 source "https://rubygems.org"
 
 gem "sqlite3", "~> 1.3.5", platforms: :ruby
-gem "rails", "4.2.5"
+gem "rails", "~> 4.2.11"
+gem "after_commit_everywhere", "~> 1.0"
 gem "nobrainer", "~> 0.33.0"
 
 gemspec path: "../"

data/gemfiles/rails_5.2.gemfile

@@ -3,12 +3,12 @@
 source "https://rubygems.org"
 
 gem "sqlite3", "~> 1.3.5", platforms: :ruby
-gem "rails", "5.2"
+gem "rails", "~> 5.2.4"
+gem "after_commit_everywhere", "~> 1.0"
 gem "mongoid", "~>6.0"
 gem "sequel"
 gem "dynamoid", "~>2.2", platforms: :ruby
 gem "aws-sdk", "~>2", platforms: :ruby
 gem "redis-objects"
-gem "after_commit_everywhere", "~> 1.0"
 
 gemspec path: "../"

data/gemfiles/rails_6.0.gemfile

@@ -0,0 +1,14 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "sqlite3", "~> 1.4", platforms: :ruby
+gem "rails", "~> 6.0.3"
+gem "after_commit_everywhere", "~> 1.0"
+gem "mongoid", "~>7.0", ">= 7.0.5"
+gem "sequel"
+gem "dynamoid", "~>3.3", platforms: :ruby
+gem "aws-sdk-dynamodb", "~> 1"
+gem "redis-objects"
+
+gemspec path: "../"

data/gemfiles/rails_6.1.gemfile

@@ -0,0 +1,14 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "sqlite3", "~> 1.4", platforms: :ruby
+gem "rails", "~> 6.1.4"
+gem "after_commit_everywhere", "~> 1.0"
+gem "mongoid", "~>7.0", ">= 7.0.5"
+gem "sequel"
+gem "dynamoid", "~>3.3", platforms: :ruby
+gem "aws-sdk-dynamodb", "~> 1"
+gem "redis-objects"
+
+gemspec path: "../"

data/gemfiles/rails_7.0.gemfile

@@ -0,0 +1,14 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "sqlite3", "~> 1.4", platforms: :ruby
+gem "rails", "~> 7.0.1"
+gem "after_commit_everywhere", "~> 1.0"
+gem "mongoid", "~>7", ">= 7.3.4"
+gem "sequel"
+gem "dynamoid", "~>3.3", platforms: :ruby
+gem "aws-sdk-dynamodb", "~> 1"
+gem "redis-objects"
+
+gemspec path: "../"

data/lib/aasm/base.rb

@@ -223,7 +223,20 @@ module AASM
         end
       end
 
-      klass.send(:define_method, method_name, method_definition)
+      klass.send(:define_method, method_name, method_definition).tap do |sym|
+        apply_ruby2_keyword(klass, sym)
+      end
+    end
+
+    def apply_ruby2_keyword(klass, sym)
+      if RUBY_VERSION >= '2.7.1'
+        if klass.instance_method(sym).parameters.find { |type, _| type.to_s.start_with?('rest') }
+          # If there is a place where you are receiving in *args, do ruby2_keywords.
+          klass.module_eval do
+            ruby2_keywords sym
+          end
+        end
+      end
     end
 
     def namespace?

data/lib/aasm/core/event.rb

@@ -10,7 +10,7 @@ module AASM::Core
       @name = name
       @state_machine = state_machine
       @transitions = []
-      @valid_transitions = {}
+      @valid_transitions = Hash.new { |h, k| h[k] = {} }
       @guards = Array(options[:guard] || options[:guards] || options[:if])
       @unless = Array(options[:unless]) #TODO: This could use a better name
       @default_display_name = name.to_s.gsub(/_/, ' ').capitalize
@@ -79,8 +79,9 @@ module AASM::Core
 
     def fire_transition_callbacks(obj, *args)
       from_state = obj.aasm(state_machine.name).current_state
-      transition = @valid_transitions[from_state]
-      @valid_transitions[from_state].invoke_success_callbacks(obj, *args) if transition
+      transition = @valid_transitions[obj.object_id][from_state]
+      transition.invoke_success_callbacks(obj, *args) if transition
+      @valid_transitions.delete(obj.object_id)
     end
 
     def ==(event)
@@ -153,7 +154,7 @@ module AASM::Core
             result = transition
           else
             result = to_state || Array(transition.to).first
-            Array(transition.to).each {|to| @valid_transitions[to] = transition }
+            Array(transition.to).each {|to| @valid_transitions[obj.object_id][to] = transition }
             transition.execute(obj, *args)
           end
 

data/lib/aasm/instance_base.rb

@@ -1,6 +1,5 @@
 module AASM
   class InstanceBase
-
     attr_accessor :from_state, :to_state, :current_event
 
     def initialize(instance, name=:default) # instance of the class including AASM, name of the state machine
@@ -115,12 +114,15 @@ module AASM
     end
 
     def fire(event_name, *args, &block)
+      event_exists?(event_name)
+
       @instance.send(event_name, *args, &block)
     end
 
     def fire!(event_name, *args, &block)
-      event_name = event_name.to_s.+("!").to_sym
-      @instance.send(event_name, *args, &block)
+      event_exists?(event_name, true)
+      bang_event_name = "#{event_name}!".to_sym
+      @instance.send(bang_event_name, *args, &block)
     end
 
     def set_current_state_with_persistence(state)
@@ -129,5 +131,13 @@ module AASM
       save_success
     end
 
+    private
+
+    def event_exists?(event_name, bang = false)
+      event = @instance.class.aasm(@name).state_machine.events[event_name]
+      event_error = bang ? "#{event_name}!" : event_name
+
+      raise AASM::UndefinedState, "State :#{event_error} doesn't exist" if event.nil?
+    end
   end
 end

data/lib/aasm/version.rb

@@ -1,3 +1,3 @@
 module AASM
-  VERSION = "5.2.0"
+  VERSION = "5.3.0"
 end

data/lib/generators/active_record/templates/migration.rb

@@ -1,4 +1,4 @@
-class AASMCreate<%= table_name.camelize %> < ActiveRecord::Migration[<%=  ActiveRecord::VERSION::STRING.to_f %>]
+class AasmCreate<%= table_name.camelize %> < ActiveRecord::Migration[<%=  ActiveRecord::VERSION::STRING.to_f %>]
   def change
     create_table(:<%= table_name %>) do |t|
       t.string :<%= column_name %>

data/spec/models/event_with_keyword_arguments.rb

@@ -0,0 +1,16 @@
+class EventWithKeywordArguments
+  include AASM
+
+  aasm do
+    state :open, :initial => true, :column => :status
+    state :closed
+
+    event :close do
+      before :_before_close
+      transitions from: :open, to: :closed
+    end
+  end
+
+  def _before_close(key:)
+  end
+end

data/spec/spec_helpers/dynamoid.rb

@@ -2,8 +2,12 @@
 
 begin
   require 'dynamoid'
-  require 'aws-sdk-resources'
   puts "dynamoid #{Dynamoid::VERSION} gem found, running Dynamoid specs \e[32m#{'✔'}\e[0m"
+  if Gem::Version.new(Dynamoid::VERSION) >= Gem::Version.new('3.0.0')
+    require 'aws-sdk-dynamodb'
+  else
+    require 'aws-sdk-resources'
+  end
 
   ENV['ACCESS_KEY'] ||= 'abcd'
   ENV['SECRET_KEY'] ||= '1234'

data/spec/unit/callbacks_spec.rb

@@ -90,11 +90,9 @@ describe 'callbacks for the new DSL' do
       expect(callback).to receive(:ensure_on_all_events).once.ordered
     end
 
-    # puts "------- close!"
     callback.close!
   end
 
-
   it "works fine after reload" do
     show_debug_log = false
 
@@ -125,10 +123,43 @@ describe 'callbacks for the new DSL' do
       expect(callback).to receive(:after_event).once.ordered
     end
 
-    # puts "------- close!"
     callback.close!
   end
 
+  it 'does not run callbacks if firing an unknown event' do
+    show_debug_log = false
+
+    callback = Callbacks::Basic.new(:log => show_debug_log)
+
+    expect(callback).to_not receive(:before_all_events).ordered
+    expect(callback).to_not receive(:before_event).ordered
+    expect(callback).to_not receive(:event_guard).ordered
+    expect(callback).to_not receive(:transition_guard)
+    expect(callback).to_not receive(:before_exit_open)
+    expect(callback).to_not receive(:exit_open)
+    expect(callback).to_not receive(:after_all_transitions)
+    expect(callback).to_not receive(:after_transition)
+    expect(callback).to_not receive(:before_enter_closed)
+    expect(callback).to_not receive(:enter_closed)
+    expect(callback).to_not receive(:aasm_write_state)
+    expect(callback).to_not receive(:event_before_success)
+    expect(callback).to_not receive(:success_transition)
+    expect(callback).to_not receive(:after_exit_open)
+    expect(callback).to_not receive(:after_enter_closed)
+    expect(callback).to_not receive(:after_event)
+    expect(callback).to_not receive(:after_all_events)
+    expect(callback).to_not receive(:ensure_event).ordered
+    expect(callback).to_not receive(:ensure_on_all_events).ordered
+
+    expect {
+      callback.aasm.fire(:unknown)
+    }.to raise_error(AASM::UndefinedState, "State :unknown doesn't exist")
+
+    expect {
+      callback.aasm.fire!(:unknown)
+    }.to raise_error(AASM::UndefinedState, "State :unknown! doesn't exist")
+  end
+
   it "does not run any state callback if the event guard fails" do
     callback = Callbacks::Basic.new(:log => false)
     callback.aasm.current_state
@@ -164,7 +195,6 @@ describe 'callbacks for the new DSL' do
     callback = Callbacks::PrivateMethod.new(:log => show_debug_log)
     callback.aasm.current_state
 
-    # puts "------- close!"
     expect {
       callback.close!
     }.to_not raise_error

data/spec/unit/complex_example_spec.rb

@@ -90,4 +90,12 @@ describe 'when being unsuspended' do
   it "should not be able to fire unknown events" do
     expect(auth.aasm.may_fire_event?(:unknown)).to be false
   end
+
+  it "should raise AASM::UndefinedState when firing unknown events" do
+    expect { auth.aasm.fire(:unknown) }.to raise_error(AASM::UndefinedState, "State :unknown doesn't exist")
+  end
+
+  it "should raise AASM::UndefinedState when firing unknown bang events" do
+    expect { auth.aasm.fire!(:unknown) }.to raise_error(AASM::UndefinedState, "State :unknown! doesn't exist")
+  end
 end

data/spec/unit/event_with_keyword_arguments_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+describe EventWithKeywordArguments do
+  let(:example) { EventWithKeywordArguments.new }
+  describe 'enable keyword arguments' do
+    it 'should be executed correctly that method registered by "before hooks" for events with keyword arguments.' do
+      expect(example.close(key: 1)).to be_truthy
+    end
+  end
+end

data/test/minitest_helper.rb

@@ -23,7 +23,11 @@ end
 # Dynamoid initialization
 begin
   require 'dynamoid'
-  require 'aws-sdk-resources'
+  if Gem::Version.new(Dynamoid::VERSION) >= Gem::Version.new('3.0.0')
+    require 'aws-sdk-dynamodb'
+  else
+    require 'aws-sdk-resources'
+  end
 
   ENV['ACCESS_KEY'] ||= 'abcd'
   ENV['SECRET_KEY'] ||= '1234'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aasm
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.3.0
 platform: ruby
 authors:
 - Thorsten Boettger
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-05-02 00:00:00.000000000 Z
+date: 2022-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -147,8 +147,8 @@ files:
 - ".document"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/workflows/build.yml"
 - ".gitignore"
-- ".travis.yml"
 - API
 - Appraisals
 - CHANGELOG.md
@@ -170,10 +170,10 @@ files:
 - gemfiles/rails_4.2.gemfile
 - gemfiles/rails_4.2_mongoid_5.gemfile
 - gemfiles/rails_4.2_nobrainer.gemfile
-- gemfiles/rails_5.0.gemfile
-- gemfiles/rails_5.0_nobrainer.gemfile
-- gemfiles/rails_5.1.gemfile
 - gemfiles/rails_5.2.gemfile
+- gemfiles/rails_6.0.gemfile
+- gemfiles/rails_6.1.gemfile
+- gemfiles/rails_7.0.gemfile
 - lib/aasm.rb
 - lib/aasm/aasm.rb
 - lib/aasm/base.rb
@@ -282,6 +282,7 @@ files:
 - spec/models/dynamoid/complex_dynamoid_example.rb
 - spec/models/dynamoid/dynamoid_multiple.rb
 - spec/models/dynamoid/dynamoid_simple.rb
+- spec/models/event_with_keyword_arguments.rb
 - spec/models/foo.rb
 - spec/models/foo_callback_multiple.rb
 - spec/models/guard_arguments_check.rb
@@ -362,6 +363,7 @@ files:
 - spec/unit/event_multiple_spec.rb
 - spec/unit/event_naming_spec.rb
 - spec/unit/event_spec.rb
+- spec/unit/event_with_keyword_arguments_spec.rb
 - spec/unit/exception_spec.rb
 - spec/unit/guard_arguments_check_spec.rb
 - spec/unit/guard_multiple_spec.rb
@@ -493,6 +495,7 @@ test_files:
 - spec/models/dynamoid/complex_dynamoid_example.rb
 - spec/models/dynamoid/dynamoid_multiple.rb
 - spec/models/dynamoid/dynamoid_simple.rb
+- spec/models/event_with_keyword_arguments.rb
 - spec/models/foo.rb
 - spec/models/foo_callback_multiple.rb
 - spec/models/guard_arguments_check.rb
@@ -573,6 +576,7 @@ test_files:
 - spec/unit/event_multiple_spec.rb
 - spec/unit/event_naming_spec.rb
 - spec/unit/event_spec.rb
+- spec/unit/event_with_keyword_arguments_spec.rb
 - spec/unit/exception_spec.rb
 - spec/unit/guard_arguments_check_spec.rb
 - spec/unit/guard_multiple_spec.rb

data/.travis.yml

@@ -1,82 +0,0 @@
-sudo: false
-language: ruby
-cache: bundler
-
-jdk:
-  - openjdk8
-
-before_install:
-  - rvm list
-  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
-  - gem install bundler -v '1.16.1'
-  - bundle _1.16.1_ install
-
-rvm:
-  - 2.5.0
-  - 2.6.5
-  - 2.7.0
-  - jruby-9.1.12.0
-
-services:
-  - mongodb
-  - redis-server
-
-#addons:
-#  rethinkdb: '2.3.4'
-
-gemfile:
-  - gemfiles/norails.gemfile
-  - gemfiles/rails_4.2.gemfile
-  - gemfiles/rails_4.2_mongoid_5.gemfile
-#  - gemfiles/rails_4.2_nobrainer.gemfile
-  - gemfiles/rails_5.0.gemfile
-#  - gemfiles/rails_5.0_nobrainer.gemfile
-  - gemfiles/rails_5.1.gemfile
-  - gemfiles/rails_5.2.gemfile
-
-before_script:
-  - mkdir /tmp/dynamodb
-  - wget -O - https://s3-ap-southeast-1.amazonaws.com/dynamodb-local-singapore/dynamodb_local_latest.tar.gz | tar xz --directory /tmp/dynamodb
-  - java -Djava.library.path=/tmp/dynamodb/DynamoDBLocal_lib -jar /tmp/dynamodb/DynamoDBLocal.jar -inMemory -delayTransientStatuses -port 30180 &
-  - mongod --version
-
-script:
-  - bundle exec rspec spec
-  - bundle exec rake test
-
-matrix:
-  exclude:
-    - rvm: 2.7.0
-      gemfile: gemfiles/rails_5.2.gemfile
-    - rvm: 2.6.5
-      gemfile: gemfiles/rails_5.2.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_4.2.gemfile
-    - rvm: 2.6.5
-      gemfile: gemfiles/rails_4.2.gemfile
-    - rvm: 2.7.0
-      gemfile: gemfiles/rails_4.2.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_4.2_mongoid_5.gemfile
-    - rvm: 2.6.5
-      gemfile: gemfiles/rails_4.2_mongoid_5.gemfile
-    - rvm: 2.7.0
-      gemfile: gemfiles/rails_4.2_mongoid_5.gemfile
-#    - rvm: 2.5.0
-#      gemfile: gemfiles/rails_4.2_nobrainer.gemfile
-    - rvm: jruby-9.1.12.0
-      gemfile: gemfiles/norails.gemfile
-    - rvm: jruby-9.1.12.0
-      gemfile: gemfiles/rails_5.0.gemfile
-    - rvm: jruby-9.1.12.0
-      gemfile: gemfiles/rails_5.1.gemfile
-    - rvm: jruby-9.1.12.0
-      gemfile: gemfiles/rails_5.2.gemfile
-#    - rvm: jruby-9.1.12.0
-#      gemfile: gemfiles/rails_4.2_nobrainer.gemfile
-#    - rvm: jruby-9.1.12.0
-#      gemfile: gemfiles/rails_5.0_nobrainer.gemfile
-
-notifications:
-  slack:
-    secure: gpltVWntdKz0nSE6A5UvuX4qbN35uW51nsW+Ojgqm8Qsv8K240/NlZRYutFHr7GnJTe0rEEP2Oy3ZBnBtZKFn13RlTEAU/FCAxebr4H24rr29Ypwwp5xjiSE4MuoBEnroo4lw6ka3LsJnrY2PKRMiLJGsS0WsEPY4x8NUG/vyY8=

data/gemfiles/rails_5.0.gemfile

@@ -1,14 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.5", platforms: :ruby
-gem "rails", "5.0.0"
-gem "mongoid", "~> 6.0"
-gem "sequel"
-gem "dynamoid", "~> 1.3", platforms: :ruby
-gem "aws-sdk", "~> 2", platforms: :ruby
-gem "redis-objects"
-gem "after_commit_everywhere", "~> 1.0"
-
-gemspec path: "../"

data/gemfiles/rails_5.0_nobrainer.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.5", platforms: :ruby
-gem "rails", "5.0.0"
-gem "nobrainer", "~> 0.33.0"
-
-gemspec path: "../"

data/gemfiles/rails_5.1.gemfile

@@ -1,14 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.5", platforms: :ruby
-gem "rails", "5.1"
-gem "mongoid", "~>6.0"
-gem "sequel"
-gem "dynamoid", "~> 1.3", platforms: :ruby
-gem "aws-sdk", "~>2", platforms: :ruby
-gem "redis-objects"
-gem "after_commit_everywhere", "~> 1.0"
-
-gemspec path: "../"