aasm 4.11.0 → 4.12.0

data/spec/unit/persistence/dynamoid_persistence_multiple_spec.rb

@@ -1,8 +1,7 @@
-describe 'dynamoid' do
-  begin
-    require 'dynamoid'
-    require 'logger'
-    require 'spec_helper'
+require 'spec_helper'
+
+if defined?(Dynamoid)
+  describe 'dynamoid' do
 
     Dir[File.dirname(__FILE__) + "/../../models/dynamoid/*.rb"].sort.each do |f|
       require File.expand_path(f)
@@ -132,9 +131,5 @@ describe 'dynamoid' do
       end
     end
 
-  rescue LoadError
-    puts "------------------------------------------------------------------------"
-    puts "Not running Dynamoid multiple-specs because dynamoid gem is not installed!!!"
-    puts "------------------------------------------------------------------------"
   end
 end

data/spec/unit/persistence/dynamoid_persistence_spec.rb

@@ -1,8 +1,7 @@
-describe 'dynamoid' do
-  begin
-    require 'dynamoid'
-    require 'logger'
-    require 'spec_helper'
+require 'spec_helper'
+
+if defined?(Dynamoid)
+  describe 'dynamoid' do
 
     Dir[File.dirname(__FILE__) + "/../../models/dynamoid/*.rb"].sort.each do |f|
       require File.expand_path(f)
@@ -81,9 +80,5 @@ describe 'dynamoid' do
       end
     end
 
-  rescue LoadError
-    puts "------------------------------------------------------------------------"
-    puts "Not running Dynamoid specs because dynamoid gem is not installed!!!"
-    puts "------------------------------------------------------------------------"
   end
 end

data/spec/unit/persistence/mongoid_persistence_multiple_spec.rb

@@ -1,8 +1,7 @@
-describe 'mongoid' do
-  begin
-    require 'mongoid'
-    require 'logger'
-    require 'spec_helper'
+require 'spec_helper'
+
+if defined?(Mongoid::Document)
+  describe 'mongoid' do
 
     Dir[File.dirname(__FILE__) + "/../../models/mongoid/*.rb"].sort.each do |f|
       require File.expand_path(f)
@@ -24,9 +23,12 @@ describe 'mongoid' do
     describe "named scopes with the old DSL" do
 
       context "Does not already respond_to? the scope name" do
-        it "should add a scope" do
+        it "should add a scope for each state" do
           expect(SimpleMongoidMultiple).to respond_to(:unknown_scope)
+          expect(SimpleMongoidMultiple).to respond_to(:another_unknown_scope)
+
           expect(SimpleMongoidMultiple.unknown_scope.class).to eq(Mongoid::Criteria)
+          expect(SimpleMongoidMultiple.another_unknown_scope.class).to eq(Mongoid::Criteria)
         end
       end
 
@@ -69,6 +71,85 @@ describe 'mongoid' do
 
     end
 
+    describe 'transitions with persistence' do
+
+      it "should work for valid models" do
+        valid_object = MultipleValidatorMongoid.create(:name => 'name')
+        expect(valid_object).to be_sleeping
+        valid_object.status = :running
+        expect(valid_object).to be_running
+      end
+
+      it 'should not store states for invalid models' do
+        validator = MultipleValidatorMongoid.create(:name => 'name')
+        expect(validator).to be_valid
+        expect(validator).to be_sleeping
+
+        validator.name = nil
+        expect(validator).not_to be_valid
+        expect { validator.run! }.to raise_error(Mongoid::Errors::Validations)
+        expect(validator).to be_sleeping
+
+        validator.reload
+        expect(validator).not_to be_running
+        expect(validator).to be_sleeping
+
+        validator.name = 'another name'
+        expect(validator).to be_valid
+        expect(validator.run!).to be_truthy
+        expect(validator).to be_running
+
+        validator.reload
+        expect(validator).to be_running
+        expect(validator).not_to be_sleeping
+      end
+
+      it 'should not store states for invalid models silently if configured' do
+        validator = MultipleSilentPersistorMongoid.create(:name => 'name')
+        expect(validator).to be_valid
+        expect(validator).to be_sleeping
+
+        validator.name = nil
+        expect(validator).not_to be_valid
+        expect(validator.run!).to be_falsey
+        expect(validator).to be_sleeping
+
+        validator.reload
+        expect(validator).not_to be_running
+        expect(validator).to be_sleeping
+
+        validator.name = 'another name'
+        expect(validator).to be_valid
+        expect(validator.run!).to be_truthy
+        expect(validator).to be_running
+
+        validator.reload
+        expect(validator).to be_running
+        expect(validator).not_to be_sleeping
+      end
+
+      it 'should store states for invalid models if configured' do
+        persistor = MultipleInvalidPersistorMongoid.create(:name => 'name')
+        expect(persistor).to be_valid
+        expect(persistor).to be_sleeping
+
+        persistor.name = nil
+        expect(persistor).not_to be_valid
+        expect(persistor.run!).to be_truthy
+        expect(persistor).to be_running
+
+        persistor = MultipleInvalidPersistorMongoid.find(persistor.id)
+        persistor.valid?
+        expect(persistor).to be_valid
+        expect(persistor).to be_running
+        expect(persistor).not_to be_sleeping
+
+        persistor.reload
+        expect(persistor).to be_running
+        expect(persistor).not_to be_sleeping
+      end
+    end
+
     describe "complex example" do
       it "works" do
         record = ComplexMongoidExample.new
@@ -119,9 +200,5 @@ describe 'mongoid' do
       end
     end
 
-  rescue LoadError
-    puts "--------------------------------------------------------------------------"
-    puts "Not running Mongoid multiple-specs because mongoid gem is not installed!!!"
-    puts "--------------------------------------------------------------------------"
   end
 end

data/spec/unit/persistence/mongoid_persistence_spec.rb

@@ -1,8 +1,7 @@
-describe 'mongoid' do
-  begin
-    require 'mongoid'
-    require 'logger'
-    require 'spec_helper'
+require 'spec_helper'
+
+if defined?(Mongoid::Document)
+  describe 'mongoid' do
 
     Dir[File.dirname(__FILE__) + "/../../models/mongoid/*.rb"].sort.each do |f|
       require File.expand_path(f)
@@ -24,9 +23,12 @@ describe 'mongoid' do
     describe "named scopes with the old DSL" do
 
       context "Does not already respond_to? the scope name" do
-        it "should add a scope" do
+        it "should add a scope for each state" do
           expect(SimpleMongoid).to respond_to(:unknown_scope)
+          expect(SimpleMongoid).to respond_to(:another_unknown_scope)
+
           expect(SimpleMongoid.unknown_scope.class).to eq(Mongoid::Criteria)
+          expect(SimpleMongoid.another_unknown_scope.class).to eq(Mongoid::Criteria)
         end
       end
 
@@ -82,9 +84,86 @@ describe 'mongoid' do
 
     end
 
-  rescue LoadError
-    puts "--------------------------------------------------------------------------"
-    puts "Not running Mongoid specs because mongoid gem is not installed!!!"
-    puts "--------------------------------------------------------------------------"
+    describe 'transitions with persistence' do
+
+      it 'should work for valid models' do
+        valid_object = ValidatorMongoid.create(:name => 'name')
+        expect(valid_object).to be_sleeping
+        valid_object.status = :running
+        expect(valid_object).to be_running
+      end
+
+      it 'should not store states for invalid models' do
+        validator = ValidatorMongoid.create(:name => 'name')
+        expect(validator).to be_valid
+        expect(validator).to be_sleeping
+
+        validator.name = nil
+        expect(validator).not_to be_valid
+        expect { validator.run! }.to raise_error(Mongoid::Errors::Validations)
+        expect(validator).to be_sleeping
+
+        validator.reload
+        expect(validator).not_to be_running
+        expect(validator).to be_sleeping
+
+        validator.name = 'another name'
+        expect(validator).to be_valid
+        expect(validator.run!).to be_truthy
+        expect(validator).to be_running
+
+        validator.reload
+        expect(validator).to be_running
+        expect(validator).not_to be_sleeping
+      end
+
+      it 'should not store states for invalid models silently if configured' do
+        validator = SilentPersistorMongoid.create(:name => 'name')
+        expect(validator).to be_valid
+        expect(validator).to be_sleeping
+
+        validator.name = nil
+        expect(validator).not_to be_valid
+        expect(validator.run!).to be_falsey
+        expect(validator).to be_sleeping
+
+        validator.reload
+        expect(validator).not_to be_running
+        expect(validator).to be_sleeping
+
+        validator.name = 'another name'
+        expect(validator).to be_valid
+        expect(validator.run!).to be_truthy
+        expect(validator).to be_running
+
+        validator.reload
+        expect(validator).to be_running
+        expect(validator).not_to be_sleeping
+      end
+
+      it 'should store states for invalid models if configured' do
+        persistor = InvalidPersistorMongoid.create(:name => 'name')
+        expect(persistor).to be_valid
+        expect(persistor).to be_sleeping
+
+        persistor.name = nil
+
+        expect(persistor).not_to be_valid
+        expect(persistor.run!).to be_truthy
+        expect(persistor).to be_running
+
+        persistor = InvalidPersistorMongoid.find(persistor.id)
+
+        persistor.valid?
+        expect(persistor).to be_valid
+        expect(persistor).to be_running
+        expect(persistor).not_to be_sleeping
+
+        persistor.reload
+        expect(persistor).to be_running
+        expect(persistor).not_to be_sleeping
+      end
+    end
+
   end
 end

data/spec/unit/persistence/redis_persistence_spec.rb

@@ -1,9 +1,7 @@
+require 'spec_helper'
 
-describe 'redis' do
-  begin
-    require 'redis-objects'
-    require 'logger'
-    require 'spec_helper'
+if defined?(Redis::Objects)
+  describe 'redis' do
 
     before(:all) do
       Redis.current = Redis.new(host: '127.0.0.1', port: 6379)
@@ -71,7 +69,5 @@ describe 'redis' do
       end
     end
 
-  rescue LoadError
-    puts "Not running Redis specs because sequel gem is not installed!!!"
   end
 end

data/spec/unit/persistence/sequel_persistence_multiple_spec.rb

@@ -1,8 +1,7 @@
-describe 'sequel' do
-  begin
-    require 'sequel'
-    require 'logger'
-    require 'spec_helper'
+require 'spec_helper'
+
+if defined?(Sequel)
+  describe 'sequel' do
 
     Dir[File.dirname(__FILE__) + "/../../models/sequel/*.rb"].sort.each do |f|
       require File.expand_path(f)
@@ -145,9 +144,5 @@ describe 'sequel' do
       end
     end
 
-  rescue LoadError
-    puts "------------------------------------------------------------------------"
-    puts "Not running Sequel multiple-specs because sequel gem is not installed!!!"
-    puts "------------------------------------------------------------------------"
   end
 end

data/spec/unit/persistence/sequel_persistence_spec.rb

@@ -1,8 +1,7 @@
-describe 'sequel' do
-  begin
-    require 'sequel'
-    require 'logger'
-    require 'spec_helper'
+require 'spec_helper'
+
+if defined?(Sequel)
+  describe 'sequel' do
 
     Dir[File.dirname(__FILE__) + "/../../models/sequel/*.rb"].sort.each do |f|
       require File.expand_path(f)
@@ -92,9 +91,5 @@ describe 'sequel' do
       end
     end
 
-  rescue LoadError
-    puts "------------------------------------------------------------------------"
-    puts "Not running Sequel specs because sequel gem is not installed!!!"
-    puts "------------------------------------------------------------------------"
   end
 end

data/spec/unit/simple_multiple_example_spec.rb

@@ -60,4 +60,32 @@ describe 'state machine' do
     expect(SimpleMultipleExample::STATE_PROCESSING).to eq(:processing)
     expect(SimpleMultipleExample::STATE_RUNNING).to eq(:running)
   end
+
+  context 'triggers binding_events in bindind_state_machine' do
+    it 'does persist' do
+      expect(simple).to be_sleeping
+      expect(simple).to be_answered
+      expect(simple).to receive(:start!).and_call_original
+      simple.ask!
+      expect(simple).to be_asked
+      expect(simple).to be_processing
+      expect(simple).to receive(:stop!).and_call_original
+      simple.answer!
+      expect(simple).to be_sleeping
+      expect(simple).to be_answered
+    end
+
+    it 'does not persist' do
+      expect(simple).to be_sleeping
+      expect(simple).to be_answered
+      expect(simple).to receive(:start).and_call_original
+      simple.ask
+      expect(simple).to be_asked
+      expect(simple).to be_processing
+      expect(simple).to receive(:stop).and_call_original
+      simple.answer
+      expect(simple).to be_sleeping
+      expect(simple).to be_answered
+    end
+  end
 end

data/spec/unit/subclassing_multiple_spec.rb

@@ -19,7 +19,7 @@ describe 'subclassing with multiple state machines' do
     expect(SuperClassMultiple.aasm(:right).states).not_to include(:archived)
   end
 
-  it "should have the same events as its parent" do
+  it 'should have the same events as its parent' do
     expect(SubClassMultiple.aasm(:left).events).to eq(SuperClassMultiple.aasm(:left).events)
     expect(SubClassMultiple.aasm(:right).events).to eq(SuperClassMultiple.aasm(:right).events)
   end
@@ -35,5 +35,40 @@ describe 'subclassing with multiple state machines' do
     expect(son.aasm(:left).current_state).to eq(:ended)
   end
 
-end
+  it 'should allow the child to modify its left state machine' do
+    son = SubClassMultiple.new
+    expect(son.left_called_after).to eq(nil)
+    expect(son.right_called_after).to eq(nil)
+    son.foo
+    expect(son.left_called_after).to eq(true)
+    expect(son.right_called_after).to eq(nil)
+    global_callbacks = SubClassMultiple.aasm(:left).state_machine.global_callbacks
+    expect(global_callbacks).to_not be_empty
+    expect(global_callbacks[:after_all_transitions]).to eq :left_after_all_event
+  end
+
+  it 'should allow the child to modify its right state machine' do
+    son = SubClassMultiple.new
+    expect(son.right_called_after).to eq(nil)
+    expect(son.left_called_after).to eq(nil)
+    son.close
+    expect(son.right_called_after).to eq(true)
+    expect(son.left_called_after).to eq(nil)
+    global_callbacks = SubClassMultiple.aasm(:right).state_machine.global_callbacks
+    expect(global_callbacks).to_not be_empty
+    expect(global_callbacks[:after_all_transitions]).to eq :right_after_all_event
+  end
 
+  it 'should not modify the parent left state machine' do
+    super_class_event = SuperClassMultiple.aasm(:left).events.select { |event| event.name == :foo }.first
+    expect(super_class_event.options).to be_empty
+    expect(SuperClassMultiple.aasm(:left).state_machine.global_callbacks).to be_empty
+  end
+
+  it 'should not modify the parent right state machine' do
+    super_class_event = SuperClassMultiple.aasm(:right).events.select { |event| event.name == :close }.first
+    expect(super_class_event.options).to be_empty
+    expect(SuperClassMultiple.aasm(:right).state_machine.global_callbacks).to be_empty
+  end
+
+end

data/spec/unit/subclassing_spec.rb

@@ -13,7 +13,7 @@ describe 'subclassing' do
     expect(SuperClass.aasm.states).not_to include(:foo)
   end
 
-  it "should have the same events as its parent" do
+  it 'should have the same events as its parent' do
     expect(SubClass.aasm.events).to eq(SuperClass.aasm.events)
   end
 
@@ -27,5 +27,20 @@ describe 'subclassing' do
     expect(son.aasm.current_state).to eq(:ended)
   end
 
-end
+  it 'should allow the child to modify its state machine' do
+    son = SubClass.new
+    expect(son.called_after).to eq(nil)
+    son.foo
+    expect(son.called_after).to eq(true)
+    global_callbacks = SubClass.aasm.state_machine.global_callbacks
+    expect(global_callbacks).to_not be_empty
+    expect(global_callbacks[:after_all_transitions]).to eq :after_all_event
+  end
 
+  it 'should not modify the parent state machine' do
+    super_class_event = SuperClass.aasm.events.select { |event| event.name == :foo }.first
+    expect(super_class_event.options).to be_empty
+    expect(SuperClass.aasm.state_machine.global_callbacks).to be_empty
+  end
+
+end