a11y-lint 0.4.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: df2381933d808c2694937750b55b63897d22feb8b3726e8635504afa6bcb320b
-  data.tar.gz: 5b04343e74f0ebb363cb2b2c065d67b9b20398d4b5bd12e86e89fe38a7bcfa8d
+  metadata.gz: c543a94f664746bb807384be228f6e83fcd7046f399f9c478e2c355cf26fa3c8
+  data.tar.gz: c37a04f979ad17e79e35b8b6fa9d615cbedebcb1fce9188eb24335e046fa4400
 SHA512:
-  metadata.gz: 4a71a89a925316ae52107958bed1cdc927d653ccc0425b81ad2bca612f694cdc63b52d9c277f24c1957976e5972ed5c810b831f150c353393014908e7e187a6d
-  data.tar.gz: d9982d126da0a7f412d8d43b68e90b27fcde739a3b08c2b6cc0e948241eb18b95e9e42542e5bb7ce75048f389fec11351901da0e900076369c3889d1e8c16b0a
+  metadata.gz: 3bb877b34c79e5e3dd5c969b21bb1e756acc8968ae245e7cd1274dc880529647ca83283a0d3ea7576d446df94d37a7565b45082f4a75008e826f1bcc9245f16d
+  data.tar.gz: bb23c43c6274d45fd5e9ea5cb9f73947357127fe9aa08c225438d436910357b32ca367fbe843827a3bddf4600159b4945c1bdd248805547a47a42657dd9e9cd2

data/.claude/rules/testing.md

@@ -34,3 +34,19 @@ globs: test/**/*.rb
     assert_equal("ImgMissingAlt", offense.rule)
   end
   ```
+
+- Rules that inspect `ruby_code` (e.g. `link_to`, `image_tag` helpers) must include test cases for all three calling styles:
+  1. Single-line with parentheses: `= link_to("", "/path", class: "icon")`
+  2. Single-line without parentheses: `= link_to "", "/path", class: "icon"`
+  3. Multiline with trailing comma:
+     ```slim
+     = link_to(\
+         "",
+         "/path",
+         class: "icon",
+       )
+     ```
+
+  Each style must be tested for both the offense case and the "passes with fix" case.
+
+- Every rule must be tested against both the Slim and ERB pipelines.

data/CHANGELOG.md

@@ -7,6 +7,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.5.1] - 2026-03-31
+
+### Fixed
+
+- `LinkMissingAccessibleName` rule: detect multiline method calls with trailing commas
+
+## [0.5.0] - 2026-03-31
+
+### Added
+
+- `LinkMissingAccessibleName` rule: detects `<a>` tags without accessible text content
+
 ## [0.4.0] - 2026-03-27
 
 ### Added

data/lib/a11y/lint/rules/link_missing_accessible_name.rb

@@ -0,0 +1,106 @@
+# frozen_string_literal: true
+
+require "ripper"
+
+module A11y
+  module Lint
+    module Rules
+      # Checks that link_to / external_link_to calls with empty text
+      # include an aria-label (WCAG 4.1.2).
+      class LinkMissingAccessibleName < Rule
+        LINK_METHODS = %w[link_to external_link_to].freeze
+
+        def check(node)
+          return unless link_with_empty_text_and_no_accessible_name?(node)
+
+          "link with empty text content requires an aria-label (WCAG 4.1.2)"
+        end
+
+        private
+
+        def link_with_empty_text_and_no_accessible_name?(node)
+          code = node.ruby_code
+          return false unless code
+
+          sexp = Ripper.sexp(code)
+          return false unless sexp
+
+          call = extract_link_call(sexp)
+          return false unless call
+
+          first_arg_empty_string?(call) && !aria_label_within?(call)
+        end
+
+        def extract_link_call(sexp)
+          return unless sexp.is_a?(Array)
+          return sexp if link_call?(sexp)
+
+          sexp.each do |child|
+            result = extract_link_call(child)
+            return result if result
+          end
+
+          nil
+        end
+
+        def link_call?(sexp)
+          case sexp
+          in [:command, [:@ident, name, *], *] if LINK_METHODS.include?(name) then true
+          in [:method_add_arg, [:fcall, [:@ident, name, *]], *] if LINK_METHODS.include?(name) then true
+          else false
+          end
+        end
+
+        def first_arg_empty_string?(call)
+          args = extract_args(call)
+          return false unless args&.first
+
+          args.first in [:string_literal, [:string_content]]
+        end
+
+        def extract_args(call)
+          case call
+          in [:command, _, [:args_add_block, args, *]] then args
+          in [:method_add_arg, _, [:arg_paren, [:args_add_block, args, *]]] then args
+          in [:method_add_arg, _, [:arg_paren, Array => args]] then args
+          else nil
+          end
+        end
+
+        def aria_label_within?(sexp)
+          return true if aria_hash_with_label?(sexp)
+          return true if aria_label_string_key?(sexp)
+          return false unless sexp.is_a?(Array)
+
+          sexp.any? { |child| aria_label_within?(child) }
+        end
+
+        def aria_hash_with_label?(sexp)
+          return false unless sexp.is_a?(Array) && sexp[0] == :assoc_new
+
+          key = sexp[1]
+          value = sexp[2]
+
+          (key in [:@label, "aria:", *]) && label_key_within?(value)
+        end
+
+        def label_key_within?(sexp)
+          return true if label_key?(sexp)
+          return false unless sexp.is_a?(Array)
+
+          sexp.any? { |child| label_key_within?(child) }
+        end
+
+        def label_key?(sexp)
+          sexp.is_a?(Array) && sexp[0] == :assoc_new && (sexp[1] in [:@label, "label:", *])
+        end
+
+        def aria_label_string_key?(sexp)
+          return false unless sexp.is_a?(Array) && sexp[0] == :assoc_new
+
+          sexp[1] in [:string_literal, [:string_content, [:@tstring_content, "aria-label", *]]]
+        end
+      end
+    end
+  end
+end

data/lib/a11y/lint/version.rb

@@ -2,6 +2,6 @@
 
 module A11y
   module Lint
-    VERSION = "0.4.0"
+    VERSION = "0.5.1"
   end
 end

data/lib/a11y/lint.rb

@@ -9,6 +9,7 @@ require_relative "lint/erb_node"
 require_relative "lint/rule"
 require_relative "lint/rules/image_tag_missing_alt"
 require_relative "lint/rules/img_missing_alt"
+require_relative "lint/rules/link_missing_accessible_name"
 require_relative "lint/slim_runner"
 require_relative "lint/erb_runner"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: a11y-lint
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Abdullah Hashim
@@ -63,6 +63,7 @@ files:
 - lib/a11y/lint/rule.rb
 - lib/a11y/lint/rules/image_tag_missing_alt.rb
 - lib/a11y/lint/rules/img_missing_alt.rb
+- lib/a11y/lint/rules/link_missing_accessible_name.rb
 - lib/a11y/lint/slim_runner.rb
 - lib/a11y/lint/version.rb
 - sig/a11y/lint.rbs