a11y-lint 0.3.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c000b195d8308dc83a3480df00e9a469e064535305ece969f779ee05b93fc87
-  data.tar.gz: cf3ec59befbf3057ff5f1a9d971925656fbf0f0c001e40780202abd862bd67a2
+  metadata.gz: 7cb772a75e7dc2bc7f36f7869efac31d0f9281a196ef237f57e2e2db4f3116c1
+  data.tar.gz: ddb88dd42e274631a6d289ab56b2c0353e305b37816b9232bd7689578d19ed87
 SHA512:
-  metadata.gz: ad3e23e799fce7418f9e28224a9ec63120f42d5a04bd27710637df12e278118728af0a3baf47c5fe8b3cfa2a12e6bfbc366d8f334a453b385111b1befc2828df
-  data.tar.gz: 8be4c61819523edcbb0a11bb4959ab5834b0552d0fe27be2fc71aa30362dc18eb5ca8f9d25bffa5578f7f77d0af11b5e1716e8429b4c2a865fcd3a243031ede0
+  metadata.gz: 98b46acd6a78f33f546b6c2aa88e6ff40f7ffe89aaf196d3df0b355a7e2cd2a96d0fdc74c89796764953d47e40b3e89a26dc0008ae55528c3585f48a4d31493d
+  data.tar.gz: 2571c7dbaef8b3c37cea2a6426b29586c1ad5d3e5d120504ff20c3d4b70cabe8578cbcd50d2f8c677056aabee4520f264eae642be07e610290a4303317031c41

data/.rubocop.yml

@@ -6,3 +6,7 @@ Style/StringLiterals:
 
 Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
+
+Metrics/ClassLength:
+  Exclude:
+    - "test/**/*"

data/CHANGELOG.md

@@ -7,6 +7,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.5.0] - 2026-03-31
+
+### Added
+
+- `LinkMissingAccessibleName` rule: detects `<a>` tags without accessible text content
+
+## [0.4.0] - 2026-03-27
+
+### Added
+
+- ERB template support: scans `.erb` files using Nokogiri for HTML parsing
+  - Both `ImgMissingAlt` and `ImageTagMissingAlt` rules now work on ERB templates
+  - CLI automatically detects and routes `.slim` and `.erb` files to the appropriate runner
+
+### Changed
+
+- **Breaking:** `Runner` has been renamed to `SlimRunner`
+
 ## [0.3.1] - 2026-03-27
 
 ### Fixed

data/CLAUDE.md

@@ -19,8 +19,11 @@ a11y-lint is a Ruby gem (v0.1.0) for accessibility linting. It uses the `A11y::L
 
 ## Architecture
 
-- **CLI:** `lib/a11y/lint/cli.rb` — command-line interface; executable at `exe/a11y-lint`
+- **CLI:** `lib/a11y/lint/cli.rb` — command-line interface; executable at `exe/a11y-lint`; routes `.slim` files to `SlimRunner` and `.erb` files to `ErbRunner`
 - **Entry point:** `lib/a11y/lint.rb` — defines the `A11y::Lint` module and `A11y::Lint::Error` exception
+- **Slim pipeline:** `SlimRunner` parses Slim templates via `Slim::Parser`; `Node` wraps Slim S-expressions
+- **ERB pipeline:** `ErbRunner` parses ERB templates via Nokogiri; `ErbNode` wraps Nokogiri nodes and extracted `<%= %>` Ruby code
+- **Rules:** `lib/a11y/lint/rules/` — rules implement `check(node)` against the shared node interface (`tag_name`, `attribute?`, `attributes`, `ruby_code`, `line`)
 - **Version:** `lib/a11y/lint/version.rb`
 - **Type signatures (RBS):** `sig/a11y/lint.rbs`
 - **Tests:** `test/` directory using Minitest; test helper at `test/test_helper.rb`

data/README.md

@@ -33,7 +33,7 @@ a11y-lint app/views/
 a11y-lint app/views/home.html.slim app/views/about.html.slim
 ```
 
-With no arguments, it scans the current directory recursively for `.slim` files:
+With no arguments, it scans the current directory recursively for `.slim` and `.erb` files:
 
 ```bash
 a11y-lint
@@ -45,7 +45,7 @@ a11y-lint
 require "a11y/lint"
 
 source = File.read("app/views/home.html.slim")
-runner = A11y::Lint::Runner.new([A11y::Lint::Rules::ImgMissingAlt.new])
+runner = A11y::Lint::SlimRunner.new([A11y::Lint::Rules::ImgMissingAlt.new])
 offenses = runner.run(source, filename: "app/views/home.html.slim")
 
 offenses.each do |offense|

data/lib/a11y/lint/cli.rb

@@ -17,7 +17,7 @@ module A11y
         files = resolve_files(@argv)
 
         if files.empty?
-          @stderr.puts("No .slim files found")
+          @stderr.puts("No .slim or .erb files found")
           return 0
         end
 
@@ -56,7 +56,7 @@ module A11y
 
       def expand_path(path)
         if File.directory?(path)
-          Dir.glob(File.join(path, "**", "*.slim"))
+          Dir.glob(File.join(path, "**", "*.{slim,erb}"))
         elsif File.file?(path)
           [path]
         else
@@ -66,10 +66,13 @@ module A11y
       end
 
       def lint_files(files)
-        runner = Runner.new(all_rules)
+        rules = all_rules
+        slim_runner = SlimRunner.new(rules)
+        erb_runner = ErbRunner.new(rules)
 
         files.flat_map do |file|
           source = File.read(file)
+          runner = file.end_with?(".erb") ? erb_runner : slim_runner
           runner.run(source, filename: file)
         end
       end

data/lib/a11y/lint/erb_node.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module A11y
+  module Lint
+    # Wraps a Nokogiri node or extracted ERB output tag as a queryable node for lint rules.
+    class ErbNode
+      attr_reader :line
+
+      def initialize(line:, nokogiri_node: nil, ruby_code: nil)
+        @nokogiri_node = nokogiri_node
+        @ruby_code_string = ruby_code
+        @line = line
+      end
+
+      def tag_name
+        @nokogiri_node&.name
+      end
+
+      def attribute?(name)
+        attributes.key?(name)
+      end
+
+      def attributes
+        @attributes ||= extract_attributes
+      end
+
+      def ruby_code
+        @ruby_code_string
+      end
+
+      private
+
+      def extract_attributes
+        return {} unless @nokogiri_node
+
+        @nokogiri_node.attributes.each_with_object({}) do |(name, _attr), result|
+          result[name] = true
+        end
+      end
+    end
+  end
+end

data/lib/a11y/lint/erb_runner.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require "nokogiri"
+
+module A11y
+  module Lint
+    # Parses ERB templates and checks them against accessibility rules.
+    class ErbRunner
+      ERB_TAG = /<%.*?%>/m
+      ERB_OUTPUT_TAG = /<%=\s*(.*?)\s*-?%>/m
+
+      def initialize(rules)
+        @rules = rules
+      end
+
+      def run(source, filename:)
+        @filename = filename
+        @offenses = []
+
+        check_html_nodes(source)
+        check_erb_output_tags(source)
+
+        @offenses
+      end
+
+      private
+
+      attr_reader :rules
+
+      def check_html_nodes(source)
+        html = source.gsub(ERB_TAG, "")
+        doc = Nokogiri::HTML4::DocumentFragment.parse(html)
+
+        doc.traverse do |nokogiri_node|
+          next unless nokogiri_node.element?
+
+          node = ErbNode.new(nokogiri_node: nokogiri_node, line: nokogiri_node.line)
+          check_node(node)
+        end
+      end
+
+      def check_erb_output_tags(source)
+        source.scan(ERB_OUTPUT_TAG) do
+          match = Regexp.last_match
+          code = match[1]
+          line_number = source[0...match.begin(0)].count("\n") + 1
+          node = ErbNode.new(ruby_code: code, line: line_number)
+          check_node(node)
+        end
+      end
+
+      def check_node(node)
+        rules.each do |rule|
+          message = rule.check(node)
+          next unless message
+
+          @offenses << Offense.new(
+            rule: rule.name,
+            filename: @filename,
+            line: node.line,
+            message: message
+          )
+        end
+      end
+    end
+  end
+end

data/lib/a11y/lint/rules/link_missing_accessible_name.rb

@@ -0,0 +1,105 @@
+# frozen_string_literal: true
+
+require "ripper"
+
+module A11y
+  module Lint
+    module Rules
+      # Checks that link_to / external_link_to calls with empty text
+      # include an aria-label (WCAG 4.1.2).
+      class LinkMissingAccessibleName < Rule
+        LINK_METHODS = %w[link_to external_link_to].freeze
+
+        def check(node)
+          return unless link_with_empty_text_and_no_accessible_name?(node)
+
+          "link with empty text content requires an aria-label (WCAG 4.1.2)"
+        end
+
+        private
+
+        def link_with_empty_text_and_no_accessible_name?(node)
+          code = node.ruby_code
+          return false unless code
+
+          sexp = Ripper.sexp(code)
+          return false unless sexp
+
+          call = extract_link_call(sexp)
+          return false unless call
+
+          first_arg_empty_string?(call) && !aria_label_within?(call)
+        end
+
+        def extract_link_call(sexp)
+          return unless sexp.is_a?(Array)
+          return sexp if link_call?(sexp)
+
+          sexp.each do |child|
+            result = extract_link_call(child)
+            return result if result
+          end
+
+          nil
+        end
+
+        def link_call?(sexp)
+          case sexp
+          in [:command, [:@ident, name, *], *] if LINK_METHODS.include?(name) then true
+          in [:method_add_arg, [:fcall, [:@ident, name, *]], *] if LINK_METHODS.include?(name) then true
+          else false
+          end
+        end
+
+        def first_arg_empty_string?(call)
+          args = extract_args(call)
+          return false unless args&.first
+
+          args.first in [:string_literal, [:string_content]]
+        end
+
+        def extract_args(call)
+          case call
+          in [:command, _, [:args_add_block, args, *]] then args
+          in [:method_add_arg, _, [:arg_paren, [:args_add_block, args, *]]] then args
+          else nil
+          end
+        end
+
+        def aria_label_within?(sexp)
+          return true if aria_hash_with_label?(sexp)
+          return true if aria_label_string_key?(sexp)
+          return false unless sexp.is_a?(Array)
+
+          sexp.any? { |child| aria_label_within?(child) }
+        end
+
+        def aria_hash_with_label?(sexp)
+          return false unless sexp.is_a?(Array) && sexp[0] == :assoc_new
+
+          key = sexp[1]
+          value = sexp[2]
+
+          (key in [:@label, "aria:", *]) && label_key_within?(value)
+        end
+
+        def label_key_within?(sexp)
+          return true if label_key?(sexp)
+          return false unless sexp.is_a?(Array)
+
+          sexp.any? { |child| label_key_within?(child) }
+        end
+
+        def label_key?(sexp)
+          sexp.is_a?(Array) && sexp[0] == :assoc_new && (sexp[1] in [:@label, "label:", *])
+        end
+
+        def aria_label_string_key?(sexp)
+          return false unless sexp.is_a?(Array) && sexp[0] == :assoc_new
+
+          sexp[1] in [:string_literal, [:string_content, [:@tstring_content, "aria-label", *]]]
+        end
+      end
+    end
+  end
+end

data/lib/a11y/lint/{runner.rb → slim_runner.rb}

@@ -3,7 +3,7 @@
 module A11y
   module Lint
     # Parses Slim templates and checks them against accessibility rules.
-    class Runner
+    class SlimRunner
       def initialize(rules)
         @rules = rules
       end

data/lib/a11y/lint/version.rb

@@ -2,6 +2,6 @@
 
 module A11y
   module Lint
-    VERSION = "0.3.1"
+    VERSION = "0.5.0"
   end
 end

data/lib/a11y/lint.rb

@@ -1,13 +1,17 @@
 # frozen_string_literal: true
 
 require "slim"
+require "nokogiri"
 require_relative "lint/version"
 require_relative "lint/offense"
 require_relative "lint/node"
+require_relative "lint/erb_node"
 require_relative "lint/rule"
 require_relative "lint/rules/image_tag_missing_alt"
 require_relative "lint/rules/img_missing_alt"
-require_relative "lint/runner"
+require_relative "lint/rules/link_missing_accessible_name"
+require_relative "lint/slim_runner"
+require_relative "lint/erb_runner"
 
 module A11y
   module Lint

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: a11y-lint
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Abdullah Hashim
@@ -9,6 +9,20 @@ bindir: exe
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.13'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.13'
 - !ruby/object:Gem::Dependency
   name: slim
   requirement: !ruby/object:Gem::Requirement
@@ -42,12 +56,15 @@ files:
 - exe/a11y-lint
 - lib/a11y/lint.rb
 - lib/a11y/lint/cli.rb
+- lib/a11y/lint/erb_node.rb
+- lib/a11y/lint/erb_runner.rb
 - lib/a11y/lint/node.rb
 - lib/a11y/lint/offense.rb
 - lib/a11y/lint/rule.rb
 - lib/a11y/lint/rules/image_tag_missing_alt.rb
 - lib/a11y/lint/rules/img_missing_alt.rb
-- lib/a11y/lint/runner.rb
+- lib/a11y/lint/rules/link_missing_accessible_name.rb
+- lib/a11y/lint/slim_runner.rb
 - lib/a11y/lint/version.rb
 - sig/a11y/lint.rbs
 homepage: https://github.com/Guided-Rails/a11y-lint