a11y-lint 0.13.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c17375bf978e252c281fec08a28a33d0fc22642e49d8aeb5af721454dc967f1
-  data.tar.gz: 9c89ac25d4163cb4807b31c396114bac42a153ecd7309effb4c77fd19c292c91
+  metadata.gz: c80dbcc5dec24d2850b42b84b2bbf512dc792f9c77e41ba4fd778d792c0d750a
+  data.tar.gz: aff2c4e3002a785f2f8fbfc5cfe9b115466cc3850299114b8724a82b5c71e52a
 SHA512:
-  metadata.gz: 637000bab2f93eacb3a7a799a22e8844c450f7a0da6226cada99866c57accc4bb60a4dfc36bbf7355fa35aaaf155a88bf593caef26c159d8451b0053b83f5105
-  data.tar.gz: ae04ef4e64f360df93fae63aaa502f08462958f29c3fa5e1f9afe89b263dd0d1a8ec2f0212e35507bb30ddfab7804ae50f88e9278b3e565ca591c889beb739dd
+  metadata.gz: c6431784a0c4704f7040953c2ef881678b13e61fee513f639c1ff4de019a4bb1599633638902764dc0cf9f9b25fe553349262639e0f30029033e5498f252f23a
+  data.tar.gz: 5b140955d0e2eadc1fefe2314bf85a16f0129d0c2cf569deb507c829ca0cf1aeb633ed601d670e4eef814d1b825a0576a5ad5d41e733bf4c8fceae7b6040f4fe

data/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.14.0] - 2026-04-28
+
+### Changed
+
+- **Breaking:** `SimpleFormSelectMissingAccessibleName` is now `SimpleFormInputMissingAccessibleName` and flags any Simple Form `form.input` with `label: false`/`label: ""` that has no `aria-label` or `aria-labelledby` in `input_html`, regardless of input type (WCAG 4.1.2). `as: :hidden` is skipped. Projects that pinned the rule by name in `.a11y-lint.yml` need to update the key
+
 ## [0.13.0] - 2026-04-28
 
 ### Added

data/docs/src/rules/form-controls-need-accessible-names.md

@@ -29,15 +29,19 @@ In Simple Form, both go inside `input_html`:
 
 A placeholder is **not** a label. It disappears as soon as the user types, browsers don't reliably expose it as the accessible name, and it fails users who rely on the prompt staying visible while they fill the field.
 
-## SimpleFormSelectMissingAccessibleName
-{:#simple-form-select-missing-accessible-name}
+## SimpleFormInputMissingAccessibleName
+{:#simple-form-input-missing-accessible-name}
 
-Applies to: Simple Form `form.input` calls that render a `<select>` — either `collection:` is passed, or `as: :select` is set — when `label: false` or `label: ""` hides the visible label.
+Applies to: Simple Form `form.input` calls with `label: false` or `label: ""` — regardless of input type. `as: :hidden` is skipped, since hidden inputs don't render a visible control.
 
 The rule passes when `input_html` provides `aria-label` or `aria-labelledby`. Both hash and string keys are accepted (`aria: { label: "..." }` and `"aria-label" => "..."`).
 
 ### Bad
 
+```erb
+<%%= form.input :name, label: false %>
+```
+
 ```erb
 <%%= form.input :sort_by, collection: opts, label: false %>
 ```
@@ -48,17 +52,18 @@ The rule passes when `input_html` provides `aria-label` or `aria-labelledby`. Bo
 
 ### Good
 
-Render a visible label by removing `label: false`:
+Render a visible label by removing `label: false` and letting Simple Form generate one from the attribute name, or by passing an explicit string:
 
 ```erb
+<%%= form.input :name %>
 <%%= form.input :sort_by, collection: opts, label: "Sort by" %>
 ```
 
 Or, when there's no visible label, supply `aria-label`:
 
 ```erb
-<%%= form.input :sort_by, collection: opts, label: false,
-      input_html: { aria: { label: "Sort by" } } %>
+<%%= form.input :name, label: false,
+      input_html: { aria: { label: "Name" } } %>
 ```
 
 Or `aria-labelledby` pointing to existing visible text:
@@ -69,19 +74,25 @@ Or `aria-labelledby` pointing to existing visible text:
       input_html: { aria: { labelledby: "sort-label" } } %>
 ```
 
+`as: :hidden` doesn't render a visible control, so it's exempt:
+
+```erb
+<%%= form.input :secret, as: :hidden, label: false %>
+```
+
 ### Slim equivalent
 
 ```slim
-= form.input :sort_by, collection: opts, label: false, input_html: { aria: { label: "Sort by" } }
+= form.input :name, label: false, input_html: { aria: { label: "Name" } }
 ```
 
 ## What this rule doesn't catch
 
 This rule has a deliberately narrow scope. Things it doesn't flag:
 
-- **Plain `<select>` elements.** The rule targets Simple Form's `form.input` helper. A bare `<select>` with no associated `<label>` is not reported.
+- **Plain HTML form controls.** The rule targets Simple Form's `form.input` helper. A bare `<input>`, `<select>`, or `<textarea>` with no associated `<label>` is not reported.
 - **Other Simple Form helpers.** `form.select`, `form.association`, and similar helpers aren't checked — only `form.input`.
-- **Other input types.** `form.input` rendering as text, email, checkbox, radio, etc. is not checked. Selects are flagged because the `label: false` + missing aria pattern is unusually common for sort and filter dropdowns.
+- **Inputs without `label: false`.** Simple Form auto-generates a label from the attribute name, so `form.input :name` is treated as having a visible label. The rule only kicks in once the label is explicitly suppressed.
 - **Phlex views.** The rule is a no-op in Phlex by design. The Phlex pipeline only walks receiverless calls, so `form.input(...)` isn't surfaced as a candidate node. Simple Form code embedded inside a Phlex component won't be checked.
 - **Bad accessible name content.** `aria: { label: "" }` will pass the rule check above (an empty aria-label is its own problem, but not this rule's). `aria: { label: "select" }` will pass. The linter checks that an aria attribute is present, not that the value is useful.
 - **Dynamic accessible names.** `aria: { label: variable }` satisfies the rule even if `variable` is `nil` at runtime.

data/lib/a11y/lint/rules/robust/{simple_form_select_missing_accessible_name.rb → simple_form_input_missing_accessible_name.rb}

@@ -3,11 +3,11 @@
 module A11y
   module Lint
     module Rules
-      # Checks that Simple Form `form.input` calls rendering a select
-      # (via `collection:` or `as: :select`) with `label: false` /
+      # Checks that Simple Form `form.input` calls with `label: false` /
       # `label: ""` provide an accessible name through `input_html:`
-      # `aria-label` or `aria-labelledby` (WCAG 4.1.2).
-      class SimpleFormSelectMissingAccessibleName < NodeRule
+      # `aria-label` or `aria-labelledby` (WCAG 4.1.2). Skips
+      # `as: :hidden`, which doesn't render a visible control.
+      class SimpleFormInputMissingAccessibleName < NodeRule
         def check
           return if no_offense?
 
@@ -18,14 +18,13 @@ module A11y
 
         def no_offense?
           !helper_call ||
-            !select_like? ||
             !helper_call.label_hidden? ||
+            hidden_input? ||
             aria_label_in_input_html?
         end
 
-        def select_like?
-          helper_call.keyword?(:collection) ||
-            helper_call.keyword_symbol?(:as, :select)
+        def hidden_input?
+          helper_call.keyword_symbol?(:as, :hidden)
         end
 
         def aria_label_in_input_html?
@@ -53,7 +52,7 @@ module A11y
 
         def offense_message
           <<~MSG.strip
-            form.input select missing an accessible name \
+            form.input missing an accessible name \
             requires aria-label or aria-labelledby in input_html (WCAG 4.1.2)
           MSG
         end

data/lib/a11y/lint/version.rb

@@ -2,6 +2,6 @@
 
 module A11y
   module Lint
-    VERSION = "0.13.0"
+    VERSION = "0.14.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: a11y-lint
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.14.0
 platform: ruby
 authors:
 - Abdullah Hashim
@@ -124,7 +124,7 @@ files:
 - lib/a11y/lint/rules/robust/button_missing_accessible_name.rb
 - lib/a11y/lint/rules/robust/button_tag_missing_accessible_name.rb
 - lib/a11y/lint/rules/robust/link_to_missing_accessible_name.rb
-- lib/a11y/lint/rules/robust/simple_form_select_missing_accessible_name.rb
+- lib/a11y/lint/rules/robust/simple_form_input_missing_accessible_name.rb
 - lib/a11y/lint/slim_node.rb
 - lib/a11y/lint/slim_runner.rb
 - lib/a11y/lint/version.rb