TrelloCycleTime 1.0.2 → 1.0.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Y2RhOTdkNGY4M2E0YTQ0MTAyMWZiZDMzZjRlNTFiZTQxN2Y1ZmI5Mw==
+    MzUzNmViNzIxOGM1MTI5NTFiYTY0M2I2ZTkyNDE3ODViZTI1MWRjNA==
   data.tar.gz: !binary |-
-    NGMwMzFiZGViYjViYzRmMzY3OWU4MzMxNTM4YTMxYmY3OTFhNmZhMw==
+    ZjIwMzlmNWVkYmNmMjQ4OGI5ZjhmMDYzZGU3MDRkYjJiN2YzMmQ1Mw==
 SHA512:
   metadata.gz: !binary |-
-    NzA3ODVlYzFjYTM4NzljZjVlMmI5NjIxYjkyY2FmYjVmOTQ3MTI1M2MwYmZm
-    YWE1NTczODRjZTQyN2FkZGQwMmVkOGI0YWE1MTBkMDY5OWQzNmNlMDY3ZmEy
-    ZTFlNmM4OWMxNmUwYTE3MDkzZjg1ZTRjZDUwY2RhYjQwZTM4MTI=
+    ZTgxZWEwZDA1YTQ2M2Y1ZGY0YjJhYjQ5NWJlOTZkOTY4MGYzMDUxYTQ3NTg4
+    YzAxZmM3MWJiYmZkMzMzY2QzY2UwZGM5OWU1NWNmNmQyMzdjNTQyY2ViMDQ2
+    ZDVmNDllODhkNmYzMGZiZDBjNWQwYTFlODNjZDcyZTE1YTY5OGY=
   data.tar.gz: !binary |-
-    MTdiZGFiYWQ3NzZiNjk5YmFlY2QyZWE2NWMyMDMzM2JjZTRmN2NkMTFhMDky
-    ZDFjYTU3YzE3ODY0OWM3OGI2OGJhNzRlNjUyOWJhYjkwNDFjOTMzMjg5NDQy
-    ZjhmMjFlNjk0MWRlMDliNzMwYjAzOGI1YWVmYTk5MDQ2ZTVhZTc=
+    YjVjYmU1ZGM5OTViOTZlMWU5ZjE1ZTkyZTU0YTBjYzJhYzM5OTg1YzZkNTNm
+    MTg2NDA3Zjk1N2M2NzI2ZTUwMzE2NzFiNzM5NGM5OGJjOGJkMTFmNDZjYTkx
+    ZjQyZDk5MTc3ZmQzYTNiMWIwYjJjMTlhYzIwY2QwNGIwMmI3ZTE=

data/lib/{CardRepository.rb → BoardCardRepository.rb}

@@ -1,15 +1,14 @@
 module AgileTrello
-	class CardRepository
-		def initialize(trello, parameters)
-			@trello_board = trello.get_board(parameters[:board_id])
-			@end_list = parameters[:end_list]
+	class BoardCardRepository
+		def initialize(trello_board)
+			@trello_board = trello_board
 		end
 
-		def get_cards_after
+		def get_cards_after(end_list)
 			cards_after = []
 			ignore = true
 			@trello_board.lists.each do | list | 
-				ignore = !list.name.include?(@end_list) if ignore
+				ignore = !list.name.include?(end_list) if ignore
 				if !ignore
 					list.cards.each do | card |
 						cards_after.push(card)

data/lib/BoardCardRepositoryFactory.rb

@@ -0,0 +1,14 @@
+require_relative './BoardCardRepository'
+
+module AgileTrello
+	class BoardCardRepositoryFactory
+		def initialize(trello)
+			@trello = trello
+		end
+
+		def create(board_id)
+			trello_board = @trello.get_board(board_id)
+			BoardCardRepository.new(trello_board)
+		end
+	end
+end

data/lib/CompletedCard.rb

@@ -7,5 +7,9 @@ module AgileTrello
 		def initialize(start_date, end_date)
 			@cycle_time = ((end_date - start_date) / SECONDS_IN_24HRS).round(2)
 		end
+
+		def shareCycleTimeWith(calculator)
+			calculator.add(@cycle_time)
+		end
 	end
 end

data/lib/CompletedCardFactory.rb

@@ -11,13 +11,26 @@ module AgileTrello
 			@start_list = parameters[:start_list]
 			@end_list = parameters[:end_list]
 			@all_lists = parameters[:all_lists]
+			@measurement_start_date = 
+				parameters[:measurement_start_date].nil? ? Time.new(1066) : parameters[:measurement_start_date]
 		end
 
 		def create(trello_card)
 			card_history = CardHistory.new(trello_card, @all_lists)
-			start_date = card_history.find_date_entered_list(@start_list)
 			end_date = card_history.find_date_entered_list(@end_list)
-			CompletedCard.new(start_date, end_date)
+			is_in_measured_period = end_date > @measurement_start_date
+
+			if (is_in_measured_period)
+				start_date = card_history.find_date_entered_list(@start_list)
+				CompletedCard.new(start_date, end_date)
+			else
+				CardBeforeMeasurementPeriod.new
+			end
+		end
+	end
+
+	class CardBeforeMeasurementPeriod
+		def shareCycleTimeWith(calculator)
 		end
 	end
 end

data/lib/CompletedCards.rb

@@ -0,0 +1,34 @@
+require 'peach'
+require_relative './CompletedCardFactory'
+require_relative './BoardCardRepositoryFactory'
+
+module AgileTrello
+	class CompletedCards
+		def initialize(trello, average_cycle_time_calculator, trello_list_repository)
+			@board_card_repository_factory = BoardCardRepositoryFactory.new(trello)
+			@trello_list_repository = trello_list_repository
+			@average_cycle_time_calculator = average_cycle_time_calculator
+		end
+
+		def retrieve(parameters)
+			board_id = parameters[:board_id]
+			end_list = parameters[:end_list]
+
+			completed_card_for_board_factory = CompletedCardFactory.new(
+				start_list: parameters[:start_list], 
+				end_list: end_list,
+				all_lists: @trello_list_repository.get(board_id),
+				average_cycle_time_calculator: parameters[:average_cycle_time_calculator],
+				measurement_start_date: parameters[:measurement_start_date]
+			)
+			@board_card_repository_factory
+				.create(board_id)
+				.get_cards_after(end_list)
+				.peach do |card|
+					completed_card_for_board_factory
+						.create(card)
+						.shareCycleTimeWith(@average_cycle_time_calculator)
+				end
+		end
+	end
+end

data/lib/TrelloCycleTime.rb

@@ -1,24 +1,21 @@
-require 'peach'
 require_relative './TrelloFactory'
 require_relative './TrelloCredentials'
 require_relative './AverageCycleTimeCalculator'
-require_relative './CompletedCardRepository'
+require_relative './CompletedCards'
+require_relative './TrelloListRepository'
 
 module AgileTrello
 	class TrelloCycleTime
 		def initialize(parameters = {}) 
 			trello_credentials = TrelloCredentials.new(parameters[:public_key], parameters[:access_token])
 			trello_factory = parameters[:trello_factory].nil? ? TrelloFactory.new : parameters[:trello_factory]
-			@trello = trello_factory.create(trello_credentials) 
+			trello = trello_factory.create(trello_credentials) 
 			@average_cycle_time_calculator = AverageCycleTimeCalculator.new
+			@completed_cards = CompletedCards.new(trello, @average_cycle_time_calculator, TrelloListRepository.new(trello))
 		end
 
 		def get(parameters)
-			completed_card_repository = CompletedCardRepository.new(@trello, parameters)
-			finished_cards = completed_card_repository.get
-			finished_cards.peach do | card |
-				@average_cycle_time_calculator.add(card.cycle_time)
-			end
+			@completed_cards.retrieve(parameters)
 			return @average_cycle_time_calculator.average
 		end
 	end

data/lib/TrelloListRepository.rb

@@ -0,0 +1,14 @@
+module AgileTrello
+	class TrelloListRepository
+		def initialize(trello)
+			@trello = trello
+		end
+
+		def get(board_id)
+			trello_board = @trello.get_board(board_id)
+			trello_board.lists.map do |list|
+				list.name
+			end
+		end
+	end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: TrelloCycleTime
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - iainjmitchell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-30 00:00:00.000000000 Z
+date: 2014-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-trello
@@ -45,14 +45,16 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/AverageCycleTimeCalculator.rb
+- lib/BoardCardRepository.rb
+- lib/BoardCardRepositoryFactory.rb
 - lib/CardHistory.rb
-- lib/CardRepository.rb
 - lib/CompletedCard.rb
 - lib/CompletedCardFactory.rb
-- lib/CompletedCardRepository.rb
+- lib/CompletedCards.rb
 - lib/TrelloCredentials.rb
 - lib/TrelloCycleTime.rb
 - lib/TrelloFactory.rb
+- lib/TrelloListRepository.rb
 homepage: https://github.com/code-computerlove/trello-cycletime
 licenses:
 - MIT

data/lib/CompletedCardRepository.rb

@@ -1,26 +0,0 @@
-require_relative './CompletedCardFactory'
-require_relative './CardRepository'
-
-module AgileTrello
-	class CompletedCardRepository
-		def initialize(trello, parameters)
-			trello_board = trello.get_board(parameters[:board_id])
-			all_lists_on_board = trello_board.lists.map do |list|
-				list.name
-			end
-			@card_repository = CardRepository.new(trello, parameters)
-			@completed_card_factory = CompletedCardFactory.new(
-				start_list: parameters[:start_list], 
-				end_list: parameters[:end_list],
-				all_lists: all_lists_on_board
-			)
-		end
-
-		def get
-			completed_cards = @card_repository.get_cards_after
-			completed_cards.map do |card|
-				@completed_card_factory.create(card)
-			end
-		end
-	end
-end