Standupguy 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba4bd2e4edfbcee6241461bb5008fe793faf4b65
-  data.tar.gz: 1238127b7bb2644348b6318a2e2cc156d79cd549
+  metadata.gz: d89d88926c7b160d56688692aace3e91aad9185b
+  data.tar.gz: 7e357661c32ebb99e0556c0769e95dd4e09e98d3
 SHA512:
-  metadata.gz: 8017d3360110eeb5df50d4036bc3d1b53589f265087cd51ad060f5b8acbaf3931470b25806bfe62c4ec7dda768a74b5e829998549d8ad4b1cbe94e256f25eda5
-  data.tar.gz: c734bd54c9da9f8b2d4680c96d5810107158c661015b6e0a37d348e2f477f5bbbfc884b0618bb05a319da1b87f1e800167ed577ba0d2d4ed18221b46f4d7bfde
+  metadata.gz: dc19f6bb20eae4f7cb5a6e9e6e6e9318346fffcd8432b871d82acad48c58c4f9e7634d240ec51565241b9efb8aab8de6339c58f6787adabfceae53a29f8516fc
+  data.tar.gz: ccfce4d5eed8e03a15fc577d8225d53821f0a3f63c7091f261c969072e970b64b6b1c07b9c6409a41aaa27c2ca1d2b88f4e3b25dc3364ce7d798fa8969199d8a

data/.rubocop.yml

@@ -0,0 +1,4 @@
+Metrics/LineLength:
+  Enabled: false
+Rails/Output:
+  Enabled: false

data/.semver

@@ -1,5 +1,5 @@
 ---
 :major: 0
 :minor: 0
-:patch: 8
+:patch: 9
 :special: ''

data/Standupguy.gemspec

@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "byebug"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "rspec-nc"
   spec.add_development_dependency "guard"
   spec.add_development_dependency "guard-rspec"
   spec.add_development_dependency "semver"

data/lib/Standupguy.rb

@@ -176,25 +176,47 @@ module Standupguy
     attr_accessor :data
 
     def method_missing(method, *args)
-      return unless [:description=, :name=, :date=].include?(method)
+      method_list = [:description=, :name=, :date=, :ticket_id=]
+      return unless method_list.include?(method)
       method = method.to_s.chop.to_sym
       @data[method] = args.first
     end
 
+    def continue?
+      puts <<-EOS
+This ticket has already been added. Do you want to continue adding it? (y/N)
+      EOS
+      STDIN.gets.downcase.chomp[0] == "y"
+    end
+
     def save
       current_standup = load_data
       current_standup ||= { date_key => [] }
       data_exists = current_standup.keys.include?(date_key)
-      current_standup[date_key] = [] unless data_exists
+      begin
+        if data_exists && !!@data[:ticket_id]
+          ticket_list = current_standup[date_key]
+          ticket_list.map! { |item| item["ticket_id"] }
+          unless ticket_list.empty?
+            already_added = ticket_list.include?(@data[:ticket_id])
+            raise "Already added" if already_added
+          end
+        end
+      rescue RuntimeError
+        return unless continue?
+      end
+
+      current_standup[date_key] ||= []
       current_standup[date_key] << @data
       write_data(current_standup)
     end
 
     def add_to_today(item)
-      @data ||= { description: "", name: "", date: "" }
+      @data ||= { description: "", date: "", ticket_id: false }
       ticket = TicketUrl.new(item)
       if ticket.valid?
         zendesk_ticket = client(ticket.subdomain).tickets.find(id: ticket.id)
+        self.ticket_id = item
         self.description = "#{item} => (#{zendesk_ticket.subject})"
       else
         self.description = item

data/lib/Standupguy/version.rb

@@ -1,3 +1,3 @@
 module Standupguy
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/spec/item_spec.rb

@@ -2,43 +2,83 @@ require "spec_helper"
 require_relative "../lib/Standupguy"
 
 describe Standupguy::Item do
+  before { @datafile = create_test_file! }
   describe "#add_to_today" do
-    subject(:item) { Standupguy::Item.new }
-
-    context "for zendesk tickets" do
+    describe "for zendesk tickets" do
       before do
+        @item = Standupguy::Item.new
         expect_zendesk("foo", "api/v2/tickets/1").
           to_return(headers: {"Content-Type" => "application/json"}, body: JSON.dump("ticket" => {"subject" => "test ticket"}))
-        item.add_to_today("https://foo.zendesk.com/tickets/1")
+        @item.add_to_today("https://foo.zendesk.com/tickets/1")
       end
 
       it "includes the ticket subject in the description" do
-        expect(item.data[:description]).to match(/test ticket/)
+        expect(@item.data[:description]).to match(/test ticket/)
       end
 
       it "includes the original url" do
-        expect(item.data[:description]).to match(/foo.zendesk.com\/tickets\/1/)
+        expect(@item.data[:description]).to match(/foo.zendesk.com\/tickets\/1/)
+      end
+
+      it "includes the ticket_id" do
+        expect(@item.data[:ticket_id]).to eq("https://foo.zendesk.com/tickets/1")
+      end
+
+      describe "adding the same ticket again" do
+        subject { Standupguy::Item.new }
+
+        before do
+          @item.save
+          expect_zendesk("foo", "api/v2/tickets/1").
+            to_return(headers: {"Content-Type" => "application/json"}, body: JSON.dump("ticket" => {"subject" => "test ticket"}))
+        end
+
+        describe "choosing to continue" do
+          it "adds the item" do
+            Standupguy::Item.any_instance.expects(:continue?).returns(true)
+            subject.add_to_today("https://foo.zendesk.com/tickets/1")
+            subject.save
+            expect(JSON.load(@datafile.read)[key].size).to eq(2)
+          end
+
+          describe "#continue?" do
+            it "outputs" do
+              STDIN.expects(:gets).returns("y")
+              expect do
+                subject.add_to_today("https://foo.zendesk.com/tickets/1")
+                subject.save
+              end.to output.to_stdout
+            end
+          end
+        end
+
+        describe "choosing not to continue" do
+          it "does not add the item" do
+            Standupguy::Item.any_instance.expects(:continue?).returns(false)
+            subject.add_to_today("https://foo.zendesk.com/tickets/1")
+            subject.save
+            expect(JSON.load(@datafile.read)[key].size).to eq(1)
+          end
+        end
       end
     end
 
-    context "for non-zendesk tickets" do
+    describe "for non-zendesk tickets" do
+      subject{ Standupguy::Item.new }
+
       it "takes an item" do
-        item.add_to_today("foob")
-        expect(item.data[:description]).to match(/foob/)
-        expect(item.data[:name]).to match(`whoami`.chop)
-        expect(item.data[:date]).to match(key)
+        subject.add_to_today("foob")
+        expect(subject.data[:description]).to match(/foob/)
+        expect(subject.data[:name]).to match(`whoami`.chop)
+        expect(subject.data[:date]).to match(key)
       end
     end
   end
 
   describe "#save" do
-    before do
-      @datafile = create_test_file!
-    end
-
     subject(:item) do
       test_item = Standupguy::Item.new
-      test_item.add_to_today("foo")
+      test_item.add_to_today("foo bazzyle")
       test_item
     end
 
@@ -46,10 +86,10 @@ describe Standupguy::Item do
       item.save
       expect_datafile(@datafile, %r{foo})
     end
+  end
 
-    after do
-      @datafile.close
-      @datafile.unlink
-    end
+  after do
+    @datafile.close
+    @datafile.unlink
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: Standupguy
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Adam Panzer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-30 00:00:00.000000000 Z
+date: 2015-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,20 +66,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-nc
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -217,6 +203,7 @@ files:
 - ".coveralls.yml"
 - ".gitignore"
 - ".hound.yml"
+- ".rubocop.yml"
 - ".semver"
 - ".travis.yml"
 - Gemfile