SassyLists 0.4.5 → 0.4.6

data/CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
-* `0.4.5`: made `sort()` able to return in descending order
+* `0.4.6`: fixing an issue when passing an empty list to `chunk()` and improved code quality
+* `0.4.5`: making `sort()` able to return in descending order
 * `0.4.4`: fixing a typo in `purge()`
 * `0.4.3`: improving `insert-nth()`, `prepend()`, `replace-nth()` and `replace()` to prevent from adding empty lists
 * `0.4.2`: improving `insert-nth()` and cleaning some indentation issues

data/lib/SassyLists.rb

@@ -5,8 +5,8 @@ Compass::Frameworks.register('SassyLists', :path => extension_path)
 #  Version is a number. If a version contains alphas, it will be created as a prerelease version
 #  Date is in the form of YYYY-MM-DD
 module SassyLists
-  VERSION = "0.4.5"
-  DATE = "2013-12-06"
+  VERSION = "0.4.6"
+  DATE = "2013-12-07"
 end
 
 module Sass::Script::Functions

data/stylesheets/SassyLists/_chunk.scss

@@ -8,9 +8,16 @@
 // @param $list [List] : list
 // @param $size [Number] : length of lists
 // -------------------------------------------------------------------------------
-// @return [List]
+// @raise [Error] if $list is empty
+// -------------------------------------------------------------------------------
+// @return [List] | false
 
 @function chunk($list, $size) {
+    @if $list == () {
+        @warn "Trying to chunk empty list in `chunk`.";
+        @return false;
+    }
+
     @if $size >= length($list) {
         @return $list;
     }

data/stylesheets/SassyLists/_contain.scss

@@ -13,7 +13,7 @@
 // @return [Boolean]
 
 @function contain($list, $value) {
-    @return not not index($list, $value)
+    @return not not index($list, $value);
 }
 
 // Alias

data/stylesheets/SassyLists/_debug.scss

@@ -12,10 +12,6 @@
 // @return [String]
 
 @function debug($list, $pre: false, $level: 1) {
-    $tab: "    ";
-    $indent: "";
-    $break: if($pre, "\A ", "");
-  
     @if length($list) == 0 {
         @return "( )";
     }
@@ -24,6 +20,10 @@
         @return if($pre,  "(" + type-of($list) + ") ", "") + $list;
     }
 
+    $tab: "    ";
+    $indent: "";
+    $break: if($pre, "\A ", "");
+
     @for $i from 1 to $level {
         $indent: $indent + $tab;
     }

data/stylesheets/SassyLists/_insert-nth.scss

@@ -18,34 +18,30 @@
 // @return [List] | false
 
 @function insert-nth($list, $index, $value) {
-    $result: false;
-
     @if type-of($index) != number {
         @warn "List index #{$index} is not a number for `insert-nth`.";
-        @return $result;
+        @return false;
     }
 
-    @else if $index < 1 {
+    @if $index < 1 {
         @warn "List index #{$index} must be a non-zero integer for `insert-nth`";
-        @return $result;
+        @return false;
     }
 
-    @else if $index > length($list) {
+    @if $index > length($list) {
         @return append($list, $value);
     }
 
-    @else {
-        $result: ();
+    $result: ();
 
-        @for $i from 1 through length($list) {
-            @if $i == $index {
-                @if $value and $value != "" and $value != () {
-                    $result: append($result, $value);
-                }
+    @for $i from 1 through length($list) {
+        @if $i == $index {
+            @if $value and $value != "" and $value != () {
+                $result: append($result, $value);
             }
-
-            $result: append($result, nth($list, $i));
         }
+
+        $result: append($result, nth($list, $i));
     }
 
     @return $result;

data/stylesheets/SassyLists/_replace-nth.scss

@@ -19,31 +19,27 @@
 // @return [List] | false
 
 @function replace-nth($list, $index, $value) {
-    $result: false;
-
     @if type-of($index) != number {
         @warn "List index #{$index} is not a number for `replace-nth`/`remove-nth`.";
-        @return $result;
+        @return false;
     }
 
-    @else if $index == 0 {
+    @if $index == 0 {
         @warn "List index 0 must be a non-zero integer for `replace-nth`/`remove-nth`.";
-        @return $result;
+        @return false;
     }
 
-    @else if abs($index) > length($list) {
+    @if abs($index) > length($list) {
         @warn "List index is #{$index} but list is only #{length($list)} item long for `replace-nth`/`remove-nth`.";
-        @return $result;
+        @return false;
     }
 
-    @else {
-        $result: ();
-        $index: if($index < 0, length($list) + $index + 1, $index);  
+    $result: ();
+    $index: if($index < 0, length($list) + $index + 1, $index);  
 
-        @for $i from 1 through length($list) {
-            @if $value and $value != "" and $value != () {
-                $result: append($result, if($i == $index, $value, nth($list, $i)));
-            }
+    @for $i from 1 through length($list) {
+        @if $value and $value != "" and $value != () {
+            $result: append($result, if($i == $index, $value, nth($list, $i)));
         }
     }
 

data/stylesheets/SassyLists/_slice.scss

@@ -22,39 +22,35 @@
 // @return [List] | false
 
 @function slice($list, $start: 1, $end: length($list)) {
-    $result: false;
-
     @if type-of($start) != number or type-of($end) != number {
         @warn "List indexes #{$start} and #{$end} must be numbers for `slice`.";
-        @return $result;
+        @return false;
     }
 
-    @else if $start > $end {
+    @if $start > $end {
         @warn "Start index is #{$start} but has to be lesser than or equals to the end index (#{$end}) for `slice`.";
-        @return $result;
+        @return false;
     }
 
-    @else if $start < 1 or $end < 1 {
+    @if $start < 1 or $end < 1 {
         @warn "List indexes must be non-zero integers for `slice`.";
-        @return $result;
+        @return false;
     }
 
-    @else if $start > length($list) {
+    @if $start > length($list) {
         @warn "Start index is #{$start} but list is only #{length($list)} items long for `slice`.";
-        @return $result;
+        @return false;
     }
 
-    @else if $end > length($list) {
+    @if $end > length($list) {
         @warn "End index is #{$end} but list is only #{length($list)} items long for `slice`.";
-        @return $result;
+        @return false;
     }
 
-    @else {
-        $result: ();
-            
-        @for $i from $start through $end {
-            $result: append($result, nth($list, $i));
-        }
+    $result: ();
+        
+    @for $i from $start through $end {
+        $result: append($result, nth($list, $i));
     }
 
     @return $result;

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: SassyLists
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-06 00:00:00.000000000 Z
+date: 2013-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sass