ProMotion 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: be839599d650130f82f0fa241e88bf2b76fc4964
-  data.tar.gz: b1f0799f8f393b3de1d8b60307b6e256225682c3
+  metadata.gz: 22dee782b5f904dab39ce97ce900fe1012daf866
+  data.tar.gz: 92a7e426f1d01a67fa8a8431d23f912109e14322
 SHA512:
-  metadata.gz: 3fedb2aff2f4df877da8a384599ea6aaec3ef572c479016a7fc84d8447b4089459a88ef1611502df27668bd29a2fa25f597d7c83333ffeae5c26091b43a1e88c
-  data.tar.gz: 54c0ccb64e0eb8dab7b113efa724ce33e239d2b6464a69107ba5087ec9d6025f6306ddbda274980f944770769d72ff35ff2b6d56d7fc06320e2def33409de071
+  metadata.gz: ad1fd5927fa02167ecb552141242827953fc22288e625ab342ec592ff2ef26da757f76c37f7d88657cb5df7968873ca97188fd99f3abd7d545f324d4328cdc0b
+  data.tar.gz: 773bb526a2679efdc727e460e59b087cdb8d599c3264c6838279605af19117ba0cbd2bf600c8849cffe2ee90a54732dc39608e67f616033d7edd8cffe6ea0b68

data/README.md

@@ -132,10 +132,14 @@ If you need help, feel free to open an issue on GitHub. If we don't respond with
 
 See [CONTRIBUTING.md](https://github.com/clearsightstudio/ProMotion/blob/master/CONTRIBUTING.md).
 
-## Primary Contributors
+## Core Team
 
 * Jamon Holmgren: [@jamonholmgren](https://twitter.com/jamonholmgren)
 * Silas Matson: [@silasjmatson](https://twitter.com/silasjmatson)
 * Mark Rickert: [@markrickert](https://twitter.com/markrickert)
 * Ryan Linton: [@ryanlntn](https://twitter.com/ryanlntn)
+* David Larrabee: [@squidpunch](https://twitter.com/squidpunch)
+
+## Other Contributors
+
 * [Many others](https://github.com/clearsightstudio/ProMotion/graphs/contributors)

data/lib/ProMotion/screen/screen_module.rb

@@ -42,9 +42,13 @@ module ProMotion
       when :light
         status_bar_hidden false
         status_bar_style UIStatusBarStyleLightContent
-      else
+      when :dark
         status_bar_hidden false
         status_bar_style UIStatusBarStyleDefault
+      else
+        status_bar_hidden false
+        global_style = NSBundle.mainBundle.objectForInfoDictionaryKey("UIStatusBarStyle")
+        status_bar_style global_style ? Object.const_get(global_style) : UIStatusBarStyleDefault
       end
     end
 

data/lib/ProMotion/table/table.rb

@@ -20,6 +20,7 @@ module ProMotion
       set_up_refreshable
       set_up_longpressable
       set_up_row_height
+      set_up_accessibility
     end
 
     def check_table_data
@@ -89,6 +90,19 @@ module ProMotion
       end
     end
 
+    def editable?
+      self.promotion_table_data.sections.each do |section|
+        section[:cells].each do |cell|
+          return true if [:insert,:delete].include?(cell[:editing_style])
+        end
+      end
+      false
+    end
+
+    def set_up_accessibility
+      self.extend(Editable) if editable?
+    end
+
     def searching?
       self.promotion_table_data.filtered
     end
@@ -155,14 +169,22 @@ module ProMotion
         new_cell.extend(PM::TableViewCellModule) unless new_cell.is_a?(PM::TableViewCellModule)
         new_cell.autoresizingMask = UIViewAutoresizingFlexibleWidth|UIViewAutoresizingFlexibleLeftMargin|UIViewAutoresizingFlexibleRightMargin
         new_cell.clipsToBounds = true # fix for changed default in 7.1
-        new_cell.send(:on_load) if new_cell.respond_to?(:on_load)
+        on_cell_created new_cell, data_cell
         new_cell
       end
       table_cell.setup(data_cell, self) if table_cell.respond_to?(:setup)
-      table_cell.send(:on_reuse) if !new_cell && table_cell.respond_to?(:on_reuse)
+      on_cell_reused(table_cell, data_cell) if !new_cell
       table_cell
     end
 
+    def on_cell_created(new_cell, data_cell)
+      new_cell.send(:on_load) if new_cell.respond_to?(:on_load)
+    end
+
+    def on_cell_reused(cell, data)
+      cell.send(:on_reuse) if cell.respond_to?(:on_reuse)
+    end
+
     def update_table_data(args = {})
       args = { index_paths: args } unless args.is_a?(Hash)
 
@@ -235,9 +257,11 @@ module ProMotion
       map_cell_editing_style(data_cell[:editing_style])
     end
 
-    def tableView(_, commitEditingStyle: editing_style, forRowAtIndexPath: index_path)
-      if editing_style == UITableViewCellEditingStyleDelete
-        delete_row(index_path)
+    module Editable
+      def tableView(_, commitEditingStyle: editing_style, forRowAtIndexPath: index_path)
+        if editing_style == UITableViewCellEditingStyleDelete
+          delete_row(index_path)
+        end
       end
     end
 

data/lib/ProMotion/version.rb

@@ -1,3 +1,3 @@
 module ProMotion
-  VERSION = "2.3.0" unless defined?(ProMotion::VERSION)
+  VERSION = "2.3.1" unless defined?(ProMotion::VERSION)
 end

data/spec/unit/screen_spec.rb

@@ -43,6 +43,24 @@ describe "screen properties" do
     UIApplication.sharedApplication.statusBarStyle.should == UIStatusBarStyleLightContent
   end
 
+  it "should set the UIStatusBar style to :dark" do
+    UIApplication.sharedApplication.statusBarStyle = UIStatusBarStyleLightContent
+    @screen.class.status_bar :dark
+    @screen.view_will_appear(false)
+    UIApplication.sharedApplication.isStatusBarHidden.should == false
+    UIApplication.sharedApplication.statusBarStyle.should == UIStatusBarStyleDefault
+  end
+
+  it "should default to a global UIStatusBar style" do
+    NSBundle.mainBundle.mock!(:objectForInfoDictionaryKey) do |key|
+      "UIStatusBarStyleLightContent"
+    end
+    @screen.class.status_bar :default
+    @screen.view_will_appear(false)
+    UIApplication.sharedApplication.isStatusBarHidden.should == false
+    UIApplication.sharedApplication.statusBarStyle.should == UIStatusBarStyleLightContent
+  end
+
   it "should set the tab bar item with a system item" do
     @screen.set_tab_bar_item system_item: :contacts
     comparison = UITabBarItem.alloc.initWithTabBarSystemItem(UITabBarSystemItemContacts, tag: 0)

data/spec/unit/tables/table_screen_spec.rb

@@ -63,6 +63,28 @@ describe "table screens" do
       screen.view.estimatedRowHeight.should == 77
     end
 
+    it "sets up proper accessibility methods" do
+      class NoneditableTableScreen < PM::TableScreen
+        def on_load
+        end
+
+        def table_data
+          [{
+            title: "test",
+            cells: [{ title: "Non-editable test" }]
+          }]
+        end
+      end
+
+      noneditable = NoneditableTableScreen.new
+      noneditable.on_load
+      noneditable.editable?.should==false
+      index_path = NSIndexPath.indexPathForRow(0, inSection: 0)
+      lambda { noneditable.tableView(noneditable, commitEditingStyle: UITableViewCellEditingStyleDelete, forRowAtIndexPath: index_path) }.should.raise NoMethodError
+      @screen.editable?.should == true
+      @screen.should.respond_to(:"tableView:commitEditingStyle:forRowAtIndexPath")
+    end
+
   end
 
   describe "search functionality" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ProMotion
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - Jamon Holmgren
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-03 00:00:00.000000000 Z
+date: 2015-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: methadone