ProMotion 2.0.0.rc1 → 2.0.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 71f77fdb9b22a8f0cd193388c516ccdc22a1e809
-  data.tar.gz: 180d0751d10df56d4c1f3a17bb689a8b584b0bd3
+  metadata.gz: 237481070752e84a433f41a7d0bc8aca9d315999
+  data.tar.gz: 64fb7aa97e1f907c0805d623a60eb9435ef510f8
 SHA512:
-  metadata.gz: c2e5f9f37a826c0456b47995ecf36b8240ec45d07244523aa18256e2f8882f445973f950f6f389321b260c63c8f5608c1cc7d601de433d85d0aa01ff4d6e1fdd
-  data.tar.gz: 30404bfa59a50c7212a7881b40062f242001b5b5f46bff2b4d87f450a66421f28594e0179a12a7e1a6106054fe94d70cc52f6c7924a505e538701c67b2fe2096
+  metadata.gz: 8395a8ece941acb58790fef73b2b32c13bc1097fb02fefb15e150526d2c4597a6167f96379eb938f35cc3a5b66a2da536ecc3a4b554f0e2a6d847de5c45e86c7
+  data.tar.gz: 6b77365b92b5a7905f904c1e25c0d913068fa9d7382132299ef9e733d775886410ec70aa64f5b16605c7afe101903f77d8adc6a6e3dcc88ae88a748279ff2126

data/README.md

@@ -87,6 +87,8 @@ end
 
 Overview: In ProMotion 2.0, we removed deprecated APIs, refactored and cleaned up a ton of code, pulled `PushNotification` and `MapScreen` into their own gems, and simplified the API. It now builds 55% faster and is 20%+ lighter.
 
+Follow our [Migration Guide](https://github.com/clearsightstudio/ProMotion/wiki/Migration-Guide:-ProMotion-1.2-to-2.0) for a painless upgrade.
+
 **API changes**
 
 1. Extracted `PM::MapScreen` into [ProMotion-map](https://github.com/clearsightstudio/ProMotion-map)
@@ -111,7 +113,7 @@ Overview: In ProMotion 2.0, we removed deprecated APIs, refactored and cleaned u
 3. Moved many files around into a more logical, simpler structure.
 4. Removed `PM::Conversions`. The only helper we were using was the `objective_c_method_name` method, and that was only used in `PM::Styling`. So we moved it there.
 5. New module, `PM::NavBarModule`. Moved any navigation controller methods into this module, cleaning up the `PM::ScreenModule` quite a bit.
-6. Lots of code refactoring -- CodeClimate went from 2.47 to 3.42 GPA.
+6. Lots of code refactoring -- CodeClimate went from [2.47 to 3.35 GPA](http://clrsight.co/jh/8fi5l31nzs.png).
 7. Much cleaner `open` code!
 8. Converted several *slow* functional tests into *fast* unit tests with the same coverage.
 

data/lib/ProMotion/table/cell/table_view_cell_module.rb

@@ -16,15 +16,16 @@ module ProMotion
       set_remote_image
       set_accessory_view
       set_selection_style
+      set_accessory_type
     end
 
   protected
 
     # TODO: Remove this in ProMotion 2.1. Just for migration purposes.
     def check_deprecated_styles
-      whitelist = [ :title, :subtitle, :image, :remote_image, :accessory, :selection_style, :action, :arguments, :cell_style, :cell_class, :cell_identifier, :editing_style, :search_text, :keep_selection, :height ]
+      whitelist = [ :title, :subtitle, :image, :remote_image, :accessory, :selection_style, :action, :long_press_action, :arguments, :cell_style, :cell_class, :cell_identifier, :editing_style, :search_text, :keep_selection, :height, :accessory_type ]
       if (data_cell.keys - whitelist).length > 0
-        PM.logger.deprecated("In #{self.table_screen.class.to_s}#table_data, you should set :#{(data_cell.keys - whitelist).join(", :")} in a `styles:` hash. See TableScreen documentation.")
+        PM.logger.deprecated("In #{self.table_screen.class.to_s}#table_data, you should set :#{(data_cell.keys - whitelist).join(", :")} in a `style:` hash. See TableScreen documentation.")
       end
     end
 
@@ -80,6 +81,10 @@ module ProMotion
       self.selectionStyle = map_selection_style_symbol(data_cell[:selection_style]) if data_cell[:selection_style]
     end
 
+    def set_accessory_type
+      self.accessoryType = map_accessory_type_symbol(data_cell[:accessory_type]) if data_cell[:accessory_type]
+    end
+
   private
 
     def jm_image_cache?
@@ -121,5 +126,15 @@ module ProMotion
         default:  UITableViewCellSelectionStyleDefault
       }[symbol] || symbol
     end
+
+    def map_accessory_type_symbol(symbol)
+      {
+        none:                 UITableViewCellAccessoryNone,
+        disclosure_indicator: UITableViewCellAccessoryDisclosureIndicator,
+        disclosure_button:    UITableViewCellAccessoryDetailDisclosureButton,
+        checkmark:            UITableViewCellAccessoryCheckmark,
+        detail_button:        UITableViewCellAccessoryDetailButton
+      }[symbol] || symbol
+    end
   end
 end

data/lib/ProMotion/version.rb

@@ -1,3 +1,3 @@
 module ProMotion
-  VERSION = "2.0.0.rc1" unless defined?(ProMotion::VERSION)
+  VERSION = "2.0.0.rc2" unless defined?(ProMotion::VERSION)
 end

data/spec/unit/tables/table_view_cell_spec.rb

@@ -13,7 +13,7 @@ describe "PM::TableViewCellModule" do
       accessory: {
         view: :switch, # currently only :switch is supported
         value: true
-      }, 
+      },
       image: {
         image: UIImage.imageNamed("list"),
         radius: 15
@@ -24,7 +24,8 @@ describe "PM::TableViewCellModule" do
           masks_to_bounds: true
         },
         background_color: UIColor.redColor
-      }
+      },
+      accessory_type: :disclosure_indicator
     }
   end
 
@@ -136,6 +137,8 @@ describe "PM::TableViewCellModule" do
     @subject.imageView.layer.cornerRadius.should == 15.0
   end
 
-end
-
+  it "should have the proper accessory type" do
+    @subject.accessoryType.should == UITableViewCellAccessoryDisclosureIndicator
+  end
 
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ProMotion
 version: !ruby/object:Gem::Version
-  version: 2.0.0.rc1
+  version: 2.0.0.rc2
 platform: ruby
 authors:
 - Jamon Holmgren
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-22 00:00:00.000000000 Z
+date: 2014-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: methadone