PageRankr 2.0.0 → 2.0.1

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change Log
 
+## Version 2.0.1
+* Alexa sometimes returns result for the incorrect site. In this case, the results returned are ignored.
+
 ## Version 2.0.0
 * URL validation
 * Parallel requests = way faster!

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    PageRankr (1.7.1)
+    PageRankr (2.0.0)
       json (>= 1.4.6)
       nokogiri (>= 1.4.1)
       public_suffix_service (~> 0.8.1)

data/PageRankr.gemspec

@@ -7,8 +7,8 @@ Gem::Specification.new do |s|
   s.authors     = ["Allen Madsen"]
   s.email       = ["blatyo@gmail.com"]
   s.homepage    = "http://github.com/blatyo/page_rankr"
-  s.summary     = "Easy way to retrieve Google Page Rank, Alexa Rank, and backlink counts"
-  s.description = "Easy way to retrieve Google Page Rank, Alexa Rank, and backlink counts"
+  s.summary     = "Easy way to retrieve Google Page Rank, Alexa Rank, backlink counts, and index counts."
+  s.description = "Easy way to retrieve Google Page Rank, Alexa Rank, backlink counts, and index counts."
 
   s.required_rubygems_version = ">= 1.3.6"
   s.add_development_dependency "rspec",   "~> 2.1.0"

data/README.md

@@ -1,6 +1,6 @@
 # PageRankr
 
-Provides an easy way to retrieve Google Page Rank, Alexa Rank, and backlink counts.
+Provides an easy way to retrieve Google Page Rank, Alexa Rank, backlink counts, and index counts.
 
 Check out a little [web app][1] I wrote up that uses it or look at the [source][2].
 
@@ -142,10 +142,12 @@ Then, just make sure you require the class and PageRankr and whenever you call P
     * Optionally use API keys
     * Maybe allow API key cycling to get around query limits
 * Google search API is deprecated
+* Some search engines throttle the amount of queries. It would be nice to know when this happens. Probably throw an exception.
 
 ## Contributors
-* [Druwerd](https://github.com/Druwerd) - Use Google Search API instead of scraping.
+* [Dru Ibarra](https://github.com/Druwerd) - Use Google Search API instead of scraping.
 * [Iteration Labs, LLC](https://github.com/iterationlabs) - Compete rank tracker and domain indexes.
+* [Mark Seeger](https://github.com/rb2k) - Ignore invalid ranks that Alexa returns for incorrect sites.
 
 ## Shout Out
 Gotta give credit where credits due!

data/lib/page_rankr/ranks/alexa_global.rb

@@ -6,8 +6,14 @@ module PageRankr
     class AlexaGlobal
       include Rank
       
+      # Alexa may sometimes return a result for the incorrect site and thus it is necessary to check if
+      # the results returned are for the site we want.
+      #
+      # For example, slocourts.net returns results for ca.gov, presumably because www.slocourts.ca.gov redirects
+      # to slocourts.net. Clearly something is wrong with how Alexa handles this case and so in the event this
+      # happens we treat the results as if there were no results.
       def xpath
-        "//popularity/@text"
+         "//popularity[contains(@url, '#{@site.domain}')]/@text"
       end
       
       def request

data/lib/page_rankr/ranks/alexa_us.rb

@@ -6,8 +6,14 @@ module PageRankr
     class AlexaUs
       include Rank
       
+      # Alexa may sometimes return a result for the incorrect site and thus it is necessary to check if
+      # the results returned are for the site we want.
+      #
+      # For example, slocourts.net returns results for ca.gov, presumably because www.slocourts.ca.gov redirects
+      # to slocourts.net. Clearly something is wrong with how Alexa handles this case and so in the event this
+      # happens we treat the results as if there were no results.
       def xpath
-        "//reach/@rank"
+        "//popularity[contains(@url, '#{@site.domain}')]/../reach/@rank"
       end
       
       def request

data/lib/page_rankr/version.rb

@@ -1,3 +1,3 @@
 module PageRankr
-  VERSION = "2.0.0"
+  VERSION = "2.0.1"
 end

data/spec/edge_cases_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe PageRankr do
+  describe "#ranks" do
+    # Alexa may sometimes return a result for the incorrect site and thus it is necessary to check if
+    # the results returned are for the site we want.
+    #
+    # For example, slocourts.net returns results for ca.gov, presumably because www.slocourts.ca.gov redirects
+    # to slocourts.net. Clearly something is wrong with how Alexa handles this case and so in the event this
+    # happens we treat the results as if there were no results.
+    describe "when Alexa returns results for the incorrect site" do
+      subject{ PageRankr.ranks("slocourts.net", :alexa_us, :alexa_global) }
+      
+      it{ should have_key(:alexa_us) }
+      it{ should have_key(:alexa_global) }
+      
+      it{ subject[:alexa_us].should be_nil }
+      it{ subject[:alexa_global].should be_nil }
+    end
+  end
+end

metadata

@@ -1,12 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: PageRankr
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 2
-  - 0
-  - 0
-  version: 2.0.0
+  prerelease: 
+  version: 2.0.1
 platform: ruby
 authors: 
 - Allen Madsen
@@ -14,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-02 00:00:00 -05:00
+date: 2011-02-23 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -25,10 +21,6 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        segments: 
-        - 2
-        - 1
-        - 0
         version: 2.1.0
   type: :development
   version_requirements: *id001
@@ -40,10 +32,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 0
-        - 0
         version: 1.0.0
   type: :development
   version_requirements: *id002
@@ -55,10 +43,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 0
-        - 1
         version: 0.0.1
   type: :development
   version_requirements: *id003
@@ -70,10 +54,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 4
-        - 1
         version: 1.4.1
   type: :runtime
   version_requirements: *id004
@@ -85,10 +65,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 4
-        - 6
         version: 1.4.6
   type: :runtime
   version_requirements: *id005
@@ -100,10 +76,6 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 8
-        - 1
         version: 0.8.1
   type: :runtime
   version_requirements: *id006
@@ -115,14 +87,10 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 2
-        - 1
         version: 0.2.1
   type: :runtime
   version_requirements: *id007
-description: Easy way to retrieve Google Page Rank, Alexa Rank, and backlink counts
+description: Easy way to retrieve Google Page Rank, Alexa Rank, backlink counts, and index counts.
 email: 
 - blatyo@gmail.com
 executables: []
@@ -162,6 +130,7 @@ files:
 - lib/page_rankr/site.rb
 - lib/page_rankr/tracker.rb
 - lib/page_rankr/version.rb
+- spec/edge_cases_spec.rb
 - spec/page_rankr_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
@@ -178,26 +147,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 1
-      - 3
-      - 6
       version: 1.3.6
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
-summary: Easy way to retrieve Google Page Rank, Alexa Rank, and backlink counts
+summary: Easy way to retrieve Google Page Rank, Alexa Rank, backlink counts, and index counts.
 test_files: 
+- spec/edge_cases_spec.rb
 - spec/page_rankr_spec.rb
 - spec/spec_helper.rb