MuranoCLI 3.0.1 → 3.0.2

data/spec/cmd_exchange_spec.rb

@@ -0,0 +1,118 @@
+# Last Modified: 2017.08.31 /coding: utf-8
+# frozen_string_literal: true
+
+# Copyright © 2016-2017 Exosite LLC.
+# License: MIT. See LICENSE.txt.
+#  vim:tw=0:ts=2:sw=2:et:ai
+
+require 'fileutils'
+require 'open3'
+require 'pathname'
+
+require 'cmd_common'
+require 'MrMurano/Config'
+
+RSpec.describe 'murano exchange', :cmd, :needs_password do
+  include_context 'CI_CMD'
+
+  context 'without project' do
+    it 'help' do
+      cmd_verify_help('exchange')
+    end
+  end
+
+  context 'with project' do
+    #before(:example) { project_up }
+    #after(:example) { project_down }
+
+    def expect_exchange_element_table(stdout, stderr, num_cols: nil)
+      expect(stderr).to eq('')
+      lines = stdout.lines
+      # FIXME/2017-08-29: Is this too much detail??
+      #   What about running test once, dumping output to file,
+      #   and expecting same output next time?
+      expect(lines[0]).to match(/^Found [\d]+ elements.$/)
+      # Outline of table. n columns. '+-----+-----+---...----+\n'
+      expect(lines[1]).to match(/^(\+-+){#{num_cols}}\+$/)
+      # Header.
+      expect(lines[2]).to match(/^\| elementId/)
+      # Separator.
+      expect(lines[3]).to match(/^(\+-+){#{num_cols}}\+$/)
+      # Content. Starts with elementId.
+      (4..(lines.length - 2)).to_a.each do |line|
+        expect(lines[line]).to match(/^\| [0-9a-f]+ \| /)
+      end
+      expect(lines[-1]).to match(/^(\+-+){#{num_cols}}\+$/)
+    end
+
+    context 'list' do
+      it 'as table' do
+        stdout, stderr = murano_command_run('exchange list')
+        # 4 columns: elementId, name, status, description.
+        expect_exchange_element_table(stdout, stderr, num_cols: 4)
+      end
+
+      it 'only ids' do
+        stdout, stderr = murano_command_run('exchange list', '--idonly')
+        expect(stderr).to eq('')
+        stdout.lines.each do |line|
+          expect(line).to match(/^[0-9a-f]+$/)
+        end
+      end
+
+      it 'fewer fields' do
+        stdout, stderr = murano_command_run('exchange list', '--brief')
+        # 3 columns: elementId, name, status.
+        expect_exchange_element_table(stdout, stderr, num_cols: 3)
+      end
+
+      it 'as json' do
+        stdout, stderr = murano_command_run('exchange list', '-c', 'outformat=json')
+        expect(stderr).to eq('')
+        expect { JSON.parse(stdout) }.to_not raise_error
+        #expect(status.exitstatus).to eq(0)
+      end
+
+      it 'output to file' do
+        stdout, stderr = murano_command_run('exchange list', '--idonly', '-o', 'bob')
+        expect(stderr).to eq('')
+        expect(stdout).to eq('')
+        #expect(status.exitstatus).to eq(0)
+        expect(File.exist?('bob')).to be true
+        data = IO.read('bob')
+        expect(data).to match(/^(\S+\s)*\S+$/)
+      end
+
+      context 'purchase' do
+        # MAYBE/TESTME/2017-08-30: Cannot functional test 'exchange purchase'
+        # of 'available' element because you cannot un-add elements (you'd
+        # have to create a new business). We could add a unit test of
+        # MrMurano::Exchange.purchase, though. But it's just 4 statements,
+        # and the functional test here for adding an already added element
+        # also tests that same function. So probably no need to add test.
+
+        it 'is ambiguous name' do
+          # MEH/2017-08-31: This test is dependent on the platform having
+          # more than one element with the term 'IoT' in its name!
+          stdout, stderr = murano_command_exits('exchange purchase', 'IoT')
+          expect(stdout).to eq('')
+          expect(stderr).to a_string_starting_with(
+            'Please be more specific: More than one matching element was found: '
+          )
+        end
+
+        it 'is already added ID' do
+          element_name = 'Timer Service'
+          stdout, _stderr = murano_command_run('exchange list', element_name, '--idonly')
+          element_id = stdout.strip
+          stdout, stderr = murano_command_exits('exchange purchase', element_id)
+          expect(stdout).to eq('')
+          expect(stderr).to eq(
+            "The specified element has already been purchased: ‘#{element_name}’ (#{element_id})\n"
+          )
+        end
+      end
+    end
+  end
+end
+

data/spec/cmd_help_spec.rb

@@ -1,25 +1,66 @@
+# Last Modified: 2017.08.31 /coding: utf-8
+# frozen_string_literal: true
+
+# Copyright © 2016-2017 Exosite LLC.
+# License: MIT. See LICENSE.txt.
+#  vim:tw=0:ts=2:sw=2:et:ai
+
 require 'fileutils'
 require 'open3'
 require 'pathname'
+
+require 'highline/import'
+
 require 'cmd_common'
 
 RSpec.describe 'murano help', :cmd do
-  include_context "CI_CMD"
+  include_context 'CI_CMD'
 
-  it "no args" do
-    out, err, status = Open3.capture3(capcmd('murano'))
-    expect(err).to eq('')
-    expect(out).to_not eq('')
-    expect(status.exitstatus).to eq(0)
-  end
+  context 'using subshell' do
+    it 'no args' do
+      out, err, status = Open3.capture3(capcmd('murano'))
+      expect(err).to eq('')
+      expect(out).to_not eq('')
+      expect(status.exitstatus).to eq(0)
+    end
 
-  it "as --help" do
-    out, err, status = Open3.capture3(capcmd('murano', '--help'))
-    expect(err).to eq('')
-    expect(out).to_not eq('')
-    expect(status.exitstatus).to eq(0)
+    it 'as --help' do
+      out, err, status = Open3.capture3(capcmd('murano', '--help'))
+      expect(err).to eq('')
+      expect(out).to_not eq('')
+      expect(status.exitstatus).to eq(0)
+    end
   end
 
+  context 'using commander' do
+    it 'no args' do
+      #cmd_verify_help('help')
+      stdout, stderr = murano_command_run('help')
+      # The :help command gets processed by optparse, since we did
+      # not call run!, and optparse looks at $0, which is 'rspec'.
+      expect(strip_color(stdout)).to start_with(
+        "  NAME:\n\n    #{File.basename $PROGRAM_NAME}\n\n  DESCRIPTION:\n\n    "
+      )
+      expect(stderr).to eq('')
+    end
+
+    it 'as --help' do
+      stdout, stderr = murano_command_wont_parse('help', '--help')
+      # See comment above; optparse uses $0, or 'rspec'.
+      expect(strip_color(stdout)).to start_with(
+        "Usage: #{File.basename $PROGRAM_NAME} [options]\n"
+      )
+      expect(stderr).to eq('')
+    end
+
+    # The version flag is processed in ::Commander::Runner.instance.run!,
+    # which we're not calling, and if we try to test it here, optparse
+    # ends up trying to handle it and barfs when it cannot find parser.ver
+    #it 'cannot test version' do
+    #  #stdout, stderr = murano_command_run('-v')
+    #  #stdout, stderr = murano_command_run('help', '-v')
+    #  #stdout, stderr = murano_command_run('help', '--version')
+    #end
+  end
 end
 
-#  vim: set ai et sw=2 ts=2 :

data/spec/cmd_init_spec.rb

@@ -1,4 +1,4 @@
-# Last Modified: 2017.08.16 /coding: utf-8
+# Last Modified: 2017.08.29 /coding: utf-8
 # frozen_string_literal: true
 
 # Copyright © 2016-2017 Exosite LLC.
@@ -136,17 +136,6 @@ RSpec.describe 'murano init', :cmd do
     expecting
   end
 
-  def murano_solutions_expunge_yes
-    out, err, status = Open3.capture3(capcmd('murano', 'solutions', 'expunge', '-y'))
-    expect(out).to eq('').
-      or eq("No solutions found\n").
-      or eq("Deleted 1 solution\n").
-      or eq("Deleted 2 solutions\n")
-    expect(err).to eq('').
-      or eq("\e[31mNo solutions found\e[0m\n")
-    expect(status.exitstatus).to eq(0).or eq(1)
-  end
-
   it "Won't init in HOME (gracefully)" do
     # this is in the project dir. Want to be in HOME
     Dir.chdir(ENV['HOME']) do

data/spec/cmd_link_spec.rb

@@ -1,4 +1,4 @@
-# Last Modified: 2017.08.16 /coding: utf-8
+# Last Modified: 2017.08.30 /coding: utf-8
 # frozen_string_literal: probably not yet
 
 # Copyright © 2016-2017 Exosite LLC.
@@ -8,91 +8,113 @@
 require 'fileutils'
 require 'open3'
 require 'pathname'
+
 require 'cmd_common'
+require 'MrMurano/Config'
 
 RSpec.describe 'murano link', :cmd, :needs_password do
   include_context "CI_CMD"
 
-  before(:example) do
-    @solz_name = rname('linktest')
-    out, err, status = Open3.capture3(capcmd('murano', 'application', 'create', @solz_name, '--save'))
-    expect(err).to eq('')
-    expect(out.chomp).to match(/^[a-zA-Z0-9]+$/)
-    expect(status.exitstatus).to eq(0)
+  context "without project" do
+    it "help" do
+      cmd_verify_help('link')
+    end
 
-    out, err, status = Open3.capture3(capcmd('murano', 'product', 'create', @solz_name, '--save'))
-    expect(err).to eq('')
-    expect(out.chomp).to match(/^[a-zA-Z0-9]+$/)
-    expect(status.exitstatus).to eq(0)
-  end
-  after(:example) do
-    out, err, status = Open3.capture3(capcmd('murano', 'application', 'delete', @solz_name, '-y'))
-    expect(out).to eq('')
-    expect(err).to eq('')
-    expect(status.exitstatus).to eq(0)
+    # 2017-08-30: The next two tests show the difference between using a
+    # subshell to run murano commands versus running them directly. The
+    # latter method lets us get coverage of the command modules.
+    context "subshell vs inline" do
+      context "using subshell" do
+        it "will not list" do
+          out, err, status = Open3.capture3(capcmd('murano', 'link', 'list'))
+          expect(strip_color(out)).to eq(MrMurano::Config::INVALID_PROJECT_HINT + "\n")
+          expecting = %(The "link list" command only works in a Murano project.\n)
+          expect(strip_color(err)).to eq(expecting)
+          expect(status.exitstatus).to eq(1)
+        end
+      end
 
-    out, err, status = Open3.capture3(capcmd('murano', 'product', 'delete', @solz_name, '-y'))
-    expect(out).to eq('')
-    expect(err).to eq('')
-    expect(status.exitstatus).to eq(0)
+      context "using commander" do
+        it "will not list" do
+          stdout, stderr = murano_command_run('link list')
+          expect(stdout).to eq(MrMurano::Config::INVALID_PROJECT_HINT + "\n")
+          expect(stderr).to eq(
+            %(The "link list" command only works in a Murano project.\n)
+          )
+        end
+      end
+    end
   end
 
-  it "links and lists" do
-    out, err, status = Open3.capture3(capcmd('murano', 'assign', 'set'))
-    #expect(out).to a_string_starting_with("Linked product #{@solz_name}")
-    olines = out.lines
+  context "with project" do
+    before(:example) { project_up(skip_link: true) }
+    after(:example) { project_down }
 
-    # Windows has a complaint about the fancy quotes if you don't encode!, which is
-    #
-    #   expected: "Linked \u2018syncdowntestprd1e8b4034\u2019
-    #               to \u2018syncdowntestapp23d5135b\u2019\n"
-    #        got: "Linked \xE2\x80\x98syncdowntestprd1e8b4034\xE2\x80\x99
-    #               to \xE2\x80\x98syncdowntestapp23d5135b\xE2\x80\x99\n"
-    #
-    # or, to put it another way,
-    #
-    #     -Linked ?syncdowntestprd1e8b4034? to ?syncdowntestapp23d5135b?
-    #     +Linked ΓÇÿsyncdowntestprd1e8b4034ΓÇÖ to ΓÇÿsyncdowntestapp23d5135bΓÇÖ
-    #
-    # which we can solve with an encode call. (Or but using norm quotes.)
-    #
-    #expect(olines[0]).to eq("Linked ‘#{@solz_name}’ to ‘#{@solz_name}’\n")
-    expect(olines[0].encode!('UTF-8', 'UTF-8')).to eq("Linked ‘#{@solz_name}’ to ‘#{@solz_name}’\n")
+    it "links and lists" do
+      out, err, status = Open3.capture3(capcmd('murano', 'assign', 'set'))
+      #expect(out).to a_string_starting_with("Linked product #{@solz_name}")
+      olines = out.lines
 
-    expect(olines[1]).to eq("Created default event handler\n")
-    expect(err).to eq('')
-    expect(status.exitstatus).to eq(0)
+      # Windows has a complaint about the fancy quotes if you don't encode!, which is
+      #
+      #   expected: "Linked \u2018syncdowntestprd1e8b4034\u2019
+      #               to \u2018syncdowntestapp23d5135b\u2019\n"
+      #        got: "Linked \xE2\x80\x98syncdowntestprd1e8b4034\xE2\x80\x99
+      #               to \xE2\x80\x98syncdowntestapp23d5135b\xE2\x80\x99\n"
+      #
+      # or, to put it another way,
+      #
+      #     -Linked ?syncdowntestprd1e8b4034? to ?syncdowntestapp23d5135b?
+      #     +Linked ΓÇÿsyncdowntestprd1e8b4034ΓÇÖ to ΓÇÿsyncdowntestapp23d5135bΓÇÖ
+      #
+      # which we can solve with an encode call. (Or but using norm quotes.)
+      #
+      #expect(olines[0]).to eq("Linked ‘#{@solz_name}’ to ‘#{@solz_name}’\n")
+      expect(olines[0].encode!('UTF-8', 'UTF-8')).to eq(
+        "Linked ‘#{@proj_name_prod}’ to ‘#{@proj_name_appy}’\n"
+      )
 
-    out, err, status = Open3.capture3(capcmd('murano', 'assign', 'list'))
-    expect(err).to eq('')
-    olines = out.lines
-    expect(olines[0]).to match(/^(\+-+){3}\+$/)
-    expect(olines[1]).to match(/^\| name\s+\| script_key\s+\| service\s+\|$/)
-    expect(olines[2]).to match(/^(\+-+){3}\+$/)
-    expect(olines[-1]).to match(/^(\+-+){3}\+$/)
-    expect(status.exitstatus).to eq(0)
-  end
+      expect(olines[1]).to eq("Created default event handler\n")
+      expect(err).to eq('')
+      expect(status.exitstatus).to eq(0)
+
+      out, err, status = Open3.capture3(capcmd('murano', 'assign', 'list'))
+      expect(err).to eq('')
+      olines = out.lines
+      expect(olines[0]).to match(/^(\+-+){3}\+$/)
+      expect(olines[1]).to match(/^\| name\s+\| script_key\s+\| service\s+\|$/)
+      expect(olines[2]).to match(/^(\+-+){3}\+$/)
+      expect(olines[-1]).to match(/^(\+-+){3}\+$/)
+      expect(status.exitstatus).to eq(0)
+    end
 
-  it "unlinks" do
-    out, err, status = Open3.capture3(capcmd('murano', 'assign', 'set'))
-    #expect(out).to a_string_starting_with("Linked product #{@solz_name}")
-    olines = out.lines
-    expect(olines[0].encode!('UTF-8', 'UTF-8')).to eq("Linked ‘#{@solz_name}’ to ‘#{@solz_name}’\n")
-    expect(olines[1]).to eq("Created default event handler\n")
-    expect(err).to eq('')
-    expect(status.exitstatus).to eq(0)
+    it "unlinks" do
+      out, err, status = Open3.capture3(capcmd('murano', 'assign', 'set'))
+      #expect(out).to a_string_starting_with("Linked product #{@solz_name}")
+      olines = out.lines
+      expect(olines[0].encode!('UTF-8', 'UTF-8')).to eq(
+        "Linked ‘#{@proj_name_prod}’ to ‘#{@proj_name_appy}’\n"
+      )
+      expect(olines[1]).to eq("Created default event handler\n")
+      expect(err).to eq('')
+      expect(status.exitstatus).to eq(0)
 
-    out, err, status = Open3.capture3(capcmd('murano', 'link', 'unset'))
-    #expect(out).to a_string_starting_with("Unlinked #{@solz_name}")
-    # E.g.,
-    #   Unlinked ‘linktest3e7def1b86a1d680’ from ‘linktest3e7def1b86a1d680’\n
-    #   Removed ‘h2thqll2z9sqoooc0_w4w3vxla11ngg4cok_event’ from ‘linktest3e7def1b86a1d680\n
-    olines = out.lines
-    expect(olines[0].encode!('UTF-8', 'UTF-8')).to eq("Unlinked ‘#{@solz_name}’ from ‘#{@solz_name}’\n")
-    expect(olines[1].encode!('UTF-8', 'UTF-8')).to a_string_starting_with("Removed ‘")
-    expect(olines[1].encode!('UTF-8', 'UTF-8')).to match(/^Removed ‘[_a-z0-9]*’ from ‘#{@solz_name}’\n$/)
-    expect(err).to eq('')
-    expect(status.exitstatus).to eq(0)
+      out, err, status = Open3.capture3(capcmd('murano', 'link', 'unset'))
+      #expect(out).to a_string_starting_with("Unlinked #{@solz_name}")
+      # E.g.,
+      #   Unlinked ‘linktest3e7def1b86a1d680’ from ‘linktest3e7def1b86a1d680’\n
+      #   Removed ‘h2thqll2z9sqoooc0_w4w3vxla11ngg4cok_event’ from ‘linktest3e7def1b86a1d680\n
+      olines = out.lines
+      expect(olines[0].encode!('UTF-8', 'UTF-8')).to eq(
+        "Unlinked ‘#{@proj_name_prod}’ from ‘#{@proj_name_appy}’\n"
+      )
+      expect(olines[1].encode!('UTF-8', 'UTF-8')).to a_string_starting_with("Removed ‘")
+      expect(olines[1].encode!('UTF-8', 'UTF-8')).to match(
+        /^Removed ‘[_a-z0-9]*’ from ‘#{@proj_name_appy}’\n$/
+      )
+      expect(err).to eq('')
+      expect(status.exitstatus).to eq(0)
+    end
   end
 end
 

data/spec/spec_helper.rb

@@ -17,29 +17,24 @@
 #
 require 'simplecov'
 SimpleCov.start do
-  if ENV['CI_MR_EXE'].nil? then
-    coverage_dir "coverage/cov-#{RUBY_VERSION.gsub(/\./,'_')}"
+  if ENV['CI_MR_EXE'].nil?
+    coverage_dir "coverage/cov-#{RUBY_VERSION.tr('.', '_')}"
   else
-    coverage_dir "coverage/cov-#{RUBY_VERSION.gsub(/\./,'_')}-exe"
+    coverage_dir "coverage/cov-#{RUBY_VERSION.tr('.', '_')}-exe"
   end
-  add_group "Specs", "spec/.*"
-  add_group "Solution", "lib/MrMurano/Solution.*"
-  add_group "Product", "lib/MrMurano/Product.*"
+  add_group 'Specs', 'spec/.*'
+  add_group 'Solution', 'lib/MrMurano/Solution.*'
+  add_group 'Product', 'lib/MrMurano/Product.*'
 
-  track_files "lib/MrMurano/*.rb"
+  track_files 'lib/MrMurano/*.rb'
 end
 
 require 'webmock/rspec'
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-
-  if ENV['MURANO_PASSWORD'].nil? then
-    config.filter_run_excluding :needs_password
-  end
-  if Gem.win_platform? then
-    config.filter_run_excluding :broken_on_windows
-  end
+  config.filter_run_excluding :needs_password if ENV['MURANO_PASSWORD'].nil?
+  config.filter_run_excluding :broken_on_windows if Gem.win_platform?
 
   # rspec-expectations config goes here. You can use an alternate
   # assertion/expectation library such as wrong or the stdlib/minitest
@@ -84,7 +79,7 @@ RSpec.configure do |config|
   # Allows RSpec to persist some state between runs in order to support
   # the `--only-failures` and `--next-failure` CLI options. We recommend
   # you configure your source control system to ignore this file.
-  config.example_status_persistence_file_path = ".rspec_examples.txt"
+  config.example_status_persistence_file_path = '.rspec_examples.txt'
 
   # Limits the available syntax to the non-monkey patched syntax that is
   # recommended. For more details, see:
@@ -123,5 +118,5 @@ RSpec.configure do |config|
   # test failures related to randomization by passing the same `--seed` value
   # as the one that triggered the failure.
   Kernel.srand config.seed
-
 end
+