MovableInkAWS 2.7.1 → 2.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4bb30965f9a405275bbe54e8119bdc243bb4def14fb23af716488429639c6593
-  data.tar.gz: 9d31d8cde5eac0c2ae5be1673f167c2f550b2648a5593d3bc68213ce437c075d
+  metadata.gz: 4fe63a733a1146744fab177c92681cab506b4b4b7734c4cd3a7c91d65de0fd84
+  data.tar.gz: a6eab91fdcf488895c874d5cedd53e9ef4ccabba9f679461cfcb9148cefd612b
 SHA512:
-  metadata.gz: 94c2a5c1b1028585739c75c57e1a83ce5c9629539ad5c8dbb977e9b38a3abc0d9f81d47883c37a252cfe6c4dd2ee241c30349bdbf97ce0bfc37f732a8de0c6cc
-  data.tar.gz: a7e9c6001f0f659178b1be1f50527d7d1e7495f4220dfefb1e8d8d2df3b297a3d94af39603161205b719e62053548c3ae397300ed0998b88b9f998c984ad15af
+  metadata.gz: 82769e75ee09f4c0a8dc5c8a4d75c8aba427c3affd5c56270fdffd3bc5124cd20f1b1459dead8adc458f8cb9da3855d5ad4526adf391e35fe4b36ab5a9569697
+  data.tar.gz: 3a07058264a557f11c2a80c9e2eaddcb6189514d2cd449c263ca7ce148407e8ddffb5c66acc351c81f2d9edaa69edd1d2686f02308640d951d232c042136d80f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    MovableInkAWS (2.7.1)
+    MovableInkAWS (2.7.4)
       aws-sdk-athena (~> 1)
       aws-sdk-autoscaling (~> 1)
       aws-sdk-cloudwatch (~> 1)
@@ -22,7 +22,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.7.0)
+    addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     aws-eventstream (1.2.0)
     aws-partitions (1.605.0)
@@ -73,8 +73,8 @@ GEM
       aws-sigv4 (~> 1.1)
     aws-sigv4 (1.5.0)
       aws-eventstream (~> 1, >= 1.0.2)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
+    crack (0.4.5)
+      rexml
     deep_merge (1.2.2)
     diff-lcs (1.3)
     diplomat (2.4.2)
@@ -82,7 +82,7 @@ GEM
       faraday (>= 0.9, < 1.1.0)
     faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    hashdiff (1.0.0)
+    hashdiff (1.0.1)
     httparty (0.16.3)
       mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
@@ -92,7 +92,8 @@ GEM
     mime-types-data (3.2022.0105)
     multi_xml (0.6.0)
     multipart-post (2.2.3)
-    public_suffix (4.0.5)
+    public_suffix (4.0.7)
+    rexml (3.2.5)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -106,9 +107,8 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    safe_yaml (1.0.5)
-    webmock (3.7.6)
-      addressable (>= 2.3.6)
+    webmock (3.17.1)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
 
@@ -121,4 +121,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   2.3.14
+   2.3.11

data/lib/movable_ink/aws/errors.rb

@@ -8,6 +8,21 @@ module MovableInk
       class InvalidDiscoveryTypeError < StandardError; end
       class RoleNameRequiredError < StandardError; end
       class RoleNameInvalidError < StandardError; end
+
+      class ExpectedError
+        def initialize(error_class, message_patterns = [])
+          @error_class = error_class
+          message_patterns.each { |pattern| raise StandardError.new("Invalid message pattern provided #{pattern.inspect}") unless pattern.class == Regexp }
+          @message_patterns = message_patterns
+        end
+
+        def match?(exception)
+          return false unless exception.class == @error_class
+          return true if @message_patterns.length == 0
+          @message_patterns.each {|pattern| return true if exception.message.match(pattern) }
+          false
+        end
+      end
     end
   end
 end

data/lib/movable_ink/aws/route53.rb

@@ -16,7 +16,7 @@ module MovableInk
         resource_record_sets(zone, client).select{|rrs| rrs.set_identifier == instance_name}.map(&:to_h)
       end
 
-      def delete_resource_record_sets(zone, instance_name, client = nil)
+      def delete_resource_record_sets(zone, instance_name, client = nil, expected_errors = [])
         resource_record_sets = get_resource_record_sets_by_instance_name(zone, instance_name, client)
         return if resource_record_sets.empty?
 
@@ -29,7 +29,7 @@ module MovableInk
           }
         }
 
-        run_with_backoff do
+        run_with_backoff(expected_errors: expected_errors) do
           route53(client).change_resource_record_sets({change_batch: change_batch, hosted_zone_id: zone})
         end
       end

data/lib/movable_ink/aws.rb

@@ -61,7 +61,8 @@ module MovableInk
       end
     end
 
-    def run_with_backoff(quiet: false, tries: 9)
+    # exected_errors[0].class == MovableInk::AWS::ExpectedError
+    def run_with_backoff(quiet: false, tries: 9, expected_errors: [])
       tries.times do |num|
         begin
           return yield
@@ -75,6 +76,7 @@ module MovableInk
                Aws::SNS::Errors::Throttling,
                Aws::AutoScaling::Errors::Throttling,
                Aws::AutoScaling::Errors::ThrottledException,
+               Aws::AutoScaling::Errors::InternalFailure,
                Aws::S3::Errors::SlowDown,
                Aws::Route53::Errors::Throttling,
                Aws::Route53::Errors::ThrottlingException,
@@ -97,6 +99,7 @@ module MovableInk
             notify_and_sleep(sleep_time, $!.class)
           end
         rescue Aws::Errors::ServiceError => e
+          expected_errors.each {|expected_error| return if expected_error.match?(e) }
           message = "#{e.class}: #{e.message}\nFrom #{$0}\n```\n#{e.backtrace.first(3).join("\n").gsub("`","'")}\n```"
           notify_slack(subject: 'Unhandled AWS API Error', message: message)
           puts message

data/lib/movable_ink/version.rb

@@ -1,5 +1,5 @@
 module MovableInk
   class AWS
-    VERSION = '2.7.1'
+    VERSION = '2.7.4'
   end
 end

data/spec/errors_spec.rb

@@ -0,0 +1,21 @@
+require_relative '../lib/movable_ink/aws'
+require 'webmock/rspec'
+
+describe MovableInk::AWS::Errors do
+  context 'ExpectedError' do
+    it 'matches exception by class name and pattern' do
+      expected = MovableInk::AWS::Errors::ExpectedError.new(Aws::Errors::ServiceError, [/something failed/])
+      expect(expected.match?(Aws::Errors::ServiceError.new(nil, 'There\'s something failed.'))).to eq(true)
+    end
+
+    it 'matches exception by class name only' do
+      expected = MovableInk::AWS::Errors::ExpectedError.new(Aws::Errors::ServiceError)
+      expect(expected.match?(Aws::Errors::ServiceError.new(nil, 'There\'s something failed.'))).to eq(true)
+    end
+
+    it 'matches exception by class name only - negative match' do
+      expected = MovableInk::AWS::Errors::ExpectedError.new(Aws::IAM::Errors::Throttling)
+      expect(expected.match?(Aws::Errors::ServiceError.new(nil, 'There\'s something failed.'))).to eq(false)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: MovableInkAWS
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.7.4
 platform: ruby
 authors:
 - MI SRE
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-20 00:00:00.000000000 Z
+date: 2022-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-core
@@ -268,6 +268,7 @@ files:
 - spec/consul_spec.rb
 - spec/ec2_spec.rb
 - spec/elasticache_spec.rb
+- spec/errors_spec.rb
 - spec/iam_spec.rb
 - spec/metadata_spec.rb
 - spec/route53_spec.rb