MonkeyEngine 2.0.0 → 2.0.2

Sign up to get free protection for your applications and to get access to all the features.
Files changed (41) hide show
  1. checksums.yaml +4 -4
  2. data/.rubocop.yml +192 -0
  3. data/CHANGELOG.md +12 -4
  4. data/Gemfile.lock +16 -19
  5. data/lib/Action/action.rb +0 -2
  6. data/lib/Monkey/monkey.rb +1 -2
  7. data/lib/MonkeyAction/monkey_action.rb +0 -2
  8. data/lib/MonkeyAction/monkey_action_dead.rb +1 -3
  9. data/lib/MonkeyAction/monkey_action_eat.rb +1 -3
  10. data/lib/MonkeyAction/monkey_action_pause.rb +1 -3
  11. data/lib/MonkeyAction/monkey_action_sleep.rb +1 -3
  12. data/lib/MonkeyAction/monkey_action_type.rb +5 -7
  13. data/lib/MonkeyAction/monkey_action_wake.rb +1 -3
  14. data/lib/MonkeyAction/monkey_timed_action.rb +2 -4
  15. data/lib/MonkeyEngine/action_rules.rb +1 -1
  16. data/lib/MonkeyEngine/monkey_engine.rb +2 -8
  17. data/lib/MonkeyEngine/version.rb +1 -1
  18. data/lib/MonkeyKeyboard/keyboard_char.rb +0 -1
  19. data/lib/MonkeyKeyboard/keyboard_key.rb +9 -9
  20. data/lib/MonkeyKeyboard/keyboard_key_evaluator.rb +1 -1
  21. data/lib/MonkeyKeyboard/monkey_keyboard_en_us.rb +2 -2
  22. data/lib/MonkeyManager/monkey_manager.rb +5 -5
  23. data/lib/tasks/engine.rb +11 -7
  24. data/monkeyengine.gemspec +6 -2
  25. data/spec/action_rules_spec.rb +8 -14
  26. data/spec/engine_spec.rb +10 -10
  27. data/spec/keyboard_char_spec.rb +1 -1
  28. data/spec/keyboard_key_spec.rb +5 -5
  29. data/spec/monkey_action_eat_spec.rb +8 -8
  30. data/spec/monkey_action_pause_spec.rb +9 -9
  31. data/spec/monkey_action_sleep_spec.rb +9 -9
  32. data/spec/monkey_action_type_spec.rb +7 -7
  33. data/spec/monkey_action_wake_spec.rb +5 -5
  34. data/spec/monkey_factory_spec.rb +3 -11
  35. data/spec/monkey_keyboard_en_us_spec.rb +4 -7
  36. data/spec/monkey_manager_spec.rb +1 -1
  37. data/spec/monkey_service_spec.rb +11 -11
  38. data/spec/monkey_spec.rb +1 -1
  39. data/spec/spec_helper.rb +1 -1
  40. data/spec/support/shared_examples.rb +9 -9
  41. metadata +10 -9
data/lib/tasks/engine.rb CHANGED
@@ -9,7 +9,7 @@ require 'LittleWeasel'
9
9
  require File.expand_path('../MonkeyFactory', __dir__)
10
10
  require File.expand_path('../MonkeyEngine', __dir__)
11
11
 
12
- LittleWeasel.configure do |config| end
12
+ LittleWeasel.configure { |config| }
13
13
 
14
14
  module Runner
15
15
  class MonkeyRun
@@ -26,8 +26,6 @@ module Runner
26
26
  go
27
27
  sleep @runtime
28
28
  end
29
-
30
- self
31
29
  end
32
30
 
33
31
  def go
@@ -90,17 +88,23 @@ namespace :engine do
90
88
  word = monkey_word[0]
91
89
  times = monkey_word[1]
92
90
  if word.length > 1
93
- puts "#{word_index}. Monkey [#{monkey.capitalize}] typed [#{word.capitalize}] [#{times}] time(s) <=== #{word.length}-letter word!".colorize(color: :green, mode: :bold)
91
+ puts "#{word_index}. Monkey [#{monkey.capitalize}] typed [#{word.capitalize}] [#{times}] time(s) " \
92
+ "<=== #{word.length}-letter word!".colorize(
93
+ color: :green, mode: :bold
94
+ )
94
95
  else
95
- puts "#{word_index}. Monkey [#{monkey.capitalize}] typed [#{word.capitalize}] [#{times}] time(s)".colorize(color: :green)
96
+ puts "#{word_index}. Monkey [#{monkey.capitalize}] typed [#{word.capitalize}] [#{times}] time(s)"
97
+ .colorize(color: :green)
96
98
  end
97
99
  end
98
100
  end
99
- total_valid_words_count = runner.monkey_words.inject(0) { |sum, monkey_word_info| sum + monkey_word_info[1].keys.count }
101
+ total_valid_words_count = runner.monkey_words.inject(0) do |sum, monkey_word_info|
102
+ sum + monkey_word_info[1].keys.count
103
+ end
100
104
 
101
105
  puts '-----------------------------------------'
102
106
  puts "Total valid words: #{total_valid_words_count}"
103
- puts 'These monkeys can type!' if total_valid_words_count > 0
107
+ puts 'These monkeys can type!' if total_valid_words_count.positive?
104
108
  puts 'Done.'
105
109
  puts
106
110
  puts
data/monkeyengine.gemspec CHANGED
@@ -11,17 +11,21 @@ Gem::Specification.new do |spec|
11
11
  spec.version = MonkeyEngine::VERSION
12
12
  spec.authors = ['Gene M. Angelo, Jr.']
13
13
  spec.email = ['public.gma@gmail.com']
14
- spec.description = "Have some fun! MonkeyEngine is a gem that allows virtual monkeys to tap away on a virtual keyboard! Can any of them complete a sentence? write a book? The sky's the limit! Add your own AI! Publish the results! Go...BANANAS!"
14
+ spec.description = "Have some fun! MonkeyEngine is a gem that allows virtual monkeys " \
15
+ "to tap away on a virtual keyboard! Can any of them complete a sentence? " \
16
+ "write a book? The sky is the limit! Add your own AI! Publish the results! " \
17
+ "Go...BANANAS!"
15
18
  spec.summary = 'The engine that drives my monkeys!'
16
19
  spec.homepage = 'https://github.com/gangelo/monkeyengine'
17
20
  spec.license = 'MIT'
21
+ spec.required_ruby_version = '>= 3.0.1'
18
22
 
19
23
  spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
20
24
  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
21
25
  spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
22
26
  spec.require_paths = ['lib']
23
27
 
24
- spec.add_development_dependency 'bundler', '~> 2.3', '>= 2.3.20'
28
+ spec.add_development_dependency 'bundler', '~> 2.4', '>= 2.4.21'
25
29
  spec.add_development_dependency 'colorize', '~> 0.8.1'
26
30
  spec.add_development_dependency 'pry-byebug', '~> 3.9'
27
31
  spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
@@ -8,14 +8,8 @@ require 'MonkeyActions'
8
8
  require_relative '../lib/MonkeyKeyboard/keyboard_input'
9
9
 
10
10
  describe 'ActionRules' do
11
- before(:each) do
12
- end
13
-
14
- after(:all) do
15
- end
16
-
17
11
  context 'get_next_action' do
18
- it 'should throw an exception if the action is not completed' do
12
+ it 'throws an exception if the action is not completed' do
19
13
  monkey = MonkeyFactory.create :groucho
20
14
 
21
15
  monkey.extend(SpecHelpers::SetMonkeyAction)
@@ -26,24 +20,24 @@ describe 'ActionRules' do
26
20
  action = MonkeyActionType.new(monkey, keyboard_input)
27
21
  action.action_completed = false
28
22
 
29
- monkey.set_action(action)
23
+ monkey.force_action(action)
30
24
 
31
25
  lambda {
32
26
  ActionRules.instance.get_next_action monkey
33
27
  }.should raise_error MonkeyEngine::Exceptions::InvalidOperationException
34
28
  end
35
29
 
36
- it 'should get correct action if current action is nil?' do
30
+ it 'gets correct action if current action is nil?' do
37
31
  monkey = MonkeyFactory.create :groucho
38
32
 
39
33
  monkey.extend(SpecHelpers::SetMonkeyAction)
40
34
 
41
- monkey.set_action(nil)
35
+ monkey.force_action(nil)
42
36
 
43
- ActionRules.instance.get_next_action(monkey).is_a?(MonkeyActionWake).should == true
37
+ ActionRules.instance.get_next_action(monkey).is_a?(MonkeyActionWake).should be true
44
38
  end
45
39
 
46
- it 'should get correct action if current action is MonkeyActionSleep' do
40
+ it 'gets correct action if current action is MonkeyActionSleep' do
47
41
  monkey = MonkeyFactory.create :groucho
48
42
 
49
43
  monkey.extend(SpecHelpers::SetMonkeyAction)
@@ -51,9 +45,9 @@ describe 'ActionRules' do
51
45
  action = MonkeyActionSleep.new(monkey, 6 * 60)
52
46
  action.action_completed = true
53
47
 
54
- monkey.set_action(action)
48
+ monkey.force_action(action)
55
49
 
56
- ActionRules.instance.get_next_action(monkey).is_a?(MonkeyActionWake).should == true
50
+ ActionRules.instance.get_next_action(monkey).is_a?(MonkeyActionWake).should be true
57
51
  end
58
52
  end
59
53
  end
data/spec/engine_spec.rb CHANGED
@@ -5,46 +5,46 @@ require 'MonkeyActions'
5
5
  require 'MonkeyFactory'
6
6
 
7
7
  describe 'Engine' do
8
- before(:each) do
8
+ before do
9
9
  @engine = MonkeyEngine::Engine.instance
10
10
  @monkey = MonkeyFactory.create :groucho
11
11
  @monkey.extend(SpecHelpers::SetMonkeyAction)
12
12
  end
13
13
 
14
14
  context 'action_eval!' do
15
- it 'should return action completed if the action is completed' do
15
+ it 'returns action completed if the action is completed' do
16
16
  action = MonkeyActionPause.new(@monkey, 10)
17
17
  action.action_completed = false
18
18
  action.action_time_of_completion = action.action_time
19
19
 
20
- @monkey.set_action(action)
20
+ @monkey.force_action(action)
21
21
 
22
- @engine.action_eval!(action).should == true
22
+ @engine.action_eval!(action).should be true
23
23
  end
24
24
 
25
- it 'should return action not completed if the action is not completed' do
25
+ it 'returns action not completed if the action is not completed' do
26
26
  action = MonkeyActionPause.new(@monkey, 60)
27
27
  action.action_completed = false
28
28
 
29
- @monkey.set_action(action)
29
+ @monkey.force_action(action)
30
30
 
31
- @engine.action_eval!(action).should == false
31
+ @engine.action_eval!(action).should be false
32
32
  end
33
33
  end
34
34
 
35
35
  context 'action_new' do
36
- it 'should return a new action if a the current action is completed' do
36
+ it 'returns a new action if a the current action is completed' do
37
37
  action = MonkeyActionSleep.new(@monkey, 60 * 8)
38
38
  action.action_completed = true
39
39
 
40
- @monkey.set_action(action)
40
+ @monkey.force_action(action)
41
41
 
42
42
  @engine.new_action(@monkey).is_a?(MonkeyActionSleep).should_not == true
43
43
  end
44
44
  end
45
45
 
46
46
  context 'do_action' do
47
- it 'should do something' do
47
+ it 'does something' do
48
48
  skip 'todo'
49
49
  end
50
50
  end
@@ -3,7 +3,7 @@
3
3
  require 'MonkeyKeyboardEnUs'
4
4
 
5
5
  describe 'KeyboardChar' do
6
- it 'should return the proper char that it represents' do
6
+ it 'returns the proper char that it represents' do
7
7
  keyboard_char = KeyboardChar.new 'a'
8
8
 
9
9
  keyboard_char.char.should == 'a'
@@ -3,12 +3,12 @@
3
3
  require 'MonkeyKeyboardEnUs'
4
4
 
5
5
  describe 'KeyboardKey' do
6
- it 'should should return correct properties' do
6
+ it 'shoulds return correct properties' do
7
7
  keyboard_key = KeyboardKey.new 'a', 'A', :left, 1
8
8
 
9
- keyboard_key.keyboard_char.should == 'a'
10
- keyboard_key.keyboard_shift_char.should == 'A'
11
- keyboard_key.keyboard_key_section.should == :left
12
- keyboard_key.keyboard_key_weight.should == 1
9
+ keyboard_key.keyboard_char.should eq 'a'
10
+ keyboard_key.keyboard_shift_char.should eq 'A'
11
+ keyboard_key.keyboard_key_section.should eq :left
12
+ keyboard_key.keyboard_key_weight.should eq 1
13
13
  end
14
14
  end
@@ -23,10 +23,10 @@ describe 'MonkeyActionEat' do
23
23
  MonkeyEngine::MonkeyManager.instance.join_all(10)
24
24
  end
25
25
 
26
- it_should_behave_like 'MonkeyAction'
26
+ it_behaves_like 'MonkeyAction'
27
27
 
28
28
  it '@it should be the correct type' do
29
- @it.is_a?(MonkeyActionEat).should == true
29
+ @it.is_a?(MonkeyActionEat).should be true
30
30
  end
31
31
 
32
32
  # Monkey
@@ -40,7 +40,7 @@ describe 'MonkeyActionEat' do
40
40
  end
41
41
 
42
42
  it '@value should be is_a? Integer' do
43
- @it.value.is_a?(Integer).should == true
43
+ @it.value.is_a?(Integer).should be true
44
44
  end
45
45
 
46
46
  # Weight
@@ -49,34 +49,34 @@ describe 'MonkeyActionEat' do
49
49
  end
50
50
 
51
51
  # validate
52
- it 'should not raise an error if value is within acceptable range' do
52
+ it 'does not raise an error if value is within acceptable range' do
53
53
  monkey = MonkeyFactory.create(:eating_monkey2)
54
54
  MonkeyEngine::MonkeyManager.instance.add(monkey)
55
55
  -> { MonkeyActionEat.new(monkey, 40) }.should_not raise_error
56
56
  end
57
57
 
58
- it 'should raise an error if value is the wrong type' do
58
+ it 'raises an error if value is the wrong type' do
59
59
  monkey = MonkeyFactory.create(:eating_monkey3)
60
60
  MonkeyEngine::MonkeyManager.instance.add(monkey)
61
61
  -> { MonkeyActionEat.new(monkey, :wrong_type) }.should \
62
62
  raise_error MonkeyEngine::Exceptions::InvalidArgumentTypeException
63
63
  end
64
64
 
65
- it 'should raise an error if value is less than min acceptable range' do
65
+ it 'raises an error if value is less than min acceptable range' do
66
66
  monkey = MonkeyFactory.create(:eating_monkey4)
67
67
  MonkeyEngine::MonkeyManager.instance.add(monkey)
68
68
  -> { MonkeyActionEat.new(monkey, 29) }.should \
69
69
  raise_error MonkeyEngine::Exceptions::InvalidArgumentValueException
70
70
  end
71
71
 
72
- it 'should raise an error if value is greater than max acceptable range' do
72
+ it 'raises an error if value is greater than max acceptable range' do
73
73
  monkey = MonkeyFactory.create(:eating_monkey5)
74
74
  MonkeyEngine::MonkeyManager.instance.add(monkey)
75
75
  -> { MonkeyActionEat.new(monkey, 61) }.should \
76
76
  raise_error MonkeyEngine::Exceptions::InvalidArgumentValueException
77
77
  end
78
78
 
79
- it 'should raise an error if value is nil' do
79
+ it 'raises an error if value is nil' do
80
80
  monkey = MonkeyFactory.create(:eating_monkey6)
81
81
  MonkeyEngine::MonkeyManager.instance.add(monkey)
82
82
  -> { MonkeyActionEat.new(monkey, nil) }.should \
@@ -24,10 +24,10 @@ describe 'MonkeyActionPause' do
24
24
  MonkeyEngine::MonkeyManager.instance.join_all(10)
25
25
  end
26
26
 
27
- it_should_behave_like 'MonkeyAction'
27
+ it_behaves_like 'MonkeyAction'
28
28
 
29
29
  it '@it should be the correct type' do
30
- @it.is_a?(MonkeyActionPause).should == true
30
+ @it.is_a?(MonkeyActionPause).should be true
31
31
  end
32
32
 
33
33
  # Monkey
@@ -41,11 +41,11 @@ describe 'MonkeyActionPause' do
41
41
  end
42
42
 
43
43
  it '@value should be is_a? Integer' do
44
- @it.value.is_a?(Integer).should == true
44
+ @it.value.is_a?(Integer).should be true
45
45
  end
46
46
 
47
47
  it '@value should >= 1' do
48
- (@it.value >= 1).should == true
48
+ (@it.value >= 1).should be true
49
49
  end
50
50
 
51
51
  # Weight
@@ -54,34 +54,34 @@ describe 'MonkeyActionPause' do
54
54
  end
55
55
 
56
56
  # validate
57
- it 'should not raise an error if value is within acceptable range' do
57
+ it 'does not raise an error if value is within acceptable range' do
58
58
  monkey = MonkeyFactory.create(:pausing_monkey2)
59
59
  MonkeyEngine::MonkeyManager.instance.add(monkey)
60
60
  -> { MonkeyActionPause.new(monkey, 5) }.should_not raise_error
61
61
  end
62
62
 
63
- it 'should raise an error if value is the wrong type' do
63
+ it 'raises an error if value is the wrong type' do
64
64
  monkey = MonkeyFactory.create(:pausing_monkey3)
65
65
  MonkeyEngine::MonkeyManager.instance.add(monkey)
66
66
  -> { MonkeyActionPause.new(monkey, :wrong_type) }.should \
67
67
  raise_error MonkeyEngine::Exceptions::InvalidArgumentTypeException
68
68
  end
69
69
 
70
- it 'should raise an error if value is less than min acceptable range' do
70
+ it 'raises an error if value is less than min acceptable range' do
71
71
  monkey = MonkeyFactory.create(:pausing_monkey4)
72
72
  MonkeyEngine::MonkeyManager.instance.add(monkey)
73
73
  -> { MonkeyActionPause.new(monkey, -1) }.should \
74
74
  raise_error MonkeyEngine::Exceptions::InvalidArgumentValueException
75
75
  end
76
76
 
77
- it 'should raise an error if value is greater than max acceptable range' do
77
+ it 'raises an error if value is greater than max acceptable range' do
78
78
  monkey = MonkeyFactory.create(:pausing_monkey5)
79
79
  MonkeyEngine::MonkeyManager.instance.add(monkey)
80
80
  -> { MonkeyActionPause.new(monkey, 61) }.should \
81
81
  raise_error MonkeyEngine::Exceptions::InvalidArgumentValueException
82
82
  end
83
83
 
84
- it 'should raise an error if value is nil' do
84
+ it 'raises an error if value is nil' do
85
85
  monkey = MonkeyFactory.create(:pausing_monkey6)
86
86
  MonkeyEngine::MonkeyManager.instance.add(monkey)
87
87
  -> { MonkeyActionPause.new(monkey, nil) }.should \
@@ -23,10 +23,10 @@ describe 'MonkeyActionSleep' do
23
23
  MonkeyEngine::MonkeyManager.instance.join_all(10)
24
24
  end
25
25
 
26
- it_should_behave_like 'MonkeyAction'
26
+ it_behaves_like 'MonkeyAction'
27
27
 
28
28
  it '@it should be the correct type' do
29
- @it.is_a?(MonkeyActionSleep).should == true
29
+ @it.is_a?(MonkeyActionSleep).should be true
30
30
  end
31
31
 
32
32
  # Monkey
@@ -40,11 +40,11 @@ describe 'MonkeyActionSleep' do
40
40
  end
41
41
 
42
42
  it '@value should be is_a? Integer' do
43
- @it.value.is_a?(Integer).should == true
43
+ @it.value.is_a?(Integer).should be true
44
44
  end
45
45
 
46
46
  it '@value should equal 60 * 8' do
47
- (@it.value == 60 * 8).should == true
47
+ (@it.value == 60 * 8).should be true
48
48
  end
49
49
 
50
50
  # Weight
@@ -53,34 +53,34 @@ describe 'MonkeyActionSleep' do
53
53
  end
54
54
 
55
55
  # validate
56
- it 'should not raise an error if value is within acceptable range' do
56
+ it 'does not raise an error if value is within acceptable range' do
57
57
  monkey = MonkeyFactory.create(:sleeping_monkey2)
58
58
  MonkeyEngine::MonkeyManager.instance.add(monkey)
59
59
  -> { MonkeyActionSleep.new(monkey, 60 * 8) }.should_not raise_error
60
60
  end
61
61
 
62
- it 'should raise an error if value is the wrong type' do
62
+ it 'raises an error if value is the wrong type' do
63
63
  monkey = MonkeyFactory.create(:sleeping_monkey3)
64
64
  MonkeyEngine::MonkeyManager.instance.add(monkey)
65
65
  -> { MonkeyActionSleep.new(monkey, :wrong_type) }.should \
66
66
  raise_error MonkeyEngine::Exceptions::InvalidArgumentTypeException
67
67
  end
68
68
 
69
- it 'should raise an error if value is less than min acceptable range' do
69
+ it 'raises an error if value is less than min acceptable range' do
70
70
  monkey = MonkeyFactory.create(:sleeping_monkey4)
71
71
  MonkeyEngine::MonkeyManager.instance.add(monkey)
72
72
  -> { MonkeyActionSleep.new(monkey, 60 * 5) }.should \
73
73
  raise_error MonkeyEngine::Exceptions::InvalidArgumentValueException
74
74
  end
75
75
 
76
- it 'should raise an error if value is greater than max acceptable range' do
76
+ it 'raises an error if value is greater than max acceptable range' do
77
77
  monkey = MonkeyFactory.create(:sleeping_monkey5)
78
78
  MonkeyEngine::MonkeyManager.instance.add(monkey)
79
79
  -> { MonkeyActionSleep.new(monkey, 60 * 9) }.should \
80
80
  raise_error MonkeyEngine::Exceptions::InvalidArgumentValueException
81
81
  end
82
82
 
83
- it 'should raise an error if value is nil' do
83
+ it 'raises an error if value is nil' do
84
84
  monkey = MonkeyFactory.create(:sleeping_monkey6)
85
85
  MonkeyEngine::MonkeyManager.instance.add(monkey)
86
86
  -> { MonkeyActionSleep.new(monkey, nil) }.should \
@@ -28,10 +28,10 @@ describe 'MonkeyActionType' do
28
28
  MonkeyEngine::MonkeyManager.instance.join_all(10)
29
29
  end
30
30
 
31
- it_should_behave_like 'MonkeyAction'
31
+ it_behaves_like 'MonkeyAction'
32
32
 
33
33
  it '@it should be the correct type' do
34
- @it.is_a?(MonkeyActionType).should == true
34
+ @it.is_a?(MonkeyActionType).should be true
35
35
  end
36
36
 
37
37
  # Monkey
@@ -45,7 +45,7 @@ describe 'MonkeyActionType' do
45
45
  end
46
46
 
47
47
  it '@value should be is_a? Array' do
48
- @it.value.is_a?(Array).should == true
48
+ @it.value.is_a?(Array).should be true
49
49
  end
50
50
 
51
51
  it '@value should not be nil?' do
@@ -58,7 +58,7 @@ describe 'MonkeyActionType' do
58
58
  end
59
59
 
60
60
  # validate
61
- it 'should not raise an error if value is valid' do
61
+ it 'does not raise an error if value is valid' do
62
62
  monkey = MonkeyFactory.create(:typing_monkey2)
63
63
  MonkeyEngine::MonkeyManager.instance.add(monkey)
64
64
 
@@ -68,14 +68,14 @@ describe 'MonkeyActionType' do
68
68
  -> { MonkeyActionType.new(monkey, keyboard_input) }.should_not raise_error
69
69
  end
70
70
 
71
- it 'should raise an error if value is the wrong type' do
71
+ it 'raises an error if value is the wrong type' do
72
72
  monkey = MonkeyFactory.create(:typing_monkey3)
73
73
  MonkeyEngine::MonkeyManager.instance.add(monkey)
74
74
  -> { MonkeyActionType.new(monkey, :wrong_type) }.should \
75
75
  raise_error MonkeyEngine::Exceptions::InvalidArgumentTypeException
76
76
  end
77
77
 
78
- it 'should raise an error if value is empty?' do
78
+ it 'raises an error if value is empty?' do
79
79
  monkey = MonkeyFactory.create(:typing_monkey4)
80
80
  MonkeyEngine::MonkeyManager.instance.add(monkey)
81
81
 
@@ -86,7 +86,7 @@ describe 'MonkeyActionType' do
86
86
  raise_error MonkeyEngine::Exceptions::InvalidArgumentValueException
87
87
  end
88
88
 
89
- it 'should raise an error if value is nil' do
89
+ it 'raises an error if value is nil' do
90
90
  monkey = MonkeyFactory.create(:typing_monkey5)
91
91
  MonkeyEngine::MonkeyManager.instance.add(monkey)
92
92
  -> { MonkeyActionType.new(monkey, nil) }.should \
@@ -23,10 +23,10 @@ describe 'MonkeyActionWake' do
23
23
  MonkeyEngine::MonkeyManager.instance.join_all(10)
24
24
  end
25
25
 
26
- it_should_behave_like 'MonkeyAction'
26
+ it_behaves_like 'MonkeyAction'
27
27
 
28
28
  it '@it should be the correct type' do
29
- @it.is_a?(MonkeyActionWake).should == true
29
+ @it.is_a?(MonkeyActionWake).should be true
30
30
  end
31
31
 
32
32
  # Monkey
@@ -36,11 +36,11 @@ describe 'MonkeyActionWake' do
36
36
 
37
37
  # Value
38
38
  it '@value should return the right value' do
39
- @it.value.should == true
39
+ @it.value.should be true
40
40
  end
41
41
 
42
42
  it '@value should be is_a? TrueClass' do
43
- @it.value.is_a?(TrueClass).should == true
43
+ @it.value.is_a?(TrueClass).should be true
44
44
  end
45
45
 
46
46
  # Weight
@@ -49,7 +49,7 @@ describe 'MonkeyActionWake' do
49
49
  end
50
50
 
51
51
  # validate
52
- it 'should not raise an error if value is within acceptable range' do
52
+ it 'does not raise an error if value is within acceptable range' do
53
53
  monkey = MonkeyFactory.create(:waking_monkey2)
54
54
  MonkeyEngine::MonkeyManager.instance.add(monkey)
55
55
  -> { MonkeyActionWake.new(monkey) }.should_not raise_error
@@ -3,20 +3,12 @@
3
3
  require 'MonkeyFactory'
4
4
 
5
5
  describe 'MonkeyFactory' do
6
- before(:all) do
7
- end
8
-
9
- after(:all) do
10
- end
11
-
12
6
  context 'create' do
13
- it 'should instantiate an object from the factory' do
14
- monkey = MonkeyFactory.create(:harpo)
15
- monkey.nil?.should == false
16
- monkey.is_a?(Monkey).should == true
7
+ it 'instantiates an object from the factory' do
8
+ MonkeyFactory.create(:harpo).is_a?(Monkey).should be true
17
9
  end
18
10
 
19
- it 'should not instantiate an object without using the factory' do
11
+ it 'does not instantiate an object without using the factory' do
20
12
  -> { Monkey.new :groucho }.should raise_error NoMethodError
21
13
  end
22
14
  end
@@ -7,14 +7,11 @@ describe 'MonkeyKeyboardEnUs' do
7
7
  @it = MonkeyEngine::MonkeyKeyboardEnUs.instance
8
8
  end
9
9
 
10
- context 'keys' do
11
- end
12
-
13
10
  context 'left_keys' do
14
- it 'should have the correct amount of keyboard entries on the left side of the keyboard' do
11
+ it 'has the correct amount of keyboard entries on the left side of the keyboard' do
15
12
  key_count = 0
16
13
 
17
- @it.keys.each do |key|
14
+ @it.keys.each do |key| # rubocop:disable Style/HashEachMethods
18
15
  key_count += key.keyboard_key_weight if key.keyboard_key_section == :left
19
16
  end
20
17
 
@@ -23,10 +20,10 @@ describe 'MonkeyKeyboardEnUs' do
23
20
  end
24
21
 
25
22
  context 'right_keys' do
26
- it 'should have the correct amount of keyboard entries on the right side of the keyboard' do
23
+ it 'has the correct amount of keyboard entries on the right side of the keyboard' do
27
24
  key_count = 0
28
25
 
29
- @it.keys.each do |key|
26
+ @it.keys.each do |key| # rubocop:disable Style/HashEachMethods
30
27
  key_count += key.keyboard_key_weight if key.keyboard_key_section == :right
31
28
  end
32
29
 
@@ -3,7 +3,7 @@
3
3
  describe 'MonkeyManager' do
4
4
  before { skip 'todo' }
5
5
 
6
- it 'should do something' do
6
+ it 'does something' do
7
7
  skip 'todo'
8
8
  end
9
9
  end
@@ -24,26 +24,26 @@ describe 'MonkeyService' do
24
24
  @it.join_all(10)
25
25
  end
26
26
 
27
- def update(time, action, param)
27
+ def update(time, action, _param)
28
28
  # puts "Time: [#{time}], Action: [#{action}], Param: [#{param}]"
29
29
  puts "Time: [#{time}], Action: [#{action}], Param: <not shown>"
30
30
  end
31
31
 
32
32
  context 'initialization' do
33
- it 'it should have 3 monkeys' do
33
+ it 'has 3 monkeys' do
34
34
  @it.count.should == 3
35
35
  end
36
36
 
37
- it 'should have monkey harpo' do
38
- @it.exists?(:harpo).should == true
37
+ it 'has monkey harpo' do
38
+ @it.exists?(:harpo).should be true
39
39
  end
40
40
 
41
- it 'should have monkey groucho' do
42
- @it.exists?(:groucho).should == true
41
+ it 'has monkey groucho' do
42
+ @it.exists?(:groucho).should be true
43
43
  end
44
44
 
45
- it 'should have monkey chico' do
46
- @it.exists?(:chico).should == true
45
+ it 'has monkey chico' do
46
+ @it.exists?(:chico).should be true
47
47
  end
48
48
  end
49
49
 
@@ -59,7 +59,7 @@ describe 'MonkeyService' do
59
59
  end
60
60
 
61
61
  it "'any_alive?' should return objects that are alive" do
62
- @it.any_alive?.should == true
62
+ @it.any_alive?.should be true
63
63
  end
64
64
  end
65
65
 
@@ -71,7 +71,7 @@ describe 'MonkeyService' do
71
71
  # Give them a little bit to finish.
72
72
  @it.join_all(10)
73
73
 
74
- @it.any_alive?.should == false
74
+ @it.any_alive?.should be false
75
75
  end
76
76
 
77
77
  it 'kill_all! should return all monkeys killed' do
@@ -87,7 +87,7 @@ describe 'MonkeyService' do
87
87
 
88
88
  monkey_service.join_all(10)
89
89
 
90
- (monkeys == killed_monkeys).should == true
90
+ (monkeys == killed_monkeys).should be true
91
91
  end
92
92
  end
93
93
  end
data/spec/monkey_spec.rb CHANGED
@@ -3,7 +3,7 @@
3
3
  describe 'Monkey' do
4
4
  before { skip 'todo' }
5
5
 
6
- it 'should do something' do
6
+ it 'does something' do
7
7
  skip 'todo'
8
8
  end
9
9
  end
data/spec/spec_helper.rb CHANGED
@@ -4,7 +4,7 @@ require 'pry-byebug'
4
4
 
5
5
  module SpecHelpers
6
6
  module SetMonkeyAction
7
- def set_action(action)
7
+ def force_action(action)
8
8
  @action = action
9
9
  end
10
10
  end