LittleWeasel 5.0.5 → 5.0.6

data/spec/lib/LittleWeasel/preprocessors/word_preprocessor_managable_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
 
     class << self
-      def preprocess(word) [true, "#{word}-0"]; end
+      def preprocess(word) = [true, "#{word}-0"]
     end
   end
 
@@ -27,7 +27,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
 
     class << self
-      def preprocess(word) [true, "#{word}-1"]; end
+      def preprocess(word) = [true, "#{word}-1"]
     end
   end
 
@@ -37,14 +37,19 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
 
     class << self
-      def preprocess(word) [true, "#{word}-2"]; end
+      def preprocess(word) = [true, "#{word}-2"]
     end
   end
 
   let(:word_preprocessors_01_thru_03) do
     [MockWordPreprocessor03.new,
-      MockWordPreprocessor02.new,
-      MockWordPreprocessor01.new]
+     MockWordPreprocessor02.new,
+     MockWordPreprocessor01.new]
+  end
+  let(:word_preprocessors_04_thru_06) do
+    [MockWordPreprocessor06.new,
+     MockWordPreprocessor05.new,
+     MockWordPreprocessor04.new]
   end
 
   class MockWordPreprocessor04 < MockWordPreprocessor01
@@ -53,7 +58,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
 
     class << self
-      def preprocess(word) [true, "#{word}-3"]; end
+      def preprocess(word) = [true, "#{word}-3"]
     end
   end
 
@@ -63,7 +68,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
 
     class << self
-      def preprocess(word) [true, "#{word}-4"]; end
+      def preprocess(word) = [true, "#{word}-4"]
     end
   end
 
@@ -73,27 +78,21 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
 
     class << self
-      def preprocess(word) [true, "#{word}-5"]; end
+      def preprocess(word) = [true, "#{word}-5"]
     end
   end
 
-  let(:word_preprocessors_04_thru_06) do
-    [MockWordPreprocessor06.new,
-      MockWordPreprocessor05.new,
-      MockWordPreprocessor04.new]
-  end
-
-  #preprocessed_word
+  # preprocessed_word
   describe '#preprocessed_word' do
     context 'when word is blank' do
       it 'returns nil' do
-        expect(subject.preprocessed_word word: 'word').to be_nil
+        expect(subject.preprocessed_word(word: 'word')).to be_nil
       end
     end
 
     context 'when word is not a String' do
       it 'returns nil' do
-        expect(subject.preprocessed_word word: :not_a_word).to be_nil
+        expect(subject.preprocessed_word(word: :not_a_word)).to be_nil
       end
     end
 
@@ -103,19 +102,19 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
       end
 
       it 'returns the preprocessed word' do
-        expect(subject.preprocessed_word word: 'word').to eq 'word-0-1-2'
+        expect(subject.preprocessed_word(word: 'word')).to eq 'word-0-1-2'
       end
     end
   end
 
-  #word_preprocessors
+  # word_preprocessors
   describe '#word_preprocessors' do
     it 'returns an empty Array ([]) by default' do
       expect(subject.word_preprocessors).to eq []
     end
   end
 
-  #clear_preprocessors
+  # clear_preprocessors
   describe '#clear_preprocessors' do
     before do
       subject.replace_preprocessors word_preprocessors: word_preprocessors_01_thru_03
@@ -126,12 +125,12 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
   end
 
-  #add_preprocessors
+  # add_preprocessors
   describe '#add_preprocessors' do
     context 'when passing an INVALID argument' do
       context 'when passing an Array of invalid word preprocessors' do
         it 'raises an error' do
-          expect { subject.add_preprocessors(word_preprocessors: %i(bad word preprocessors)) }.to raise_error(/Argument word_preprocessor: does not respond to/)
+          expect { subject.add_preprocessors(word_preprocessors: %i[bad word preprocessors]) }.to raise_error(/Argument word_preprocessor: does not respond to/)
         end
       end
     end
@@ -161,7 +160,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
         it 'does NOT raise an error' do
           expect do
             subject.add_preprocessors { |_word_preprocessors| }
-          end.to_not raise_error
+          end.not_to raise_error
         end
 
         it 'uses the word preprocessors added via the block' do
@@ -181,7 +180,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
   end
 
-  #replace_preprocessors
+  # replace_preprocessors
   describe '#replace_preprocessors' do
     before do
       subject.add_preprocessors word_preprocessors: word_preprocessors_01_thru_03
@@ -193,12 +192,12 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
 
     it 'replaces the word preprocessors in #word_preprocessors and sorts the #word_preprocessors Array by WordPreprocessor#order' do
       expect(subject.word_preprocessors).to match_array word_preprocessors_01_thru_03
-      expect(subject.replace_preprocessors word_preprocessors: word_preprocessors_04_thru_06).to eq expected_results
+      expect(subject.replace_preprocessors(word_preprocessors: word_preprocessors_04_thru_06)).to eq expected_results
       expect(subject.word_preprocessors).to eq expected_results
     end
   end
 
-  #preprocessors_on=
+  # preprocessors_on=
   describe '#preprocessors_on=' do
     context 'when assigning true' do
       before do
@@ -225,7 +224,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
     end
   end
 
-  #preprocess
+  # preprocess
   describe '#preprocess' do
     before do
       subject.add_preprocessors word_preprocessors: word_preprocessors
@@ -236,7 +235,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorManagable, type: :mo
 
     it 'preprocesses the word' do
       expect(subject.word_preprocessors.count).to eq word_preprocessors.count
-      expect(subject.preprocess(word: word).preprocessed_words.map(&:preprocessed_word)).to eq %w(word-0 word-0-1 word-0-1-2)
+      expect(subject.preprocess(word: word).preprocessed_words.map(&:preprocessed_word)).to eq %w[word-0 word-0-1 word-0-1-2]
     end
   end
 end

data/spec/lib/LittleWeasel/preprocessors/word_preprocessor_spec.rb

@@ -13,11 +13,11 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
   let(:order) { 0 }
   let(:word) { 'word' }
 
-  #.new
+  # .new
   describe '.new' do
     context 'when arguments are valid' do
       it 'instantiates the object' do
-        expect { subject }.to_not raise_error
+        expect { subject }.not_to raise_error
       end
     end
 
@@ -52,7 +52,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
     end
   end
 
-  #.preprocess
+  # .preprocess
   describe '.preprocess' do
     context 'when not overridden' do
       it 'raises an error' do
@@ -61,7 +61,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
     end
   end
 
-  #preprocessor_on
+  # preprocessor_on
   describe '#preprocessor_on' do
     context 'when set to true' do
       before do
@@ -69,7 +69,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
       end
 
       it 'returns true' do
-        expect(subject.preprocessor_on).to eq true
+        expect(subject.preprocessor_on).to be true
       end
     end
 
@@ -79,30 +79,30 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
       end
 
       it 'returns false' do
-        expect(subject.preprocessor_on).to eq false
+        expect(subject.preprocessor_on).to be false
       end
     end
   end
 
-  #preprocessor_on!
+  # preprocessor_on!
   describe '#preprocessor_on!' do
     before do
-      expect(subject.preprocessor_off?).to eq true
+      expect(subject.preprocessor_off?).to be true
     end
 
     let(:preprocessor_on) { false }
 
     it 'turns the preprocessor on' do
       subject.preprocessor_on!
-      expect(subject.preprocessor_on).to eq true
+      expect(subject.preprocessor_on).to be true
     end
   end
 
-  #preprocessor_on?
+  # preprocessor_on?
   describe '#preprocessor_on?' do
     context 'when #preprocessor_on is true' do
       it 'returns true' do
-        expect(subject.preprocessor_on?).to eq true
+        expect(subject.preprocessor_on?).to be true
       end
     end
 
@@ -110,12 +110,12 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
       let(:preprocessor_on) { false }
 
       it 'returns false' do
-        expect(subject.preprocessor_on?).to eq false
+        expect(subject.preprocessor_on?).to be false
       end
     end
   end
 
-  #preprocess
+  # preprocess
   describe '#preprocess' do
     context 'when not overridden' do
       it 'raises an error' do
@@ -125,16 +125,13 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
 
     context 'when overridden' do
       before do
-        allow(described_class).to receive(:preprocess?)
-          .and_return true
-        allow(described_class).to receive(:preprocess)
-          .and_return [true, 'preprocessed-word']
+        allow(described_class).to receive_messages(preprocess?: true, preprocess: [true, 'preprocessed-word'])
       end
 
       context 'when #preprocessor_on? is true' do
         it 'calls .preprocess and returns a ProcessedWord object' do
           expect(described_class).to receive(:preprocess)
-          expect(subject.preprocess word).to be_kind_of LittleWeasel::Preprocessors::PreprocessedWord
+          expect(subject.preprocess(word)).to be_a LittleWeasel::Preprocessors::PreprocessedWord
         end
       end
 
@@ -142,20 +139,19 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
         let(:preprocessor_on) { false }
 
         it 'does NOT call .preprocess and returns a ProcessedWord object' do
-          expect(described_class).to_not receive(:preprocess)
-          expect(subject.preprocess word).to be_kind_of LittleWeasel::Preprocessors::PreprocessedWord
+          expect(described_class).not_to receive(:preprocess)
+          expect(subject.preprocess(word)).to be_a LittleWeasel::Preprocessors::PreprocessedWord
         end
-
       end
     end
   end
 
-  #preprocess?
+  # preprocess?
   describe '#preprocess?' do
     let(:word) { 'word' }
 
     it 'returns true by default' do
-      expect(subject.preprocess? word).to be true
+      expect(subject.preprocess?(word)).to be true
     end
 
     context 'when #preprocess? returns true' do
@@ -187,32 +183,32 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessor do
     end
   end
 
-  #preprocessor_off?
+  # preprocessor_off?
   describe '#preprocessor_off?' do
     context 'when #preprocessor_on is false' do
       let(:preprocessor_on) { false }
 
       it 'returns true' do
-        expect(subject.preprocessor_off?).to eq true
+        expect(subject.preprocessor_off?).to be true
       end
     end
 
     context 'when #preprocessor_on is true' do
       it 'returns false' do
-        expect(subject.preprocessor_off?).to eq false
+        expect(subject.preprocessor_off?).to be false
       end
     end
   end
 
-  #preprocessor_off!
+  # preprocessor_off!
   describe '#preprocessor_off!' do
     before do
-      expect(subject.preprocessor_on?).to eq true
+      expect(subject.preprocessor_on?).to be true
     end
 
     it 'turns the preprocessor off' do
       subject.preprocessor_off!
-      expect(subject.preprocessor_on).to eq false
+      expect(subject.preprocessor_on).to be false
     end
   end
 end

data/spec/lib/LittleWeasel/preprocessors/word_preprocessor_validatable_spec.rb

@@ -45,7 +45,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorValidatable, type: :
     end
   end
 
-  #.validate_word_preprocessor
+  # .validate_word_preprocessor
   describe '.validate_word_preprocessor' do
     before do
       allow(word_preprocessor.class).to receive(:respond_to?).and_call_original
@@ -54,7 +54,7 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorValidatable, type: :
 
     context 'when the object quacks right' do
       it 'passes validation' do
-        expect { WordPreprocessorValidatable.validate_word_preprocessor word_preprocessor: word_preprocessor }.to_not raise_error
+        expect { WordPreprocessorValidatable.validate_word_preprocessor word_preprocessor: word_preprocessor }.not_to raise_error
       end
     end
 
@@ -64,11 +64,13 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorValidatable, type: :
       context 'when a class method is missing' do
         context 'when the class does not respond to .preprocess' do
           let(:method) { :preprocess }
+
           it_behaves_like 'a class method is missing'
         end
 
         context 'when the class does not respond to .preprocess?' do
           let(:method) { :preprocess? }
+
           it_behaves_like 'a class method is missing'
         end
       end
@@ -76,31 +78,37 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorValidatable, type: :
       context 'when an instance method is missing' do
         context 'when the object does not respond to #preprocess' do
           let(:method) { :preprocess }
+
           it_behaves_like 'an instance method is missing'
         end
 
         context 'when the object does not respond to #preprocess?' do
           let(:method) { :preprocess? }
+
           it_behaves_like 'an instance method is missing'
         end
 
         context 'when the object does not respond to #preprocessor_off?' do
           let(:method) { :preprocessor_off? }
+
           it_behaves_like 'an instance method is missing'
         end
 
         context 'when the object does not respond to #preprocessor_on' do
           let(:method) { :preprocessor_on }
+
           it_behaves_like 'an instance method is missing'
         end
 
         context 'when the object does not respond to #preprocessor_on=' do
           let(:method) { :preprocessor_on= }
+
           it_behaves_like 'an instance method is missing'
         end
 
         context 'when the object does not respond to #preprocessor_on?' do
           let(:method) { :preprocessor_on? }
+
           it_behaves_like 'an instance method is missing'
         end
       end

data/spec/lib/LittleWeasel/preprocessors/word_preprocessors_validatable_spec.rb

@@ -3,8 +3,6 @@
 require 'spec_helper'
 
 RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorsValidatable, type: :module do
-  subject { MockSubject.new }
-
   WordPreprocessorsValidatable = described_class
 
   class MockSubject
@@ -20,21 +18,21 @@ RSpec.describe LittleWeasel::Preprocessors::WordPreprocessorsValidatable, type:
     end
 
     class << self
-      def preprocess(word) [true, "#{word}-0"]; end
+      def preprocess(word) = [true, "#{word}-0"]
     end
   end
 
-  #.validate_word_preprocessors
+  # .validate_word_preprocessors
   describe '.validate_word_preprocessors' do
     context 'when passing a blank Array' do
       it 'passes validaton' do
-        expect { WordPreprocessorsValidatable.validate_word_preprocessors(word_preprocessors: []) }.to_not raise_error
+        expect { WordPreprocessorsValidatable.validate_word_preprocessors(word_preprocessors: []) }.not_to raise_error
       end
     end
 
     context 'when passing a an Array with valid word preprocessors' do
       it 'passes validation' do
-        expect { WordPreprocessorsValidatable.validate_word_preprocessors(word_preprocessors: [MockWordPreprocessor.new]) }.to_not raise_error
+        expect { WordPreprocessorsValidatable.validate_word_preprocessors(word_preprocessors: [MockWordPreprocessor.new]) }.not_to raise_error
       end
     end