LVS-JSONService 0.3.4 → 0.3.5

data/.gitignore

@@ -2,4 +2,4 @@
 coverage/
 spec/reports
 pkg/
-JSONService-*.gem
+LVS-JSONService-*.gem

data/.specification

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: LVS-JSONService 
 version: !ruby/object:Gem::Version 
-  version: 0.3.4
+  version: 0.3.5
 require_paths:
 - lib
 platform: ruby

data/LVS-JSONService.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{LVS-JSONService}
-  s.version = "0.3.4"
+  s.version = "0.3.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["LVS", "andyjeffries"]

data/VERSION

@@ -1 +1 @@
-0.3.4
+0.3.5

data/lib/lvs/json_service/base.rb

@@ -158,14 +158,15 @@ module LVS
       def respond_to?(name)
         name = name.to_s
         key = name_to_key(name)
-        value = @data[key]
+        value = value_for_key(key)
         !value.nil?
       end
       
       def value_for_key(key)
         value = @data[key]
         if value.blank?
-          value = @data[key.capitalize]
+          key[0..0] = key[0..0].upcase # TODO: This feels like an awful hack, but having a day when nothing's working
+          value = @data[key]
         end
         value
       end
@@ -176,8 +177,6 @@ module LVS
           return respond_to?(args[0])
         end
         key = name_to_key(name)
-        puts "Name #{name} is key #{key}"
-        value = @data[key]
         value = value_for_key(key)
         if name =~ /=$/
           @data[key] = ManuallySetData.new(args[0])

data/lib/lvs/json_service/request.rb

@@ -11,11 +11,15 @@ module LVS
       end      
       
       module ClassMethods
+        def unique_request_id
+          Digest::SHA1.hexdigest((rand(4294967295)+Time.now.usec).to_s)
+        end
+        
         def http_request_with_timeout(service, args, options)
           uri = URI.parse(service)
         
           req = Net::HTTP::Post.new(uri.path)
-          args[:requestId] = Digest::SHA1.hexdigest((rand(4294967295)+Time.now.usec).to_s)
+          args[:requestId] = unique_request_id
           req.form_data = { "object_request" => args.to_json }
 
           options[:encrypted] ||= require_ssl?

data/spec/lvs/json_service/json_methods_spec.rb

@@ -56,6 +56,6 @@ describe LVS::JsonService::Base do
   end
   
   it "should recognise keys that start with two capital letters" do
-    TestServiceForJsonMethodsCall.details.e_credit.should eql(1)
+    lambda {TestServiceForJsonMethodsCall.details.e_credit.should eql(1)}.should_not raise_error(NoMethodError)
   end
 end

data/spec/lvs/json_service/request_spec.rb

@@ -54,6 +54,8 @@ describe LVS::JsonService::Request do
     end
     
     it "should assign the JSON parameters to a Net::HTTP::Post object" do
+      ClassWithRequest.stub!(:unique_request_id).and_return("1")
+      @args[:requestId] = "1"
       @mock_post.should_receive(:form_data=).with({ "object_request" => @args.to_json })
       do_request
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: LVS-JSONService
 version: !ruby/object:Gem::Version 
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors: 
 - LVS