IsbnUtils 0.0.0.2 → 0.0.0.3

data/lib/Isbn10DigitValidator.rb

@@ -9,7 +9,7 @@ class Isbn10DigitValidator < IsbnValidator
   def checkDigit
     @strippedIsbn =  @isbn.gsub(/[^0-9a-z]/i,'')
     if @strippedIsbn.length != 10
-      raise "error not an isbn"
+      raise "error not a 10 digit isbn"
     end
     
   end

data/lib/Isbn13DigitValidator.rb

@@ -6,22 +6,30 @@ class Isbn13DigitValidator < IsbnValidator
    def initialize(isbn13)
       @isbn = isbn13
    end
+
+ def checkDigit
+    @strippedIsbn =  @isbn.gsub(/[^0-9a-z]/i,'')
+    if @strippedIsbn.length != 13
+      raise "error not a 13 digit isbn"
+    end
+    
+  end
   
   
-  def isIsbn13Valid
+  def validateIsbn
      check = 0
      i = 0
      while i < 12 do
-       check = check +  @isbn[i].to_i
+       check = check +  @strippedIsbn[i].to_i
        i = i + 2 
       end 
       
       i = 1 
       while i < 12 do
-       check = check + 3* @isbn[i].to_i
+       check = check + 3* @strippedIsbn[i].to_i
        i = i + 2 
       end 
-      check = check +  @isbn[12].to_i
+      check = check +  @strippedIsbn[12].to_i
      return check % 10 == 0;
   end
 

data/lib/IsbnValidatorFactory.rb

@@ -1,25 +1,24 @@
-
-
 #
 # The IsbnValidatorFactory is a validator factory class that returns either an object of Isbn10DigitValidator or Isbn13DigitValidator
-# 
+# IsbnValidatorFactory.getIsbnValidator("1402894627").validate() == true 
+#  IsbnValidatorFactory.getIsbnValidator("1402894627").validate() == true
+#
+
 require 'IsbnValidator'
 require 'Isbn10DigitValidator'
 require 'Isbn13DigitValidator'
 class IsbnValidatorFactory
 
-
-
 def self.getIsbnValidator(isbn)
 
 	strippedIsbn =  isbn.gsub(/[^0-9a-z]/i,'')
 	
 	if strippedIsbn.length == 10 
 		return Isbn10DigitValidator.new(strippedIsbn)
-	elsif strippedIsbn.length == 14
+	elsif strippedIsbn.length == 13
 		return Isbn13DigitValidator.new(strippedIsbn)
 	else
-	   raise "error Invalid Isbn"
+	   return false
 	end
 	
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: IsbnUtils
 version: !ruby/object:Gem::Version
-  version: 0.0.0.2
+  version: 0.0.0.3
   prerelease: 
 platform: ruby
 authors: