HornsAndHooves-moribus 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 458dd43da4a7bb700075f307e8bac67beea88ac91cc103d01dbc873e754c53ee
-  data.tar.gz: 699fd07e4333c5cea0c317c43f82d1f33e6b1f9629d32ff55099dd280f28a4f8
+  metadata.gz: 39ad765918ae1ca73efc10e704346476936df1793e19f25089d27910089871d7
+  data.tar.gz: 0b579beea800b1b5987e9b7996137efc9dfa5c3e12f70fb04c53f7a5e113ea84
 SHA512:
-  metadata.gz: 8379ba55ec3c949f21961b50ac3d2979a093fa2790e3e9bd134574d76f7f2ed9cd82eb06ee752771f5e265a63568fc3cb69fe01502e38fdd5ff829d5df279add
-  data.tar.gz: 533dc47aa565a5ce7b84ef924eea7a18d0a3d4776c29d6a971e1a430b7a3dd713143b7e9d4db253d00777dc5b430571dd62d3b7b3c64fd01a45b09b9ae8790a2
+  metadata.gz: bf6c76a8ae0260b424abefe0de61c9b5bb11cfd2b6c00d604db9144bf92b911363f7a5bbaed5f22bd403e218ba9a3db0c92ef1b372430cbdb0f155fba200f9f5
+  data.tar.gz: c54c2c7fd4f356dadb559bb41ac262c00d54f8e4ae5f8999f53be79b0bf6a651f5ea2c797f9dcff2f2d1a149df5ea4494250bf728bd27411910fbf4f049ae9a3

data/.ruby-version

@@ -1 +1 @@
-2.6.6
+2.7.6

data/lib/moribus/aggregated_behavior.rb

@@ -26,7 +26,7 @@ module Moribus
     # the lookup succeeds, we don't want the original #save to be executed.
     # But if +false+ is returned by the callback, it will also be returned
     # by the #save method, wrongly indicating the result of saving.
-    def save(*)
+    def save(**)
       @updated_as_aggregated = false
       run_callbacks(:save) do
         return (lookup_self_and_replace or super) if new_record?
@@ -47,8 +47,8 @@ module Moribus
     end
 
     # Bang version of #save.
-    def save!(*args)
-      save(*args) or raise_record_not_saved_error
+    def save!(**kwargs)
+      save(**kwargs) or raise_record_not_saved_error
     end
 
     # Raise "record not saved".

data/lib/moribus/extensions/has_current_extension.rb

@@ -6,21 +6,32 @@ module Moribus
       # Sets 'is_current' flag of overridden record to false, instead
       # of deleting it or setting foreign key to nil.
       def remove_target!(*)
+        # Use custom update to avoid running ActiveRecord optimistic locking
+        # and to avoid updating lock_version column:
         if target.new_record?
           target.is_current = false
+          target.updated_at = Time.zone.now if has_updated_at_column?
         else
-          # Use custom update to avoid running ActiveRecord optimistic locking
-          # and to avoid updating lock_version column:
           klass = target.class
 
           sql =  "UPDATE #{klass.quoted_table_name} " \
                  "SET \"is_current\" = #{klass.connection.quote(false)} "
+
+          sql << %{, "updated_at" = #{klass.connection.quote(Time.zone.now)} } if has_updated_at_column?
+
           sql << "WHERE #{klass.quoted_primary_key} = " \
                  "#{klass.connection.quote(target.send(klass.primary_key))} "
 
           klass.connection.update sql
         end
       end
+
+      # Is the record has a column with name `updated_at`
+      #
+      # @return [Boolean]
+      private def has_updated_at_column?
+        target.class.column_names.include?("updated_at")
+      end
     end
   end
 end

data/lib/moribus/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moribus # :nodoc:
-  VERSION = "0.9.0" # :nodoc:
+  VERSION = "0.10.0" # :nodoc:
 end

data/spec/moribus/extensions/has_current_extension_spec.rb

@@ -16,6 +16,7 @@ describe Moribus::Extensions::HasCurrentExtension do
 
     class SpecCustomer < MoribusSpecModel(spec_status_id: :integer)
       has_one_current :spec_customer_info, inverse_of: :spec_customer, dependent: :destroy
+      delegate_associated :previous_id, to: :spec_customer_info
     end
   end
 
@@ -24,17 +25,45 @@ describe Moribus::Extensions::HasCurrentExtension do
   end
 
   let(:customer) { SpecCustomer.create }
-  let!(:info)    { SpecCustomerInfo.create(spec_customer: customer, is_current: true) }
+  let!(:info) do
+    SpecCustomerInfo.create(spec_customer: customer, is_current: true, created_at: 1.hour.ago, updated_at: 1.hour.ago)
+  end
 
   describe ".remove_target!" do
-    before do
-      allow(customer.spec_customer_info).to receive(:new_record?).and_return(true)
+    context "new record" do
+      before do
+        allow(customer.spec_customer_info).to receive(:new_record?).and_return(true)
+      end
+
+      it "sets 'is_current' flag of overridden record to false for new record" do
+        old_info = customer.spec_customer_info
+        customer.spec_customer_info = SpecCustomerInfo.new
+        expect(old_info.is_current).to be false
+      end
+
+      it "sets 'is_current' flag updates updated_at column" do
+        old_info = customer.spec_customer_info
+        customer.spec_customer_info = SpecCustomerInfo.new
+        expect(old_info.updated_at >= old_info.created_at + 1.hour).to be true
+      end
     end
 
-    it "sets 'is_current' flag of overridden record to false for new record" do
-      old_info = customer.spec_customer_info
-      customer.spec_customer_info = SpecCustomerInfo.new
-      expect(old_info.is_current).to be_falsey
+    context "persisted record" do
+      it "sets 'is_current' flag updates updated_at column" do
+        old_info = customer.spec_customer_info
+        customer.spec_customer_info = SpecCustomerInfo.new
+        old_info.reload
+        # I use 59 minutes instead of hour because there can be small difference in milliseconds
+        expect(old_info.updated_at >= old_info.created_at + 59.minutes).to be true
+      end
+
+      it "sets 'is_current' flag updates updated_at column" do
+        old_info = customer.spec_customer_info
+        customer.update!(previous_id: 123)
+        old_info.reload
+        # I use 59 minutes instead of hour because there can be small difference in milliseconds
+        expect(old_info.updated_at >= old_info.created_at + 59.minutes).to be true
+      end
     end
   end
 end

data/spec/support/moribus_spec_model.rb

@@ -47,8 +47,7 @@ def MoribusSpecModel(column_definition = {})
               end
               options[:default] = 0 if name == :lock_version
               args = [type, name]
-              args << options unless options.empty?
-              t.send(*args)
+              t.send(*args, **options)
             end
           end
         end
@@ -56,4 +55,4 @@ def MoribusSpecModel(column_definition = {})
       end
     end
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: HornsAndHooves-moribus
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - HornsAndHooves
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-11 00:00:00.000000000 Z
+date: 2024-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -208,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.9
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Introduces Aggregated and Tracked behavior to ActiveRecord::Base models