GoogleFinance 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc77798175dc21b3f1cef042d0b7b513ff1d8d03
-  data.tar.gz: adfbe8159064529c21caf62d12550998d7e0905b
+  metadata.gz: b30307bb6718c9806a5fc4236d0e5e668f9b5bf3
+  data.tar.gz: b8875f943c3145c7396d661e05c8e2d28d394f2a
 SHA512:
-  metadata.gz: eaa36fc13de8847cd026d50c8888cde476ef7d36eafcabaaa3abe7fab528c919f804887ce67a1cc02cbe07b7a7973960aa923eba7e7bee69daba8993f88838a9
-  data.tar.gz: '0280fc20584d14e6e4a1d964d244028874e5ad04c499169f07d4228f897cb10b4a4c9bc3fc877e490cb339091a7d85a018e114479a724fb777bdd14d873ef6c7'
+  metadata.gz: f7f76e676302cba8e7e63c929217b0f63de1539194c302a95c0612cf8d33bd412d05c9278d3390dd8897653225c420b63dbb2756f7c6e75fa33669895bf3ba8b
+  data.tar.gz: ca84f039b1d971532bb8a9240c5f91f6f4640d02165cad3316c7f3993f6affbca8a19ce40734f8d11d043ed9d4754b607f55fc5e7450f759fb4ca6f55e69a26e

data/lib/GoogleFinance/Company.rb

@@ -6,17 +6,17 @@ require 'GoogleFinance/HistoricalPrices'
 module GoogleFinance
 
   #
-  # Google Company class 
+  # Google Company class
   class Company
 
     attr_accessor :ticker, :name, :employees, :prices
-  
+
     #
     # get the ticker with the initialize
     def initialize(ticker)
       @ticker = ticker
     end
-    
+
     #
     # Get company name as in Google Finance
     def name
@@ -37,7 +37,7 @@ module GoogleFinance
       page       = Nokogiri::HTML(open(name_url))
       @employees = page.xpath("//div[@class='sfe-section']/table/tr[6]/td[@class='period']").inner_html.gsub(/\n|,|-/, "").to_i
       @employees
-    
+
     end # employees
 
     #
@@ -48,7 +48,7 @@ module GoogleFinance
 
     end # get_historical_prices
 
-    
+
   end # class Company
 
 end #module

data/lib/GoogleFinance/HistoricalPrices.rb

@@ -1,28 +1,29 @@
 require 'date'
 
 module GoogleFinance
-  
+
   class HistoricalPrices
 
     # xpath positions on which Google Finance returns the prices
-    STOCK_OPEN  = 0 
-    STOCK_HIGH  = 1
-    STOCK_LOW   = 2
-    STOCK_CLOSE = 3
-    NUM_COLS    = STOCK_CLOSE + 1
-    NUM_ROWS    = 100
+    STOCK_OPEN   = 0
+    STOCK_HIGH   = 1
+    STOCK_LOW    = 2
+    STOCK_CLOSE  = 3
+    STOCK_VOLUME = 4
+    NUM_COLS     = STOCK_VOLUME
+    NUM_ROWS     = 100
 
     attr_reader :stock_perf
 
     #
-    # 
+    #
     def initialize(ticker, date_start, date_end)
-      
+
       @ticker     = ticker
       @date_start = Date.strptime(date_start, "%Y-%m-%d")
       @date_end   = Date.strptime(date_end,   "%Y-%m-%d")
       @stock_perf = {}
-    
+
       load_share_prices()
 
     end # def initialize
@@ -30,7 +31,7 @@ module GoogleFinance
     #
     # Load the historical prices in the internal hash
     def load_share_prices()
-      
+      #
       # build URL in the right format, in pages of 100 day quotes
       historical_url = @@URL_HIS + @ticker + "&startdate=" + HistoricalPrices.fix_date(@date_start) + 
                        "&enddate=" + HistoricalPrices.fix_date(@date_end) + "&num=#{NUM_ROWS}&start=0"
@@ -44,18 +45,17 @@ module GoogleFinance
       # first page is already acquired, don't make another call
       extract_prices_from_page(page)
       for i in 1..num_calls
-        
+
         historical_url = @@URL_HIS + @ticker + "&startdate=" + HistoricalPrices.fix_date(@date_start) + 
                          "&enddate=" + HistoricalPrices.fix_date(@date_end) + "&num=#{NUM_ROWS}&start=#{i * NUM_ROWS}"
         page = Nokogiri::HTML(open(historical_url))
         extract_prices_from_page(page)
       end
-      
-      
+
     end # load_share_prices
-      
+
+    #
     #
-    # 
     def extract_prices_from_page(page)
 
       quote_dates  = []
@@ -64,12 +64,12 @@ module GoogleFinance
       quote_high   = []
       quote_low    = []
       quote_volume = []
-  
+
       # extract the dates
       dates = page.xpath("//td[@class='lm']")
       dates.each do |date|
         quote_dates.push(HistoricalPrices.google_date_to_ruby(date.content.gsub("\n","")))
-      end 
+      end
 
        # get the stock prices
        counter = 0
@@ -85,9 +85,9 @@ module GoogleFinance
         elsif counter.modulo(GoogleFinance::HistoricalPrices::NUM_COLS) == GoogleFinance::HistoricalPrices::STOCK_CLOSE then
           quote_close.push(val)
         end
-        counter = counter + 1 
+        counter = counter + 1
       end
-    
+
       # get the volumnes
       volumes = page.xpath("//td[@class='rgt rm']")
       volumes.each do |volume|
@@ -95,7 +95,7 @@ module GoogleFinance
       end
 
       # we've extracted everything - build the share price hash
-      for i in 0..(quote_dates.length - 1) 
+      for i in 0..(quote_dates.length - 1)
         @stock_perf[quote_dates[i]] = [quote_open[i], quote_high[i], quote_low[i], quote_close[i], quote_volume[i]]
       end
 
@@ -105,10 +105,10 @@ module GoogleFinance
     #
     # Input date should be in dd-mm-yyyy format
     def self.fix_date(input_date)
-    
+
       months = %w{Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec}
       d = Date.strptime(input_date.to_s, "%Y-%m-%d") unless input_date.class == "Date"
-  
+
       # add '+' between all paramters, and for some reason, the ',' is equal to %2C but won't 
       #   escape to it using addresable, whatever, it works this way
       "#{months[d.mon - 1]}+#{d.day}%2C+#{d.year}"
@@ -118,16 +118,16 @@ module GoogleFinance
     #
     # Take the Gooel date format, bring it in to YYYY-mm-dd
     def self.google_date_to_ruby(input_date)
-      
+
       dump, mon, day, year = input_date.split(/(...) ([0-9]*), (....)/) 
-    
+
       # change month to numerical stuff
       months = { "Jan" => 1, "Feb" => 2, "Mar" => 3, "Apr" => 4,
                  "May" => 5, "Jun" => 6, "Jul" => 7, "Aug" => 8,
                  "Sep" => 9, "Oct" => 10,"Nov" => 11, "Dec" => 12}
       mon = months[mon]
-      mon = "0" + mon.to_s unless mon > 10
-      day = "0" + day.to_s unless day.to_i > 10
+      mon = "0" + mon.to_s unless mon >= 10
+      day = "0" + day.to_s unless day.to_i >= 10
 
       return  "#{year}-#{mon}-#{day}" 
 

data/lib/GoogleFinance/version.rb

@@ -1,3 +1,3 @@
 module GoogleFinance
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: GoogleFinance
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Max Brunet
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-15 00:00:00.000000000 Z
+date: 2016-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -77,6 +77,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - Gemfile
+- GoogleFinance-0.1.2.gem
 - GoogleFinance.gemspec
 - LICENSE.txt
 - README.md