Fingertips-on-test-spec 0.2.0 → 0.2.1

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:minor: 2
-:patch: 0
 :major: 0
+:minor: 2
+:patch: 1

data/lib/test/spec/rails/macros/authorization.rb

@@ -11,11 +11,24 @@ module Test
           #   should.disallow.get :index
           def disallow
             Test::Spec::Rails::Macros::Authorization::TestGenerator.new(test_case,
-              :access_denied?,
+              :access_denied?, true,
               'Expected access to be denied'
             )
           end
           
+          # Generates a test which tests authorization code. It assumes a method called <code>access_denied?</code>
+          # on the test case. The <code>access_denied?</code> method should return true when access is denied
+          # (ie. a 403 status code) and false in other cases.
+          #
+          # Example:
+          #   should.allow.get :index
+          def allow
+            Test::Spec::Rails::Macros::Authorization::TestGenerator.new(test_case,
+              :access_denied?, false,
+              'Expected access to be allowed'
+            )
+          end
+          
           # Generates a test which tests authorization code. It assumes a method called <code>access_denied?</code>
           # on the test case. The <code>login_required?</code> method should return true when the visitor was
           # asked for credentials (ie. a 401 status code or a redirect to a login page) and false in other cases.
@@ -24,7 +37,7 @@ module Test
           #   should.require_login.get :index
           def require_login
             Test::Spec::Rails::Macros::Authorization::TestGenerator.new(test_case,
-              :login_required?,
+              :login_required?, true,
               'Expected login to be required'
             )
           end
@@ -32,10 +45,11 @@ module Test
         
         module Authorization
           class TestGenerator < Proxy
-            attr_accessor :validation_method, :message
+            attr_accessor :validation_method, :message, :expected
             
-            def initialize(test_case, validation_method, message)
+            def initialize(test_case, validation_method, expected, message)
               self.validation_method = validation_method
+              self.expected = expected
               self.message = message
               
               super(test_case)
@@ -47,11 +61,12 @@ module Test
                 description << " #{params.inspect}" unless params.blank?
                 
                 validation_method = self.validation_method
+                expected = self.expected
                 message = self.message
                 
                 test_case.it description do
                   send(verb, action, immediate_values(params))
-                  send(validation_method).should.messaging(message) == true
+                  send(validation_method).should.messaging(message) == expected
                 end
               else
                 super

data/on-test-spec.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{on-test-spec}
-  s.version = "0.2.0"
+  s.version = "0.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Manfred Stienstra", "Eloy Duran", "Cristi Balan"]
-  s.date = %q{2009-09-11}
+  s.date = %q{2009-09-21}
   s.description = %q{Rails plugin to make testing Rails on test/spec easier.}
   s.email = %q{eloy.de.enige@gmail.com}
   s.extra_rdoc_files = [
@@ -43,10 +43,11 @@ Gem::Specification.new do |s|
      "test/share_test.rb",
      "test/test_helper.rb"
   ]
+  s.has_rdoc = true
   s.homepage = %q{http://github.com/Fingertips/on-test-spec}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.5}
+  s.rubygems_version = %q{1.3.1}
   s.summary = %q{Rails plugin to make testing Rails on test/spec easier.}
   s.test_files = [
     "test/add_allow_switch_test.rb",
@@ -61,7 +62,7 @@ Gem::Specification.new do |s|
 
   if s.respond_to? :specification_version then
     current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 3
+    s.specification_version = 2
 
     if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
     else

data/test/macros/authorization_test.rb

@@ -4,7 +4,7 @@ require 'test/spec/rails/macros'
 describe "TestGenerator, concerning generation" do
   before do
     @test = mock('Test')
-    @generator = Test::Spec::Rails::Macros::Authorization::TestGenerator.new(@test, :access_denied?, 'Expected access to be denied')
+    @generator = Test::Spec::Rails::Macros::Authorization::TestGenerator.new(@test, :access_denied?, true, 'Expected access to be denied')
   end
   
   it "should generate a test description for a GET" do
@@ -32,7 +32,7 @@ end
 
 describe "TestGenerator, concerning test contents" do
   before do
-    @generator = Test::Spec::Rails::Macros::Authorization::TestGenerator.new(Immediate, :access_denied?, 'Expected access to be denied')
+    @generator = Test::Spec::Rails::Macros::Authorization::TestGenerator.new(Immediate, :access_denied?, true, 'Expected access to be denied')
     @generator.stubs(:send).with(:access_denied?).returns(true)
   end
   
@@ -52,6 +52,16 @@ describe "TestGenerator, concerning test contents" do
     
     @generator.post(:create, params)
   end
+  
+  it "should test the return value of the validation method against the expected method" do
+    @generator.expected = false
+    params = {:name => 'bitterzoet'}
+    
+    @generator.expects(:immediate_values).with(params).returns(params)
+    @generator.stubs(:send).returns(false)
+    
+    @generator.post(:create, params)
+  end
 end
 
 describe "Macros::Authorization" do
@@ -67,6 +77,17 @@ describe "Macros::Authorization" do
     generator.test_case.should == @test_case
     generator.validation_method.should == :access_denied?
     generator.message.should == 'Expected access to be denied'
+    generator.expected.should == true
+  end
+  
+  it "should return a test generator when a new allow rule is invoked" do
+    generator = @proxy.allow
+    
+    generator.should.is_a(Test::Spec::Rails::Macros::Authorization::TestGenerator)
+    generator.test_case.should == @test_case
+    generator.validation_method.should == :access_denied?
+    generator.message.should == 'Expected access to be denied'
+    generator.expected.should == false
   end
   
   it "should return a test generator when a new login_required rule is invoked" do
@@ -76,5 +97,6 @@ describe "Macros::Authorization" do
     generator.test_case.should == @test_case
     generator.validation_method.should == :login_required?
     generator.message.should == 'Expected login to be required'
+    generator.expected.should == true
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: Fingertips-on-test-spec
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Manfred Stienstra
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-11 00:00:00 -07:00
+date: 2009-09-21 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -50,7 +50,7 @@ files:
 - test/rails_test.rb
 - test/share_test.rb
 - test/test_helper.rb
-has_rdoc: false
+has_rdoc: true
 homepage: http://github.com/Fingertips/on-test-spec
 licenses: 
 post_install_message: 
@@ -75,7 +75,7 @@ requirements: []
 rubyforge_project: 
 rubygems_version: 1.3.5
 signing_key: 
-specification_version: 3
+specification_version: 2
 summary: Rails plugin to make testing Rails on test/spec easier.
 test_files: 
 - test/add_allow_switch_test.rb