Eman_Fraction 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 38e53b504f69bd6698569dd50107b2e6dd42b64c13112a8d7601deb19ad1a828
-  data.tar.gz: 4c969e17cc77bc7a20cbe6ab04d9bf850512def29ab9f355ea083bf4fc29b3d7
+  metadata.gz: 965800579a72dbb17f7b371c12b1b8e1b36b676392740c486c99a61decace1b9
+  data.tar.gz: 3ba3d937aa02559bdba4d7270a9066bb76e02d9950ae6d2f754a95b2c809b26b
 SHA512:
-  metadata.gz: 89f7d093224fe65b7ce7689843a46191a317bb902b2c2af337561c8a2c60534bba78dc116166df43ae3cc32f0687cb35b999f8435dc80cd28ceed8f3cbc19649
-  data.tar.gz: bd80e28a8dc5699e5f38712b97453a654ad9f84fcdfc8ec16a0479bce8f225b8f7739403c707441d93d363158b5625ed2caf029e6d7926bcb9ce56a01a62c659
+  metadata.gz: 71c2c459d4655436018b6785ae599b543df3e2df636580e0283775425bf6222609e4930740d8f05e3fc10ed078d54ffddca45cc9c9a55546920e4500ddd67418
+  data.tar.gz: 96da9117823ab068a59af2bd18f259974adea66cf72f71d853443003aa1bcc27771a2eba3a58ee8da0c3a3c024d0d3809550a6cc0eafd2a26561cce1d4f8c419

data/lib/eman_fraction.rb

@@ -1,6 +1,8 @@
 class Fraction < Numeric
   attr_reader :numerator, :denominator
   def initialize(numerator:, denominator:)
+    raise InvalidFraction, 'denominator cannot be zero' if denominator.zero?
+
     @numerator = numerator
     @denominator = denominator
     simplify
@@ -8,9 +10,26 @@ class Fraction < Numeric
 
   def +(other)
     return 0 if zeros?(other) # Don't really know how to deal with this otherwise
+
     self_numerator = numerator * other.denominator
     other_numerator = other.numerator * denominator
-    self.class.new(numerator: self_numerator + other_numerator, denominator: other.denominator * denominator)
+    new_fraction = self.class.new(numerator: self_numerator + other_numerator, denominator: other.denominator * denominator)
+
+    return 0 if new_fraction.numerator.zero?
+
+    new_fraction
+  end
+
+  def -(other)
+    self_numerator = numerator * other.denominator
+    other_numerator = other.numerator * denominator
+    new_fraction = self.class.new(
+      numerator: self_numerator - other_numerator,
+      denominator: other.denominator * denominator
+    )
+    return 0 if new_fraction.numerator.zero?
+
+    new_fraction
   end
 
   def ==(other)
@@ -26,16 +45,19 @@ class Fraction < Numeric
     num_factors = factors(numerator)
     common_factors = denon_factors & num_factors
     return if common_factors.empty?
-    @numerator = @numerator / common_factors.last
-    @denominator = @denominator / common_factors.last
+
+    @numerator /= common_factors.last
+    @denominator /= common_factors.last
   end
 
   def factors(number)
-    (1..number).select {|x| number % x == 0 }
+    (1..number).select { |x| number % x == 0 }
   end
 
   def zeros?(other)
-    (other.zero? || (other.numerator.zero? && other.denominator.zero?)) && 
-    (self.numerator.zero? && self.denominator.zero?)
+    (other.zero? || (other.numerator.zero? && other.denominator.zero?)) &&
+      (numerator.zero? && denominator.zero?)
+  end
+  class InvalidFraction < StandardError
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: Eman_Fraction
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Emmanuel Genard