ETL 1.1.0 → 1.1.1

data/lib/etl.rb

@@ -69,6 +69,8 @@ class ETL
   # for any given variable included in the method name's array
   (ORDERED_ETL_OPERATIONS - [:etl]).each do |method|
     define_method method do |*args, &block|
+      warn_args_will_be_deprecated_for method unless args.empty?
+
       if block
         instance_variable_set("@#{method}", block)
       else
@@ -79,6 +81,8 @@ class ETL
   end
 
   def etl *args, &block
+    warn_args_will_be_deprecated_for :etl unless args.empty?
+
     if block_given?
       @etl = block
     else
@@ -114,6 +118,8 @@ class ETL
   # for any given variable included in the method name's array
   ITERATOR_OPERATIONS.each do |method|
     define_method method do |*args, &block|
+      warn_args_will_be_deprecated_for method unless args.empty?
+
       if block
         instance_variable_set("@_#{method}_block", block)
       else
@@ -142,6 +148,10 @@ class ETL
 
 private
 
+  def warn_args_will_be_deprecated_for method
+    warn "DEPRECATED: passing arguments to ##{method} will be removed in an upcoming release and will raise an exception. Please remove this from your code."
+  end
+
   def iterate?
     ITERATOR_OPERATIONS.all? do |method|
       instance_variable_defined?("@_#{method}_block")

data/lib/etl/version.rb

@@ -1,3 +1,3 @@
 class ETL
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/etl_spec.rb

@@ -38,6 +38,94 @@ end
 describe ETL do
   let(:logger) { nil }
 
+  describe "deprecations" do
+    let(:etl) { described_class.new }
+
+    context "#ensure_destination" do
+      it "does not warn when no args are passed" do
+        etl.should_receive(:warn).never
+        etl.ensure_destination {}
+      end
+
+      it "warns when args are passed that this is deprecated" do
+        etl.should_receive(:warn).with("DEPRECATED: passing arguments to #ensure_destination will be removed in an upcoming release and will raise an exception. Please remove this from your code.")
+        etl.ensure_destination('some arg') {}
+      end
+    end
+
+    context "#before_etl" do
+      it "does not warn when no args are passed" do
+        etl.should_receive(:warn).never
+        etl.before_etl {}
+      end
+
+      it "warns when args are passed that this is deprecated" do
+        etl.should_receive(:warn).with("DEPRECATED: passing arguments to #before_etl will be removed in an upcoming release and will raise an exception. Please remove this from your code.")
+        etl.before_etl('some arg') {}
+      end
+    end
+
+    context "#start" do
+      it "does not warn when no args are passed" do
+        etl.should_receive(:warn).never
+        etl.start {}
+      end
+
+      it "warns when args are passed that this is deprecated" do
+        etl.should_receive(:warn).with("DEPRECATED: passing arguments to #start will be removed in an upcoming release and will raise an exception. Please remove this from your code.")
+        etl.start('some arg') {}
+      end
+    end
+
+    context "#step" do
+      it "does not warn when no args are passed" do
+        etl.should_receive(:warn).never
+        etl.step {}
+      end
+
+      it "warns when args are passed that this is deprecated" do
+        etl.should_receive(:warn).with("DEPRECATED: passing arguments to #step will be removed in an upcoming release and will raise an exception. Please remove this from your code.")
+        etl.step('some arg') {}
+      end
+    end
+
+    context "#stop" do
+      it "does not warn when no args are passed" do
+        etl.should_receive(:warn).never
+        etl.stop {}
+      end
+
+      it "warns when args are passed that this is deprecated" do
+        etl.should_receive(:warn).with("DEPRECATED: passing arguments to #stop will be removed in an upcoming release and will raise an exception. Please remove this from your code.")
+        etl.stop('some arg') {}
+      end
+    end
+
+    context "#etl" do
+      it "does not warn when no args are passed" do
+        etl.should_receive(:warn).never
+        etl.etl {}
+      end
+
+      it "warns when args are passed that this is deprecated" do
+        etl.should_receive(:warn).with("DEPRECATED: passing arguments to #etl will be removed in an upcoming release and will raise an exception. Please remove this from your code.")
+        etl.etl('some arg') {}
+      end
+    end
+
+    context "#after_etl" do
+      it "does not warn when no args are passed" do
+        etl.should_receive(:warn).never
+        etl.after_etl {}
+      end
+
+      it "warns when args are passed that this is deprecated" do
+        etl.should_receive(:warn).with("DEPRECATED: passing arguments to #after_etl will be removed in an upcoming release and will raise an exception. Please remove this from your code.")
+        etl.after_etl('some arg') {}
+      end
+    end
+  end
+
   describe ".connection=" do
     let(:class_level_connection) { stub('class_level_connection') }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ETL
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
   prerelease: 
 platform: ruby
 authors: