EGP_Rates 0.1.0 → 0.2.0

data/spec/cassettes/CIB.yml

@@ -0,0 +1,58 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: http://www.cibeg.com/_layouts/15/LINKDev.CIB.CurrenciesFunds/FundsCurrencies.aspx/GetCurrencies
+    body:
+      encoding: UTF-8
+      string: '{"lang":"en"}'
+    headers:
+      Content-Type:
+      - application/json
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - www.cibeg.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - private, max-age=0
+      Content-Type:
+      - application/json; charset=utf-8
+      Vary:
+      - Accept-Encoding
+      Server:
+      - ''
+      X-Sharepointhealthscore:
+      - '0'
+      Sprequestguid:
+      - bbcab69d-7775-603d-69e8-36d340f9fb56
+      Request-Id:
+      - bbcab69d-7775-603d-69e8-36d340f9fb56
+      X-Frame-Options:
+      - SAMEORIGIN
+      Sprequestduration:
+      - '16'
+      Spiislatency:
+      - '0'
+      X-Content-Type-Options:
+      - nosniff
+      X-Ms-Invokeapp:
+      - 1; RequireReadOnly
+      Date:
+      - Sat, 12 Nov 2016 21:43:33 GMT
+      Content-Length:
+      - '336'
+    body:
+      encoding: ASCII-8BIT
+      string: '{"d":[{"__type":"LINKDev.CIB.CurrenciesFunds.CIBFund.CurrencyObject","CurrencyID":"USD","BuyRate":15.9,"SellRate":16.05},{"__type":"LINKDev.CIB.CurrenciesFunds.CIBFund.CurrencyObject","CurrencyID":"EUR","BuyRate":17.1904,"SellRate":17.5234},{"__type":"LINKDev.CIB.CurrenciesFunds.CIBFund.CurrencyObject","CurrencyID":"GBP","BuyRate":19.9359,"SellRate":20.292},{"__type":"LINKDev.CIB.CurrenciesFunds.CIBFund.CurrencyObject","CurrencyID":"CHF","BuyRate":16.0433,"SellRate":16.3176},{"__type":"LINKDev.CIB.CurrenciesFunds.CIBFund.CurrencyObject","CurrencyID":"SAR","BuyRate":4.2327,"SellRate":4.281},{"__type":"LINKDev.CIB.CurrenciesFunds.CIBFund.CurrencyObject","CurrencyID":"KWD","BuyRate":52.2074,"SellRate":53.0018}]}'
+    http_version: 
+  recorded_at: Sat, 12 Nov 2016 21:48:36 GMT
+recorded_with: VCR 3.0.3

data/spec/egp_rates/aaib_spec.rb

@@ -0,0 +1,88 @@
+# frozen_string_literal: true
+describe EGPRates::AAIB do
+  subject(:bank) { described_class.new }
+
+  it 'Live Testing', :live do
+    expect(bank.exchange_rates).to include(:buy, :sell)
+    expect(bank.exchange_rates[:buy].size).to eq 7
+    expect(bank.exchange_rates[:sell].size).to eq 7
+  end
+
+  describe '.new' do
+    it 'initialize instance variables' do
+      expect(bank.sym).to eq :AAIB
+      expect(bank.instance_variable_get(:@uri)).to be_a URI
+    end
+  end
+
+  describe '#exchange_rates', vcr: { cassette_name: :AAIB } do
+    it 'calls #parse with #raw_exchange_rates' do
+      expect(bank).to receive(:raw_exchange_rates)
+      expect(bank).to receive(:parse)
+      bank.exchange_rates
+    end
+  end
+
+  describe '#raw_exchange_rates' do
+    it 'raises ResponseError unless Net::HTTPSuccess', :no_vcr do
+      stub_request(:get, /.*aaib.*/).to_return(body: '', status: 500)
+      expect { bank.send(:raw_exchange_rates) }.to raise_error\
+        EGPRates::ResponseError, '500'
+    end
+
+    it 'raises ResponseError if HTML structure changed', :no_vcr do
+      stub_request(:get, /.*aaib.*/).to_return(body: '', status: 200)
+      expect { bank.send(:raw_exchange_rates) }.to raise_error\
+        EGPRates::ResponseError, 'Unknown HTML'
+    end
+
+    it 'returns <#Enumerator::Lazy> of 7 rows', vcr: { cassette_name: :AAIB } do
+      lazy_enumerator = bank.send(:raw_exchange_rates)
+      expect(lazy_enumerator).to be_a Enumerator::Lazy
+      expect(lazy_enumerator.size).to eq 7
+    end
+  end
+
+  describe '#currency_symbol' do
+    %w(US EURO STERLING SWISS SAUDI KUWAIT DIRHAM)\
+      .each do |currency|
+      it "returns currency :SYM for #{currency}" do
+        symbols = %i(USD EUR GBP CHF SAR KWD AED)
+        expect(symbols).to include(bank.send(:currency_symbol, currency))
+      end
+    end
+
+    it 'raises ResponseError when Unknown Currency' do
+      expect { bank.send(:currency_symbol, 'EGYPTIAN POUND') }.to raise_error\
+        EGPRates::ResponseError, 'Unknown currency EGYPTIAN POUND'
+    end
+  end
+
+  describe '#parse', vcr: { cassette_name: :AAIB } do
+    let(:raw_data) { bank.send(:raw_exchange_rates) }
+
+    it 'returns sell: hash of selling prices' do
+      expect(bank.send(:parse, raw_data)[:sell]).to include(
+        AED: 4.3697,
+        CHF: 16.3259,
+        EUR: 17.5314,
+        GBP: 20.3402,
+        KWD: 53.2869,
+        SAR: 4.2797,
+        USD: 16.05
+      )
+    end
+
+    it 'returns buy: hash of buying prices' do
+      expect(bank.send(:parse, raw_data)[:buy]).to include(
+        AED: 4.3043,
+        CHF: 16.0687,
+        EUR: 17.2213,
+        GBP: 19.9609,
+        KWD: 52.2056,
+        SAR: 4.2157,
+        USD: 15.9
+      )
+    end
+  end
+end

data/spec/egp_rates/cbe_spec.rb

@@ -4,6 +4,8 @@ describe EGPRates::CBE do
 
   it 'Live Testing', :live do
     expect(bank.exchange_rates).to include(:buy, :sell)
+    expect(bank.exchange_rates[:buy].size).to eq 9
+    expect(bank.exchange_rates[:sell].size).to eq 9
   end
 
   describe '.new' do

data/spec/egp_rates/cib_spec.rb

@@ -0,0 +1,92 @@
+# frozen_string_literal: true
+describe EGPRates::CIB do
+  subject(:bank) { described_class.new }
+
+  it 'Live Testing', :live do
+    expect(bank.exchange_rates).to include(:buy, :sell)
+    expect(bank.exchange_rates[:buy].size).to eq 6
+    expect(bank.exchange_rates[:sell].size).to eq 6
+  end
+
+  describe '.new' do
+    it 'initialize instance variables' do
+      expect(bank.sym).to eq :CIB
+      expect(bank.instance_variable_get(:@uri)).to be_a URI
+    end
+  end
+
+  describe '#exchange_rates', vcr: { cassette_name: :CIB } do
+    it 'calls #parse with #raw_exchange_rates' do
+      expect(bank).to receive(:raw_exchange_rates)
+      expect(bank).to receive(:parse)
+      bank.exchange_rates
+    end
+  end
+
+  describe '#raw_exchange_rates' do
+    it 'raises ResponseError unless Net::HTTPSuccess', :no_vcr do
+      stub_request(:post, /.*cib.*/).to_return(body: '', status: 500)
+      expect { bank.send(:raw_exchange_rates) }.to raise_error\
+        EGPRates::ResponseError, '500'
+    end
+
+    it 'raises ResponseError if JSON respnonse changed', :no_vcr do
+      stub_request(:post, /.*cib.*/).to_return(
+        body: { d: { USD: 1 } }.to_json,
+        status: 200
+      )
+      expect { bank.send(:raw_exchange_rates) }.to raise_error\
+        EGPRates::ResponseError, /Unknown JSON/
+    end
+
+    it 'raises ResponseError if empty JSON respnonse', :no_vcr do
+      stub_request(:post, /.*cib.*/).to_return(body: '"{}"', status: 200)
+      expect { bank.send(:raw_exchange_rates) }.to raise_error\
+        EGPRates::ResponseError, /Unknown JSON/
+    end
+
+    it 'raises ResponseError if malformed JSON respnonse', :no_vcr do
+      stub_request(:post, /.*cib.*/).to_return(body: '{ data', status: 200)
+      expect { bank.send(:raw_exchange_rates) }.to raise_error\
+        EGPRates::ResponseError, /Unknown JSON/
+    end
+
+    it 'raises ResponseError if empty respnonse', :no_vcr do
+      stub_request(:post, /.*cib.*/).to_return(body: '""', status: 200)
+      expect { bank.send(:raw_exchange_rates) }.to raise_error\
+        EGPRates::ResponseError, /Unknown JSON/
+    end
+
+    it 'returns Hash of 6 currencies rates', vcr: { cassette_name: :CIB } do
+      response = bank.send(:raw_exchange_rates)
+      expect(response.size).to eq 1
+      expect(response['d'].size).to eq 6
+    end
+  end
+
+  describe '#parse', vcr: { cassette_name: :CIB } do
+    let(:raw_data) { bank.send(:raw_exchange_rates) }
+
+    it 'returns sell: hash of selling prices' do
+      expect(bank.send(:parse, raw_data)[:sell]).to include(
+        CHF: 16.3176,
+        EUR: 17.5234,
+        GBP: 20.292,
+        KWD: 53.0018,
+        SAR: 4.281,
+        USD: 16.05
+      )
+    end
+
+    it 'returns buy: hash of buying prices' do
+      expect(bank.send(:parse, raw_data)[:buy]).to include(
+        CHF: 16.0433,
+        EUR: 17.1904,
+        GBP: 19.9359,
+        KWD: 52.2074,
+        SAR: 4.2327,
+        USD: 15.9
+      )
+    end
+  end
+end

data/spec/egp_rates/nbe_spec.rb

@@ -4,6 +4,8 @@ describe EGPRates::NBE do
 
   it 'Live Testing', :live do
     expect(bank.exchange_rates).to include(:buy, :sell)
+    expect(bank.exchange_rates[:buy].size).to eq 17
+    expect(bank.exchange_rates[:sell].size).to eq 17
   end
 
   describe '.new' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: EGP_Rates
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Ahmed Abdel-Razzak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-12 00:00:00.000000000 Z
+date: 2016-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -172,13 +172,19 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/egp_rates.rb
+- lib/egp_rates/aaib.rb
 - lib/egp_rates/bank.rb
 - lib/egp_rates/cbe.rb
+- lib/egp_rates/cib.rb
 - lib/egp_rates/nbe.rb
+- spec/cassettes/AAIB.yml
 - spec/cassettes/CBE.yml
+- spec/cassettes/CIB.yml
 - spec/cassettes/NBE.yml
+- spec/egp_rates/aaib_spec.rb
 - spec/egp_rates/bank_spec.rb
 - spec/egp_rates/cbe_spec.rb
+- spec/egp_rates/cib_spec.rb
 - spec/egp_rates/nbe_spec.rb
 - spec/egp_rates_spec.rb
 - spec/spec_helper.rb