Dutchie-Style 2.0.7 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65273e051cf2984400af56b705adb309d5d679664f0e4b0d2516223db16e0470
-  data.tar.gz: '0208a19e313688ff46475083fce4b44d446eb30f3a4010bf6dd07931227d7bbe'
+  metadata.gz: 66d1a3b386238c749fe8a2a57e69ac726ab64167e54fbf18fb3242e8e9988d21
+  data.tar.gz: 5590171816b08b40de46bf110d7d5e59eae4a8289a2dbd71cec88be6e94a5da7
 SHA512:
-  metadata.gz: b74f3ff0bc262f7f7c4312b4a390e84655925915b9eddfd9f95f7863e632e922643a3c791797b60c753f4a5aab60c98f63c7bb3556b2a4aebe17de31afd9d8e8
-  data.tar.gz: 62fcfc8ffe8461d3eaabbc4d5579a4d18ca4c6eca8320b461d3280b16a7d4dac90203b74076bd00084b15128995e3a9fbf4340e75207e599c4b8d1ac09923261
+  metadata.gz: 95e9b22ce1d0f8016bb718f94145149f9f7f0daef5f8e431946559e3443e53e60935249884240dc8605293a64ee62156640bbc4923be535150213187bd6b516c
+  data.tar.gz: 906c6e5cb0961f91a2fae2b04628e42f73773f0e77e75e01cfc19a35fb4a52e6e7c403554e7abb4f1c2ae380b5c3e05d6e1af24cc1f2961e9e923d76d4114c9c

data/Dutchie-Style.gemspec

@@ -1,4 +1,6 @@
-require_relative 'lib/Dutchie/Style/version'
+# frozen_string_literal: true
+
+require_relative "lib/Dutchie/Style/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "Dutchie-Style"
@@ -6,12 +8,12 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Christopher Ostrowski"]
   spec.email         = ["chris@dutchie.com"]
 
-  spec.license = 'MIT'
+  spec.license = "MIT"
 
-  spec.summary       = %q{Rubocop Settings for all dutchie Ruby Apps}
-  spec.description   = %q{Rubocop Settings for all dutchie Ruby Apps}
+  spec.summary       = "Rubocop Settings for all dutchie Ruby Apps"
+  spec.description   = "Rubocop Settings for all dutchie Ruby Apps"
   spec.homepage      = "https://github.com/GetDutchie/Dutchie-Style"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
+  spec.required_ruby_version = Gem::Requirement.new(">= 3.0.6")
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/GetDutchie/Dutchie-Style"
@@ -19,14 +21,20 @@ Gem::Specification.new do |spec|
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  end
+  spec.files =
+    Dir.chdir(File.expand_path(__dir__)) do
+      `git ls-files -z`.split("\x0").reject {|f| f.match(%r{^(test|spec|features)/}) }
+    end
   spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.executables   = spec.files.grep(%r{^exe/}) {|f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 1.56"
-  spec.add_dependency "rubocop-rspec"
-  spec.add_dependency "rubocop-rails"
+  spec.add_dependency "rubocop", "~> 1.72"
+  spec.add_dependency "rubocop-capybara", "~> 2.18"
+  spec.add_dependency "rubocop-factory_bot", "~> 2.24"
+  spec.add_dependency "rubocop-rails", "~> 2.21"
+  spec.add_dependency "rubocop-rspec", "~> 2.24"
+  spec.add_dependency "rubocop-rspec_rails", "~> 2.25"
+
+  spec.metadata["rubygems_mfa_required"] = "true"
 end

data/Gemfile

@@ -5,5 +5,5 @@ gemspec
 
 gem "rake", "~> 12.0"
 gem "rspec", "~> 3.0"
-gem "rubocop", "~> 1.56"
+gem "rubocop", "~> 1.72"
 gem "rubocop-rails", "~> 2.14"

data/Gemfile.lock

@@ -1,10 +1,13 @@
 PATH
   remote: .
   specs:
-    Dutchie-Style (2.0.7)
-      rubocop (~> 1.56)
-      rubocop-rails
-      rubocop-rspec
+    Dutchie-Style (2.1.0)
+      rubocop (~> 1.72)
+      rubocop-capybara (~> 2.18)
+      rubocop-factory_bot (~> 2.24)
+      rubocop-rails (~> 2.21)
+      rubocop-rspec (~> 2.24)
+      rubocop-rspec_rails (~> 2.25)
 
 GEM
   remote: https://rubygems.org/
@@ -14,25 +17,25 @@ GEM
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    ast (2.4.2)
-    base64 (0.1.1)
+    ast (2.4.3)
     concurrent-ruby (1.2.2)
     diff-lcs (1.4.2)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    json (2.6.3)
-    language_server-protocol (3.17.0.3)
+    json (2.13.2)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
     minitest (5.20.0)
-    parallel (1.23.0)
-    parser (3.2.2.3)
+    parallel (1.27.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
-    racc (1.7.1)
+    prism (1.4.0)
+    racc (1.8.1)
     rack (3.0.8)
     rainbow (3.1.1)
     rake (12.3.3)
-    regexp_parser (2.8.1)
-    rexml (3.2.6)
+    regexp_parser (2.10.0)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -46,36 +49,44 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    rubocop (1.56.2)
-      base64 (~> 0.1.1)
+    rubocop (1.79.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 3.2.2.3)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.29.0)
-      parser (>= 3.2.1.0)
+      tsort (>= 0.2.0)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.46.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
     rubocop-capybara (2.18.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.1)
-      rubocop (~> 1.33)
-    rubocop-rails (2.14.2)
+    rubocop-factory_bot (2.27.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-rails (2.22.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 1.7.0, < 2.0)
-    rubocop-rspec (2.23.2)
-      rubocop (~> 1.33)
+      rubocop (>= 1.33.0, < 2.0)
+    rubocop-rspec (2.31.0)
+      rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
+      rubocop-rspec_rails (~> 2.28)
+    rubocop-rspec_rails (2.29.0)
+      rubocop (~> 1.40)
     ruby-progressbar (1.13.0)
+    tsort (0.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.4.2)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
 
 PLATFORMS
   ruby
@@ -84,7 +95,7 @@ DEPENDENCIES
   Dutchie-Style!
   rake (~> 12.0)
   rspec (~> 3.0)
-  rubocop (~> 1.56)
+  rubocop (~> 1.72)
   rubocop-rails (~> 2.14)
 
 BUNDLED WITH

data/README.md

@@ -8,6 +8,8 @@ This repo contains all shared linter configs and style guides used by dutchie en
 
 It is available as a rubygem as well as an NPM package.
 
+To run rubocop on the project using the current style guide: `bundle exec rubocop -c config/default.yml`.
+
 [Join Us! We're Hiring!](https://dutchie.com/careers)
 
 Includes:
@@ -15,4 +17,4 @@ Includes:
 * RuboCop Config
 * RuboCop Rspec Config
 * Eslint Config
-* Prettier Config
+* Prettier Config

data/config/default.yml

@@ -0,0 +1,326 @@
+require:
+  - rubocop-rspec
+  - rubocop-rspec_rails
+  - rubocop-rails
+  - rubocop-capybara
+
+AllCops:
+  TargetRubyVersion: 3.1.4
+  EnabledByDefault: true
+  DisplayCopNames: true
+  Exclude:
+    - 'bin/**/*'
+    - 'db/**/*'
+    - 'vendor/**/*'
+    - 'config/**/*'
+    - 'docs/**/*'
+    - 'app/channels/**/*'
+    - 'script/**/*'
+    - 'lib/assets/**/*'
+    - 'Rakefile'
+    - 'Gemfile'
+    - 'Guardfile'
+    - '*.yml'
+    - '.pryrc'
+
+# Capybara/RSpec cops
+
+# Allows us to use scenario/feature instead of it/describes
+RSpec/Dialect:
+  Enabled: true
+  PreferredMethods: ['feature', 'scenario']
+
+# https://docs.rubocop.org/rubocop/1.10/cops_layout.html#layoutclassstructure
+Layout/ClassStructure:
+  Enabled: true
+
+# Commonly used screens these days easily fit more than 80 characters.
+# Ignores long lines with Heredocs or URIs in them
+Layout/LineLength:
+  Max: 120
+  AllowHeredoc: true
+  # - There's a bug which considers commas after a URI too long so we can't use built-in AllowURI setting.
+  # Pattern matches valid URI encapsulated within a string literal.
+  # - Ignore top level comments (sometimes autogenerated, e.g. annotate_models)
+  AllowedPatterns: ['["\u0027].*https?[\w\:\/\$\–\-\#\.\+\!\*\‘\(\)\,]*.*["\u0027]', '\A#']
+
+
+# No space makes the method definition shorter and differentiates
+# from a regular assignment.
+Layout/SpaceAroundEqualsInParameterDefault:
+  EnforcedStyle: no_space
+
+# Most readable form.
+Layout/HashAlignment:
+  EnforcedHashRocketStyle: table
+  EnforcedColonStyle: table
+
+# Indenting the chained dots beneath each other is not supported by this cop,
+# see https://github.com/bbatsov/rubocop/issues/1633
+Layout/MultilineOperationIndentation:
+  Enabled: false
+
+# Suppressing exceptions can be perfectly fine, and be it to avoid to
+# explicitly type nil into the rescue since that's what you want to return,
+# or suppressing LoadError for optional dependencies
+Lint/SuppressedException:
+  Enabled: false
+
+Layout/SpaceInsideBlockBraces:
+  # The space here provides no real gain in readability while consuming
+  # horizontal space that could be used for a better parameter name.
+  # Also {| differentiates better from a hash than { | does.
+  SpaceBeforeBlockParameters: false
+
+# No trailing space differentiates better from the block:
+# foo} means hash, foo } means block.
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
+# Exclude RSpec
+Metrics/BlockLength:
+  Exclude:
+    - "spec/factories/**/*.rb"
+  AllowedMethods: ['describe', 'context']
+
+# Too short methods lead to extraction of single-use methods, which can make
+# the code easier to read (by naming things), but can also clutter the class
+Metrics/MethodLength:
+  Max: 20
+
+# The guiding principle of classes is SRP, SRP can't be accurately measured by LoC
+Metrics/ClassLength:
+  Max: 1500
+
+# Check with yard instead.
+Style/DocumentationMethod:
+  Enabled: false
+
+Style/Copyright:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+# We are using DateTime extensively.
+Style/DateTime:
+  Enabled: false
+
+# We do not need to support Ruby 1.9, so this is good to use.
+Style/SymbolArray:
+  Enabled: true
+
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/MissingElse
+Style/MissingElse:
+  Enabled: false
+
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/StringHashKeys
+Style/StringHashKeys:
+  Enabled: false
+
+# Single quotes being faster is hardly measurable and only affects parse time.
+# Enforcing double quotes reduces the times where you need to change them
+# when introducing an interpolation. Use single quotes only if their semantics
+# are needed.
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/HashSyntax:
+  EnforcedStyle: ruby19_no_mixed_keys
+  EnforcedShorthandSyntax: either
+
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashEachMethods
+Style/HashEachMethods:
+  Enabled: true
+
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformKeys
+Style/HashTransformKeys:
+  Enabled: false
+
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformValues
+Style/HashTransformValues:
+  Enabled: false
+
+# has_key? and has_value? are far more readable than key? and value?
+Style/PreferredHashMethods:
+  Enabled: false
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styledisablecopswithinsourcecodedirective
+Style/DisableCopsWithinSourceCodeDirective:
+  Enabled: false
+
+# String#% is by far the least verbose and only object oriented variant.
+Style/FormatString:
+  EnforcedStyle: percent
+
+Style/CollectionMethods:
+  Enabled: true
+  PreferredMethods:
+    # find is not equivalent on mongoid embeds or collections
+    find: "detect"
+    # inject seems more common in the community.
+    reduce: "inject"
+
+# Either allow this style or don't. Marking it as safe with parenthesis
+# is silly. Let's try to live without them for now.
+Style/ParenthesesAroundCondition:
+  AllowSafeAssignment: false
+
+# https://github.com/rubocop-hq/rubocop/blob/master/config/default.yml#L3095
+# https://getdutchie.slack.com/archives/CJQCWSWQ4/p1592860363429600
+# Optional inline and required multi
+Style/MethodCallWithArgsParentheses:
+  Description: 'Use parentheses for method calls with arguments.'
+  StyleGuide: '#method-invocation-parens'
+  Enabled: false
+  VersionAdded: '0.47'
+  VersionChanged: '0.61'
+  IgnoreMacros: true
+  AllowedMethods: []
+  AllowedPatterns: []
+  IncludedMacros: []
+  AllowParenthesesInMultilineCall: false
+  AllowParenthesesInChaining: false
+  AllowParenthesesInCamelCaseMethod: false
+  EnforcedStyle: require_parentheses
+  SupportedStyles:
+    - require_parentheses
+    - omit_parentheses
+
+Style/MethodCallWithoutArgsParentheses:
+  Description: 'Do not use parentheses for method calls with no arguments.'
+  StyleGuide: '#method-invocation-parens'
+  Enabled: true
+  AllowedMethods: []
+  VersionAdded: '0.47'
+  VersionChanged: '0.55'
+
+# A specialized exception class will take one or more arguments and construct the message from it.
+# So both variants make sense.
+Style/RaiseArgs:
+  Enabled: false
+
+  # Fail is an alias of raise. Avoid aliases, it's more cognitive load for no gain.
+# The argument that fail should be used to abort the program is wrong too,
+# there's Kernel#abort for that.
+Style/SignalException:
+  EnforcedStyle: only_raise
+
+# do / end blocks should be used for side effects,
+# methods that run a block for side effects and have
+# a useful return value are rare, assign the return
+# value to a local variable for those cases.
+Style/MethodCalledOnDoEndBlock:
+  Enabled: true
+
+  
+# OpenStruct shouldn't be used anymore due to performance
+# degradation on ruby 3.2+
+Style/OpenStructUse:
+  Enabled: true
+
+# Enforcing the names of variables? To single letter ones? Just no.
+Style/SingleLineBlockParams:
+  Enabled: false
+
+# Style preference
+Style/MethodDefParentheses:
+  Enabled: false
+
+# Ignores requirement to add underscore to separate every 3 digits in a number
+Style/NumericLiterals:
+  Enabled: false
+
+# Shadowing outer local variables with block parameters is often useful
+# to not reinvent a new name for the same thing, it highlights the relation
+# between the outer variable and the parameter. The cases where it's actually
+# confusing are rare, and usually bad for other reasons already, for example
+# because the method is too long.
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/Debugger
+# Show linting errors on debugger/binding.pry even in development
+Lint/Debugger:
+  Enabled: true
+
+Lint/AssignmentInCondition:
+  AllowSafeAssignment: false
+
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/NumberConversion
+Lint/NumberConversion:
+  Enabled: false
+
+Naming/BinaryOperatorParameterName:
+  Enabled: false
+
+Lint/ConstantResolution:
+  Enabled: false
+
+
+# Rails
+Rails/SaveBang:
+  Enabled: false
+
+# Temporarily removing until Mongoid is no more...
+# Mongoid #find_by raises an exception if it can't be found, unlike AR #find_by, so .where().first is preferred
+# Rubocop can't tell the difference between the two
+Rails/FindBy:
+  Enabled: false
+  Include:
+    - app/**/*.rb
+
+# not a method in mongoid
+Rails/FindEach:
+  Enabled: false
+
+Rails/PluckId:
+  Enabled: false
+
+Rails/PluckInWhere:
+  Enabled: false
+
+# Disable I18n locale texts cop
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+# RSpec
+
+# Start context description without 'when', 'with', or 'without'.
+RSpec/ContextWording:
+  Enabled: false
+
+RSpec/AlignLeftLetBrace:
+  Enabled: true
+
+RSpec/AlignRightLetBrace:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 5
+
+# Allows us to mark specs as "skip"
+RSpec/Pending:
+  Enabled: false
+
+# Dutchie Custom Cops
+
+# Ensures all LaunchDarkly feature flag calls have default values
+# Supports both Armageddon (DutchieFeatureFlags) and MenuConnector (ld_client.variation) patterns
+Dutchie/LaunchDarklyDefaults:
+  Enabled: true
+  Severity: warning
+  AutoCorrect: true
+
+# Flags questionable usage of safety_assured in migrations
+# The Include directive overrides the global Exclude: db/**/* for this cop only
+Dutchie/MigrationSafetyAssured:
+  Enabled: true
+  Severity: warning
+  Include:
+    - 'db/migrate/**/*.rb'
+    - 'lib/migration_helpers.rb'
+    - 'lib/**/migration_helpers.rb'

data/lib/Dutchie/Style/version.rb

@@ -2,6 +2,7 @@
 
 module Dutchie
   module Style
-    VERSION = '2.0.7'
+    VERSION = "2.1.0"
+    public_constant :VERSION
   end
 end

data/lib/Dutchie/Style.rb

@@ -1,8 +1,19 @@
+# frozen_string_literal: true
+
 require "Dutchie/Style/version"
 
 module Dutchie
   module Style
     class Error < StandardError; end
-    # Your code goes here...
+
+    # Returns the absolute path to the default configuration file
+    def self.config_path
+      File.expand_path("../../config/default.yml", __dir__)
+    end
+
+    # Returns the gem's root directory
+    def self.root
+      File.expand_path("../..", __dir__)
+    end
   end
 end

data/lib/dutchie-style.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+require_relative "Dutchie/Style"
+require_relative "rubocop/cop/dutchie/launchdarkly_defaults"
+require_relative "rubocop/cop/dutchie/migration_safety_assured"

data/lib/rubocop/cop/dutchie/launchdarkly_defaults.rb

@@ -0,0 +1,291 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Dutchie
+      # Ensures all LaunchDarkly feature flag calls have default values
+      # to prevent failures during LaunchDarkly service outages
+      #
+      # This cop supports two LaunchDarkly patterns:
+      # 1. Armageddon pattern: DutchieFeatureFlags.flag(), .context_flag(), etc.
+      # 2. MenuConnector pattern: ld_client.variation(), MenuConnector::App[:launchdarkly].variation()
+      #
+      # @example Armageddon pattern
+      #   # bad
+      #   DutchieFeatureFlags.flag("some.flag")
+      #   DutchieFeatureFlags.context_flag("some.flag", dispensary_id: id)
+      #   DutchieFeatureFlags.on?("some.flag")
+      #
+      #   # good
+      #   DutchieFeatureFlags.flag("some.flag", false)
+      #   DutchieFeatureFlags.context_flag("some.flag", default: false, dispensary_id: id)
+      #   DutchieFeatureFlags.on?("some.flag", default: false)
+      #
+      # @example MenuConnector pattern
+      #   # bad
+      #   ld_client.variation("flag", context)
+      #   MenuConnector::App[:launchdarkly].variation("flag", context)
+      #
+      #   # good
+      #   ld_client.variation("flag", context, false)
+      #   MenuConnector::App[:launchdarkly].variation("flag", context, false)
+      #
+      class LaunchDarklyDefaults < ::RuboCop::Cop::Base
+        extend AutoCorrector
+
+        MSG_FLAG = 'DutchieFeatureFlags.flag must have a default value as 2nd parameter'
+        MSG_CONTEXT_FLAG = 'DutchieFeatureFlags.context_flag must have a default: parameter'
+        MSG_DISPENSARY_FLAG = 'DutchieFeatureFlags.dispensary_flag must have a default: parameter'
+        MSG_ENTERPRISE_FLAG = 'DutchieFeatureFlags.enterprise_flag must have a default: parameter'
+        MSG_ON = 'DutchieFeatureFlags.on? should have a default: parameter'
+        MSG_OFF = 'DutchieFeatureFlags.off? should have a default: parameter'
+        MSG_VARIATION = 'LaunchDarkly variation must have a default value as 3rd parameter'
+
+        # DutchieFeatureFlags.flag("key", default, ...)
+        def_node_matcher :dutchie_flag_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :flag
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.context_flag("key", ...)
+        def_node_matcher :context_flag_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :context_flag
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.dispensary_flag("key", ...)
+        def_node_matcher :dispensary_flag_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :dispensary_flag
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.enterprise_flag("key", ...)
+        def_node_matcher :enterprise_flag_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :enterprise_flag
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.on?("key", ...)
+        def_node_matcher :on_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :on?
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.off?("key", ...)
+        def_node_matcher :off_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :off?
+            $_
+            $...
+          )
+        PATTERN
+
+        # Direct variation calls on ld_client or MenuConnector::App[:launchdarkly]
+        def_node_matcher :variation_call?, <<~PATTERN
+          (send
+            {
+              (send nil? :ld_client)
+              (send
+                (const (const nil? :MenuConnector) :App)
+                :[]
+                (sym :launchdarkly)
+              )
+              (send _ :ld_client)
+            }
+            :variation
+            $_
+            $...
+          )
+        PATTERN
+
+        # MockLaunchDarkly variation calls (for test environments)
+        def_node_matcher :mock_variation_call?, <<~PATTERN
+          (send
+            (const (const nil? :MenuConnector) :MockLaunchDarkly)
+            :variation
+            $_
+            $...
+          )
+        PATTERN
+
+        def on_send(node)
+          # Check Armageddon patterns
+          check_flag_method(node)
+          check_context_flag_method(node)
+          check_dispensary_flag_method(node)
+          check_enterprise_flag_method(node)
+          check_on_method(node)
+          check_off_method(node)
+
+          # Check MenuConnector patterns
+          check_variation_method(node)
+          check_mock_variation_method(node)
+        end
+
+        private
+
+        # Armageddon pattern checks
+
+        def check_flag_method(node)
+          flag_key, *args = dutchie_flag_call?(node)
+          return unless flag_key
+
+          # Need at least one more argument after the key (the default value)
+          return if args.any?
+
+          add_offense(node, message: MSG_FLAG) do |corrector|
+            corrector.insert_after(flag_key, ', false')
+          end
+        end
+
+        def check_context_flag_method(node)
+          flag_key, *args = context_flag_call?(node)
+          return unless flag_key
+
+          return if has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_CONTEXT_FLAG) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        def check_dispensary_flag_method(node)
+          flag_key, *args = dispensary_flag_call?(node)
+          return unless flag_key
+
+          return if has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_DISPENSARY_FLAG) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        def check_enterprise_flag_method(node)
+          flag_key, *args = enterprise_flag_call?(node)
+          return unless flag_key
+
+          return if has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_ENTERPRISE_FLAG) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        def check_on_method(node)
+          flag_key, *args = on_call?(node)
+          return unless flag_key
+
+          # on? accepts default: as keyword or as second positional argument
+          # Return if there's a positional default (non-hash arg) or default: kwarg
+          return if has_positional_default?(args) || has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_ON) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        def check_off_method(node)
+          flag_key, *args = off_call?(node)
+          return unless flag_key
+
+          # off? accepts default: as keyword or as second positional argument
+          # Return if there's a positional default (non-hash arg) or default: kwarg
+          return if has_positional_default?(args) || has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_OFF) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        # MenuConnector pattern checks
+
+        def check_variation_method(node)
+          flag_key, *args = variation_call?(node)
+          return unless flag_key
+
+          # variation(flag, context, default) - need at least 2 args after flag
+          return if args.size >= 2
+
+          add_offense(node, message: MSG_VARIATION) do |corrector|
+            if args.empty?
+              # No context provided, add both context and default
+              corrector.insert_after(flag_key, ', nil, false')
+            elsif args.size == 1
+              # Context provided but no default
+              corrector.insert_after(args.last, ', false')
+            end
+          end
+        end
+
+        def check_mock_variation_method(node)
+          # Don't check mock variation calls in test code
+          return if in_test_file?(node)
+
+          flag_key, *args = mock_variation_call?(node)
+          return unless flag_key
+
+          # Same logic as regular variation
+          return if args.size >= 2
+
+          add_offense(node, message: MSG_VARIATION) do |corrector|
+            if args.empty?
+              corrector.insert_after(flag_key, ', nil, false')
+            elsif args.size == 1
+              corrector.insert_after(args.last, ', false')
+            end
+          end
+        end
+
+        # Helper methods
+
+        def has_default_kwarg?(args)
+          args.any? do |arg|
+            next false unless arg.hash_type?
+
+            arg.pairs.any? do |pair|
+              pair.key.sym_type? && pair.key.value == :default
+            end
+          end
+        end
+
+        def has_positional_default?(args)
+          args.any? { |arg| !arg.hash_type? }
+        end
+
+        def insert_default_kwarg(corrector, flag_key, args)
+          if args.any? && args.last.hash_type?
+            # Add to existing hash
+            corrector.insert_after(args.last.source_range.end.adjust(begin_pos: -1), ', default: false')
+          elsif args.any?
+            # Add as new keyword argument after existing args
+            corrector.insert_after(args.last, ', default: false')
+          else
+            # Add as first argument after flag key
+            corrector.insert_after(flag_key, ', default: false')
+          end
+        end
+
+        def in_test_file?(node)
+          processed_source.file_path.include?('spec/')
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/dutchie/migration_safety_assured.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Dutchie
+      # Flags usage of safety_assured in migrations
+      #
+      # The safety_assured block bypasses strong_migrations safety checks,
+      # which should only be used when you're certain the operation is safe
+      # and have documented why it's necessary.
+      #
+      # @example
+      #   # bad
+      #   def change
+      #     safety_assured do
+      #       remove_column :users, :email
+      #     end
+      #   end
+      #
+      #   # good - avoid safety_assured when possible
+      #   def change
+      #     # Use strong_migrations approved patterns instead
+      #     remove_column :users, :email, type: :string
+      #   end
+      #
+      #   # acceptable - with clear documentation
+      #   def change
+      #     # This operation is safe because:
+      #     # 1. The column was already removed from the model
+      #     # 2. No code references this column anymore
+      #     # 3. We've verified in production logs that no queries use this column
+      #     safety_assured do
+      #       remove_column :users, :deprecated_field
+      #     end
+      #   end
+      #
+      class MigrationSafetyAssured < ::RuboCop::Cop::Base
+        MSG = 'Avoid `safety_assured` in migrations. It bypasses strong_migrations safety checks. ' \
+              'Ensure this operation is truly safe, consider safer alternatives, and document why ' \
+              'safety_assured is necessary.'
+
+        # Matches: safety_assured do...end or safety_assured {...}
+        def_node_matcher :safety_assured_block?, <<~PATTERN
+          (block
+            (send nil? :safety_assured)
+            ...
+          )
+        PATTERN
+
+        def on_block(node)
+          return unless safety_assured_block?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/{default.yml → old-default.yml}

@@ -3,7 +3,7 @@ require:
   - rubocop-rails
 
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 2.7.4
   EnabledByDefault: true
   DisplayCopNames: true
   Exclude:
@@ -21,7 +21,6 @@ AllCops:
     - '*.yml'
     - '.pryrc'
 
-
 # Capybara cops
 
 # Allows us to use scenario/feature instead of it/describes
@@ -80,7 +79,7 @@ Layout/SpaceInsideHashLiteralBraces:
 Metrics/BlockLength:
   Exclude:
     - "spec/factories/**/*.rb"
-  IgnoredMethods: ['describe', 'context']
+  AllowedMethods: ['describe', 'context']
 
 # Too short methods lead to extraction of single-use methods, which can make
 # the code easier to read (by naming things), but can also clutter the class
@@ -175,7 +174,7 @@ Style/MethodCallWithArgsParentheses:
   VersionAdded: '0.47'
   VersionChanged: '0.61'
   IgnoreMacros: true
-  IgnoredMethods: []
+  AllowedMethods: []
   AllowedPatterns: []
   IncludedMacros: []
   AllowParenthesesInMultilineCall: false
@@ -190,7 +189,7 @@ Style/MethodCallWithoutArgsParentheses:
   Description: 'Do not use parentheses for method calls with no arguments.'
   StyleGuide: '#method-invocation-parens'
   Enabled: true
-  IgnoredMethods: []
+  AllowedMethods: []
   VersionAdded: '0.47'
   VersionChanged: '0.55'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: Dutchie-Style
 version: !ruby/object:Gem::Version
-  version: 2.0.7
+  version: 2.1.0
 platform: ruby
 authors:
 - Christopher Ostrowski
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-09-11 00:00:00.000000000 Z
+date: 2026-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,42 +16,84 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.56'
+        version: '1.72'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.56'
+        version: '1.72'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.18'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.18'
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.24'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.24'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.21'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.21'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.24'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.24'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.25'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.25'
 description: Rubocop Settings for all dutchie Ruby Apps
 email:
 - chris@dutchie.com
@@ -65,9 +107,13 @@ files:
 - Gemfile
 - Gemfile.lock
 - README.md
-- default.yml
+- config/default.yml
 - lib/Dutchie/Style.rb
 - lib/Dutchie/Style/version.rb
+- lib/dutchie-style.rb
+- lib/rubocop/cop/dutchie/launchdarkly_defaults.rb
+- lib/rubocop/cop/dutchie/migration_safety_assured.rb
+- old-default.yml
 homepage: https://github.com/GetDutchie/Dutchie-Style
 licenses:
 - MIT
@@ -75,6 +121,7 @@ metadata:
   homepage_uri: https://github.com/GetDutchie/Dutchie-Style
   source_code_uri: https://github.com/GetDutchie/Dutchie-Style
   changelog_uri: https://github.com/GetDutchie/Dutchie-Style/releases
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -83,7 +130,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 3.0.6
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="