Dutchie-Style 1.0.6 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72123335746ee44a301cd242be9a829c8eab52d0f3e9b2eac39c9d6d482f3d50
-  data.tar.gz: 3ffef58d229b152eaa24a231e8c94dc197a241ddd9bd7cae86b489a9f8c6e985
+  metadata.gz: 2979ce72ee0581c527a64720f84203514d2d3f9f68ec96a7e48b0785a3b5574a
+  data.tar.gz: '040977d7c8ecdaf0000a5fe714677365bb8361ec743f26a8682fc1b8f39a7f78'
 SHA512:
-  metadata.gz: 49c2a6528d2e6f3dcaacc1b3dae7f22a60552cfcd385153aea88b06a1e464ff2e6ae11f38f6fe1a23cc3f5192aff27b81c31ac634bb5c9bfdb6fad1255406cec
-  data.tar.gz: 6efb2fb2cdf66e1b2267fa1b4f4bf19c7f331765aa4e533ed98aba3b5f832919c8563a2fd87ad95268d343a77eebbb4f678e0e8cbbff70a934cb08d15a257343
+  metadata.gz: 9d2272007d026c87ea281c4502251e87cd1fc21c238840f5cda86e1a35155b16df1c82763f76b80fee0935b53eaeb6d470767abd46065ad4f37297ab43e86951
+  data.tar.gz: 36c8d0bc49b88c07d86f149966422acf23d17635acd07147a644d9ebc0002bf8a3cdc78576e73ac58b2073759e426a6cd2399cbe2306610c275ac2529510d810

data/Dutchie-Style.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.93.1"
+  spec.add_dependency "rubocop", "~> 1.30.1"
   spec.add_dependency "rubocop-rspec"
   spec.add_dependency "rubocop-rails"
 end

data/Gemfile

@@ -5,5 +5,5 @@ gemspec
 
 gem "rake", "~> 12.0"
 gem "rspec", "~> 3.0"
-gem "rubocop", "~> 0.93.1"
-gem "rubocop-rails", "~> 2.6.0"
+gem "rubocop", "~> 1.30.1"
+gem "rubocop-rails", "~> 2.14.2"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    Dutchie-Style (1.0.4)
+    Dutchie-Style (1.0.10)
       rubocop (~> 0.93.1)
       rubocop-rails
       rubocop-rspec
@@ -57,9 +57,9 @@ GEM
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 0.82.0)
-    rubocop-rspec (1.44.0)
+    rubocop-rspec (1.44.1)
       rubocop (~> 0.87)
-      rubocop-ast (~> 0.7.1)
+      rubocop-ast (>= 0.7.1)
     ruby-progressbar (1.10.1)
     thread_safe (0.3.6)
     tzinfo (1.2.7)
@@ -78,4 +78,4 @@ DEPENDENCIES
   rubocop-rails (~> 2.6.0)
 
 BUNDLED WITH
-   2.1.4
+   2.2.27

data/default.yml

@@ -21,9 +21,27 @@ AllCops:
     - '*.yml'
     - '.pryrc'
 
+
+# Capybara cops
+
+# Allows us to use scenario/feature instead of it/describes
+Capybara/FeatureMethods:
+  Enabled: true
+  EnabledMethods: ['feature', 'scenario']
+
+# https://docs.rubocop.org/rubocop/1.10/cops_layout.html#layoutclassstructure
+Layout/ClassStructure:
+  Enabled: true
+
 # Commonly used screens these days easily fit more than 80 characters.
+# Ignores long lines with Heredocs or URIs in them
 Layout/LineLength:
   Max: 120
+  AllowHeredoc: true
+  # There's a bug which considers commas after a URI too long so we can't use built-in AllowURI setting.
+  # Pattern matches valid URI encapsulated within a string literal.
+  IgnoredPatterns: ['["\u0027].*https?[\w\:\/\$\–\-\#\.\+\!\*\‘\(\)\,]*.*["\u0027]']
+
 
 # No space makes the method definition shorter and differentiates
 # from a regular assignment.
@@ -59,6 +77,8 @@ Layout/SpaceInsideHashLiteralBraces:
 
 # Exclude RSpec
 Metrics/BlockLength:
+  Exclude:
+    - "spec/factories/**/*.rb"
   ExcludedMethods: ['describe', 'context']
 
 # Too short methods lead to extraction of single-use methods, which can make
@@ -134,6 +154,8 @@ Style/FormatString:
 Style/CollectionMethods:
   Enabled: true
   PreferredMethods:
+    # find is not equivalent on mongoid embeds or collections
+    find: "detect"
     # inject seems more common in the community.
     reduce: "inject"
 
@@ -197,6 +219,10 @@ Style/SingleLineBlockParams:
 Style/MethodDefParentheses:
   Enabled: false
 
+# Ignores requirement to add underscore to separate every 3 digits in a number
+Style/NumericLiterals:
+  Enabled: false
+
 # Shadowing outer local variables with block parameters is often useful
 # to not reinvent a new name for the same thing, it highlights the relation
 # between the outer variable and the parameter. The cases where it's actually
@@ -228,14 +254,32 @@ Lint/ConstantResolution:
 Rails/SaveBang:
   Enabled: false
 
+# Temporarily removing until Mongoid is no more...
+# Mongoid #find_by raises an exception if it can't be found, unlike AR #find_by, so .where().first is preferred
+# Rubocop can't tell the difference between the two
 Rails/FindBy:
-  Enabled: true
+  Enabled: false
   Include:
     - app/**/*.rb
 
 # RSpec
+
+# Start context description without 'when', 'with', or 'without'.
+RSpec/ContextWording:
+  Enabled: false
+
 RSpec/AlignLeftLetBrace:
   Enabled: true
 
 RSpec/AlignRightLetBrace:
   Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 5
+
+# Allows us to mark specs as "skip"
+RSpec/Pending:
+  Enabled: false

data/lib/Dutchie/Style/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Dutchie
   module Style
-    VERSION = "1.0.6"
+    VERSION = '2.0.0'
   end
 end

metadata

@@ -1,38 +1,38 @@
 --- !ruby/object:Gem::Specification
 name: Dutchie-Style
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 2.0.0
 platform: ruby
 authors:
 - Christopher Ostrowski
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-11-11 00:00:00.000000000 Z
+date: 2022-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: 1.30.1
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: 1.30.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -40,13 +40,13 @@ dependencies:
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -75,7 +75,7 @@ metadata:
   homepage_uri: https://github.com/GetDutchie/Dutchie-Style
   source_code_uri: https://github.com/GetDutchie/Dutchie-Style
   changelog_uri: https://github.com/GetDutchie/Dutchie-Style/releases
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -90,8 +90,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: Rubocop Settings for all dutchie Ruby Apps
 test_files: []