Dutchie-Style 1.0.3 → 1.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6e8be6da9285da4169240066b62bd6b00ab07e3057ec7074fb45d0ea129ce13
-  data.tar.gz: 92b93fec973c1211aaeb451ea5b03c8af90231266be06ed35f66d390a17661fd
+  metadata.gz: 304c7a57d19f039460011d0d8a47454bfb838f73de6113da8bac3e552ab29f61
+  data.tar.gz: 31ef6fbbacf0d729cc0107d59f86267288f7abc6bc396f31b653da4f044976ae
 SHA512:
-  metadata.gz: 2af0ff46dc142444dd6582e8d80caa4983dc3c202fef12cbd7e72a26ae06aa7748dea0ae6c7c315507efeb7a7b1b9d522dcfb78d85742fa9ded144c3d84f7af4
-  data.tar.gz: cc3fe2666d59a1bd5cea5b9ac20a9269b9f5875975fe3c4cf7f7d7702a39e0100b44bb3437bcbc1d1fd322bf1e279a427d9ed23ef491d76fae0cabde81d701ca
+  metadata.gz: 47f5540ae2e8a454664c8776b702080bee8ceb78507b5d876b1cabaa1ff40f3f357325b2041662d779e38d72e5bb7fc0e07e559911bf3e6d69aa3ef8d0318eae
+  data.tar.gz: cc499085838e10a922164dd1d9596d8f2c978583127d25b3859ee43e68e15237433c4757c7cbf26f67a46e9c4708ab560479d464484fcaf4ade78e595cea60fa

data/Dutchie-Style.gemspec

@@ -26,6 +26,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.86.0"
+  spec.add_dependency "rubocop", "~> 0.93.1"
   spec.add_dependency "rubocop-rspec"
+  spec.add_dependency "rubocop-rails"
 end

data/Gemfile

@@ -5,4 +5,5 @@ gemspec
 
 gem "rake", "~> 12.0"
 gem "rspec", "~> 3.0"
-gem "rubocop", "~> 0.86"
+gem "rubocop", "~> 0.93.1"
+gem "rubocop-rails", "~> 2.6.0"

data/Gemfile.lock

@@ -1,21 +1,33 @@
 PATH
   remote: .
   specs:
-    Dutchie-Style (1.0.2)
-      rubocop (~> 0.86.0)
+    Dutchie-Style (1.0.9)
+      rubocop (~> 0.93.1)
+      rubocop-rails
       rubocop-rspec
 
 GEM
   remote: https://rubygems.org/
   specs:
+    activesupport (6.0.3.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
     ast (2.4.1)
+    concurrent-ruby (1.1.7)
     diff-lcs (1.4.2)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    minitest (5.14.2)
     parallel (1.19.2)
-    parser (2.7.1.4)
+    parser (2.7.2.0)
       ast (~> 2.4.1)
+    rack (2.2.3)
     rainbow (3.0.0)
     rake (12.3.3)
-    regexp_parser (1.7.1)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
@@ -30,21 +42,30 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    rubocop (0.86.0)
+    rubocop (0.93.1)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.0.3, < 1.0)
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.0.3)
-      parser (>= 2.7.0.1)
-    rubocop-rspec (1.38.1)
-      rubocop (>= 0.68.1)
+    rubocop-ast (0.7.1)
+      parser (>= 2.7.1.5)
+    rubocop-rails (2.6.0)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 0.82.0)
+    rubocop-rspec (1.44.1)
+      rubocop (~> 0.87)
+      rubocop-ast (>= 0.7.1)
     ruby-progressbar (1.10.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
     unicode-display_width (1.7.0)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -53,7 +74,8 @@ DEPENDENCIES
   Dutchie-Style!
   rake (~> 12.0)
   rspec (~> 3.0)
-  rubocop (~> 0.86)
+  rubocop (~> 0.93.1)
+  rubocop-rails (~> 2.6.0)
 
 BUNDLED WITH
    2.1.4

data/default.yml

@@ -1,5 +1,6 @@
 require:
   - rubocop-rspec
+  - rubocop-rails
 
 AllCops:
   TargetRubyVersion: 2.6
@@ -20,6 +21,10 @@ AllCops:
     - '*.yml'
     - '.pryrc'
 
+# https://docs.rubocop.org/rubocop/1.10/cops_layout.html#layoutclassstructure
+Layout/ClassStructure:
+  Enabled: true
+
 # Commonly used screens these days easily fit more than 80 characters.
 Layout/LineLength:
   Max: 120
@@ -56,6 +61,10 @@ Layout/SpaceInsideBlockBraces:
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
+# Exclude RSpec
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+
 # Too short methods lead to extraction of single-use methods, which can make
 # the code easier to read (by naming things), but can also clutter the class
 Metrics/MethodLength:
@@ -102,12 +111,15 @@ Style/StringLiterals:
 Style/HashSyntax:
   EnforcedStyle: ruby19_no_mixed_keys
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashEachMethods
 Style/HashEachMethods:
-  Enabled: false
+  Enabled: true
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformKeys
 Style/HashTransformKeys:
   Enabled: false
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformValues
 Style/HashTransformValues:
   Enabled: false
 
@@ -126,6 +138,8 @@ Style/FormatString:
 Style/CollectionMethods:
   Enabled: true
   PreferredMethods:
+    # find is not equivalent on mongoid embeds or collections
+    find: "detect"
     # inject seems more common in the community.
     reduce: "inject"
 
@@ -174,11 +188,6 @@ Style/RaiseArgs:
 Style/SignalException:
   EnforcedStyle: only_raise
 
-# { ... } for multi-line blocks is okay, follow Weirichs rule instead:
-# https://web.archive.org/web/20140221124509/http://onestepback.org/index.cgi/Tech/Ruby/BraceVsDoEnd.rdoc
-Style/BlockDelimiters:
-  Enabled: false
-
 # do / end blocks should be used for side effects,
 # methods that run a block for side effects and have
 # a useful return value are rare, assign the return
@@ -202,10 +211,10 @@ Style/MethodDefParentheses:
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
-# There are valid cases, for example debugging Cucumber steps,
-# also they'll fail CI anyway
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/Debugger
+# Show linting errors on debugger/binding.pry even in development
 Lint/Debugger:
-  Enabled: false
+  Enabled: true
 
 Lint/AssignmentInCondition:
   AllowSafeAssignment: false
@@ -218,4 +227,30 @@ Naming/BinaryOperatorParameterName:
   Enabled: false
 
 Lint/ConstantResolution:
-  Enabled: false
+  Enabled: false
+
+
+# Rails
+Rails/SaveBang:
+  Enabled: false
+
+# Temporarily removing until Mongoid is no more...
+# Mongoid #find_by raises an exception if it can't be found, unlike AR #find_by, so .where().first is preferred
+# Rubocop can't tell the difference between the two
+Rails/FindBy:
+  Enabled: false
+  Include:
+    - app/**/*.rb
+
+# RSpec
+RSpec/AlignLeftLetBrace:
+  Enabled: true
+
+RSpec/AlignRightLetBrace:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 10
+
+RSpec/NestedGroups:
+  Max: 5

data/lib/Dutchie/Style/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Dutchie
   module Style
-    VERSION = "1.0.3"
+    VERSION = '1.0.9'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: Dutchie-Style
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.9
 platform: ruby
 authors:
 - Christopher Ostrowski
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-08-19 00:00:00.000000000 Z
+date: 2021-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.86.0
+        version: 0.93.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.86.0
+        version: 0.93.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rubocop Settings for all dutchie Ruby Apps
 email:
 - chris@dutchie.com
@@ -61,7 +75,7 @@ metadata:
   homepage_uri: https://github.com/GetDutchie/Dutchie-Style
   source_code_uri: https://github.com/GetDutchie/Dutchie-Style
   changelog_uri: https://github.com/GetDutchie/Dutchie-Style/releases
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -76,8 +90,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Rubocop Settings for all dutchie Ruby Apps
 test_files: []