Dutchie-Style 1.0.2 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 066526e708d8f2a893f5ea9cd80e3f604561ecceff470388428d28d1aa3ec840
-  data.tar.gz: b9f4d64f67af501279d8e0256b89b42ce485ff6a117a46fc0e1fd9b76a2402c5
+  metadata.gz: c69dc43615ecb7c6ff2ed0227adf72aad4624335a4eac8bd05fbd26a77115e88
+  data.tar.gz: 3ccac1ce08f3b92cf1c6a849861a640e06571a9bda9ef75aae289e18547828ab
 SHA512:
-  metadata.gz: feb63624398019cf3f98a2f098a1ec4f3a5b2a879c5bd479fcbfb437aa98ae25285a96ba5cf883a65606db9d634b7296085800fcd292af55b2d2eef672430489
-  data.tar.gz: e48233617b83933614c6e5ce7d9a171a2c866ac9e21ea2db913f8aa13beba52514d42593b7197102a14c304c013d55f551cce7f2448baffb6a547bbbb8c7329c
+  metadata.gz: f8624992de693b1f7ac48151b31ea299b63d3655414c9e24e8a15549153d47dbbb6c07bb22ae5deab5e1521c60a49f6583af6ab9fae3750e53087ddd93ad57f1
+  data.tar.gz: 5b1ea31e288124fe8f7dd7b679a18c063c804d82c22f494bb9339bf45081cb0a37119d721aa3955e8519b6c9c1832fd8381da3c3b259b81b972cbd6fd3e39502

data/.gitignore

@@ -19,12 +19,10 @@ yarn-error.log
 
 # Ignore master key for decrypting credentials and more.
 /config/master.key
-
 .env
 
 # Emacs droppings
 *~
-
 *.gem
 
 # Mac OS noise

data/Dutchie-Style.gemspec

@@ -26,5 +26,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.86.0"
+  spec.add_dependency "rubocop", "~> 0.93.1"
+  spec.add_dependency "rubocop-rspec"
+  spec.add_dependency "rubocop-rails"
 end

data/Gemfile

@@ -5,4 +5,5 @@ gemspec
 
 gem "rake", "~> 12.0"
 gem "rspec", "~> 3.0"
-gem "rubocop", "~> 0.86"
+gem "rubocop", "~> 0.93.1"
+gem "rubocop-rails", "~> 2.6.0"

data/Gemfile.lock

@@ -1,20 +1,33 @@
 PATH
   remote: .
   specs:
-    Dutchie-Style (1.0.1)
-      rubocop (~> 0.86.0)
+    Dutchie-Style (1.0.4)
+      rubocop (~> 0.93.1)
+      rubocop-rails
+      rubocop-rspec
 
 GEM
   remote: https://rubygems.org/
   specs:
+    activesupport (6.0.3.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
     ast (2.4.1)
+    concurrent-ruby (1.1.7)
     diff-lcs (1.4.2)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    minitest (5.14.2)
     parallel (1.19.2)
-    parser (2.7.1.4)
+    parser (2.7.2.0)
       ast (~> 2.4.1)
+    rack (2.2.3)
     rainbow (3.0.0)
     rake (12.3.3)
-    regexp_parser (1.7.1)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
@@ -29,19 +42,30 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    rubocop (0.86.0)
+    rubocop (0.93.1)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.0.3, < 1.0)
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.0.3)
-      parser (>= 2.7.0.1)
+    rubocop-ast (0.7.1)
+      parser (>= 2.7.1.5)
+    rubocop-rails (2.6.0)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 0.82.0)
+    rubocop-rspec (1.44.0)
+      rubocop (~> 0.87)
+      rubocop-ast (~> 0.7.1)
     ruby-progressbar (1.10.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
     unicode-display_width (1.7.0)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -50,7 +74,8 @@ DEPENDENCIES
   Dutchie-Style!
   rake (~> 12.0)
   rspec (~> 3.0)
-  rubocop (~> 0.86)
+  rubocop (~> 0.93.1)
+  rubocop-rails (~> 2.6.0)
 
 BUNDLED WITH
    2.1.4

data/README.md

@@ -13,5 +13,6 @@ It is available as a rubygem as well as an NPM package.
 Includes:
 
 * RuboCop Config
+* RuboCop Rspec Config
 * Eslint Config
 * Prettier Config

data/default.yml

@@ -1,3 +1,7 @@
+require:
+  - rubocop-rspec
+  - rubocop-rails
+
 AllCops:
   TargetRubyVersion: 2.6
   EnabledByDefault: true
@@ -8,7 +12,6 @@ AllCops:
     - 'vendor/**/*'
     - 'config/**/*'
     - 'docs/**/*'
-    - 'spec/**/*'
     - 'app/channels/**/*'
     - 'script/**/*'
     - 'lib/assets/**/*'
@@ -54,6 +57,10 @@ Layout/SpaceInsideBlockBraces:
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
+# Exclude RSpec
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+
 # Too short methods lead to extraction of single-use methods, which can make
 # the code easier to read (by naming things), but can also clutter the class
 Metrics/MethodLength:
@@ -100,12 +107,15 @@ Style/StringLiterals:
 Style/HashSyntax:
   EnforcedStyle: ruby19_no_mixed_keys
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashEachMethods
 Style/HashEachMethods:
-  Enabled: false
+  Enabled: true
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformKeys
 Style/HashTransformKeys:
   Enabled: false
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformValues
 Style/HashTransformValues:
   Enabled: false
 
@@ -172,11 +182,6 @@ Style/RaiseArgs:
 Style/SignalException:
   EnforcedStyle: only_raise
 
-# { ... } for multi-line blocks is okay, follow Weirichs rule instead:
-# https://web.archive.org/web/20140221124509/http://onestepback.org/index.cgi/Tech/Ruby/BraceVsDoEnd.rdoc
-Style/BlockDelimiters:
-  Enabled: false
-
 # do / end blocks should be used for side effects,
 # methods that run a block for side effects and have
 # a useful return value are rare, assign the return
@@ -200,10 +205,10 @@ Style/MethodDefParentheses:
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
-# There are valid cases, for example debugging Cucumber steps,
-# also they'll fail CI anyway
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/Debugger
+# Show linting errors on debugger/binding.pry even in development
 Lint/Debugger:
-  Enabled: false
+  Enabled: true
 
 Lint/AssignmentInCondition:
   AllowSafeAssignment: false
@@ -216,4 +221,30 @@ Naming/BinaryOperatorParameterName:
   Enabled: false
 
 Lint/ConstantResolution:
-  Enabled: false
+  Enabled: false
+
+
+# Rails
+Rails/SaveBang:
+  Enabled: false
+
+# Temporarily removing until Mongoid is no more...
+# Mongoid #find_by raises an exception if it can't be found, unlike AR #find_by, so .where().first is preferred
+# Rubocop can't tell the difference between the two
+Rails/FindBy:
+  Enabled: false
+  Include:
+    - app/**/*.rb
+
+# RSpec
+RSpec/AlignLeftLetBrace:
+  Enabled: true
+
+RSpec/AlignRightLetBrace:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 10
+
+RSpec/NestedGroups:
+  Max: 5

data/lib/Dutchie/Style/version.rb

@@ -1,5 +1,5 @@
 module Dutchie
   module Style
-    VERSION = "1.0.2"
+    VERSION = "1.0.7"
   end
 end

metadata

@@ -1,29 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: Dutchie-Style
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.7
 platform: ruby
 authors:
 - Christopher Ostrowski
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-29 00:00:00.000000000 Z
+date: 2020-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
+  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.86.0
+        version: 0.93.1
   type: :runtime
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.86.0
+        version: 0.93.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  prerelease: false
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  prerelease: false
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rubocop Settings for all dutchie Ruby Apps
 email:
 - chris@dutchie.com