Dutchie-Style 1.0.1 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11ddb54b3aa7cb2c824cee5c85bd5a119b4a6ed8b4525976d17698889daf8518
-  data.tar.gz: 5db89e8b089059cde2ff7a4c5167e76a51b52268021903214f9ac37c0dc2cb54
+  metadata.gz: 72123335746ee44a301cd242be9a829c8eab52d0f3e9b2eac39c9d6d482f3d50
+  data.tar.gz: 3ffef58d229b152eaa24a231e8c94dc197a241ddd9bd7cae86b489a9f8c6e985
 SHA512:
-  metadata.gz: bb675f7ea0a6a6f46967309efe9b575f6a0474f0496976f4ed179b03b9729273ae500d05004223f93e2a1510f38f8df7ceb5c163a95b213a72cf4f785831acbd
-  data.tar.gz: bb05c8601b8ae30941ee33e48b0bf928a1bd7871d0de38c2d6a27169776b08194f8b430624ae3ba0ee85445c2d06cc98dfcc9c2f69e0a7c00bc066ef5e0e621a
+  metadata.gz: 49c2a6528d2e6f3dcaacc1b3dae7f22a60552cfcd385153aea88b06a1e464ff2e6ae11f38f6fe1a23cc3f5192aff27b81c31ac634bb5c9bfdb6fad1255406cec
+  data.tar.gz: 6efb2fb2cdf66e1b2267fa1b4f4bf19c7f331765aa4e533ed98aba3b5f832919c8563a2fd87ad95268d343a77eebbb4f678e0e8cbbff70a934cb08d15a257343

data/.gitignore

@@ -19,12 +19,10 @@ yarn-error.log
 
 # Ignore master key for decrypting credentials and more.
 /config/master.key
-
 .env
 
 # Emacs droppings
 *~
-
 *.gem
 
 # Mac OS noise

data/Dutchie-Style.gemspec

@@ -6,6 +6,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Christopher Ostrowski"]
   spec.email         = ["chris@dutchie.com"]
 
+  spec.license = 'MIT'
+
   spec.summary       = %q{Rubocop Settings for all dutchie Ruby Apps}
   spec.description   = %q{Rubocop Settings for all dutchie Ruby Apps}
   spec.homepage      = "https://github.com/GetDutchie/Dutchie-Style"
@@ -24,5 +26,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.86.0"
+  spec.add_dependency "rubocop", "~> 0.93.1"
+  spec.add_dependency "rubocop-rspec"
+  spec.add_dependency "rubocop-rails"
 end

data/Gemfile

@@ -5,4 +5,5 @@ gemspec
 
 gem "rake", "~> 12.0"
 gem "rspec", "~> 3.0"
-gem "rubocop", "~> 0.86"
+gem "rubocop", "~> 0.93.1"
+gem "rubocop-rails", "~> 2.6.0"

data/Gemfile.lock

@@ -1,20 +1,33 @@
 PATH
   remote: .
   specs:
-    Dutchie-Style (1.0.1)
-      rubocop (~> 0.86.0)
+    Dutchie-Style (1.0.4)
+      rubocop (~> 0.93.1)
+      rubocop-rails
+      rubocop-rspec
 
 GEM
   remote: https://rubygems.org/
   specs:
+    activesupport (6.0.3.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
     ast (2.4.1)
+    concurrent-ruby (1.1.7)
     diff-lcs (1.4.2)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    minitest (5.14.2)
     parallel (1.19.2)
-    parser (2.7.1.4)
+    parser (2.7.2.0)
       ast (~> 2.4.1)
+    rack (2.2.3)
     rainbow (3.0.0)
     rake (12.3.3)
-    regexp_parser (1.7.1)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
@@ -29,19 +42,30 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    rubocop (0.86.0)
+    rubocop (0.93.1)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.0.3, < 1.0)
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.0.3)
-      parser (>= 2.7.0.1)
+    rubocop-ast (0.7.1)
+      parser (>= 2.7.1.5)
+    rubocop-rails (2.6.0)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 0.82.0)
+    rubocop-rspec (1.44.0)
+      rubocop (~> 0.87)
+      rubocop-ast (~> 0.7.1)
     ruby-progressbar (1.10.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
     unicode-display_width (1.7.0)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -50,7 +74,8 @@ DEPENDENCIES
   Dutchie-Style!
   rake (~> 12.0)
   rspec (~> 3.0)
-  rubocop (~> 0.86)
+  rubocop (~> 0.93.1)
+  rubocop-rails (~> 2.6.0)
 
 BUNDLED WITH
    2.1.4

data/README.md

@@ -13,5 +13,6 @@ It is available as a rubygem as well as an NPM package.
 Includes:
 
 * RuboCop Config
+* RuboCop Rspec Config
 * Eslint Config
 * Prettier Config

data/default.yml

@@ -1,3 +1,7 @@
+require:
+  - rubocop-rspec
+  - rubocop-rails
+
 AllCops:
   TargetRubyVersion: 2.6
   EnabledByDefault: true
@@ -8,7 +12,6 @@ AllCops:
     - 'vendor/**/*'
     - 'config/**/*'
     - 'docs/**/*'
-    - 'spec/**/*'
     - 'app/channels/**/*'
     - 'script/**/*'
     - 'lib/assets/**/*'
@@ -54,6 +57,10 @@ Layout/SpaceInsideBlockBraces:
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
+# Exclude RSpec
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+
 # Too short methods lead to extraction of single-use methods, which can make
 # the code easier to read (by naming things), but can also clutter the class
 Metrics/MethodLength:
@@ -100,12 +107,15 @@ Style/StringLiterals:
 Style/HashSyntax:
   EnforcedStyle: ruby19_no_mixed_keys
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashEachMethods
 Style/HashEachMethods:
-  Enabled: false
+  Enabled: true
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformKeys
 Style/HashTransformKeys:
   Enabled: false
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformValues
 Style/HashTransformValues:
   Enabled: false
 
@@ -172,11 +182,6 @@ Style/RaiseArgs:
 Style/SignalException:
   EnforcedStyle: only_raise
 
-# { ... } for multi-line blocks is okay, follow Weirichs rule instead:
-# https://web.archive.org/web/20140221124509/http://onestepback.org/index.cgi/Tech/Ruby/BraceVsDoEnd.rdoc
-Style/BlockDelimiters:
-  Enabled: false
-
 # do / end blocks should be used for side effects,
 # methods that run a block for side effects and have
 # a useful return value are rare, assign the return
@@ -200,10 +205,10 @@ Style/MethodDefParentheses:
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
-# There are valid cases, for example debugging Cucumber steps,
-# also they'll fail CI anyway
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/Debugger
+# Show linting errors on debugger/binding.pry even in development
 Lint/Debugger:
-  Enabled: false
+  Enabled: true
 
 Lint/AssignmentInCondition:
   AllowSafeAssignment: false
@@ -212,6 +217,25 @@ Lint/AssignmentInCondition:
 Lint/NumberConversion:
   Enabled: false
 
-# This is just silly. Calling the argument `other` in all cases makes no sense.
 Naming/BinaryOperatorParameterName:
-  Enabled: false
+  Enabled: false
+
+Lint/ConstantResolution:
+  Enabled: false
+
+
+# Rails
+Rails/SaveBang:
+  Enabled: false
+
+Rails/FindBy:
+  Enabled: true
+  Include:
+    - app/**/*.rb
+
+# RSpec
+RSpec/AlignLeftLetBrace:
+  Enabled: true
+
+RSpec/AlignRightLetBrace:
+  Enabled: false

data/lib/Dutchie/Style/version.rb

@@ -1,5 +1,5 @@
 module Dutchie
   module Style
-    VERSION = "1.0.1"
+    VERSION = "1.0.6"
   end
 end

metadata

@@ -1,29 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: Dutchie-Style
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.6
 platform: ruby
 authors:
 - Christopher Ostrowski
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-24 00:00:00.000000000 Z
+date: 2020-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
+  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.86.0
+        version: 0.93.1
   type: :runtime
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.86.0
+        version: 0.93.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  prerelease: false
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  prerelease: false
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rubocop Settings for all dutchie Ruby Apps
 email:
 - chris@dutchie.com
@@ -41,7 +69,8 @@ files:
 - lib/Dutchie/Style.rb
 - lib/Dutchie/Style/version.rb
 homepage: https://github.com/GetDutchie/Dutchie-Style
-licenses: []
+licenses:
+- MIT
 metadata:
   homepage_uri: https://github.com/GetDutchie/Dutchie-Style
   source_code_uri: https://github.com/GetDutchie/Dutchie-Style