Dutchie-Style 1.0.0 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6b2a358d911c4029b29bca907108565f063310fdbafb8943d2e26280ae6f244
-  data.tar.gz: 4b4773a79dc3816ec0b91ea449843ac8318718e727aabcff1d6c4727e9bc40c0
+  metadata.gz: c9bf9825ba4ba0d6fa99e628e3ed84a735a8db714e820c5388758519d211fa1a
+  data.tar.gz: e7b222b019334fd7077589761fdf1aed7f93833fce5bd76a6c7aed50a8637eac
 SHA512:
-  metadata.gz: 1af2412d988306af579894d663732726d86e5569702e06321266fbea13b59bf1c3970d6700e7c82c44e564f01800ac251ee18db45c4514cef6bfc1e3d4ce1194
-  data.tar.gz: da5b2893cfb5b3b555313606eedabb48f932b861435d8425f778355e121fe0540616bc57a90db7ec843a9073c07b4cafc13eb17e93e66761d30f5529afe91c9c
+  metadata.gz: a17c05f6343d77102a8ae400129e6429d450ec04e428c9166e9f68dacc5fc731a6a3b61750b5d9568684feed166301eefd5ca600d5e5484b5c93eb35ab71a7f4
+  data.tar.gz: 0f3f2d8d3d221841420dfbeac66ce89fa935ec5bde86cb735bc7e04f7c0b851ba650f62e39786917d70b57da256431441d5aaa2c30b81b4279e145640dde72ff

data/.gitignore

@@ -19,11 +19,11 @@ yarn-error.log
 
 # Ignore master key for decrypting credentials and more.
 /config/master.key
-
 .env
 
 # Emacs droppings
 *~
+*.gem
 
 # Mac OS noise
 .DS_Store

data/Dutchie-Style.gemspec

@@ -6,6 +6,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Christopher Ostrowski"]
   spec.email         = ["chris@dutchie.com"]
 
+  spec.license = 'MIT'
+
   spec.summary       = %q{Rubocop Settings for all dutchie Ruby Apps}
   spec.description   = %q{Rubocop Settings for all dutchie Ruby Apps}
   spec.homepage      = "https://github.com/GetDutchie/Dutchie-Style"
@@ -24,5 +26,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.80.0"
+  spec.add_dependency "rubocop", "~> 0.93.1"
+  spec.add_dependency "rubocop-rspec"
+  spec.add_dependency "rubocop-rails"
 end

data/Gemfile

@@ -5,4 +5,5 @@ gemspec
 
 gem "rake", "~> 12.0"
 gem "rspec", "~> 3.0"
-gem "rubocop", "~> 0.80"
+gem "rubocop", "~> 0.93.1"
+gem "rubocop-rails", "~> 2.6.0"

data/Gemfile.lock

@@ -0,0 +1,81 @@
+PATH
+  remote: .
+  specs:
+    Dutchie-Style (1.0.4)
+      rubocop (~> 0.93.1)
+      rubocop-rails
+      rubocop-rspec
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (6.0.3.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    ast (2.4.1)
+    concurrent-ruby (1.1.7)
+    diff-lcs (1.4.2)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    minitest (5.14.2)
+    parallel (1.19.2)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
+    rack (2.2.3)
+    rainbow (3.0.0)
+    rake (12.3.3)
+    regexp_parser (1.8.2)
+    rexml (3.2.4)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rubocop (0.93.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.1.5)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8)
+      rexml
+      rubocop-ast (>= 0.6.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.7.1)
+      parser (>= 2.7.1.5)
+    rubocop-rails (2.6.0)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 0.82.0)
+    rubocop-rspec (1.44.0)
+      rubocop (~> 0.87)
+      rubocop-ast (~> 0.7.1)
+    ruby-progressbar (1.10.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.7.0)
+    zeitwerk (2.4.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  Dutchie-Style!
+  rake (~> 12.0)
+  rspec (~> 3.0)
+  rubocop (~> 0.93.1)
+  rubocop-rails (~> 2.6.0)
+
+BUNDLED WITH
+   2.1.4

data/README.md

@@ -13,5 +13,6 @@ It is available as a rubygem as well as an NPM package.
 Includes:
 
 * RuboCop Config
+* RuboCop Rspec Config
 * Eslint Config
 * Prettier Config

data/default.yml

@@ -1,3 +1,7 @@
+require:
+  - rubocop-rspec
+  - rubocop-rails
+
 AllCops:
   TargetRubyVersion: 2.6
   EnabledByDefault: true
@@ -8,7 +12,6 @@ AllCops:
     - 'vendor/**/*'
     - 'config/**/*'
     - 'docs/**/*'
-    - 'spec/**/*'
     - 'app/channels/**/*'
     - 'script/**/*'
     - 'lib/assets/**/*'
@@ -54,6 +57,10 @@ Layout/SpaceInsideBlockBraces:
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
+# Exclude RSpec
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+
 # Too short methods lead to extraction of single-use methods, which can make
 # the code easier to read (by naming things), but can also clutter the class
 Metrics/MethodLength:
@@ -100,12 +107,15 @@ Style/StringLiterals:
 Style/HashSyntax:
   EnforcedStyle: ruby19_no_mixed_keys
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashEachMethods
 Style/HashEachMethods:
-  Enabled: false
+  Enabled: true
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformKeys
 Style/HashTransformKeys:
   Enabled: false
 
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformValues
 Style/HashTransformValues:
   Enabled: false
 
@@ -200,10 +210,10 @@ Style/MethodDefParentheses:
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
-# There are valid cases, for example debugging Cucumber steps,
-# also they'll fail CI anyway
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/Debugger
+# Show linting errors on debugger/binding.pry even in development
 Lint/Debugger:
-  Enabled: false
+  Enabled: true
 
 Lint/AssignmentInCondition:
   AllowSafeAssignment: false
@@ -212,6 +222,25 @@ Lint/AssignmentInCondition:
 Lint/NumberConversion:
   Enabled: false
 
-# This is just silly. Calling the argument `other` in all cases makes no sense.
 Naming/BinaryOperatorParameterName:
-  Enabled: false
+  Enabled: false
+
+Lint/ConstantResolution:
+  Enabled: false
+
+
+# Rails
+Rails/SaveBang:
+  Enabled: false
+
+Rails/FindBy:
+  Enabled: true
+  Include:
+    - app/**/*.rb
+
+# RSpec
+RSpec/AlignLeftLetBrace:
+  Enabled: true
+
+RSpec/AlignRightLetBrace:
+  Enabled: false

data/lib/Dutchie/Style/version.rb

@@ -1,5 +1,5 @@
 module Dutchie
   module Style
-    VERSION = "1.0.0"
+    VERSION = "1.0.5"
   end
 end

metadata

@@ -1,29 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: Dutchie-Style
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.5
 platform: ruby
 authors:
 - Christopher Ostrowski
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-24 00:00:00.000000000 Z
+date: 2020-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
+  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.80.0
+        version: 0.93.1
   type: :runtime
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.80.0
+        version: 0.93.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  prerelease: false
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  prerelease: false
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rubocop Settings for all dutchie Ruby Apps
 email:
 - chris@dutchie.com
@@ -35,12 +63,14 @@ files:
 - ".gitignore"
 - Dutchie-Style.gemspec
 - Gemfile
+- Gemfile.lock
 - README.md
 - default.yml
 - lib/Dutchie/Style.rb
 - lib/Dutchie/Style/version.rb
 homepage: https://github.com/GetDutchie/Dutchie-Style
-licenses: []
+licenses:
+- MIT
 metadata:
   homepage_uri: https://github.com/GetDutchie/Dutchie-Style
   source_code_uri: https://github.com/GetDutchie/Dutchie-Style