Avatax_AddressService 1.0.10 → 1.0.11

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZDE0YjRhNzgxMDVmY2M2MDQ1YTRmYjdhOTFhZTMzNjM0ODdlZTAwYw==
+    YjllZjY5OTY0NGE2OGM3ZGM5ZDI1ZmQ4MDVkOTc2NjI2NzZjZTU1MQ==
   data.tar.gz: !binary |-
-    ZjkyYmJjYjc0YjJlYzVjMzAwMmEwNjZjMmIxNzZmYTYyNDQ0YjczYg==
+    NTIyYzQzYjIwYmI4NTI5MmY0NjY4MzRiNGU3NjU5MTE5YmZjYjU1YQ==
 SHA512:
   metadata.gz: !binary |-
-    ZWI4NjkyOGFkMzJjMGNmYmJjNWVhYjVkMmE3ZjBhNDRhZmRjZjM0MjI3OTA0
-    MDFkNmYwYzVkNDc5MGYzZTczM2Y2YmE4MjJjM2FlYmQ0NWVjMWUwYjU0MjBl
-    MGUyOGUzYmU3ZjNiMzY3NzE2MWFlZmY0MWU3MWNjZjRhYWFjM2I=
+    ZDZiZjFiODAyMTU0YzFmOWZkYTY0NzUyOTM0MTM1MWYzMzFhMDc2Zjg3YmVm
+    N2RiMzk4MGEzNGExNmNiY2I1NmJmOWI5NmYxZTdmYTIxNDg5OTJhNjU0MzQ0
+    MzQwOWZmNTcyMWI1YzUyYmMxZTg1YjQxY2Q4YzgwNTM3MjM3OWU=
   data.tar.gz: !binary |-
-    NmUzODk2NWE3NWYwOGNiYTU4MGMyNmNhNTVhMWFmYTdlYzU1NTVkMzU5OGNl
-    NmY1MTkwNDNlMGY1NDNmNmQxMWRhODM0YWIzZjdiYmNhMmQwYjc5ZTQ5ZWM1
-    NjlhNTY2OWMwMTFlMzVhYjdlMzAzN2ZmZTg0ZWJkOGM1MjA1YTk=
+    ODczZTE5NDY5NTAzMDgwNjg5MGE5ZTU3YTBkZTE2YmYzMjliNGI3NzJjYzQ5
+    MzdhZWMwNGE5ZWIyMzhiMjJhOTAwMjZiNDg4YzQ5MjU0NjRlZjJhYjc2ZTVm
+    MWU1N2I2MjNhZTVmYjE2MjJhYThiOTgyNzVkZDFiYmY4MjcyYmE=

data/Avatax_AddressService.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "Avatax_AddressService"
-  s.version = "1.0.10"
+  s.version = "1.0.11"
   s.date = "2012-12-16"
   s.author = "Graham S Wilson"
   s.email = "support@Avalara.com"

data/lib/avatax_addressservice.rb

@@ -91,9 +91,8 @@ module AvaTax
         @response = @client.call(:ping, xml: @soap).to_hash
 
       #Strip off outer layer of the hash - not needed
-      @response = @response[:ping_response][:ping_result]
+      return messages_to_array(@response[:ping_response][:ping_result])
 
-      return @response
       
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -126,10 +125,8 @@ module AvaTax
         @response = @client.call(:validate, xml: @soap).to_hash
 
       #Strip off outer layer of the hash - not needed
-      @response = @response[:validate_response][:validate_result]
-      
-      #Return data to calling program
-      return @response
+      return messages_to_array(@response[:validate_response][:validate_result])
+
       
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -155,9 +152,7 @@ module AvaTax
         @response = @client.call(:is_authorized, xml: @soap).to_hash
 
       #Strip off outer layer of the hash - not needed
-      @response = @response[:is_authorized_response][:is_authorized_result]
-      
-      return @response
+      return messages_to_array(@response[:is_authorized_response][:is_authorized_result])
       
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -176,7 +171,30 @@ module AvaTax
       @response[:result_code] = 'Error'
       @response[:summary] = @response[:fault][:faultcode]
       @response[:details] = @response[:fault][:faultstring]   
-      return @response
+      return messages_to_array(@response)
+    end
+    
+    ############################################################################################################
+    #standardizes error message format to an array of messages - nokogiri will collapse a single element array into the response hash.
+    ############################################################################################################
+    def messages_to_array(response)
+      if not response[:messages].nil? 
+        return response
+      end
+      # add the messages array to the response - if we got here, there was only one error.
+      response[:messages] = [{
+        :summary => response[:summary],
+        :details => response[:details],
+        :helplink => response[:helplink],
+        :refersto => response[:refersto],
+        :severity => response[:severity],
+        :source => response[:source]
+        }]
+      #remove all the error information from the hash  
+      response[:messages][0].each do |k,v|
+        response.delete(k)
+      end  
+      return response
     end
   end
 end

data/samples/credentials.yml

@@ -1,4 +1,4 @@
-username: username
+username: username 
 password: password
 clientname: AvaTaxCalcSOAP Ruby Sample
 production: false

data/spec/isauthorized_spec.rb

@@ -23,7 +23,7 @@ describe "IsAuthorized" do
     it "error when username is missing" do
       @creds[:username] = nil
       @service = AvaTax::AddressService.new(@creds)
-      @service.isauthorized[:result_code].should eql "Error"
+      @service.isauthorized[:result_code].should eql "Error"     
     end
     it "error when password is omitted" do
       @creds[:password] = nil
@@ -46,7 +46,9 @@ describe "IsAuthorized" do
       @creds[:password] = nil
       @service = AvaTax::AddressService.new(@creds)
       @result = @service.isauthorized
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::AddressService.new(@creds)

data/spec/ping_spec.rb

@@ -46,7 +46,9 @@ describe "Ping" do
       @creds[:password] = nil
       @service = AvaTax::AddressService.new(@creds)
       @result = @service.ping
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::AddressService.new(@creds)

data/spec/validate_spec.rb

@@ -60,7 +60,9 @@ describe "Validate" do
       @creds[:password] = nil
       @service = AvaTax::AddressService.new(@creds)
       @result = @service.validate(@address_req)
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @result = @svc.validate(@address_req)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: Avatax_AddressService
 version: !ruby/object:Gem::Version
-  version: 1.0.10
+  version: 1.0.11
 platform: ruby
 authors:
 - Graham S Wilson