ADB 0.5.1 → 0.5.2

data/ChangeLog

@@ -1,5 +1,9 @@
-=== Release 0.5.1
-* Bug Fixes
+=== Release 0.5.2 / 2012-9-18
+* Fixes
+  * Corrected install when path has space
+
+=== Release 0.5.1 / 2012-9-11
+* Fixes
   * Corrected filename for stdout and stderr so it will work properly on Windows
 
 === Release 0.5 / 2012-9-9
@@ -11,7 +15,7 @@
   * Added ability to pass options to the install command
 
 === Release 0.3 / 2012-8-22
-* Bug Fixes
+* Fixes
   * DateTime adjustment bug on Linux
   * Add wait-for-device for install on Linux
 

data/lib/ADB.rb

@@ -94,7 +94,7 @@ module ADB
   # seconds.
   #
   def install(installable, options=nil, target={}, timeout=30)
-    execute_adb_with(timeout, "#{which_one(target)} wait-for-device install #{options} #{installable}")
+    execute_adb_with_exactly(timeout, *"#{which_one(target)} wait-for-device install #{options}".split, installable)
     raise ADBError, "Could not install #{installable}" unless stdout_contains "Success"
   end
 
@@ -204,7 +204,11 @@ module ADB
 
   def execute_adb_with(timeout, arguments)
     args = arguments.split
-    process = ChildProcess.build('adb', *args)
+    execute_adb_with_exactly timeout, *args
+  end
+
+  def execute_adb_with_exactly(timeout, *arguments)
+    process = ChildProcess.build('adb', *arguments)
     process.io.stdout, process.io.stderr = std_out_err
     process.start
     kill_if_longer_than(process, timeout)

data/lib/ADB/version.rb

@@ -1,3 +1,3 @@
 module ADB
-  VERSION = "0.5.1"
+  VERSION = "0.5.2"
 end

data/spec/lib/ADB_spec.rb

@@ -133,6 +133,12 @@ describe ADB do
       ADB.install 'Test.apk'
     end
 
+    it "should be able to install an application with spaces in the path" do
+      ADB.should_receive(:last_stdout).and_return("Success")
+      should_call_adb_with('wait-for-device', 'install', 'Test Path With Spaces.apk')
+      ADB.install 'Test Path With Spaces.apk'
+    end
+
     it "should install to the only connected device" do
       ADB.should_receive(:last_stdout).and_return("Success")
       should_call_adb_with('-d', 'wait-for-device', 'install', 'Test.apk')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ADB
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-11 00:00:00.000000000 Z
+date: 2012-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -104,7 +104,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3370634203742753858
+      hash: -4396733677998798054
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -113,7 +113,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3370634203742753858
+      hash: -4396733677998798054
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24