7digital 0.0.5 → 0.0.6

data/spec/model/api_response_spec.rb

@@ -1,112 +1,49 @@
-require File.expand_path('../../spec_helper', __FILE__)
-require 'time'
-
-describe "ApiResponse" do
-
-  it "should be ok if error code is 0 and content is not empty" do
-
-    response = Sevendigital::ApiResponse.new
-    response.error_code = 0
-    response.content = '<xml></xml>'
-    response.ok?.should == true
-
-  end
-
-  it "should not be ok if error code is not 0" do
-
-    response = Sevendigital::ApiResponse.new
-    response.error_code = 5
-    response.content = '<xml></xml>'
-    response.ok?.should == false
-
-    end
-
-  it "should not be ok if response content is nil" do
-
-    response = Sevendigital::ApiResponse.new
-    response.error_code = 0
-    response.ok?.should == false
-
-  end
-
-  it "should be serializable" do
-    original_response = Sevendigital::ApiResponseDigestor.new(@client).from_xml\
-      ("<response status='ok'><testElement id='123'>value</testElement></response>")
-    original_response.error_code = 99
-    original_response.headers = {"header" => "value"}
-
-
-    tmp = Marshal.dump(original_response)
-    restored_response = Marshal.load(tmp)
-
-    restored_response.error_code.should == original_response.error_code
-    restored_response.content.to_s.should == original_response.content.to_s
-    restored_response.content.test_element.value.should == "value"
-    restored_response.headers.should == original_response.headers
-
-  end
-
-  it "should be out of date if it's past its cache max age" do
-    now = Time.now.utc
-    yesterday = now - 24*60*60
-    max_age = 12*60*60
-
-    response = Sevendigital::ApiResponse.new
-    response.headers = {"cache-control" => "private, max-age=#{max_age}", "Date" => yesterday.httpdate}
-
-    response.out_of_date?(now).should == true
-
-  end
-
-  it "should be out of date if it's past its cache max age" do
-    now = Time.now.utc
-    yesterday = now - 24*60*60
-    max_age = 12*60*60
-
-    response = Sevendigital::ApiResponse.new
-    response.headers = {"cache-control" => "private, max-age=#{max_age}", "Date" => yesterday.httpdate}
-
-    response.out_of_date?(now).should == true
-
-  end
-
-  it "should not be out of date if it's within its cache max age" do
-    now = Time.now.utc
-    yesterday = now - 24*60*60
-    max_age = 48*60*60
-  #  stub_time(now)
-
-    response = Sevendigital::ApiResponse.new
-    response.headers = {"cache-control" => "private, max-age=#{max_age}", "Date" => yesterday.httpdate}
-
-    response.out_of_date?(now).should == false
-
-  end
-
-  it "should be out of date if it is missing caching headers" do
-
-    response = Sevendigital::ApiResponse.new
-    response.out_of_date?(Time.now.utc).should == true
-
-    response.headers = {"Date" => Time.now.utc.httpdate}
-    response.out_of_date?(Time.now.utc).should == true
-
-  end
-
-  it "should be out of date if no max-age has been specified" do
-
-    response = Sevendigital::ApiResponse.new
-    response.headers = {"cache-control" => "no-cache", "Date" => Time.now.utc.httpdate}
-    response.out_of_date?(Time.now.utc).should == true
-
-  end
-
-  it "should be out of date if it is missing Date header" do
-
-    response = Sevendigital::ApiResponse.new
-    response.headers = {"cache-control" => "private, max-age=#{2**30}"}
-    response.out_of_date?(Time.now.utc).should == true
-   
-  end
-
+require File.expand_path('../../spec_helper', __FILE__)
+require 'time'
+
+describe "ApiResponse" do
+
+  it "should be ok if error code is 0 and content is not empty" do
+
+    response = Sevendigital::ApiResponse.new
+    response.error_code = 0
+    response.content = '<xml></xml>'
+    response.ok?.should == true
+
+  end
+
+  it "should not be ok if error code is not 0" do
+
+    response = Sevendigital::ApiResponse.new
+    response.error_code = 5
+    response.content = '<xml></xml>'
+    response.ok?.should == false
+
+    end
+
+  it "should not be ok if response content is nil" do
+
+    response = Sevendigital::ApiResponse.new
+    response.error_code = 0
+    response.ok?.should == false
+
+  end
+
+  it "should be serializable" do
+    original_response = Sevendigital::ApiResponseDigestor.new(@client).from_xml\
+      ("<response status='ok'><testElement id='123'>value</testElement></response>")
+    original_response.error_code = 99
+    original_response.headers = {"header" => "value"}
+
+
+    tmp = Marshal.dump(original_response)
+    restored_response = Marshal.load(tmp)
+
+    restored_response.error_code.should == original_response.error_code
+    restored_response.content.to_s.should == original_response.content.to_s
+    restored_response.content.test_element.value.should == "value"
+    restored_response.headers.should == original_response.headers
+
+  end
+
 end

data/spec/model/artist_spec.rb

@@ -1,142 +1,155 @@
-require "date"
-require File.expand_path('../../spec_helper', __FILE__)
-
-describe "Artist" do
-
-  before do
-    @client = stub(Sevendigital::Client)
-    @artist_manager = mock(Sevendigital::ArtistManager)
-    @client.stub!(:artist).and_return @artist_manager
-    
-    @artist = Sevendigital::Artist.new(@client)
-    @artist.id = 1234
-  end
-
-  it "get_details should get artist's basic details from manager" do
-    expected_options = {:page => 2}
-    fresh_artist = fake_artist_with_details
-
-    @artist_manager.should_receive(:get_details) { |artist_id, options|
-      artist_id.should == @artist.id
-      (options.keys & expected_options.keys).should == expected_options.keys
-      fresh_artist
-    }
-    @artist.get_details(expected_options)
-    
-    @artist.sort_name.should == fresh_artist.sort_name
-    @artist.image.should == fresh_artist.image
-    @artist.url.should == fresh_artist.url
-   
-  end
-
-  it "get_releases should get releases from manager" do
-    expected_options = {:page => 2}
-   
-    @artist_manager.should_receive(:get_releases) { |artist_id, options|
-      artist_id.should == @artist.id
-      (options.keys & expected_options.keys).should == expected_options.keys
-      fake_release_list
-    }
-    @artist.get_releases(expected_options)
-
-  end
-
-   it "get_top_tracks should get tracks from manager" do
-    expected_options = {:page => 2}
-   
-    @artist_manager.should_receive(:get_top_tracks) { |artist_id, options|
-      artist_id.should == @artist.id
-      (options.keys & expected_options.keys).should == expected_options.keys
-      fake_track_list
-    }
-    @artist.get_top_tracks(expected_options)
-
-  end
-
-   it "get_similar should get similar artists from manager" do
-    expected_options = {:page => 2}
-
-    @artist_manager.should_receive(:get_similar) { |artist_id, options|
-      artist_id.should == @artist.id
-      (options.keys & expected_options.keys).should == expected_options.keys
-      fake_artist_list
-    }
-    @artist.get_similar(expected_options)
-
-   end
-
-  it "should be a various artist if name contains various" do
-
-    @artist.name = "various"
-    @artist.various?.should == true
-
-  end
-
-  it "should be a various artist if appears as contains various" do
-
-    @artist.name = "mr"
-    @artist.appears_as = "mr various"
-    @artist.various?.should == true
-
-  end
-
-  it "should be a various artist if resembles various artist" do
-
-    @artist.name = "v.a."
-    @artist.various?.should == true
-    @artist.name = "vario"
-    @artist.various?.should == true
-    @artist.name = "vaious"
-    @artist.various?.should == true
-    @artist.name = "varios"
-    @artist.various?.should == true
-    @artist.name = "aaaa"
-    @artist.various?.should == false
-    @artist.name = "vaious"
-    @artist.various?.should == true
-    @artist.name = "varoius"
-    @artist.various?.should == true
-    @artist.name = "variuos"
-    @artist.various?.should == true
-
-  end
-
-  it "should not be a various artist if it doesn't resemble various artist" do
-
-    @artist.name = "mr small"
-    @artist.appears_as = "mr big"
-    @artist.various?.should == false
-
-  end
-
-
-
-  def fake_track_list
-    tracks = Array.new
-    tracks << Sevendigital::Track.new(@client)
-    tracks << Sevendigital::Track.new(@client)
-    tracks
-  end
-
-  def fake_release_list
-    releases = Array.new
-    releases << Sevendigital::Release.new(@client)
-    releases << Sevendigital::Release.new(@client)
-    releases
-  end
-
-  def fake_artist_list
-    artists = Array.new
-    artists << Sevendigital::Artist.new(@client)
-    artists << Sevendigital::Artist.new(@client)
-    artists
-  end
-
-  def fake_artist_with_details
-    artist = Sevendigital::Artist.new(@client)
-    artist.sort_name = "The, The"
-    artist.image = "image"
-    artist.url = "url"
-    artist
-end
+require "date"
+require File.expand_path('../../spec_helper', __FILE__)
+
+describe "Artist" do
+
+  before do
+    @client = stub(Sevendigital::Client)
+    @artist_manager = mock(Sevendigital::ArtistManager)
+    @client.stub!(:artist).and_return @artist_manager
+    
+    @artist = Sevendigital::Artist.new(@client)
+    @artist.id = 1234
+  end
+
+  it "get_details should get artist's basic details from manager" do
+    expected_options = {:page => 2}
+    fresh_artist = fake_artist_with_details
+
+    @artist_manager.should_receive(:get_details) { |artist_id, options|
+      artist_id.should == @artist.id
+      (options.keys & expected_options.keys).should == expected_options.keys
+      fresh_artist
+    }
+    @artist.get_details(expected_options)
+    
+    @artist.sort_name.should == fresh_artist.sort_name
+    @artist.image.should == fresh_artist.image
+    @artist.url.should == fresh_artist.url
+   
+  end
+
+  it "get_releases should get releases from manager" do
+    expected_options = {:page => 2}
+   
+    @artist_manager.should_receive(:get_releases) { |artist_id, options|
+      artist_id.should == @artist.id
+      (options.keys & expected_options.keys).should == expected_options.keys
+      fake_release_list
+    }
+    @artist.get_releases(expected_options)
+
+  end
+
+   it "get_top_tracks should get tracks from manager" do
+    expected_options = {:page => 2}
+   
+    @artist_manager.should_receive(:get_top_tracks) { |artist_id, options|
+      artist_id.should == @artist.id
+      (options.keys & expected_options.keys).should == expected_options.keys
+      fake_track_list
+    }
+    @artist.get_top_tracks(expected_options)
+
+  end
+
+   it "get_similar should get similar artists from manager" do
+    expected_options = {:page => 2}
+
+    @artist_manager.should_receive(:get_similar) { |artist_id, options|
+      artist_id.should == @artist.id
+      (options.keys & expected_options.keys).should == expected_options.keys
+      fake_artist_list
+    }
+    @artist.get_similar(expected_options)
+
+   end
+
+  it "get_tags should get tags from manager" do
+    expected_options = {:page => 2}
+
+    @artist_manager.should_receive(:get_tags) { |artist_id, options|
+      artist_id.should == @artist.id
+      (options.keys & expected_options.keys).should == expected_options.keys
+      []
+    }
+    @artist.get_tags(expected_options)
+
+  end
+
+
+  it "should be a various artist if name contains various" do
+
+    @artist.name = "various"
+    @artist.various?.should == true
+
+  end
+
+  it "should be a various artist if appears as contains various" do
+
+    @artist.name = "mr"
+    @artist.appears_as = "mr various"
+    @artist.various?.should == true
+
+  end
+
+  it "should be a various artist if resembles various artist" do
+
+    @artist.name = "v.a."
+    @artist.various?.should == true
+    @artist.name = "vario"
+    @artist.various?.should == true
+    @artist.name = "vaious"
+    @artist.various?.should == true
+    @artist.name = "varios"
+    @artist.various?.should == true
+    @artist.name = "aaaa"
+    @artist.various?.should == false
+    @artist.name = "vaious"
+    @artist.various?.should == true
+    @artist.name = "varoius"
+    @artist.various?.should == true
+    @artist.name = "variuos"
+    @artist.various?.should == true
+
+  end
+
+  it "should not be a various artist if it doesn't resemble various artist" do
+
+    @artist.name = "mr small"
+    @artist.appears_as = "mr big"
+    @artist.various?.should == false
+
+  end
+
+
+
+  def fake_track_list
+    tracks = Array.new
+    tracks << Sevendigital::Track.new(@client)
+    tracks << Sevendigital::Track.new(@client)
+    tracks
+  end
+
+  def fake_release_list
+    releases = Array.new
+    releases << Sevendigital::Release.new(@client)
+    releases << Sevendigital::Release.new(@client)
+    releases
+  end
+
+  def fake_artist_list
+    artists = Array.new
+    artists << Sevendigital::Artist.new(@client)
+    artists << Sevendigital::Artist.new(@client)
+    artists
+  end
+
+  def fake_artist_with_details
+    artist = Sevendigital::Artist.new(@client)
+    artist.sort_name = "The, The"
+    artist.image = "image"
+    artist.url = "url"
+    artist
+end
 end