7digital 0.0.1 → 0.0.2

data/spec/data/config/sevendigital.yml

@@ -1,5 +1,5 @@
-common:
-  api_url: test-yml-rails-common.7digital.com
-
-development:
-  api_url: test-yml-development.7digital.com
+common:
+  api_url: test-yml-rails-common.7digital.com
+
+development:
+  api_url: test-yml-development.7digital.com

data/spec/data/configuration_env_override.yml

@@ -1,5 +1,5 @@
-common:
-  api_url: test-yml-common.7digital.com
-
-development:
-  api_url: test-yml-development.7digital.com
+common:
+  api_url: test-yml-common.7digital.com
+
+development:
+  api_url: test-yml-development.7digital.com

data/spec/digestion_tract/api_response_digestor_spec.rb

@@ -1,74 +1,78 @@
-require 'spec'
-require File.join(File.dirname(__FILE__), %w[../spec_helper])
-
-
-describe "ApiResponseDigestor" do
-
-  before do
-    @api_response_digestor = Sevendigital::ApiResponseDigestor.new(nil)
-  end
-
-  it "should create a response with body from http ok response" do
-
-    stub_http_response = stub(Net::HTTPSuccess)
-    stub_http_response.stub!(:is_a?).with(Net::HTTPSuccess).and_return(true)
-    stub_http_response.stub!(:body).and_return('<response status="ok"></response>')
-
-    response =  @api_response_digestor.from_http_response(stub_http_response)
-    response.error_code.should == 0
-  end
-
-  it "should create an error response from http non-ok response" do
-    expected_message = 'Authorisation failed'
-    expected_error_code = 401
-
-    stub_http_response = stub(Net::HTTPSuccess)
-    stub_http_response.stub!(:is_a?).with(Net::HTTPSuccess).and_return(false)
-    stub_http_response.stub!(:code).and_return(expected_error_code.to_s)
-    stub_http_response.stub!(:body).and_return(expected_message)
-
-    response =  @api_response_digestor.from_http_response(stub_http_response)
-    response.error_code.should == 401
-    response.error_message.should == expected_message
-
-  end
-
-
-
-  it "should create a response with body from xml ok response" do
-
-    xml_response = <<XML
-    <response status="ok"><test></test></response>
-XML
-    response = @api_response_digestor.from_xml(xml_response)
-    response.error_code.should == 0
-    response.content.test.should_not == nil
-    response.content.nothing.should == nil
-  end
-
-
-  it "should create a response with error details from xml error response" do
-
-    xml_response = '<response status="error"><error code="1000"><errorMessage>expected error message</errorMessage></error></response>'
-    response = @api_response_digestor.from_xml(xml_response)
-    response.error_code.should == 1000
-    response.error_message.should == 'expected error message'
-  end
-
-  it "should create a response with error details from invalid xml response" do
-
-    xml_response = '<wrongresponse status="ok"><test /></wrongresponse>'
-    response = @api_response_digestor.from_xml(xml_response)
-    response.error_code.should == 10000
-    response.error_message.should == 'Invalid 7digital API response'
-  end
-
-    it "should create a response with error details from valid xml response with invalid status" do
-
-    xml_response = '<response status="unkown"><test></test></response>'
-    response = @api_response_digestor.from_xml(xml_response)
-    response.error_code.should == 10000
-    response.error_message.should == 'Invalid 7digital API response'
-  end
-
-end
+require File.join(File.dirname(__FILE__), %w[../spec_helper])
+
+describe "ApiResponseDigestor" do
+
+  before do
+    @api_response_digestor = Sevendigital::ApiResponseDigestor.new(nil)
+  end
+
+  it "should create a response with body from http ok response" do
+
+    stub_http_response = stub(Net::HTTPSuccess)
+    stub_http_response.stub!(:is_a?).with(Net::HTTPSuccess).and_return(true)
+    stub_http_response.stub!(:body).and_return('<response status="ok"></response>')
+
+    response =  @api_response_digestor.from_http_response(stub_http_response)
+    response.error_code.should == 0
+  end
+
+  it "should create an error response from http non-ok response" do
+    expected_message = 'Authorisation failed'
+    expected_error_code = 401
+
+    stub_http_response = stub(Net::HTTPSuccess)
+    stub_http_response.stub!(:is_a?).with(Net::HTTPSuccess).and_return(false)
+    stub_http_response.stub!(:code).and_return(expected_error_code.to_s)
+    stub_http_response.stub!(:body).and_return(expected_message)
+
+    response =  @api_response_digestor.from_http_response(stub_http_response)
+    response.error_code.should == 401
+    response.error_message.should == expected_message
+
+  end
+
+
+
+  it "should create a response with body from xml ok response" do
+
+    xml_response = <<XML
+    <response status="ok"><test>aaa</test></response>
+XML
+    response = @api_response_digestor.from_xml(xml_response)
+    response.error_code.should == 0
+    response.content.test.should_not == nil
+    response.content.nothing.should == nil
+  end
+
+
+  it "should create a response with error details from xml error response" do
+
+    xml_response = '<response status="error"><error code="1000"><errorMessage>expected error message</errorMessage></error></response>'
+    response = @api_response_digestor.from_xml(xml_response)
+    response.error_code.should == 1000
+    response.error_message.should == 'expected error message'
+  end
+
+  it "should create a response with error details from invalid xml response" do
+
+    xml_response = '<wrongresponse status="ok"><test /></wrongresponse>'
+    response = @api_response_digestor.from_xml(xml_response)
+    response.error_code.should == 10000
+    response.error_message.should == 'Invalid 7digital API response'
+
+    xml_response = '<response><test /></response>'
+    response = @api_response_digestor.from_xml(xml_response)
+    response.error_code.should == 10000
+    response.error_message.should == 'Invalid 7digital API response'
+  end
+
+
+    it "should create a response with error details from valid xml response with invalid status" do
+
+    xml_response = '<response status="unkown"><test></test></response>'
+    response = @api_response_digestor.from_xml(xml_response)
+    response.error_code.should == 10000
+    response.error_message.should == 'Invalid 7digital API response'
+  end
+
+end

data/spec/digestion_tract/artist_digestor_spec.rb

@@ -1,83 +1,82 @@
-require "spec"
-require "sevendigital"
-
-describe "ArtistDigestor" do
-
-  before do
-    @artist_digestor = Sevendigital::ArtistDigestor.new(Sevendigital::Client.new(nil))
-  end
-
- it "should not digest from invalid xml but throw up (exception)" do
-
-    xml_response = <<XML
-    <release id="123">
-      <name>expected artist name</name>
-    </release>
-XML
-
-    running {@artist_digestor.from_xml(xml_response)}.should raise_error Sevendigital::DigestiveProblem
-
-  end
-
-  it "should digest artist xml and populate minimum available properties" do
-
-    xml_response = <<XML
-    <artist id="123">
-      <name>expected artist name</name>
-    </artist>
-XML
-
-    artist = @artist_digestor.from_xml(xml_response)
-    artist.id.should == 123
-    artist.name.should == "expected artist name"
-  end
-
-   it "should digest artist xml and populate all available properties" do
-
-    xml_response = load_sample_object_xml("artist")
-
-    artist = @artist_digestor.from_xml(xml_response)
-    artist.id.should == 123
-    artist.name.should == "The Expected Artist"
-    artist.sort_name.should == "Expected Artist, The"
-    artist.appears_as.should == "The E.A."
-    artist.image.should == "http://somewhere.com/tea.jpg"
-    artist.url.should == "http://7digital.com/artists/tea?partner=1"
-   end
-
-    it "should digest xml containing list of artists and return a paginated array" do
-
-    xml_response = load_sample_object_xml("artist_list")
-
-    artists = @artist_digestor.list_from_xml(xml_response, :artists)
-    artists[0].id.should == 14
-    artists[1].id.should == 20
-    artists[2].id.should == 106
-    artists.size.should == 3
-    artists.total_entries.should == 26
-
-  end
-
-  it "should digest xml containing empty list of releases and return an empty paginated array" do
-
-    xml_response = load_sample_object_xml("artist_list_empty")
-
-    artists = @artist_digestor.list_from_xml(xml_response, :artists)
-    artists.size.should == 0
-    artists.total_entries.should == 0
-
-  end
-
-   it "should not digest list from invalid xml but throw up (exception)" do
-
-    xml_response = <<XML
-    <release id="123">
-      <name>expected artist name</name>
-    </release>
-XML
-
-    running {@artist_digestor.list_from_xml(xml_response)}.should raise_error Sevendigital::DigestiveProblem
-
-  end
-
+require File.join(File.dirname(__FILE__), %w[../spec_helper])
+
+describe "ArtistDigestor" do
+
+  before do
+    @artist_digestor = Sevendigital::ArtistDigestor.new(Sevendigital::Client.new(nil))
+  end
+
+ it "should not digest from invalid xml but throw up (exception)" do
+
+    xml_response = <<XML
+    <release id="123">
+      <name>expected artist name</name>
+    </release>
+XML
+
+    running {@artist_digestor.from_xml(xml_response)}.should raise_error Sevendigital::DigestiveProblem
+
+  end
+
+  it "should digest artist xml and populate minimum available properties" do
+
+    xml_response = <<XML
+    <artist id="123">
+      <name>expected artist name</name>
+    </artist>
+XML
+
+    artist = @artist_digestor.from_xml(xml_response)
+    artist.id.should == 123
+    artist.name.should == "expected artist name"
+  end
+
+   it "should digest artist xml and populate all available properties" do
+
+    xml_response = load_sample_object_xml("artist")
+
+    artist = @artist_digestor.from_xml(xml_response)
+    artist.id.should == 123
+    artist.name.should == "The Expected Artist"
+    artist.sort_name.should == "Expected Artist, The"
+    artist.appears_as.should == "The E.A."
+    artist.image.should == "http://somewhere.com/tea.jpg"
+    artist.url.should == "http://7digital.com/artists/tea?partner=1"
+   end
+
+    it "should digest xml containing list of artists and return a paginated array" do
+
+    xml_response = load_sample_object_xml("artist_list")
+
+    artists = @artist_digestor.list_from_xml(xml_response, :artists)
+    artists[0].id.should == 14
+    artists[1].id.should == 20
+    artists[2].id.should == 106
+    artists.size.should == 3
+    artists.total_entries.should == 26
+
+  end
+
+  it "should digest xml containing empty list of releases and return an empty paginated array" do
+
+    xml_response = load_sample_object_xml("artist_list_empty")
+
+    artists = @artist_digestor.list_from_xml(xml_response, :artists)
+    artists.size.should == 0
+    artists.total_entries.should == 0
+
+  end
+
+   it "should not digest list from invalid xml but throw up (exception)" do
+
+    xml_response = <<XML
+    <release id="123">
+      <name>expected artist name</name>
+    </release>
+XML
+
+    running {@artist_digestor.list_from_xml(xml_response)}.should raise_error Sevendigital::DigestiveProblem
+
+  end
+
 end

data/spec/digestion_tract/chart_digestor_spec.rb

@@ -1,54 +1,53 @@
-require "spec"
-require "sevendigital"
-
-describe "ChartItemDigestor" do
-
-  before do
-    @chart_item_digestor = Sevendigital::ChartItemDigestor.new(Sevendigital::Client.new(nil))
-  end
-
-  it "should not digest from invalid xml but throw up (exception)" do
-
-    xml_response = <<XML
-    <release id="123">
-      <name>expected artist name</name>
-    </release>
-XML
-
-    running {@chart_item_digestor.from_xml(xml_response)}.should raise_error Sevendigital::DigestiveProblem
-  end
-
-  it "should digest artist chart item" do
-    xml_response = load_sample_object_xml("artist_chart_item")
-
-    chart_item = @chart_item_digestor.from_xml(xml_response)
-    chart_item.position.should == 2
-    chart_item.change.should == :up
-    chart_item.item.id.should == 33154
-    chart_item.item.class.should == Sevendigital::Artist
-  end
-
-  
-  it "should digest release chart item" do
-    xml_response = load_sample_object_xml("release_chart_item")
-
-    chart_item = @chart_item_digestor.from_xml(xml_response)
-    chart_item.position.should == 1
-    chart_item.change.should == :up
-    chart_item.item.id.should == 932151
-    chart_item.item.class.should == Sevendigital::Release
-    end
-
-  it "should digest track chart item" do
-
-    xml_response = load_sample_object_xml("track_chart_item")
-
-    chart_item = @chart_item_digestor.from_xml(xml_response)
-    chart_item.position.should == 99
-    chart_item.change.should == :down
-    chart_item.item.id.should == 2825304
-    chart_item.item.class.should == Sevendigital::Track
-  end
-
-
+require File.join(File.dirname(__FILE__), %w[../spec_helper])
+
+describe "ChartItemDigestor" do
+
+  before do
+    @chart_item_digestor = Sevendigital::ChartItemDigestor.new(Sevendigital::Client.new(nil))
+  end
+
+  it "should not digest from invalid xml but throw up (exception)" do
+
+    xml_response = <<XML
+    <release id="123">
+      <name>expected artist name</name>
+    </release>
+XML
+
+    running {@chart_item_digestor.from_xml(xml_response)}.should raise_error Sevendigital::DigestiveProblem
+  end
+
+  it "should digest artist chart item" do
+    xml_response = load_sample_object_xml("artist_chart_item")
+
+    chart_item = @chart_item_digestor.from_xml(xml_response)
+    chart_item.position.should == 2
+    chart_item.change.should == :up
+    chart_item.item.id.should == 33154
+    chart_item.item.class.should == Sevendigital::Artist
+  end
+
+  
+  it "should digest release chart item" do
+    xml_response = load_sample_object_xml("release_chart_item")
+
+    chart_item = @chart_item_digestor.from_xml(xml_response)
+    chart_item.position.should == 1
+    chart_item.change.should == :up
+    chart_item.item.id.should == 932151
+    chart_item.item.class.should == Sevendigital::Release
+    end
+
+  it "should digest track chart item" do
+
+    xml_response = load_sample_object_xml("track_chart_item")
+
+    chart_item = @chart_item_digestor.from_xml(xml_response)
+    chart_item.position.should == 99
+    chart_item.change.should == :down
+    chart_item.item.id.should == 2825304
+    chart_item.item.class.should == Sevendigital::Track
+  end
+
+
 end

data/spec/digestion_tract/format_digestor_spec.rb

@@ -1,40 +1,39 @@
-require "spec"
-require "sevendigital"
-
-describe "FormatDigestor" do
-
-  before do
-     @format_digestor = Sevendigital::FormatDigestor.new(nil)
-  end
-
-  it "should not digest from invalid xml but throw up (exception)" do
-
-    xml_response = <<XML
-<zzz id="17">
-	<fileFormat>MP3</fileFormat>
-	<bitRate>320</bitRate>
-	<drmFree>True</drmFree>
-</zzz>
-XML
-
-    running {@format_digestor.from_xml(xml_response)}.should raise_error Sevendigital::DigestiveProblem
-  end
-
-  it "should parse from xml and populate all properties" do
-
-    xml_response = <<XML
-<format id="17">
-	<fileFormat>MP3</fileFormat>
-	<bitRate>320</bitRate>
-	<drmFree>True</drmFree>
-</format>
-XML
-
-    format = @format_digestor.from_xml(xml_response)
-    format.id.should == 17
-    format.file_format.should == :MP3
-    format.bit_rate.should == 320
-    format.drm_free.should == true
-  end
-
+require File.join(File.dirname(__FILE__), %w[../spec_helper])
+
+describe "FormatDigestor" do
+
+  before do
+     @format_digestor = Sevendigital::FormatDigestor.new(nil)
+  end
+
+  it "should not digest from invalid xml but throw up (exception)" do
+
+    xml_response = <<XML
+<zzz id="17">
+	<fileFormat>MP3</fileFormat>
+	<bitRate>320</bitRate>
+	<drmFree>True</drmFree>
+</zzz>
+XML
+
+    running {@format_digestor.from_xml(xml_response)}.should raise_error Sevendigital::DigestiveProblem
+  end
+
+  it "should parse from xml and populate all properties" do
+
+    xml_response = <<XML
+<format id="17">
+	<fileFormat>MP3</fileFormat>
+	<bitRate>320</bitRate>
+	<drmFree>True</drmFree>
+</format>
+XML
+
+    format = @format_digestor.from_xml(xml_response)
+    format.id.should == 17
+    format.file_format.should == :MP3
+    format.bit_rate.should == 320
+    format.drm_free.should == true
+  end
+
 end