xtrack 0.98.10__tar.gz → 0.98.11__tar.gz

{xtrack-0.98.10/xtrack.egg-info → xtrack-0.98.11}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: xtrack
-Version: 0.98.10
+Version: 0.98.11
 Summary: Tracking library for particle accelerators
 Author: G. Iadarola et al.
 License-Expression: Apache-2.0

{xtrack-0.98.10 → xtrack-0.98.11}/tests/test_elements.py

@@ -1349,3 +1349,33 @@ def test_beam_element_shifts_backwards_compatible():
     assert sext.shift_x == legacy_dict['_shift_x']
     assert sext.shift_y == legacy_dict['_shift_y']
     assert sext.shift_s == legacy_dict['_shift_s']
+
+def test_cavity_lag_taper():
+
+    env = xt.Environment()
+
+    line = env.new_line(components=[
+        env.new('cav', xt.Cavity, frequency=400e6, voltage=16e6),
+    ])
+    p0 = xt.Particles(p0c=450e9)
+
+    p1 = p0.copy()
+    line.track(p1)
+    xo.assert_allclose(p1.delta, 0, atol=1e-10)
+
+    env['cav'].lag = 60
+    p2 = p0.copy()
+    line.track(p2)
+    assert p2.delta != 0
+
+    env['cav'].lag_taper = -60
+    p3 = p0.copy()
+    line.track(p3)
+    # lag_taper should be ignored because radiation is off
+    xo.assert_allclose(p3.delta, p2.delta, atol=1e-10)
+
+    line.configure_radiation(model='mean')
+    p4 = p0.copy()
+    line.track(p4)
+    # lag_taper should be applied now
+    xo.assert_allclose(p4.delta, 0, atol=1e-10)

xtrack-0.98.11/xtrack/_version.py

@@ -0,0 +1 @@
+__version__ = '0.98.11'

{xtrack-0.98.10 → xtrack-0.98.11}/xtrack/beam_elements/elements.py

@@ -840,7 +840,12 @@ class CrabCavity(_HasModelRF, _HasIntegrator, BeamElement):
 
 
 class XYShift(BeamElement):
-    '''Beam element modeling an transverse shift of the reference system.
+    '''
+    Beam element modeling an transverse shift of the reference system, by applying
+    the following transformation to the particle coordinates:
+
+        x_new = x_old - dx
+        y_new = y_old - dy
 
     Parameters
     ----------
@@ -985,9 +990,12 @@ class Wire(BeamElement):
 
 
 class SRotation(BeamElement):
-    """Beam element modeling a rotation of the reference system around the s-axis.
-    Positive angle is defined as x to y, i.e. counter-clockwise when looking
-    from the end of the s-axis towards the origin.
+    """
+    Beam element modeling a rotation of the reference system around the s-axis.
+    The sign convention is such that:
+
+            px_out = px_in * cos(angle) - py_in * sin(angle)
+
 
     Parameters
     ----------
@@ -1053,9 +1061,11 @@ class SRotation(BeamElement):
 
 
 class XRotation(BeamElement):
-    """Beam element modeling a rotation of the reference system around the x-axis.
-    Positive angle is defined as y to s, i.e. counter-clockwise when looking
-    from the end of the x-axis towards the origin.
+    """
+    Beam element modeling a rotation of the reference system around the x-axis.
+    The sign convention is such that:
+
+          py_out = py_in * cos(angle) + pz_in * sin(angle)
 
     Parameters
     ----------
@@ -1142,9 +1152,11 @@ class XRotation(BeamElement):
 
 
 class YRotation(BeamElement):
-    """Beam element modeling a rotation of the reference system around the y-axis.
-    Positive angle is defined as s to x, i.e. counter-clockwise when looking
-    from the end of the y-axis towards the origin.
+    """
+    Beam element modeling a rotation of the reference system around the y-axis.
+    The sign convention is such that:
+
+            px_out = px_in * cos(angle) - pz_in * sin(angle)
 
     Parameters
     ----------
@@ -1182,8 +1194,6 @@ class YRotation(BeamElement):
         calculate the missing values from the others. If more than necessary
         parameters are given, their consistency will be checked.
         """
-        #Note MAD-X node_value('other_bv ') is ignored
-        #     minus sign follows MAD-X convention
 
         if '_xobject' in kwargs and kwargs['_xobject'] is not None:
             self.xoinitialize(**kwargs)
@@ -1591,11 +1601,12 @@ class _BendCommon(_HasKnlKsl, _HasIntegrator, _HasModelCurved):
         self._length = value
         if self.length != 0:
             self._h = self.angle / self.length
-            if self.k0_from_h:
-                self._k0 = self.h
         else:
             self._h = 0.0
 
+        if self.k0_from_h:
+            self._k0 = self.h
+
     @property
     def h(self):
         return self._h

{xtrack-0.98.10 → xtrack-0.98.11}/xtrack/beam_elements/elements_src/track_magnet_kick.h

@@ -87,7 +87,7 @@ void track_magnet_kick_single_particle(
         double const hl = h * length * kick_weight + hxl * kick_weight;
         dpx += hl * (1. + LocalParticle_get_delta(part));
         double const rv0v = 1./LocalParticle_get_rvv(part);
-        dzeta += -rv0v * chi * hl * x;
+        dzeta += -rv0v * hl * x;
     }
 
     double htot = h;

{xtrack-0.98.10 → xtrack-0.98.11}/xtrack/beam_elements/elements_src/track_rf.h

@@ -340,6 +340,10 @@ void track_rf_particles(
     double body_length;
     double factor_knl_ksl_body;
 
+    #ifndef XTRACK_MULTIPOLE_NO_SYNRAD
+        lag += lag_taper;
+    #endif
+
     if (LocalParticle_check_track_flag(part0, XS_FLAG_BACKTRACK)) {
         body_length = -length;
         factor_knl_ksl_body = -factor_knl_ksl;
@@ -405,7 +409,7 @@ void track_rf_particles(
                 body_length * weight,
                 voltage * weight,
                 frequency,
-                lag + lag_taper,
+                lag,
                 harmonic,
                 transverse_voltage * weight,
                 transverse_lag,

{xtrack-0.98.10 → xtrack-0.98.11}/xtrack/beam_elements/elements_src/track_rf.template.h

@@ -259,6 +259,10 @@ void track_rf_particles(
     double body_length;
     double factor_knl_ksl_body;
 
+    #ifndef XTRACK_MULTIPOLE_NO_SYNRAD
+        lag += lag_taper;
+    #endif
+
     if (LocalParticle_check_track_flag(part0, XS_FLAG_BACKTRACK)) {
         body_length = -length;
         factor_knl_ksl_body = -factor_knl_ksl;
@@ -324,7 +328,7 @@ void track_rf_particles(
                 body_length * weight,
                 voltage * weight,
                 frequency,
-                lag + lag_taper,
+                lag,
                 harmonic,
                 transverse_voltage * weight,
                 transverse_lag,

{xtrack-0.98.10 → xtrack-0.98.11}/xtrack/line.py

@@ -1567,6 +1567,8 @@ class Line:
 
         """
         Compute the 4D Twiss parameters. Equivalent to `twiss` with `method='4d'`.
+        See :ref:`Line.twiss method documentation<twiss_method_label>` for all
+        available options.
         """
         assert 'method' not in kwargs, 'method cannot be provided as argument to twiss4d'
         kwargs['method'] = '4d'
@@ -1576,6 +1578,8 @@ class Line:
 
         """
         Compute the 6D Twiss parameters. Equivalent to `twiss` with `method='6d'`.
+        See :ref:`Line.twiss method documentation<twiss_method_label>` for all
+        available options.
         """
         assert 'method' not in kwargs, 'method cannot be provided as argument to twiss6d'
         kwargs['method'] = '6d'