xsoar-cli 2.4.2__tar.gz → 2.4.3__tar.gz

{xsoar_cli-2.4.2 → xsoar_cli-2.4.3}/CHANGELOG.md

@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ## [Unreleased]
 
+## [2.4.2] - 2026-09-16
+
 ## [2.4.1] - 2026-06-19
 
 ## [2.4.0] - 2026-06-17
@@ -33,7 +35,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ### Fixed
 
-- `manifest update` no longer crashes with `ValueError: max() iterable argument is empty` when a custom pack is installed on the XSOAR server but has no artifacts in the configured artifact repository. The command now skips such packs (they are already reported in the pre-existing "installed but not found in artifacts repo" warning) and continues updating the remaining packs. As part of the fix, `S3ArtifactProvider.get_latest_version()` and `AzureArtifactProvider.get_latest_version()` now return `None` instead of raising when the pack has no versions in the repo.
+- `manifest update` no longer crashes with `ValueError: max() iterable argument is empty` when a custom pack is installed on the XSOAR server but has no artifacts in the configured artifact repository. The command now skips such packs (they are already reported in the pre-existing "installed but not found in artifacts repo" warning) and continues updating the remaining packs. As part of the fix, `S3ArtifactProvider.get_latest_version()` and `AzureArtifactProvider.get_latest_version()` now return `None` instead of raising when the pack has no versions in the repo, and `Packs.get_outdated()` was updated to treat `None` as the skip signal so `pack get-outdated` no longer crashes with `TypeError: unsupported format string passed to NoneType.__format__` on the same class of orphan pack.
 - `content get-detached` now returns only the content items that are actually detached. The previous query returned all system items, so the command reported every system script (or playbook) as detached instead of just the detached ones. Results are now filtered on each item's `detached` field.
 
 ## [2.3.0] - 2026-06-04

{xsoar_cli-2.4.2 → xsoar_cli-2.4.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: xsoar-cli
-Version: 2.4.2
+Version: 2.4.3
 Summary: A command-line interface for managing Palo Alto Networks XSOAR (Cortex XSOAR)
 Project-URL: Documentation, https://github.com/tlium/xsoar-cli#readme
 Project-URL: Issues, https://github.com/tlium/xsoar-cli/issues

{xsoar_cli-2.4.2 → xsoar_cli-2.4.3}/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '2.4.2'
-__version_tuple__ = version_tuple = (2, 4, 2)
+__version__ = version = '2.4.3'
+__version_tuple__ = version_tuple = (2, 4, 3)
 
 __commit_id__ = commit_id = None

{xsoar_cli-2.4.2 → xsoar_cli-2.4.3}/src/xsoar_cli/xsoar_client/packs.py

@@ -136,9 +136,8 @@ class Packs:
             if pack["author"] in self.custom_pack_authors:
                 if not self.client.artifact_provider:
                     raise RuntimeError("No artifact provider configured")
-                try:
-                    latest_version = self.client.artifact_provider.get_latest_version(pack["id"])
-                except ValueError:
+                latest_version = self.client.artifact_provider.get_latest_version(pack["id"])
+                if latest_version is None:
                     logger.warning("Custom pack '%s' installed on XSOAR server, but cannot find pack in artifacts repo", pack["id"])
                     skipped.append(pack["id"])
                     continue
@@ -164,8 +163,11 @@ class Packs:
 
         return OutdatedResult(outdated=update_available, skipped=skipped)
 
-    def get_latest_custom_version(self, pack_id: str) -> str:
-        """Gets the latest version of a custom pack from the artifacts repository."""
+    def get_latest_custom_version(self, pack_id: str) -> str | None:
+        """Gets the latest version of a custom pack from the artifacts repository.
+
+        Returns None if the pack has no artifacts in the repository.
+        """
         if not self.client.artifact_provider:
             raise RuntimeError("No artifact provider configured")
         return self.client.artifact_provider.get_latest_version(pack_id)

xsoar_cli-2.4.3/tests/cli/test_pack.py

@@ -0,0 +1,48 @@
+"""CLI integration tests for the ``pack`` command group."""
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from tests.cli.conftest import InvokeHelper
+
+
+class TestPackGroup:
+    def test_shows_help(self, invoke: InvokeHelper) -> None:
+        result = invoke(["pack"])
+        assert result.exit_code == 0
+
+    def test_help_flag(self, invoke: InvokeHelper) -> None:
+        result = invoke(["pack", "--help"])
+        assert result.exit_code == 0
+
+
+class TestPackGetOutdated:
+    """Tests for ``pack get-outdated``."""
+
+    def test_reports_orphan_custom_pack_and_lists_outdated(self, invoke: InvokeHelper, mock_xsoar_env) -> None:
+        """Regression test: an orphan custom pack (installed on the server but
+        missing from the artifacts repo) is surfaced in the warning list and
+        does not cause a formatting crash on ``pack['latest']``."""
+        from xsoar_cli.xsoar_client.packs import OutdatedResult
+
+        mock_xsoar_env.client.packs.get_outdated.return_value = OutdatedResult(
+            outdated=[
+                {
+                    "id": "CommonScripts",
+                    "currentVersion": "1.14.20",
+                    "latest": "1.15.0",
+                    "author": "Upstream",
+                },
+            ],
+            skipped=["OrphanPack"],
+        )
+
+        result = invoke(["pack", "get-outdated"])
+
+        assert result.exit_code == 0, result.output
+        assert "OrphanPack" in result.output
+        assert "installed but not found in artifacts repo" in result.output
+        assert "CommonScripts" in result.output
+        assert "1.15.0" in result.output

{xsoar_cli-2.4.2 → xsoar_cli-2.4.3}/tests/unit/test_packs.py

@@ -454,7 +454,7 @@ class TestGetOutdated:
         mock_client.make_request.return_value = _mock_response(_INSTALLED_EXPIRED)
 
         provider = MagicMock()
-        provider.get_latest_version.side_effect = ValueError("Pack not found")
+        provider.get_latest_version.return_value = None
         mock_client.artifact_provider = provider
 
         packs = Packs(mock_client, custom_pack_authors=["MyOrg"])

xsoar_cli-2.4.2/tests/cli/test_pack.py

@@ -1,18 +0,0 @@
-"""CLI integration tests for the ``pack`` command group."""
-
-from __future__ import annotations
-
-from typing import TYPE_CHECKING
-
-if TYPE_CHECKING:
-    from tests.cli.conftest import InvokeHelper
-
-
-class TestPackGroup:
-    def test_shows_help(self, invoke: InvokeHelper) -> None:
-        result = invoke(["pack"])
-        assert result.exit_code == 0
-
-    def test_help_flag(self, invoke: InvokeHelper) -> None:
-        result = invoke(["pack", "--help"])
-        assert result.exit_code == 0