xsoar-cli 2.4.1__tar.gz → 2.4.3__tar.gz

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/CHANGELOG.md

@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ## [Unreleased]
 
+## [2.4.2] - 2026-09-16
+
+## [2.4.1] - 2026-06-19
+
 ## [2.4.0] - 2026-06-17
 
 ### Added
@@ -31,6 +35,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ### Fixed
 
+- `manifest update` no longer crashes with `ValueError: max() iterable argument is empty` when a custom pack is installed on the XSOAR server but has no artifacts in the configured artifact repository. The command now skips such packs (they are already reported in the pre-existing "installed but not found in artifacts repo" warning) and continues updating the remaining packs. As part of the fix, `S3ArtifactProvider.get_latest_version()` and `AzureArtifactProvider.get_latest_version()` now return `None` instead of raising when the pack has no versions in the repo, and `Packs.get_outdated()` was updated to treat `None` as the skip signal so `pack get-outdated` no longer crashes with `TypeError: unsupported format string passed to NoneType.__format__` on the same class of orphan pack.
 - `content get-detached` now returns only the content items that are actually detached. The previous query returned all system items, so the command reported every system script (or playbook) as detached instead of just the detached ones. Results are now filtered on each item's `detached` field.
 
 ## [2.3.0] - 2026-06-04

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.4
+Metadata-Version: 2.5
 Name: xsoar-cli
-Version: 2.4.1
+Version: 2.4.3
 Summary: A command-line interface for managing Palo Alto Networks XSOAR (Cortex XSOAR)
 Project-URL: Documentation, https://github.com/tlium/xsoar-cli#readme
 Project-URL: Issues, https://github.com/tlium/xsoar-cli/issues

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '2.4.1'
-__version_tuple__ = version_tuple = (2, 4, 1)
+__version__ = version = '2.4.3'
+__version_tuple__ = version_tuple = (2, 4, 3)
 
 __commit_id__ = commit_id = None

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/src/xsoar_cli/commands/manifest/commands.py

@@ -190,12 +190,33 @@ def update(ctx: click.Context, environment: str | None, manifest: str) -> None:
             click.echo(f"  - {pack_id}", err=True)
 
     changes_made = False
+    skipped_custom_packs = set(result.skipped)
     for key in MANIFEST_KEYS:
         custom = key == "custom_packs"
         pack_type = "Custom" if custom else "Marketplace"
         for index, manifest_pack in enumerate(manifest_data[key]):
             if custom:
+                if manifest_pack["id"] in skipped_custom_packs:
+                    # Pack is installed on the server but has no artifacts in the repo.
+                    # Already surfaced to the user via the warning above.
+                    logger.debug(
+                        "%s pack '%s' skipped: not found in artifacts repo",
+                        pack_type,
+                        manifest_pack["id"],
+                    )
+                    continue
                 latest = xsoar_client.artifact_provider.get_latest_version(manifest_pack["id"])  # ty: ignore[unresolved-attribute]
+                if latest is None:
+                    # Defensive guard: the artifact provider reports no versions for this
+                    # pack. This overlaps with the skipped_custom_packs check above, but
+                    # keeps update() safe if a pack is missing from the repo without
+                    # having been flagged by get_outdated().
+                    logger.debug(
+                        "%s pack '%s' skipped: no versions returned by artifact provider",
+                        pack_type,
+                        manifest_pack["id"],
+                    )
+                    continue
             else:
                 pack = next((item for item in outdated_installed_packs if item["id"] == manifest_pack["id"]), None)
                 if not pack:

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/src/xsoar_cli/xsoar_client/artifact_providers/azure.py

@@ -58,9 +58,14 @@ class AzureArtifactProvider(BaseArtifactProvider):
         download_stream = self.container_client.download_blob(blob=key_name)
         return download_stream.readall()
 
-    def get_latest_version(self, pack_id: str) -> str:
-        """Fetch the latest version of a Pack"""
+    def get_latest_version(self, pack_id: str) -> str | None:
+        """Fetch the latest version of a Pack.
+
+        Returns None if the pack has no artifacts in the container.
+        """
         prefix = f"content/packs/{pack_id}/"
         iter_names = self.container_client.list_blob_names(name_starts_with=prefix)
         version_list = [x.split("/")[3] for x in list(iter_names)]
+        if not version_list:
+            return None
         return str(max(version_list, key=version.parse))

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/src/xsoar_cli/xsoar_client/artifact_providers/base.py

@@ -22,8 +22,14 @@ class BaseArtifactProvider(ABC):
         ...
 
     @abstractmethod
-    def get_latest_version(self, pack_id: str) -> str:
-        """Get the latest version of a pack."""
+    def get_latest_version(self, pack_id: str) -> str | None:
+        """Get the latest version of a pack.
+
+        Returns the highest available version string, or None if the pack has
+        no artifacts in the storage backend. Callers must handle the None case
+        (typically a pack installed on the server but missing from the artifact
+        repository).
+        """
         ...
 
     def get_pack_path(self, pack_id: str, pack_version: str) -> str:

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/src/xsoar_cli/xsoar_client/artifact_providers/s3.py

@@ -49,8 +49,11 @@ class S3ArtifactProvider(BaseArtifactProvider):
         response = obj.get()
         return response["Body"].read()
 
-    def get_latest_version(self, pack_id: str) -> str:
-        """Fetch the latest version of a Pack."""
+    def get_latest_version(self, pack_id: str) -> str | None:
+        """Fetch the latest version of a Pack.
+
+        Returns None if the pack has no artifacts in the S3 bucket.
+        """
         client = self.session.client("s3", verify=self.verify_ssl)
         result = client.list_objects_v2(
             Bucket=self.bucket_name,
@@ -58,4 +61,6 @@ class S3ArtifactProvider(BaseArtifactProvider):
             Delimiter="/",
         )
         version_list = [x["Prefix"].split("/")[3] for x in result.get("CommonPrefixes", [])]
+        if not version_list:
+            return None
         return str(max(version_list, key=version.parse))

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/src/xsoar_cli/xsoar_client/packs.py

@@ -136,9 +136,8 @@ class Packs:
             if pack["author"] in self.custom_pack_authors:
                 if not self.client.artifact_provider:
                     raise RuntimeError("No artifact provider configured")
-                try:
-                    latest_version = self.client.artifact_provider.get_latest_version(pack["id"])
-                except ValueError:
+                latest_version = self.client.artifact_provider.get_latest_version(pack["id"])
+                if latest_version is None:
                     logger.warning("Custom pack '%s' installed on XSOAR server, but cannot find pack in artifacts repo", pack["id"])
                     skipped.append(pack["id"])
                     continue
@@ -164,8 +163,11 @@ class Packs:
 
         return OutdatedResult(outdated=update_available, skipped=skipped)
 
-    def get_latest_custom_version(self, pack_id: str) -> str:
-        """Gets the latest version of a custom pack from the artifacts repository."""
+    def get_latest_custom_version(self, pack_id: str) -> str | None:
+        """Gets the latest version of a custom pack from the artifacts repository.
+
+        Returns None if the pack has no artifacts in the repository.
+        """
         if not self.client.artifact_provider:
             raise RuntimeError("No artifact provider configured")
         return self.client.artifact_provider.get_latest_version(pack_id)

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/tests/cli/test_manifest.py

@@ -115,6 +115,70 @@ class TestManifestValidate:
         assert mock_xsoar_env.client.packs.is_available.call_count == 2
 
 
+class TestManifestUpdate:
+    """Tests for ``manifest update``."""
+
+    def test_skips_custom_pack_missing_from_artifacts(self, invoke: InvokeHelper, mock_xsoar_env, tmp_path: Path) -> None:
+        """Regression test: a custom pack installed on the server but missing from
+        the artifacts repo is surfaced in the warning and then skipped, without
+        crashing on an empty version list."""
+        from xsoar_cli.xsoar_client.packs import OutdatedResult
+
+        manifest = tmp_path / "xsoar_config.json"
+        manifest.write_text(
+            json.dumps(
+                {
+                    "custom_packs": [{"id": "OrphanPack", "version": "1.0.0"}],
+                    "marketplace_packs": [],
+                }
+            )
+        )
+        mock_xsoar_env.client.packs.get_outdated.return_value = OutdatedResult(
+            outdated=[],
+            skipped=["OrphanPack"],
+        )
+        # If get_latest_version is reached for the orphan pack, this would
+        # historically raise ValueError. The command must not call it.
+        mock_xsoar_env.client.artifact_provider.get_latest_version.return_value = None
+
+        result = invoke(["manifest", "update", str(manifest)])
+
+        assert result.exit_code == 0, result.output
+        assert "OrphanPack" in result.output
+        assert "installed but not found in artifacts repo" in result.output
+        mock_xsoar_env.client.artifact_provider.get_latest_version.assert_not_called()
+        # Manifest must remain unchanged.
+        assert json.loads(manifest.read_text()) == {
+            "custom_packs": [{"id": "OrphanPack", "version": "1.0.0"}],
+            "marketplace_packs": [],
+        }
+
+    def test_skips_when_provider_returns_none(self, invoke: InvokeHelper, mock_xsoar_env, tmp_path: Path) -> None:
+        """Defensive guard: even if a pack is not in the skipped list, a None from
+        the artifact provider is handled cleanly instead of raising."""
+        from xsoar_cli.xsoar_client.packs import OutdatedResult
+
+        manifest = tmp_path / "xsoar_config.json"
+        manifest.write_text(
+            json.dumps(
+                {
+                    "custom_packs": [{"id": "MyOrg_EDR", "version": "1.0.0"}],
+                    "marketplace_packs": [],
+                }
+            )
+        )
+        mock_xsoar_env.client.packs.get_outdated.return_value = OutdatedResult(
+            outdated=[],
+            skipped=[],
+        )
+        mock_xsoar_env.client.artifact_provider.get_latest_version.return_value = None
+
+        result = invoke(["manifest", "update", str(manifest)])
+
+        assert result.exit_code == 0, result.output
+        mock_xsoar_env.client.artifact_provider.get_latest_version.assert_called_once_with("MyOrg_EDR")
+
+
 class TestManifestValidateOnlyChanged:
     """Tests for ``manifest validate --only-changed``."""
 

xsoar_cli-2.4.3/tests/cli/test_pack.py

@@ -0,0 +1,48 @@
+"""CLI integration tests for the ``pack`` command group."""
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from tests.cli.conftest import InvokeHelper
+
+
+class TestPackGroup:
+    def test_shows_help(self, invoke: InvokeHelper) -> None:
+        result = invoke(["pack"])
+        assert result.exit_code == 0
+
+    def test_help_flag(self, invoke: InvokeHelper) -> None:
+        result = invoke(["pack", "--help"])
+        assert result.exit_code == 0
+
+
+class TestPackGetOutdated:
+    """Tests for ``pack get-outdated``."""
+
+    def test_reports_orphan_custom_pack_and_lists_outdated(self, invoke: InvokeHelper, mock_xsoar_env) -> None:
+        """Regression test: an orphan custom pack (installed on the server but
+        missing from the artifacts repo) is surfaced in the warning list and
+        does not cause a formatting crash on ``pack['latest']``."""
+        from xsoar_cli.xsoar_client.packs import OutdatedResult
+
+        mock_xsoar_env.client.packs.get_outdated.return_value = OutdatedResult(
+            outdated=[
+                {
+                    "id": "CommonScripts",
+                    "currentVersion": "1.14.20",
+                    "latest": "1.15.0",
+                    "author": "Upstream",
+                },
+            ],
+            skipped=["OrphanPack"],
+        )
+
+        result = invoke(["pack", "get-outdated"])
+
+        assert result.exit_code == 0, result.output
+        assert "OrphanPack" in result.output
+        assert "installed but not found in artifacts repo" in result.output
+        assert "CommonScripts" in result.output
+        assert "1.15.0" in result.output

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/tests/unit/test_artifact_azure.py

@@ -225,11 +225,10 @@ class TestGetLatestVersion:
 
         assert result == "1.0.0"
 
-    def test_raises_on_empty_listing(self) -> None:
+    def test_empty_listing_returns_none(self) -> None:
         provider = _make_provider()
         mock_container = MagicMock()
         mock_container.list_blob_names.return_value = []
         provider._container_client = mock_container
 
-        with pytest.raises(ValueError):
-            provider.get_latest_version("NonExistent")
+        assert provider.get_latest_version("NonExistent") is None

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/tests/unit/test_artifact_s3.py

@@ -214,7 +214,7 @@ class TestGetLatestVersion:
 
         assert result == "1.0.0"
 
-    def test_no_versions_raises(self) -> None:
+    def test_no_versions_returns_none(self) -> None:
         provider = _make_provider()
         mock_session = MagicMock()
         mock_client = MagicMock()
@@ -222,8 +222,17 @@ class TestGetLatestVersion:
         mock_session.client.return_value = mock_client
         provider._session = mock_session
 
-        with pytest.raises(ValueError):
-            provider.get_latest_version("MyPack")
+        assert provider.get_latest_version("MyPack") is None
+
+    def test_empty_common_prefixes_returns_none(self) -> None:
+        provider = _make_provider()
+        mock_session = MagicMock()
+        mock_client = MagicMock()
+        mock_client.list_objects_v2.return_value = {"CommonPrefixes": []}
+        mock_session.client.return_value = mock_client
+        provider._session = mock_session
+
+        assert provider.get_latest_version("MyPack") is None
 
     def test_respects_verify_ssl(self) -> None:
         provider = _make_provider(verify_ssl=False)

{xsoar_cli-2.4.1 → xsoar_cli-2.4.3}/tests/unit/test_packs.py

@@ -454,7 +454,7 @@ class TestGetOutdated:
         mock_client.make_request.return_value = _mock_response(_INSTALLED_EXPIRED)
 
         provider = MagicMock()
-        provider.get_latest_version.side_effect = ValueError("Pack not found")
+        provider.get_latest_version.return_value = None
         mock_client.artifact_provider = provider
 
         packs = Packs(mock_client, custom_pack_authors=["MyOrg"])

xsoar_cli-2.4.1/tests/cli/test_pack.py

@@ -1,18 +0,0 @@
-"""CLI integration tests for the ``pack`` command group."""
-
-from __future__ import annotations
-
-from typing import TYPE_CHECKING
-
-if TYPE_CHECKING:
-    from tests.cli.conftest import InvokeHelper
-
-
-class TestPackGroup:
-    def test_shows_help(self, invoke: InvokeHelper) -> None:
-        result = invoke(["pack"])
-        assert result.exit_code == 0
-
-    def test_help_flag(self, invoke: InvokeHelper) -> None:
-        result = invoke(["pack", "--help"])
-        assert result.exit_code == 0