xai-review 0.31.0__tar.gz → 0.33.0__tar.gz

{xai_review-0.31.0/xai_review.egg-info → xai_review-0.33.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: xai-review
-Version: 0.31.0
+Version: 0.33.0
 Summary: AI-powered code review tool
 Author-email: Nikita Filonov <nikita.filonov@example.com>
 Maintainer-email: Nikita Filonov <nikita.filonov@example.com>
@@ -220,7 +220,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: Nikita-Filonov/ai-review@v0.31.0
+      - uses: Nikita-Filonov/ai-review@v0.33.0
         with:
           review-command: ${{ inputs.review-command }}
         env:

{xai_review-0.31.0 → xai_review-0.33.0}/README.md

@@ -186,7 +186,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: Nikita-Filonov/ai-review@v0.31.0
+      - uses: Nikita-Filonov/ai-review@v0.33.0
         with:
           review-command: ${{ inputs.review-command }}
         env:

{xai_review-0.31.0 → xai_review-0.33.0}/ai_review/clients/gitea/pr/schema/comments.py

@@ -28,8 +28,6 @@ class GiteaGetPRCommentsResponseSchema(RootModel[list[GiteaPRCommentSchema]]):
 
 class GiteaCreateCommentRequestSchema(BaseModel):
     body: str
-    path: str | None = None
-    line: int | None = None
 
 
 class GiteaCreateCommentResponseSchema(BaseModel):

{xai_review-0.31.0 → xai_review-0.33.0}/ai_review/services/artifacts/tools.py

@@ -1,8 +1,8 @@
 import hashlib
-from datetime import datetime
+from datetime import datetime, timezone
 
 
 def make_artifact_id(text: str) -> str:
     sha = hashlib.sha1(text.encode()).hexdigest()[:8]
-    ts = datetime.utcnow().strftime("%Y.%m.%d_%H-%M-%S")
+    ts = datetime.now(timezone.utc).strftime("%Y.%m.%d_%H-%M-%S")
     return f"{ts}_{sha}"

{xai_review-0.31.0 → xai_review-0.33.0}/ai_review/services/vcs/gitea/client.py

@@ -2,7 +2,10 @@ from ai_review.clients.gitea.client import get_gitea_http_client
 from ai_review.clients.gitea.pr.schema.comments import GiteaCreateCommentRequestSchema
 from ai_review.config import settings
 from ai_review.libs.logger import get_logger
-from ai_review.services.vcs.gitea.adapter import get_review_comment_from_gitea_comment, get_user_from_gitea_user
+from ai_review.services.vcs.gitea.adapter import (
+    get_user_from_gitea_user,
+    get_review_comment_from_gitea_comment,
+)
 from ai_review.services.vcs.types import (
     VCSClientProtocol,
     ThreadKind,
@@ -67,12 +70,13 @@ class GiteaVCSClient(VCSClientProtocol):
             return []
 
     async def get_inline_comments(self) -> list[ReviewCommentSchema]:
-        try:
-            comments = await self.get_general_comments()
-            return [comment for comment in comments if comment.file]
-        except Exception as error:
-            logger.exception(f"Failed to fetch inline comments for {self.pull_request_ref}: {error}")
-            return []
+        comments = await self.get_general_comments()
+        if comments:
+            logger.warning(
+                f"Gitea API does not support inline comments — "
+                f"returning {len(comments)} general comments as fallback inline comments"
+            )
+        return comments
 
     async def create_general_comment(self, message: str) -> None:
         try:
@@ -90,25 +94,15 @@ class GiteaVCSClient(VCSClientProtocol):
             raise
 
     async def create_inline_comment(self, file: str, line: int, message: str) -> None:
-        try:
-            logger.info(f"Posting inline comment to {self.pull_request_ref} at {file}:{line}")
-            request = GiteaCreateCommentRequestSchema(
-                body=message,
-                path=file,
-                line=line,
-            )
-            await self.http_client.pr.create_comment(
-                owner=self.owner,
-                repo=self.repo,
-                pull_number=self.pull_number,
-                request=request,
-            )
-            logger.info(f"Created inline comment in {self.pull_request_ref} at {file}:{line}")
-        except Exception as error:
-            logger.exception(f"Failed to create inline comment in {self.pull_request_ref} at {file}:{line}: {error}")
-            raise
+        fallback_message = f"[{file}:{line}] {message}"
+        logger.warning(
+            f"Gitea does not support inline comments. "
+            f"Falling back to general comment: {fallback_message}"
+        )
+        await self.create_general_comment(fallback_message)
 
     async def create_inline_reply(self, thread_id: int | str, message: str) -> None:
+        logger.warning("Gitea does not support threaded replies — posting new general comment instead")
         await self.create_general_comment(message)
 
     async def create_summary_reply(self, thread_id: int | str, message: str) -> None:
@@ -118,17 +112,15 @@ class GiteaVCSClient(VCSClientProtocol):
     async def get_inline_threads(self) -> list[ReviewThreadSchema]:
         try:
             comments = await self.get_inline_comments()
-            threads = {comment.thread_id: [comment] for comment in comments}
-
             return [
                 ReviewThreadSchema(
-                    id=thread_id,
+                    id=comment.thread_id,
                     kind=ThreadKind.INLINE,
-                    file=thread[0].file,
-                    line=thread[0].line,
-                    comments=thread,
+                    file=comment.file,
+                    line=comment.line,
+                    comments=[comment],
                 )
-                for thread_id, thread in threads.items()
+                for comment in comments
             ]
         except Exception as error:
             logger.exception(f"Failed to build inline threads for {self.pull_request_ref}: {error}")
@@ -137,15 +129,14 @@ class GiteaVCSClient(VCSClientProtocol):
     async def get_general_threads(self) -> list[ReviewThreadSchema]:
         try:
             comments = await self.get_general_comments()
-            threads = [
+            return [
                 ReviewThreadSchema(
                     id=comment.thread_id,
                     kind=ThreadKind.SUMMARY,
-                    comments=[comment]
+                    comments=[comment],
                 )
                 for comment in comments
             ]
-            return threads
         except Exception as error:
             logger.exception(f"Failed to build general threads for {self.pull_request_ref}: {error}")
             return []

{xai_review-0.31.0 → xai_review-0.33.0}/ai_review/tests/fixtures/clients/gitea.py

@@ -45,13 +45,11 @@ class FakeGiteaPullRequestsHTTPClient(GiteaPullRequestsHTTPClientProtocol):
         return GiteaGetPRFilesResponseSchema(
             root=[
                 GiteaPRFileSchema(
-                    sha="abc",
                     status="modified",
                     filename="src/main.py",
                     patch="@@ -1,2 +1,2 @@\n- old\n+ new",
                 ),
                 GiteaPRFileSchema(
-                    sha="def",
                     status="added",
                     filename="utils/helper.py",
                     patch="+ print('Hello')",

{xai_review-0.31.0 → xai_review-0.33.0}/ai_review/tests/fixtures/services/artifacts.py

@@ -2,6 +2,7 @@ from pathlib import Path
 
 import pytest
 
+from ai_review.services.artifacts.service import ArtifactsService
 from ai_review.services.artifacts.types import ArtifactsServiceProtocol
 
 
@@ -49,3 +50,8 @@ class FakeArtifactsService(ArtifactsServiceProtocol):
 @pytest.fixture
 def fake_artifacts_service() -> FakeArtifactsService:
     return FakeArtifactsService()
+
+
+@pytest.fixture
+def artifacts_service() -> ArtifactsService:
+    return ArtifactsService()

xai_review-0.33.0/ai_review/tests/suites/services/artifacts/test_service.py

@@ -0,0 +1,92 @@
+import json
+from pathlib import Path
+
+import aiofiles
+import pytest
+
+from ai_review.config import settings
+from ai_review.libs.config.artifacts import ArtifactsConfig
+from ai_review.services.artifacts.service import ArtifactsService
+
+
+@pytest.mark.asyncio
+async def test_save_llm_interaction_creates_file(
+        tmp_path: Path,
+        monkeypatch: pytest.MonkeyPatch,
+        artifacts_service: ArtifactsService
+):
+    """Checks that a JSON file is created with the correct name and content when LLM saving is enabled."""
+    monkeypatch.setattr(settings, "artifacts", ArtifactsConfig(llm_dir=tmp_path, llm_enabled=True))
+
+    artifact_id = await artifacts_service.save_llm_interaction(
+        prompt="Hello world",
+        prompt_system="system prompt",
+        response="model answer"
+    )
+
+    assert artifact_id is not None
+    artifact_path = tmp_path / f"{artifact_id}.json"
+    assert artifact_path.exists(), "Artifact file was not created"
+
+    async with aiofiles.open(artifact_path, "r", encoding="utf-8") as file:
+        content = await file.read()
+    data = json.loads(content)
+    assert data["id"] == artifact_id
+    assert data["prompt"] == "Hello world"
+    assert data["response"] == "model answer"
+    assert data["prompt_system"] == "system prompt"
+
+
+@pytest.mark.asyncio
+async def test_save_llm_interaction_disabled(
+        monkeypatch: pytest.MonkeyPatch,
+        artifacts_service: ArtifactsService
+):
+    """Checks that the method returns None and does not create a file if LLM saving is disabled."""
+    monkeypatch.setattr(settings, "artifacts", ArtifactsConfig(llm_enabled=False))
+
+    artifact_id = await artifacts_service.save_llm_interaction(
+        prompt="ignored",
+        prompt_system="ignored",
+        response="ignored"
+    )
+
+    assert artifact_id is None
+
+
+@pytest.mark.asyncio
+async def test_save_artifact_writes_file(tmp_path: Path, artifacts_service: ArtifactsService):
+    """Checks that save_artifact writes content to the given file path."""
+    file_path = tmp_path / "test.json"
+    content = '{"key": "value"}'
+
+    result = await artifacts_service.save_artifact(file=file_path, content=content, kind="test")
+
+    assert result == file_path
+    assert file_path.exists()
+    async with aiofiles.open(file_path, "r", encoding="utf-8") as f:
+        saved_content = await f.read()
+    assert saved_content == content
+
+
+@pytest.mark.asyncio
+async def test_save_artifact_handles_exception(
+        monkeypatch: pytest.MonkeyPatch,
+        artifacts_service: ArtifactsService
+):
+    """Checks that save_artifact gracefully returns None on write error."""
+
+    class BrokenAsyncFile:
+        async def __aenter__(self):
+            raise OSError("disk full")
+
+        async def __aexit__(self, exc_type, exc_val, exc_tb):
+            return False
+
+    monkeypatch.setattr(
+        "ai_review.services.artifacts.service.aiofiles.open",
+        lambda *args, **kwargs: BrokenAsyncFile()
+    )
+
+    result = await artifacts_service.save_artifact(Path("/fake/path.json"), "data")
+    assert result is None

xai_review-0.33.0/ai_review/tests/suites/services/artifacts/test_tools.py

@@ -0,0 +1,28 @@
+import hashlib
+import re
+
+import pytest
+
+from ai_review.services.artifacts.tools import make_artifact_id
+
+
+@pytest.mark.parametrize("text", ["hello", "some longer text", ""])
+def test_make_artifact_id_format_and_sha(text: str):
+    """Checks that the function returns a valid artifact ID format and correct SHA prefix."""
+    artifact_id = make_artifact_id(text)
+
+    pattern = r"^\d{4}\.\d{2}\.\d{2}_\d{2}-\d{2}-\d{2}_[0-9a-f]{8}$"
+    assert re.match(pattern, artifact_id), f"Invalid format: {artifact_id}"
+
+    expected_sha = hashlib.sha1(text.encode()).hexdigest()[:8]
+    assert artifact_id.endswith(expected_sha)
+
+
+def test_make_artifact_id_is_deterministic_for_same_input():
+    """Checks that the SHA part is deterministic (identical for the same input)."""
+    sha1 = hashlib.sha1("repeatable".encode()).hexdigest()[:8]
+    artifact_id1 = make_artifact_id("repeatable")
+    artifact_id2 = make_artifact_id("repeatable")
+
+    assert artifact_id1.split("_")[2] == sha1
+    assert artifact_id2.split("_")[2] == sha1

{xai_review-0.31.0 → xai_review-0.33.0}/ai_review/tests/suites/services/vcs/gitea/test_client.py

@@ -29,19 +29,20 @@ async def test_get_general_comments_returns_list(
         fake_gitea_pull_requests_http_client: FakeGiteaPullRequestsHTTPClient,
 ):
     comments = await gitea_vcs_client.get_general_comments()
-    assert all(isinstance(c, ReviewCommentSchema) for c in comments)
+    assert all(isinstance(comment, ReviewCommentSchema) for comment in comments)
     assert len(comments) > 0
 
 
 @pytest.mark.asyncio
 @pytest.mark.usefixtures("gitea_http_client_config")
-async def test_get_inline_comments_filters_by_file(
+async def test_get_inline_comments_returns_fallback_general_comments(
         gitea_vcs_client: GiteaVCSClient,
         fake_gitea_pull_requests_http_client: FakeGiteaPullRequestsHTTPClient,
 ):
     comments = await gitea_vcs_client.get_inline_comments()
-    assert all(c.file for c in comments)
-    assert all(isinstance(c, ReviewCommentSchema) for c in comments)
+    assert isinstance(comments, list)
+    assert all(isinstance(comment, ReviewCommentSchema) for comment in comments)
+    assert len(comments) > 0
 
 
 @pytest.mark.asyncio
@@ -57,11 +58,11 @@ async def test_create_general_comment_posts_comment(
 
 @pytest.mark.asyncio
 @pytest.mark.usefixtures("gitea_http_client_config")
-async def test_create_inline_comment_posts_comment(
+async def test_create_inline_comment_falls_back_to_general_comment(
         gitea_vcs_client: GiteaVCSClient,
         fake_gitea_pull_requests_http_client: FakeGiteaPullRequestsHTTPClient,
 ):
-    await gitea_vcs_client.create_inline_comment("src/main.py", 10, "Inline comment")
+    await gitea_vcs_client.create_inline_comment(file="src/main.py", line=10, message="Inline comment")
     calls = [name for name, _ in fake_gitea_pull_requests_http_client.calls]
     assert "create_comment" in calls
 
@@ -72,8 +73,8 @@ async def test_get_inline_threads_groups_by_comment(
         gitea_vcs_client: GiteaVCSClient,
 ):
     threads = await gitea_vcs_client.get_inline_threads()
-    assert all(isinstance(t, ReviewThreadSchema) for t in threads)
-    assert all(t.kind == ThreadKind.INLINE for t in threads)
+    assert all(isinstance(thread, ReviewThreadSchema) for thread in threads)
+    assert all(thread.kind == ThreadKind.INLINE for thread in threads)
 
 
 @pytest.mark.asyncio
@@ -82,5 +83,5 @@ async def test_get_general_threads_wraps_comments(
         gitea_vcs_client: GiteaVCSClient,
 ):
     threads = await gitea_vcs_client.get_general_threads()
-    assert all(isinstance(t, ReviewThreadSchema) for t in threads)
-    assert all(t.kind == ThreadKind.SUMMARY for t in threads)
+    assert all(isinstance(thread, ReviewThreadSchema) for thread in threads)
+    assert all(thread.kind == ThreadKind.SUMMARY for thread in threads)

{xai_review-0.31.0 → xai_review-0.33.0}/pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"
 [project]
 name = "xai-review"
 readme = { file = "README.md", content-type = "text/markdown" }
-version = "0.31.0"
+version = "0.33.0"
 license = { text = "Apache-2.0" }
 authors = [
     { name = "Nikita Filonov", email = "nikita.filonov@example.com" }

{xai_review-0.31.0 → xai_review-0.33.0/xai_review.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: xai-review
-Version: 0.31.0
+Version: 0.33.0
 Summary: AI-powered code review tool
 Author-email: Nikita Filonov <nikita.filonov@example.com>
 Maintainer-email: Nikita Filonov <nikita.filonov@example.com>
@@ -220,7 +220,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: Nikita-Filonov/ai-review@v0.31.0
+      - uses: Nikita-Filonov/ai-review@v0.33.0
         with:
           review-command: ${{ inputs.review-command }}
         env:

{xai_review-0.31.0 → xai_review-0.33.0}/xai_review.egg-info/SOURCES.txt

@@ -311,6 +311,9 @@ ai_review/tests/suites/libs/llm/test_output_json_parser.py
 ai_review/tests/suites/libs/template/__init__.py
 ai_review/tests/suites/libs/template/test_render.py
 ai_review/tests/suites/services/__init__.py
+ai_review/tests/suites/services/artifacts/__init__.py
+ai_review/tests/suites/services/artifacts/test_service.py
+ai_review/tests/suites/services/artifacts/test_tools.py
 ai_review/tests/suites/services/cost/__init__.py
 ai_review/tests/suites/services/cost/test_schema.py
 ai_review/tests/suites/services/cost/test_service.py