xai-review 0.10.0__tar.gz → 0.12.0__tar.gz

{xai_review-0.10.0 → xai_review-0.12.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: xai-review
-Version: 0.10.0
+Version: 0.12.0
 Summary: AI-powered code review tool
 Author-email: Nikita Filonov <nikita.filonov@example.com>
 Maintainer-email: Nikita Filonov <nikita.filonov@example.com>

{xai_review-0.10.0 → xai_review-0.12.0}/ai_review/libs/config/prompt.py

@@ -8,6 +8,7 @@ from ai_review.libs.resources import load_resource
 
 class PromptConfig(BaseModel):
     context: dict[str, str] = Field(default_factory=dict)
+    normalize_prompts: bool = True
     context_placeholder: str = "<<{value}>>"
     inline_prompt_files: list[FilePath] | None = None
     context_prompt_files: list[FilePath] | None = None

xai_review-0.12.0/ai_review/libs/json.py

@@ -0,0 +1,16 @@
+import re
+
+CONTROL_CHARS_RE = re.compile(r"[\x00-\x1F]")
+REPLACEMENTS = {
+    "\n": "\\n",
+    "\r": "\\r",
+    "\t": "\\t",
+}
+
+
+def sanitize_json_string(raw: str) -> str:
+    def replace(match: re.Match) -> str:
+        char = match.group()
+        return REPLACEMENTS.get(char, f"\\u{ord(char):04x}")
+
+    return CONTROL_CHARS_RE.sub(replace, raw)

{xai_review-0.10.0 → xai_review-0.12.0}/ai_review/services/prompt/service.py

@@ -1,56 +1,57 @@
 from ai_review.config import settings
 from ai_review.services.diff.schema import DiffFileSchema
 from ai_review.services.prompt.schema import PromptContextSchema
+from ai_review.services.prompt.tools import normalize_prompt, format_file
 
 
-def format_file(diff: DiffFileSchema) -> str:
-    return f"# File: {diff.file}\n{diff.diff}\n"
+class PromptService:
+    @classmethod
+    def prepare_prompt(cls, prompts: list[str], context: PromptContextSchema) -> str:
+        prompt = "\n\n".join(prompts)
+        prompt = context.apply_format(prompt)
 
+        if settings.prompt.normalize_prompts:
+            prompt = normalize_prompt(prompt)
+
+        return prompt
 
-class PromptService:
     @classmethod
     def build_inline_request(cls, diff: DiffFileSchema, context: PromptContextSchema) -> str:
-        inline_prompts = "\n\n".join(settings.prompt.load_inline())
-        inline_prompts = context.apply_format(inline_prompts)
+        prompt = cls.prepare_prompt(settings.prompt.load_inline(), context)
         return (
-            f"{inline_prompts}\n\n"
+            f"{prompt}\n\n"
             f"## Diff\n\n"
             f"{format_file(diff)}"
         )
 
     @classmethod
     def build_summary_request(cls, diffs: list[DiffFileSchema], context: PromptContextSchema) -> str:
+        prompt = cls.prepare_prompt(settings.prompt.load_summary(), context)
         changes = "\n\n".join(map(format_file, diffs))
-        summary_prompts = "\n\n".join(settings.prompt.load_summary())
-        summary_prompts = context.apply_format(summary_prompts)
         return (
-            f"{summary_prompts}\n\n"
+            f"{prompt}\n\n"
             f"## Changes\n\n"
             f"{changes}\n"
         )
 
     @classmethod
     def build_context_request(cls, diffs: list[DiffFileSchema], context: PromptContextSchema) -> str:
+        prompt = cls.prepare_prompt(settings.prompt.load_context(), context)
         changes = "\n\n".join(map(format_file, diffs))
-        inline_prompts = "\n\n".join(settings.prompt.load_context())
-        inline_prompts = context.apply_format(inline_prompts)
         return (
-            f"{inline_prompts}\n\n"
+            f"{prompt}\n\n"
             f"## Diff\n\n"
             f"{changes}\n"
         )
 
     @classmethod
     def build_system_inline_request(cls, context: PromptContextSchema) -> str:
-        prompt = "\n\n".join(settings.prompt.load_system_inline())
-        return context.apply_format(prompt)
+        return cls.prepare_prompt(settings.prompt.load_system_inline(), context)
 
     @classmethod
     def build_system_context_request(cls, context: PromptContextSchema) -> str:
-        prompt = "\n\n".join(settings.prompt.load_system_context())
-        return context.apply_format(prompt)
+        return cls.prepare_prompt(settings.prompt.load_system_context(), context)
 
     @classmethod
     def build_system_summary_request(cls, context: PromptContextSchema) -> str:
-        prompt = "\n\n".join(settings.prompt.load_system_summary())
-        return context.apply_format(prompt)
+        return cls.prepare_prompt(settings.prompt.load_system_summary(), context)

xai_review-0.12.0/ai_review/services/prompt/tools.py

@@ -0,0 +1,24 @@
+import re
+
+from ai_review.libs.logger import get_logger
+from ai_review.services.diff.schema import DiffFileSchema
+
+logger = get_logger("PROMPT_TOOLS")
+
+
+def format_file(diff: DiffFileSchema) -> str:
+    return f"# File: {diff.file}\n{diff.diff}\n"
+
+
+def normalize_prompt(text: str) -> str:
+    tails_stripped = [re.sub(r"[ \t]+$", "", line) for line in text.splitlines()]
+    text = "\n".join(tails_stripped)
+
+    text = re.sub(r"\n{3,}", "\n\n", text)
+
+    result = text.strip()
+    if len(text) > len(result):
+        logger.info(f"Prompt has been normalized from {len(text)} to {len(result)}")
+        return result
+
+    return text

{xai_review-0.10.0 → xai_review-0.12.0}/ai_review/services/review/inline/service.py

@@ -18,12 +18,12 @@ class InlineCommentService:
         try:
             return InlineCommentListSchema.model_validate_json(raw)
         except ValidationError as error:
-            logger.debug(f"Parse failed, trying sanitized JSON: {raw[:200]=}, {error=}")
+            logger.warning(f"Parse failed, trying sanitized JSON: {raw[:200]=}, {error=}")
             try:
                 cleaned = sanitize_json_string(raw)
                 return InlineCommentListSchema.model_validate_json(cleaned)
             except ValidationError as error:
-                logger.debug(f"Sanitized JSON still invalid: {raw[:200]=}, {error=}")
+                logger.warning(f"Sanitized JSON still invalid: {raw[:200]=}, {error=}")
                 return None
 
     @classmethod

{xai_review-0.10.0 → xai_review-0.12.0}/ai_review/tests/suites/libs/test_json.py

@@ -12,30 +12,16 @@ from ai_review.libs.json import sanitize_json_string
         ("a\tb", "a\\tb"),
         ("abc\0def", "abc\\u0000def"),
         ("x\n\ry\t\0z", "x\\n\\ry\\t\\u0000z"),
+        ("\n\r\t\0", "\\n\\r\\t\\u0000"),
+        ("", "")
     ],
 )
 def test_sanitize_basic_cases(actual: str, expected: str) -> None:
     assert sanitize_json_string(actual) == expected
 
 
-def test_sanitize_multiple_control_chars() -> None:
-    raw = "A\nB\rC\tD\0E"
-    result = sanitize_json_string(raw)
-    assert result == "A\\nB\\rC\\tD\\u0000E"
-
-
 def test_sanitize_idempotent() -> None:
     raw = "foo\nbar"
     once = sanitize_json_string(raw)
     twice = sanitize_json_string(once)
     assert once == twice
-
-
-def test_sanitize_empty_string() -> None:
-    assert sanitize_json_string("") == ""
-
-
-def test_sanitize_only_control_chars() -> None:
-    raw = "\n\r\t\0"
-    result = sanitize_json_string(raw)
-    assert result == "\\n\\r\\t\\u0000"

{xai_review-0.10.0 → xai_review-0.12.0}/ai_review/tests/suites/services/prompt/test_service.py

@@ -1,5 +1,6 @@
 import pytest
 
+from ai_review.config import settings
 from ai_review.libs.config.prompt import PromptConfig
 from ai_review.services.diff.schema import DiffFileSchema
 from ai_review.services.prompt.schema import PromptContextSchema
@@ -134,3 +135,35 @@ def test_diff_placeholders_are_not_replaced(dummy_context: PromptContextSchema)
 
     assert "<<merge_request_title>>" in result
     assert "Fix login bug" not in result
+
+
+def test_prepare_prompt_basic_substitution(dummy_context: PromptContextSchema) -> None:
+    prompts = ["Hello", "MR title: <<merge_request_title>>"]
+    result = PromptService.prepare_prompt(prompts, dummy_context)
+    assert "Hello" in result
+    assert "MR title: Fix login bug" in result
+
+
+def test_prepare_prompt_applies_normalization(
+        monkeypatch: pytest.MonkeyPatch,
+        dummy_context: PromptContextSchema
+) -> None:
+    monkeypatch.setattr(settings.prompt, "normalize_prompts", True)
+    prompts = ["Line with space   ", "", "", "Next line"]
+    result = PromptService.prepare_prompt(prompts, dummy_context)
+
+    assert "Line with space" in result
+    assert "Next line" in result
+    assert "\n\n\n" not in result
+
+
+def test_prepare_prompt_skips_normalization(
+        monkeypatch: pytest.MonkeyPatch,
+        dummy_context: PromptContextSchema
+) -> None:
+    monkeypatch.setattr(settings.prompt, "normalize_prompts", False)
+    prompts = ["Line with space   ", "", "", "Next line"]
+    result = PromptService.prepare_prompt(prompts, dummy_context)
+
+    assert "Line with space   " in result
+    assert "\n\n\n" in result

xai_review-0.12.0/ai_review/tests/suites/services/prompt/test_tools.py

@@ -0,0 +1,72 @@
+from ai_review.services.diff.schema import DiffFileSchema
+from ai_review.services.prompt.tools import format_file, normalize_prompt
+
+
+def test_format_file_basic():
+    diff = DiffFileSchema(file="main.py", diff="+ print('hello')")
+    result = format_file(diff)
+    assert result == "# File: main.py\n+ print('hello')\n"
+
+
+def test_format_file_empty_diff():
+    diff = DiffFileSchema(file="empty.py", diff="")
+    result = format_file(diff)
+    assert result == "# File: empty.py\n\n"
+
+
+def test_format_file_multiline_diff():
+    diff = DiffFileSchema(
+        file="utils/helpers.py",
+        diff="- old line\n+ new line\n+ another line"
+    )
+    result = format_file(diff)
+    expected = (
+        "# File: utils/helpers.py\n"
+        "- old line\n"
+        "+ new line\n"
+        "+ another line\n"
+    )
+    assert result == expected
+
+
+def test_format_file_filename_with_path():
+    diff = DiffFileSchema(file="src/app/models/user.py", diff="+ class User:")
+    result = format_file(diff)
+    assert result.startswith("# File: src/app/models/user.py\n")
+    assert result.endswith("+ class User:\n")
+
+
+def test_trailing_spaces_are_removed():
+    text = "hello   \nworld\t\t"
+    result = normalize_prompt(text)
+    assert result == "hello\nworld"
+
+
+def test_multiple_empty_lines_collapsed():
+    text = "line1\n\n\n\nline2"
+    result = normalize_prompt(text)
+    assert result == "line1\n\nline2"
+
+
+def test_leading_and_trailing_whitespace_removed():
+    text = "\n\n   hello\nworld   \n\n"
+    result = normalize_prompt(text)
+    assert result == "hello\nworld"
+
+
+def test_internal_spaces_preserved():
+    text = "foo    bar\nbaz\t\tqux"
+    result = normalize_prompt(text)
+    assert result == "foo    bar\nbaz\t\tqux"
+
+
+def test_only_whitespace_string():
+    text = "   \n   \n"
+    result = normalize_prompt(text)
+    assert result == ""
+
+
+def test_no_changes_when_already_clean():
+    text = "line1\nline2"
+    result = normalize_prompt(text)
+    assert result == text

{xai_review-0.10.0 → xai_review-0.12.0}/ai_review/tests/suites/services/review/inline/test_service.py

@@ -53,6 +53,8 @@ def test_json_with_raw_newline_sanitized():
     output = '[{"file": "e.py", "line": 3, "message": "line1\nline2"}]'
     result = InlineCommentService.parse_model_output(output)
     assert len(result.root) == 1
+    assert result.root[0].file == "e.py"
+    assert result.root[0].line == 3
     assert result.root[0].message == "line1\nline2"
 
 
@@ -85,6 +87,8 @@ def test_try_parse_valid_json():
     assert isinstance(result, InlineCommentListSchema)
     assert len(result.root) == 1
     assert result.root[0].file == "ok.py"
+    assert result.root[0].line == 1
+    assert result.root[0].message == "all good"
 
 
 def test_try_parse_needs_sanitization():
@@ -92,6 +96,8 @@ def test_try_parse_needs_sanitization():
     result = InlineCommentService.try_parse_model_output(raw)
     assert result is not None
     assert result.root[0].file == "bad.py"
+    assert result.root[0].line == 2
+    assert result.root[0].message == "line1\nline2"
     assert "line1" in result.root[0].message
 
 

{xai_review-0.10.0 → xai_review-0.12.0}/pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"
 [project]
 name = "xai-review"
 readme = "README.md"
-version = "0.10.0"
+version = "0.12.0"
 license = { text = "Apache-2.0" }
 authors = [
     { name = "Nikita Filonov", email = "nikita.filonov@example.com" }

{xai_review-0.10.0 → xai_review-0.12.0}/xai_review.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: xai-review
-Version: 0.10.0
+Version: 0.12.0
 Summary: AI-powered code review tool
 Author-email: Nikita Filonov <nikita.filonov@example.com>
 Maintainer-email: Nikita Filonov <nikita.filonov@example.com>

{xai_review-0.10.0 → xai_review-0.12.0}/xai_review.egg-info/SOURCES.txt

@@ -102,6 +102,7 @@ ai_review/services/prompt/__init__.py
 ai_review/services/prompt/adapter.py
 ai_review/services/prompt/schema.py
 ai_review/services/prompt/service.py
+ai_review/services/prompt/tools.py
 ai_review/services/review/__init__.py
 ai_review/services/review/service.py
 ai_review/services/review/inline/__init__.py
@@ -151,6 +152,7 @@ ai_review/tests/suites/services/diff/test_tools.py
 ai_review/tests/suites/services/prompt/__init__.py
 ai_review/tests/suites/services/prompt/test_schema.py
 ai_review/tests/suites/services/prompt/test_service.py
+ai_review/tests/suites/services/prompt/test_tools.py
 ai_review/tests/suites/services/review/__init__.py
 ai_review/tests/suites/services/review/inline/__init__.py
 ai_review/tests/suites/services/review/inline/test_schema.py

xai_review-0.10.0/ai_review/libs/json.py

@@ -1,19 +0,0 @@
-import re
-
-CONTROL_CHARS_RE = re.compile(r"[\x00-\x1F]")
-
-
-def sanitize_json_string(raw: str) -> str:
-    def replace(match: re.Match) -> str:
-        char = match.group()
-        match char:
-            case "\n":
-                return "\\n"
-            case "\r":
-                return "\\r"
-            case "\t":
-                return "\\t"
-            case _:
-                return f"\\u{ord(char):04x}"
-
-    return CONTROL_CHARS_RE.sub(replace, raw)