webtap-tool 0.1.3__tar.gz → 0.1.4__tar.gz

{webtap_tool-0.1.3 → webtap_tool-0.1.4}/CHANGELOG.md

@@ -15,6 +15,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Removed
 
+## [0.1.4] - 2025-09-08
+
+### Added
+- Request timeout handling (3 seconds) in Chrome extension for better error detection
+- Comprehensive `cleanup()` method for proper resource management on exit
+- `atexit` registration to ensure cleanup happens even on unexpected termination
+
+### Changed
+- **API Consolidation**: Merged `/pages` and `/instance` endpoints into single `/info` endpoint
+- Enhanced `/status` endpoint to include fetch details inline (eliminates separate API call)
+- Improved error messages in extension to distinguish between timeout, server not running, and other failures
+- API server shutdown now uses `asyncio.run()` for proper task cleanup
+
+### Fixed
+- Graceful shutdown issue that left zombie tasks with "Task was destroyed but it is pending" error
+- API server cleanup on application exit now properly cancels all async tasks
+- Extension error handling now provides specific feedback for different failure modes
+
+### Removed
+- `/instance` endpoint (functionality merged into `/info`)
+- `/fetch/paused` endpoint (data now included in `/status` response)
+
 ## [0.1.3] - 2025-09-05
 
 ### Added

{webtap_tool-0.1.3 → webtap_tool-0.1.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: webtap-tool
-Version: 0.1.3
+Version: 0.1.4
 Summary: Terminal-based web page inspector for AI debugging sessions
 Author-email: Fredrik Angelsen <fredrikangelsen@gmail.com>
 Classifier: Development Status :: 3 - Alpha

{webtap_tool-0.1.3 → webtap_tool-0.1.4}/extension/popup.js

@@ -1,14 +1,28 @@
 // API helper - communicate with WebTap service
 async function api(endpoint, method = "GET", body = null) {
   try {
-    const opts = { method };
+    const opts = { 
+      method,
+      // Add timeout to detect unresponsive server faster
+      signal: AbortSignal.timeout(3000)
+    };
     if (body) {
       opts.headers = { "Content-Type": "application/json" };
       opts.body = JSON.stringify(body);
     }
     const resp = await fetch(`http://localhost:8765${endpoint}`, opts);
+    if (!resp.ok) {
+      return { error: `HTTP ${resp.status}: ${resp.statusText}` };
+    }
     return await resp.json();
   } catch (e) {
+    // Better error messages
+    if (e.name === 'AbortError') {
+      return { error: "WebTap not responding (timeout)" };
+    }
+    if (e.message.includes('Failed to fetch')) {
+      return { error: "WebTap not running" };
+    }
     return { error: e.message };
   }
 }
@@ -17,22 +31,20 @@ async function api(endpoint, method = "GET", body = null) {
 
 // Load available pages from WebTap
 async function loadPages() {
-  const result = await api("/pages");
-
-  if (result.error) {
+  // Use combined /info endpoint for single round trip
+  const info = await api("/info");
+  
+  if (info.error) {
     document.getElementById("pageList").innerHTML =
-      "<option disabled>WebTap not running</option>";
+      `<option disabled>${info.error === "WebTap not initialized" ? "WebTap not running" : "Error loading pages"}</option>`;
     return;
   }
 
-  // Also fetch instance info if available
-  const instanceInfo = await api("/instance");
-  if (instanceInfo && !instanceInfo.error) {
-    document.getElementById("switchInstance").title =
-      `PID: ${instanceInfo.pid} | Events: ${instanceInfo.events}`;
-  }
+  // Update instance info tooltip
+  document.getElementById("switchInstance").title =
+    `PID: ${info.pid} | Events: ${info.events}`;
 
-  const pages = result.pages || [];
+  const pages = info.pages || [];
   const select = document.getElementById("pageList");
 
   select.innerHTML = "";
@@ -296,13 +308,12 @@ async function updateStatus() {
       document.getElementById("status").innerHTML =
         `<span class="connected">Connected</span> - Events: ${status.events}`;
 
-      // Get fetch details if enabled
-      if (status.fetch_enabled) {
-        const fetchDetails = await api("/fetch/paused");
+      // Use fetch details from enhanced status (no extra API call needed)
+      if (status.fetch_enabled && status.fetch_details) {
         updateFetchStatus(
           true,
-          status.paused_requests || 0,
-          fetchDetails.response_stage || false,
+          status.fetch_details.paused_count || 0,
+          status.fetch_details.response_stage || false,
         );
       } else {
         updateFetchStatus(false);

{webtap_tool-0.1.3 → webtap_tool-0.1.4}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "webtap-tool"
-version = "0.1.3"
+version = "0.1.4"
 description = "Terminal-based web page inspector for AI debugging sessions"
 readme = "README.md"
 authors = [

{webtap_tool-0.1.3 → webtap_tool-0.1.4}/src/webtap/__init__.py

@@ -9,6 +9,7 @@ PUBLIC API:
   - main: Entry point function for CLI
 """
 
+import atexit
 import sys
 import logging
 
@@ -45,12 +46,15 @@ def main():
 
 
 def _start_api_server_safely():
-    """Start API server with error handling."""
+    """Start API server with error handling and cleanup registration."""
     try:
         thread = start_api_server(app.state)
         if thread and app.state:
             app.state.api_thread = thread
             logger.info("API server started on port 8765")
+
+            # Register cleanup to shut down API server on exit
+            atexit.register(lambda: app.state.cleanup() if app.state else None)
         else:
             logger.info("Port 8765 in use by another instance")
     except Exception as e:

{webtap_tool-0.1.3 → webtap_tool-0.1.4}/src/webtap/api.py

@@ -50,22 +50,54 @@ api.add_middleware(
 app_state = None
 
 
-@api.get("/pages")
-async def list_pages() -> Dict[str, Any]:
-    """List available Chrome pages for extension selection."""
+@api.get("/health")
+async def health_check() -> Dict[str, Any]:
+    """Quick health check endpoint for extension."""
+    return {"status": "ok", "pid": os.getpid()}
+
+
+@api.get("/info")
+async def get_info() -> Dict[str, Any]:
+    """Combined endpoint for pages and instance info - reduces round trips."""
     if not app_state:
-        return {"error": "WebTap not initialized", "pages": []}
+        return {"error": "WebTap not initialized", "pages": [], "pid": os.getpid()}
+
+    # Get pages
+    pages_data = app_state.service.list_pages()
+
+    # Get instance info
+    connected_to = None
+    if app_state.cdp.is_connected and app_state.cdp.page_info:
+        connected_to = app_state.cdp.page_info.get("title", "Untitled")
 
-    return app_state.service.list_pages()
+    return {
+        "pid": os.getpid(),
+        "connected_to": connected_to,
+        "events": app_state.service.event_count,
+        "pages": pages_data.get("pages", []),
+        "error": pages_data.get("error"),
+    }
 
 
 @api.get("/status")
 async def get_status() -> Dict[str, Any]:
-    """Get current connection status and event count."""
+    """Get comprehensive status including connection, events, and fetch details."""
     if not app_state:
         return {"connected": False, "error": "WebTap not initialized", "events": 0}
 
-    return app_state.service.get_status()
+    status = app_state.service.get_status()
+
+    # Add fetch details if fetch is enabled
+    if status.get("fetch_enabled"):
+        fetch_service = app_state.service.fetch
+        paused_list = fetch_service.get_paused_list()
+        status["fetch_details"] = {
+            "paused_requests": paused_list,
+            "paused_count": len(paused_list),
+            "response_stage": fetch_service.enable_response_stage,
+        }
+
+    return status
 
 
 @api.post("/connect")
@@ -108,25 +140,6 @@ async def set_fetch_interception(request: FetchRequest) -> Dict[str, Any]:
     return result
 
 
-@api.get("/fetch/paused")
-async def get_paused_requests() -> Dict[str, Any]:
-    """Get list of currently paused fetch requests."""
-    if not app_state:
-        return {"error": "WebTap not initialized", "requests": []}
-
-    fetch_service = app_state.service.fetch
-    if not fetch_service.enabled:
-        return {"enabled": False, "requests": []}
-
-    paused_list = fetch_service.get_paused_list()
-    return {
-        "enabled": True,
-        "requests": paused_list,
-        "count": len(paused_list),
-        "response_stage": fetch_service.enable_response_stage,
-    }
-
-
 @api.get("/filters/status")
 async def get_filter_status() -> Dict[str, Any]:
     """Get current filter configuration and enabled categories."""
@@ -186,19 +199,6 @@ async def disable_all_filters() -> Dict[str, Any]:
     return {"enabled": [], "total": 0}
 
 
-@api.get("/instance")
-async def get_instance_info() -> Dict[str, Any]:
-    """Get info about this WebTap instance."""
-    if not app_state:
-        return {"error": "WebTap not initialized"}
-
-    return {
-        "pid": os.getpid(),
-        "connected_to": app_state.cdp.current_page_title if app_state.cdp.is_connected else None,
-        "events": app_state.cdp.event_count,
-    }
-
-
 @api.post("/release")
 async def release_port() -> Dict[str, Any]:
     """Release API port for another WebTap instance."""
@@ -237,8 +237,9 @@ def start_api_server(state, host: str = "127.0.0.1", port: int = 8765) -> thread
         logger.info(f"Port {port} already in use")
         return None
 
-    global app_state
+    global app_state, _shutdown_requested
     app_state = state
+    _shutdown_requested = False  # Reset flag for new instance
 
     thread = threading.Thread(target=run_server, args=(host, port), daemon=True)
     thread.start()
@@ -249,7 +250,10 @@ def start_api_server(state, host: str = "127.0.0.1", port: int = 8765) -> thread
 
 def run_server(host: str, port: int):
     """Run the FastAPI server in a thread."""
-    try:
+    import asyncio
+
+    async def run():
+        """Run server with proper shutdown handling."""
         config = uvicorn.Config(
             api,
             host=host,
@@ -259,30 +263,33 @@ def run_server(host: str, port: int):
         )
         server = uvicorn.Server(config)
 
-        # Run with checking for shutdown flag
-        import asyncio
-
-        loop = asyncio.new_event_loop()
-        asyncio.set_event_loop(loop)
+        # Start server in background task
+        serve_task = asyncio.create_task(server.serve())
 
-        async def serve():
-            await server.serve()
-
-        # Start serving
-        task = loop.create_task(serve())
-
-        # Check for shutdown flag
+        # Wait for shutdown signal
         while not _shutdown_requested:
-            loop.run_until_complete(asyncio.sleep(0.1))
-            if task.done():
+            await asyncio.sleep(0.1)
+            if serve_task.done():
                 break
 
-        # Shutdown if requested
-        if _shutdown_requested:
+        # Trigger shutdown
+        if not serve_task.done():
             logger.info("API server shutting down")
             server.should_exit = True
-            loop.run_until_complete(server.shutdown())
+            # Wait a bit for graceful shutdown
+            try:
+                await asyncio.wait_for(serve_task, timeout=1.0)
+            except asyncio.TimeoutError:
+                logger.debug("Server task timeout - cancelling")
+                serve_task.cancel()
+                try:
+                    await serve_task
+                except asyncio.CancelledError:
+                    pass
 
+    try:
+        # Use asyncio.run() which properly cleans up
+        asyncio.run(run())
     except Exception as e:
         logger.error(f"API server failed: {e}")
 

{webtap_tool-0.1.3 → webtap_tool-0.1.4}/src/webtap/app.py

@@ -36,6 +36,21 @@ class WebTapState:
         """Initialize service with self reference after dataclass init."""
         self.service = WebTapService(self)
 
+    def cleanup(self):
+        """Cleanup resources on exit."""
+        # Disconnect CDP if connected
+        if self.cdp.is_connected:
+            self.cdp.disconnect()
+
+        # Stop API server if we own it
+        if self.api_thread and self.api_thread.is_alive():
+            # Import here to avoid circular dependency
+            import webtap.api
+
+            webtap.api._shutdown_requested = True
+            # Wait up to 1 second for graceful shutdown
+            self.api_thread.join(timeout=1.0)
+
 
 # Must be created before command imports for decorator registration
 app = App(