webchanges 3.29.0__tar.gz → 3.31.0__tar.gz

{webchanges-3.29.0/webchanges.egg-info → webchanges-3.31.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: webchanges
-Version: 3.29.0
+Version: 3.31.0
 Summary: Web Changes Delivered. AI-Summarized. Totally Anonymous.
 Author-email: Mike Borsetti <mike+webchanges@borsetti.com>
 Maintainer-email: Mike Borsetti <mike+webchanges@borsetti.com>
@@ -108,7 +108,7 @@ Requires-Dist: cssselect
 Requires-Dist: h2
 Requires-Dist: html2text
 Requires-Dist: httpx
-Requires-Dist: lxml>=5.3.0
+Requires-Dist: lxml
 Requires-Dist: markdown2
 Requires-Dist: msgpack
 Requires-Dist: platformdirs
@@ -206,8 +206,9 @@ Install **webchanges**  with:
 
 Running in Docker
 -----------------
-**webchanges** can easily run in a container and you will find a `Docker <https://www.docker.com/>`__ implementation
-`here <https://github.com/yubiuser/webchanges-docker>`__.
+**webchanges** can easily run in a `Docker <https://www.docker.com/>`__ container! You will find a minimal
+implementation (no browser) `here <https://github.com/yubiuser/webchanges-docker>`__, and one with a browser
+`here <https://github.com/jhedlund/webchanges-docker>`__.
 
 
 Documentation |readthedocs|

{webchanges-3.29.0 → webchanges-3.31.0}/README.rst

@@ -39,8 +39,9 @@ Install **webchanges**  with:
 
 Running in Docker
 -----------------
-**webchanges** can easily run in a container and you will find a `Docker <https://www.docker.com/>`__ implementation
-`here <https://github.com/yubiuser/webchanges-docker>`__.
+**webchanges** can easily run in a `Docker <https://www.docker.com/>`__ container! You will find a minimal
+implementation (no browser) `here <https://github.com/yubiuser/webchanges-docker>`__, and one with a browser
+`here <https://github.com/jhedlund/webchanges-docker>`__.
 
 
 Documentation |readthedocs|

{webchanges-3.29.0 → webchanges-3.31.0}/pyproject.toml

@@ -319,3 +319,14 @@ asyncio_default_fixture_loop_scope = 'function'
 # https://github.com/pytest-dev/pytest-cov/issues/131) and to enable running tox --parallel
 # Instead of below, now runs with $ coverage run --parallel-mode
 # addopts = --cov=./ --cov-report=term --cov-report=html
+
+
+# -------------------------- pyright --------------------------
+# Config file documentation at https://microsoft.github.io/pyright/#/configuration
+[tool.pyright]
+ignore = ['webchanges/storage_minidb.py']
+
+reportMissingImports = false
+reportMissingModuleSource = false
+reportDeprecated = true
+# reportUnnecessaryTypeIgnoreComment = true

{webchanges-3.29.0 → webchanges-3.31.0}/requirements.txt

@@ -3,7 +3,7 @@ cssselect
 h2
 html2text
 httpx
-lxml >= 5.3.0  # prior versions don't build in 3.13
+lxml
 markdown2
 msgpack
 platformdirs

{webchanges-3.29.0 → webchanges-3.31.0}/webchanges/__init__.py

@@ -15,14 +15,14 @@ from __future__ import annotations
 __min_python_version__ = (3, 10)  # minimum version of Python required to run; supported until fall 2025
 
 
-__project_name__ = __package__
+__project_name__ = str(__package__)
 # Version numbering is PEP440-compliant https://www.python.org/dev/peps/pep-0440/
 # Release numbering largely follows Semantic Versioning https://semver.org/spec/v2.0.0.html#semantic-versioning-200
 # * MAJOR version when you make incompatible API changes,
 # * MINOR version when you add functionality in a backwards compatible manner, and
 # * MICRO or PATCH version when you make backwards compatible bug fixes. We no longer use '0'
 # If unsure on increments, use pkg_resources.parse_version to parse
-__version__ = '3.29.0'
+__version__ = '3.31.0'
 __description__ = (
     'Check web (or command output) for changes since last run and notify.\n'
     '\n'

{webchanges-3.29.0 → webchanges-3.31.0}/webchanges/_vendored/headers.py

@@ -1,79 +1,94 @@
 """
-Vendored version of httpx.Headers class from httpx v0.27.0 released on 21-Feb-24
-https://github.com/encode/httpx/releases/tag/0.27.0.
+Vendored version of httpx.Headers class from httpx v0.28.1 released on 06-Dec-24
+https://github.com/encode/httpx/releases/tag/0.28.1.
+(commit https://github.com/encode/httpx/commit/26d48e0634e6ee9cdc0533996db289ce4b430177).
 
-Allows us to load this class in case httpx isn't installed.
-
-See https://github.com/psf/requests and https://github.com/encode/httpx/blob/master/httpx/_models.py
+Allows us to load this class in case httpx is not installed.
 """
 
+# Copyright © 2019, [Encode OSS Ltd](https://www.encode.io/).
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without modification, are permitted provided that the
+# following conditions are met:
+#
+# * Redistributions of source code must retain the above copyright notice, this list of conditions and the following
+#   disclaimer.
+#
+# * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following
+#   disclaimer in the documentation and/or other materials provided with the distribution.
+#
+# * Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote
+#   products derived from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
+# INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
 from __future__ import annotations
 
-from typing import (
-    Any,
-    AnyStr,
-    ItemsView,
-    Iterable,
-    Iterator,
-    KeysView,
-    Mapping,
-    MutableMapping,
-    Sequence,
-    TypeAlias,
-    ValuesView,
-)
+import typing
+from collections.abc import Mapping
 
-HeaderTypes: TypeAlias = (
-    'Headers' | Mapping[str, str] | Mapping[bytes, bytes] | Sequence[tuple[str, str]] | Sequence[tuple[bytes, bytes]]
+# from https://github.com/encode/httpx/blob/master/httpx/_types.py
+HeaderTypes: typing.TypeAlias = (
+    'Headers'
+    | typing.Mapping[str, str]
+    | typing.Mapping[bytes, bytes]
+    | typing.Sequence[tuple[str, str]]
+    | typing.Sequence[tuple[bytes, bytes]]
 )
 
 
-def normalize_header_key(
-    value: str | bytes,
-    lower: bool,
-    encoding: str | None = None,
-) -> bytes:
+# from https://github.com/encode/httpx/blob/master/httpx/_utils.py
+def to_str(value: str | bytes, encoding: str = 'utf-8') -> str:
+    return value if isinstance(value, str) else value.decode(encoding)  # pyright: ignore[reportAttributeAccessIssue]
+
+
+def to_bytes_or_str(value: str, match_type_of: typing.AnyStr) -> typing.AnyStr:
+    return value if isinstance(match_type_of, str) else value.encode()  # pyright: ignore[reportReturnType]
+
+
+# from https://github.com/encode/httpx/blob/master/httpx/_models.py
+SENSITIVE_HEADERS = {'authorization', 'proxy-authorization'}
+
+
+def _normalize_header_key(key: str | bytes, encoding: str | None = None) -> bytes:
     """
     Coerce str/bytes into a strictly byte-wise HTTP header key.
     """
-    if isinstance(value, bytes):
-        bytes_value = value
-    else:
-        bytes_value = value.encode(encoding or 'ascii')
+    return (
+        key
+        if isinstance(key, bytes)
+        else key.encode(encoding or 'ascii')  # pyright: ignore[reportAttributeAccessIssue]
+    )
 
-    return bytes_value.lower() if lower else bytes_value
 
-
-def normalize_header_value(value: str | bytes, encoding: str | None = None) -> bytes:
+def _normalize_header_value(value: str | bytes, encoding: str | None = None) -> bytes:
     """
     Coerce str/bytes into a strictly byte-wise HTTP header value.
     """
     if isinstance(value, bytes):
         return value
+    if not isinstance(value, str):
+        raise TypeError(f'Header value must be str or bytes, not {type(value)}')
     return value.encode(encoding or 'ascii')
 
 
-SENSITIVE_HEADERS = {'authorization', 'proxy-authorization'}
-
-
-def obfuscate_sensitive_headers(
-    items: Iterable[tuple[AnyStr, AnyStr]],
-) -> Iterator[tuple[AnyStr, AnyStr]]:
+def _obfuscate_sensitive_headers(
+    items: typing.Iterable[tuple[typing.AnyStr, typing.AnyStr]],
+) -> typing.Iterator[tuple[typing.AnyStr, typing.AnyStr]]:
     for k, v in items:
         if to_str(k.lower()) in SENSITIVE_HEADERS:
             v = to_bytes_or_str('[secure]', match_type_of=v)
         yield k, v
 
 
-def to_str(value: str | bytes, encoding: str = 'utf-8') -> str:
-    return value if isinstance(value, str) else value.decode(encoding)
-
-
-def to_bytes_or_str(value: str, match_type_of: AnyStr) -> AnyStr:
-    return value if isinstance(match_type_of, str) else value.encode()
-
-
-class Headers(MutableMapping[str, str]):
+class Headers(typing.MutableMapping[str, str]):
     """
     HTTP headers, as a case-insensitive multi-dict.
     """
@@ -83,28 +98,20 @@ class Headers(MutableMapping[str, str]):
         headers: HeaderTypes | None = None,
         encoding: str | None = None,
     ) -> None:
-        if headers is None:
-            self._list: list[tuple[bytes, bytes, bytes]] = []
-        elif isinstance(headers, Headers):
+        self._list: list[tuple[bytes, bytes, bytes]] = []
+
+        if isinstance(headers, Headers):
             self._list = list(headers._list)
         elif isinstance(headers, Mapping):
-            self._list = [
-                (
-                    normalize_header_key(k, lower=False, encoding=encoding),
-                    normalize_header_key(k, lower=True, encoding=encoding),
-                    normalize_header_value(v, encoding),
-                )
-                for k, v in headers.items()
-            ]
-        else:
-            self._list = [
-                (
-                    normalize_header_key(k, lower=False, encoding=encoding),
-                    normalize_header_key(k, lower=True, encoding=encoding),
-                    normalize_header_value(v, encoding),
-                )
-                for k, v in headers
-            ]
+            for k, v in headers.items():
+                bytes_key = _normalize_header_key(k, encoding)
+                bytes_value = _normalize_header_value(v, encoding)
+                self._list.append((bytes_key, bytes_key.lower(), bytes_value))
+        elif headers is not None:
+            for k, v in headers:
+                bytes_key = _normalize_header_key(k, encoding)
+                bytes_value = _normalize_header_value(v, encoding)
+                self._list.append((bytes_key, bytes_key.lower(), bytes_value))
 
         self._encoding = encoding
 
@@ -144,10 +151,10 @@ class Headers(MutableMapping[str, str]):
         """
         return [(raw_key, value) for raw_key, _, value in self._list]
 
-    def keys(self) -> KeysView[str]:
+    def keys(self) -> typing.KeysView[str]:
         return {key.decode(self.encoding): None for _, key, value in self._list}.keys()
 
-    def values(self) -> ValuesView[str]:
+    def values(self) -> typing.ValuesView[str]:
         values_dict: dict[str, str] = {}
         for _, key, value in self._list:
             str_key = key.decode(self.encoding)
@@ -158,7 +165,7 @@ class Headers(MutableMapping[str, str]):
                 values_dict[str_key] = str_value
         return values_dict.values()
 
-    def items(self) -> ItemsView[str, str]:
+    def items(self) -> typing.ItemsView[str, str]:
         """
         Return `(key, value)` items of headers. Concatenate headers
         into a single comma separated value when a key occurs multiple times.
@@ -181,7 +188,7 @@ class Headers(MutableMapping[str, str]):
         """
         return [(key.decode(self.encoding), value.decode(self.encoding)) for _, key, value in self._list]
 
-    def get(self, key: str, default: Any = None) -> Any:
+    def get(self, key: str, default: typing.Any = None) -> typing.Any:
         """
         Return a header value. If multiple occurrences of the header occur
         then concatenate them together with commas.
@@ -208,9 +215,9 @@ class Headers(MutableMapping[str, str]):
         if not split_commas:
             return values
 
-        split_values: list[str] = []
+        split_values = []
         for value in values:
-            split_values.extend((item.strip() for item in value.split(',')))
+            split_values.extend([item.strip() for item in value.split(',')])
         return split_values
 
     def update(self, headers: HeaderTypes | None = None) -> None:  # type: ignore[override]
@@ -277,17 +284,17 @@ class Headers(MutableMapping[str, str]):
         for idx in reversed(pop_indexes):
             del self._list[idx]
 
-    def __contains__(self, key: Any) -> bool:
+    def __contains__(self, key: typing.Any) -> bool:
         header_key = key.lower().encode(self.encoding)
         return header_key in [key for _, key, _ in self._list]
 
-    def __iter__(self) -> Iterator[Any]:
+    def __iter__(self) -> typing.Iterator[typing.Any]:
         return iter(self.keys())
 
     def __len__(self) -> int:
         return len(self._list)
 
-    def __eq__(self, other: Any) -> bool:
+    def __eq__(self, other: typing.Any) -> bool:
         try:
             other_headers = Headers(other)
         except ValueError:
@@ -304,7 +311,7 @@ class Headers(MutableMapping[str, str]):
         if self.encoding != 'ascii':
             encoding_str = f', encoding={self.encoding!r}'
 
-        as_list = list(obfuscate_sensitive_headers(self.multi_items()))
+        as_list = list(_obfuscate_sensitive_headers(self.multi_items()))
         as_dict = dict(as_list)
 
         no_duplicate_keys = len(as_dict) == len(as_list)

{webchanges-3.29.0 → webchanges-3.31.0}/webchanges/_vendored/packaging_version.py

@@ -1,6 +1,8 @@
 """
-Vendored version of packaging.version.parse() from packaging v23.2 released on 01-Oct-23
-(commit https://github.com/pypa/packaging/commit/7e4f2588923e647bb7c3d5b350473e39e4b279d4).
+Vendored version of packaging.version.parse() from packaging v24.2 released on 08-Nov-24
+(commit https://github.com/pypa/packaging/commit/d8e3b31b734926ebbcaff654279f6855a73e052f).
+
+Allows us to load this class in case packaging is not installed.
 
 See https://github.com/pypa/packaging and https://github.com/pypa/packaging/blob/main/src/packaging/version.py.
 
@@ -309,7 +311,7 @@ class _Version(NamedTuple):
     local: LocalType | None
 
 
-def parse(version: str) -> 'Version':
+def parse(version: str) -> Version:
     """Parse the given version string.
     >>> parse('1.0.dev1')
     <Version('1.0.dev1')>
@@ -321,7 +323,7 @@ def parse(version: str) -> 'Version':
 
 class InvalidVersion(ValueError):
     """Raised when a version string is not a valid version.
-    >>> Version("invalid")
+    >>> Version('invalid')
     Traceback (most recent call last):
     ...
     packaging.version.InvalidVersion: Invalid version: 'invalid'
@@ -354,13 +356,13 @@ class _BaseVersion:
 
         return self._key == other._key
 
-    def __ge__(self, other: '_BaseVersion') -> bool:
+    def __ge__(self, other: _BaseVersion) -> bool:
         if not isinstance(other, _BaseVersion):
             return NotImplemented
 
         return self._key >= other._key
 
-    def __gt__(self, other: '_BaseVersion') -> bool:
+    def __gt__(self, other: _BaseVersion) -> bool:
         if not isinstance(other, _BaseVersion):
             return NotImplemented
 
@@ -423,8 +425,8 @@ class Version(_BaseVersion):
 
     A :class:`Version` instance is comparison aware and can be compared and sorted using the standard Python interfaces.
 
-    >>> v1 = Version("1.0a5")
-    >>> v2 = Version("1.0")
+    >>> v1 = Version('1.0a5')
+    >>> v2 = Version('1.0')
     >>> v1
     <Version('1.0a5')>
     >>> v2
@@ -457,7 +459,7 @@ class Version(_BaseVersion):
         # Validate the version and parse it into pieces
         match = self._regex.search(version)
         if not match:
-            raise InvalidVersion(f"Invalid version: '{version}'")
+            raise InvalidVersion(f'Invalid version: {version!r}')
 
         # Store the parsed out pieces of the version
         self._version = _Version(
@@ -488,9 +490,9 @@ class Version(_BaseVersion):
         return f"<Version('{self}')>"
 
     def __str__(self) -> str:
-        """A string representation of the version that can be rounded-tripped.
+        """A string representation of the version that can be round-tripped.
 
-        >>> str(Version("1.0a5"))
+        >>> str(Version('1.0a5'))
         '1.0a5'
         """
         parts = []
@@ -524,9 +526,9 @@ class Version(_BaseVersion):
     def epoch(self) -> int:
         """The epoch of the version.
 
-        >>> Version("2.0.0").epoch
+        >>> Version('2.0.0').epoch
         0
-        >>> Version("1!2.0.0").epoch
+        >>> Version('1!2.0.0').epoch
         1
         """
         return self._version.epoch
@@ -535,11 +537,11 @@ class Version(_BaseVersion):
     def release(self) -> tuple[int, ...]:
         """The components of the "release" segment of the version.
 
-        >>> Version("1.2.3").release
+        >>> Version('1.2.3').release
         (1, 2, 3)
-        >>> Version("2.0.0").release
+        >>> Version('2.0.0').release
         (2, 0, 0)
-        >>> Version("1!2.0.0.post0").release
+        >>> Version('1!2.0.0.post0').release
         (2, 0, 0)
 
         Includes trailing zeroes but not the epoch or any pre-release / development / post-release suffixes.
@@ -550,13 +552,13 @@ class Version(_BaseVersion):
     def pre(self) -> tuple[str, int] | None:
         """The pre-release segment of the version.
 
-        >>> print(Version("1.2.3").pre)
+        >>> print(Version('1.2.3').pre)
         None
-        >>> Version("1.2.3a1").pre
+        >>> Version('1.2.3a1').pre
         ('a', 1)
-        >>> Version("1.2.3b1").pre
+        >>> Version('1.2.3b1').pre
         ('b', 1)
-        >>> Version("1.2.3rc1").pre
+        >>> Version('1.2.3rc1').pre
         ('rc', 1)
         """
         return self._version.pre
@@ -565,9 +567,9 @@ class Version(_BaseVersion):
     def post(self) -> int | None:
         """The post-release number of the version.
 
-        >>> print(Version("1.2.3").post)
+        >>> print(Version('1.2.3').post)
         None
-        >>> Version("1.2.3.post1").post
+        >>> Version('1.2.3.post1').post
         1
         """
         return self._version.post[1] if self._version.post else None
@@ -576,9 +578,9 @@ class Version(_BaseVersion):
     def dev(self) -> int | None:
         """The development number of the version.
 
-        >>> print(Version("1.2.3").dev)
+        >>> print(Version('1.2.3').dev)
         None
-        >>> Version("1.2.3.dev1").dev
+        >>> Version('1.2.3.dev1').dev
         1
         """
         return self._version.dev[1] if self._version.dev else None
@@ -587,9 +589,9 @@ class Version(_BaseVersion):
     def local(self) -> str | None:
         """The local version segment of the version.
 
-        >>> print(Version("1.2.3").local)
+        >>> print(Version('1.2.3').local)
         None
-        >>> Version("1.2.3+abc").local
+        >>> Version('1.2.3+abc').local
         'abc'
         """
         if self._version.local:
@@ -601,12 +603,12 @@ class Version(_BaseVersion):
     def public(self) -> str:
         """The public portion of the version.
 
-        >>> Version("1.2.3").public
-        '1.2.3'
-        >>> Version("1.2.3+abc").public
+        >>> Version('1.2.3').public
         '1.2.3'
-        >>> Version("1.2.3+abc.dev1").public
+        >>> Version('1.2.3+abc').public
         '1.2.3'
+        >>> Version('1!1.2.3dev1+abc').public
+        '1!1.2.3.dev1'
         """
         return str(self).split('+', 1)[0]
 
@@ -614,11 +616,11 @@ class Version(_BaseVersion):
     def base_version(self) -> str:
         """The "base version" of the version.
 
-        >>> Version("1.2.3").base_version
+        >>> Version('1.2.3').base_version
         '1.2.3'
-        >>> Version("1.2.3+abc").base_version
+        >>> Version('1.2.3+abc').base_version
         '1.2.3'
-        >>> Version("1!1.2.3+abc.dev1").base_version
+        >>> Version('1!1.2.3dev1+abc').base_version
         '1!1.2.3'
 
         The "base version" is the public version of the project without any pre or post release markers.
@@ -638,15 +640,15 @@ class Version(_BaseVersion):
     def is_prerelease(self) -> bool:
         """Whether this version is a pre-release.
 
-        >>> Version("1.2.3").is_prerelease
+        >>> Version('1.2.3').is_prerelease
         False
-        >>> Version("1.2.3a1").is_prerelease
+        >>> Version('1.2.3a1').is_prerelease
         True
-        >>> Version("1.2.3b1").is_prerelease
+        >>> Version('1.2.3b1').is_prerelease
         True
-        >>> Version("1.2.3rc1").is_prerelease
+        >>> Version('1.2.3rc1').is_prerelease
         True
-        >>> Version("1.2.3dev1").is_prerelease
+        >>> Version('1.2.3dev1').is_prerelease
         True
         """
         return self.dev is not None or self.pre is not None
@@ -655,9 +657,9 @@ class Version(_BaseVersion):
     def is_postrelease(self) -> bool:
         """Whether this version is a post-release.
 
-        >>> Version("1.2.3").is_postrelease
+        >>> Version('1.2.3').is_postrelease
         False
-        >>> Version("1.2.3.post1").is_postrelease
+        >>> Version('1.2.3.post1').is_postrelease
         True
         """
         return self.post is not None
@@ -666,9 +668,9 @@ class Version(_BaseVersion):
     def is_devrelease(self) -> bool:
         """Whether this version is a development release.
 
-        >>> Version("1.2.3").is_devrelease
+        >>> Version('1.2.3').is_devrelease
         False
-        >>> Version("1.2.3.dev1").is_devrelease
+        >>> Version('1.2.3.dev1').is_devrelease
         True
         """
         return self.dev is not None
@@ -677,7 +679,7 @@ class Version(_BaseVersion):
     def major(self) -> int:
         """The first item of :attr:`release` or ``0`` if unavailable.
 
-        >>> Version("1.2.3").major
+        >>> Version('1.2.3').major
         1
         """
         return self.release[0] if len(self.release) >= 1 else 0
@@ -686,9 +688,9 @@ class Version(_BaseVersion):
     def minor(self) -> int:
         """The second item of :attr:`release` or ``0`` if unavailable.
 
-        >>> Version("1.2.3").minor
+        >>> Version('1.2.3').minor
         2
-        >>> Version("1").minor
+        >>> Version('1').minor
         0
         """
         return self.release[1] if len(self.release) >= 2 else 0
@@ -697,9 +699,9 @@ class Version(_BaseVersion):
     def micro(self) -> int:
         """The third item of :attr:`release` or ``0`` if unavailable.
 
-        >>> Version("1.2.3").micro
+        >>> Version('1.2.3').micro
         3
-        >>> Version("1").micro
+        >>> Version('1').micro
         0
         """
         return self.release[2] if len(self.release) >= 3 else 0
@@ -726,9 +728,11 @@ def _parse_letter_version(letter: str | None, number: str | bytes | SupportsInt
             letter = 'post'
 
         return letter, int(number)
-    if not letter and number:
-        # We assume if we are given a number, but we are not given a letter then this is using the implicit post
-        # release syntax (e.g. 1.0-1)
+
+    assert not letter
+    if number:
+        # We assume if we are given a number, but we are not given a letter
+        # then this is using the implicit post release syntax (e.g. 1.0-1)
         letter = 'post'
 
         return letter, int(number)
@@ -741,7 +745,7 @@ _local_version_separators = re.compile(r'[\._-]')
 
 def _parse_local_version(local: str | None) -> LocalType | None:
     """
-    Takes a string like abc.1.twelve and turns it into ("abc", 1, "twelve").
+    Takes a string like abc.1.twelve and turns it into ('abc', 1, 'twelve').
     """
     if local is not None:
         return tuple(