walla-cli 0.1.11__tar.gz → 0.1.13__tar.gz

{walla_cli-0.1.11 → walla_cli-0.1.13}/AGENTS.md

@@ -57,7 +57,9 @@ Ranks: models 10 → exceptions 15 → http 20 → core 30 → search/account/hu
 
 - **Do** keep files <= 250 LOC.
 - **Do** fail closed; typed `error_type`.
-- **Do** require `--yes` for bare say/offer/sell/unsell. `pursue` and `desk` send negotiation chat without a per-message prompt. Never pay.
+- **Do** require `--yes` for bare say/offer/sell/unsell/edit. `pursue` and `desk` send negotiation chat without a per-message prompt. Never pay.
+- **Do** use `walla edit <id> --eur N --yes` to change price/desc (no unsell+republish).
+- **Do** pass leaf id or `motor accesorios` when `--category Accesorios` is ambiguous.
 - **Don't** commit session.json, cookies, or tokens.
 - **Don't** invent wire shapes without a fixture.
 - **Don't** post buyer offers as `{item_id, amount, currency}` (HTTP 400).
@@ -65,3 +67,5 @@ Ranks: models 10 → exceptions 15 → http 20 → core 30 → search/account/hu
 - **Don't** create listings without `Accept: application/vnd.upload-v2+json`
   (HTTP 405). Use `walla sell` / `fixtures/sell_item_request.json`.
 - **Don't** require `.env` credentials; login is cookie paste.
+- **Don't** leave a sticky `must_match` from a prior hunt; clear with
+  `walla setup --must ''` or expect `mandate_note` soft shortlist fallback.

{walla_cli-0.1.11 → walla_cli-0.1.13}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: walla-cli
-Version: 0.1.11
+Version: 0.1.13
 Summary: Wallapop.es CLI - look · offer · talk · sell for humans and agents
 Project-URL: Homepage, https://github.com/berendgort/wallapop-cli
 Project-URL: Repository, https://github.com/berendgort/wallapop-cli

{walla_cli-0.1.11 → walla_cli-0.1.13}/docs/WIRE.md

@@ -36,7 +36,8 @@ optional.
 
 After `current_step=photo`, the steps `draft` may include `category_leaf_id`
 (title+photo hint). `GET /api/v3/suggested-item-data/{upload_id}` often returns
-empty HTTP 200; still poll before `loading`. CLI: `walla sell … --title … --suggest`.
+empty HTTP 200; still poll before `loading`. CLI: `walla sell … --title …
+--suggest` (explicit only; draft without `--suggest` does not upload).
 `walla desk --watch` polls the inbox until `stack.best` converges.
 
 ## Auth
@@ -80,14 +81,25 @@ Browser: `https://es.wallapop.com/app/catalog/upload/consumer-goods`.
 8. Create: `POST /api/v3/items` multipart `image` + `item` (JSON string).
    Header **`Accept: application/vnd.upload-v2+json`** (without it → HTTP 405).
    Extra photos: `POST /api/v3/items/{id}/picture2` multipart `image` + `order`.
-9. Delete: `DELETE /api/v3/items/{id}` → 204.
+9. Edit owned item: `PUT /api/v3/items/{id}` JSON body (same attribute shape as
+   create, plus `pictures: [{id, order}]`). Headers: Bearer,
+   **`Accept: application/vnd.upload-v2+json`**, **`X-Signature`** +
+   **`Timestamp`** (HMAC of `PUT|{absolute_url}|{ts_ms}|`). HTTP **204**.
+   Fixture: `fixtures/edit_item_request.json` / `walla.account.sell_edit_wire`.
+   CLI: `walla edit <id> --eur N --desc '…' --yes`.
+10. Delete: `DELETE /api/v3/items/{id}` → 204.
 
 Fixture: `fixtures/sell_item_request.json` / `walla.account.sell_wire.build_item_body`.
+HEIC/HEIF sell photos are converted to JPEG via ImageMagick (`magick`/`convert`)
+in `walla.account.sell_photos` before upload.
 
 Every CLI call (method, path, auth, body) is listed in `fixtures/wire_contracts.json`.
 `scripts/check_code_quality.py` fails if `walla/account`, `walla/search`, or `walla/http`
 grows a `/api/` or `/bff/` literal that the catalog does not list.
 CLI: `walla sell photo.jpg … --yes` (draft without `--yes`).
+Bare `Accesorios` is ambiguous across Motor / Cocina — pass leaf id or
+`motor accesorios`. Sticky `must_match` that empties a shortlist triggers a soft
+fallback + `mandate_note` (`walla setup --must ''` to clear).
 
 Writes that fail closed as `error_type: unsupported` until fixtures exist.
 

{walla_cli-0.1.11 → walla_cli-0.1.13}/fixtures/categories.json

@@ -35,6 +35,42 @@
               ]
             }
           ]
+        },
+        {
+          "id": 12484,
+          "name": "Cocina",
+          "parent_id": 12467,
+          "subcategories": [
+            {
+              "id": 24235,
+              "name": "Accesorios",
+              "parent_id": 12484,
+              "subcategories": []
+            }
+          ]
+        }
+      ],
+      "category_leaf_selection_mandatory": false
+    },
+    {
+      "id": 12800,
+      "name": "Motor y accesorios",
+      "path": "",
+      "vertical_id": "consumer_goods",
+      "icon": "engine",
+      "subcategories": [
+        {
+          "id": 10167,
+          "name": "Recambios de coches y furgonetas",
+          "parent_id": 12800,
+          "subcategories": [
+            {
+              "id": 10328,
+              "name": "Accesorios",
+              "parent_id": 10167,
+              "subcategories": []
+            }
+          ]
         }
       ],
       "category_leaf_selection_mandatory": false

walla_cli-0.1.13/fixtures/edit_item_request.json

@@ -0,0 +1,49 @@
+{
+  "endpoint": "PUT /api/v3/items/{id}",
+  "accept": "application/vnd.upload-v2+json",
+  "auth": "Bearer + X-Signature + Timestamp",
+  "signature": {
+    "message": "PUT|{absolute_url}|{timestamp_ms}|",
+    "note": "HMAC-SHA256 with Wallapop consumer key; required for edit"
+  },
+  "required_keys": [
+    "attributes",
+    "category_leaf_id",
+    "apply_discount",
+    "delivery",
+    "location",
+    "pictures"
+  ],
+  "attribute_required_keys": [
+    "title",
+    "description",
+    "price_amount",
+    "condition"
+  ],
+  "example": {
+    "attributes": {
+      "title": "TEST walla CLI edit - borrar",
+      "description": "Anuncio de prueba edit. NO COMPRAR.",
+      "price_amount": 9,
+      "condition": "good"
+    },
+    "category_leaf_id": "10105",
+    "apply_discount": false,
+    "delivery": {
+      "allowed_by_user": false,
+      "max_weight_kg": null,
+      "cost_configuration_id": null
+    },
+    "location": {
+      "latitude": 41.3874,
+      "longitude": 2.1686,
+      "approximated": true
+    },
+    "pictures": [
+      {
+        "id": 0,
+        "order": 0
+      }
+    ]
+  }
+}

{walla_cli-0.1.11 → walla_cli-0.1.13}/fixtures/wire_contracts.json

@@ -197,6 +197,19 @@
       "multipart": ["image", "order"],
       "ok_status": [200, 201, 204]
     },
+    {
+      "id": "sell_edit",
+      "cli": "edit",
+      "method": "PUT",
+      "path": "/api/v3/items/{id}",
+      "needle": "/api/v3/items/",
+      "auth": true,
+      "accept": "application/vnd.upload-v2+json",
+      "signed": true,
+      "ok_status": [200, 201, 204],
+      "fixture": "edit_item_request.json",
+      "known_bad": [{"status": 404, "cause": "missing X-Signature / upload-v2 Accept"}]
+    },
     {
       "id": "unsell",
       "cli": "unsell",

{walla_cli-0.1.11 → walla_cli-0.1.13}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "walla-cli"
-version = "0.1.11"
+version = "0.1.13"
 description = "Wallapop.es CLI - look · offer · talk · sell for humans and agents"
 authors = [{ name = "Dr. Berend Gort", email = "berend.gort@gmail.com" }]
 readme = "README.md"

{walla_cli-0.1.11 → walla_cli-0.1.13}/skills/walla-sell/SKILL.md

@@ -17,8 +17,9 @@ walla categories --find escritorio --json
 walla sell ./shot1.jpg ./shot2.jpg --title "Escritorio madera" --suggest --json
 ```
 
-`--suggest` (or draft with `--title` and no `--category`) asks Wallapop to prefill
-`category_leaf_id` from title+photos. Ask remaining `data.questions`, then:
+`--suggest` uploads photos and asks Wallapop to prefill `category_leaf_id`.
+Draft without `--suggest` stays local (no upload). Ask remaining
+`data.questions`, then:
 
 ```bash
 walla sell ./shot1.jpg ./shot2.jpg \

{walla_cli-0.1.11 → walla_cli-0.1.13}/tests/test_categories_find.py

@@ -48,6 +48,17 @@ def test_pick_by_name_and_id() -> None:
     assert forced.root_id == "12579"
 
 
+def test_accesorios_ambiguous_unless_disambiguated() -> None:
+    roots = _roots()
+    with pytest.raises(ValueError, match="ambiguous"):
+        pick_sell_category(roots, category="Accesorios")
+    motor = pick_sell_category(roots, category="motor accesorios")
+    assert motor.leaf_id == "10328"
+    assert motor.root_id == "12800"
+    by_id = pick_sell_category(roots, category="10328")
+    assert by_id.leaf_id == "10328"
+
+
 def test_find_empty_and_unknown() -> None:
     with pytest.raises(ValueError, match="empty"):
         find_categories(_roots(), "   ")

walla_cli-0.1.13/tests/test_edit.py

@@ -0,0 +1,94 @@
+"""Edit-item fixture + soft shortlist / HEIC prep."""
+
+from __future__ import annotations
+
+import json
+from pathlib import Path
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from walla.account.sell_edit_wire import assert_edit_body, build_edit_body
+from walla.account.sell_photos import prepare_sell_photos
+from walla.http.sign import sign_request
+from walla.hunter.shortlist import soft_shortlist
+
+ROOT = Path(__file__).resolve().parents[1]
+FIX = ROOT / "fixtures" / "edit_item_request.json"
+
+
+def test_edit_fixture_matches_builder() -> None:
+    meta = json.loads(FIX.read_text(encoding="utf-8"))
+    example = meta["example"]
+    assert_edit_body(example)
+    body = build_edit_body(
+        title=example["attributes"]["title"],
+        description=example["attributes"]["description"],
+        price_eur=float(example["attributes"]["price_amount"]),
+        category_leaf_id=str(example["category_leaf_id"]),
+        condition=example["attributes"]["condition"],
+        lat=float(example["location"]["latitude"]),
+        lon=float(example["location"]["longitude"]),
+        pictures=list(example["pictures"]),
+        shipping=False,
+    )
+    for key in meta["required_keys"]:
+        assert key in body
+    assert body["pictures"][0]["order"] == 0
+
+
+def test_sign_request_stable() -> None:
+    sig = sign_request(
+        method="PUT",
+        url="https://api.wallapop.com/api/v3/items/abc",
+        timestamp_ms="1700000000000",
+    )
+    assert isinstance(sig, str) and len(sig) > 20
+
+
+def test_soft_shortlist_mandate_fallback() -> None:
+    rows = [
+        {
+            "id": "a",
+            "title": "ski jacket",
+            "verdict": "PASS",
+            "price": {"amount": 50},
+            "url": "https://es.wallapop.com/item/a",
+        },
+        {
+            "id": "b",
+            "title": "other",
+            "verdict": "PASS",
+            "price": {"amount": 40},
+            "url": "https://es.wallapop.com/item/b",
+        },
+    ]
+    hard, note = soft_shortlist(rows, must_match=["north", "reach"])
+    assert hard
+    assert note is not None
+    assert note["mandate_emptied"] is True
+    assert [r["id"] for r in hard] == ["b", "a"]
+
+
+def test_prepare_rejects_unknown(tmp_path: Path) -> None:
+    bad = tmp_path / "x.gif"
+    bad.write_bytes(b"GIF")
+    with pytest.raises(ValueError, match="unsupported"):
+        prepare_sell_photos([bad])
+
+
+def test_prepare_heic_uses_convert(tmp_path: Path) -> None:
+    src = tmp_path / "shot.HEIC"
+    src.write_bytes(b"heic")
+    dest = tmp_path / "shot.jpg"
+
+    def _fake_run(cmd: list[str], **_: object) -> MagicMock:
+        dest.write_bytes(b"\xff\xd8\xff\xd9")
+        return MagicMock(returncode=0, stderr="", stdout="")
+
+    with (
+        patch("walla.account.sell_photos.shutil.which", return_value="convert"),
+        patch("walla.account.sell_photos.subprocess.run", side_effect=_fake_run),
+    ):
+        out = prepare_sell_photos([src])
+    assert out == [dest]

{walla_cli-0.1.11 → walla_cli-0.1.13}/tests/test_sell.py

@@ -70,6 +70,63 @@ def test_missing_sell_fields() -> None:
     assert CONDITIONS[0] == "as_good_as_new"
 
 
+def test_sell_draft_with_title_does_not_suggest(tmp_path: Path) -> None:
+    from typer.testing import CliRunner
+
+    from walla.cli.main import app
+
+    photo = tmp_path / "a.jpg"
+    photo.write_bytes(b"\xff\xd8\xff\xd9")
+    runner = CliRunner()
+    with (
+        patch("walla.cli.cmd_sell.load_profile") as lp,
+        patch("walla.cli.cmd_sell.suggest_from_photos") as sug,
+    ):
+        profile = MagicMock()
+        profile.lat = 41.39
+        profile.lon = 2.17
+        profile.label = "BCN"
+        lp.return_value = profile
+        result = runner.invoke(
+            app, ["sell", str(photo), "--title", "Escritorio", "--json"]
+        )
+    assert result.exit_code == 0, result.output
+    sug.assert_not_called()
+    payload = json.loads(result.output)
+    assert payload["data"]["status"] == "draft"
+    assert "suggested" not in payload["data"]
+
+
+def test_publish_prepared_reuses_upload(tmp_path: Path) -> None:
+    from walla.account.sell import publish_prepared
+
+    photo = tmp_path / "a.jpg"
+    photo.write_bytes(b"\xff\xd8\xff\xd9")
+    listing = MagicMock()
+    listing.url = "https://es.wallapop.com/item/x"
+    listing.web_slug = "x"
+    with (
+        patch(
+            "walla.account.sell.create_listing",
+            return_value={"id": "abc", "flags": {}},
+        ) as create,
+        patch("walla.account.sell.get_item", return_value=listing),
+    ):
+        out = publish_prepared(
+            [photo],
+            upload_id="upload-1",
+            title="T",
+            description="D",
+            price_eur=10,
+            category_leaf_id="24208",
+            lat=41.0,
+            lon=2.0,
+        )
+    assert out["reused_suggest"] is True
+    assert out["upload_id"] == "upload-1"
+    create.assert_called_once()
+
+
 def test_sell_cmd_draft_without_yes(tmp_path: Path) -> None:
     from typer.testing import CliRunner
 

{walla_cli-0.1.11 → walla_cli-0.1.13}/tests/test_wire_contracts.py

@@ -17,6 +17,7 @@ from walla.account.inbox import list_conversations_raw
 from walla.account.login import login_password, mint_access_token, refresh_session, whoami
 from walla.account.offer_wire import assert_offer_body
 from walla.account.sell import delete_listing, publish_listing
+from walla.account.sell_edit import edit_listing
 from walla.account.sell_wire import assert_item_body, build_item_body
 from walla.core.exceptions import WallaAuthError, WallaHTTPError, WallaUnsupportedError
 from walla.http.client import HttpClient
@@ -244,6 +245,20 @@ def test_every_contract_is_sent(
     monkeypatch.setattr("walla.account.sell.requests.Session", lambda: _Sess())
     monkeypatch.setattr("walla.account.sell.CurlMime.addpart", _addpart)
     monkeypatch.setattr("walla.account.sell.CurlMime.close", lambda _s: None)
+    monkeypatch.setattr("walla.account.sell_edit.requests.request", _Sess().request)
+    monkeypatch.setattr(
+        "walla.account.sell_edit.fetch_owned_item",
+        lambda _id: {
+            "title": {"original": "Cofre test"},
+            "description": {"original": "desc"},
+            "price": {"cash": {"amount": 79.0}},
+            "type_attributes": {"condition": {"value": "good"}},
+            "taxonomy": [{"id": 10328}],
+            "location": {"latitude": 41.39, "longitude": 2.17},
+            "shipping": {"user_allows_shipping": False},
+            "images": [{"id": 1}],
+        },
+    )
     sess = SessionData(
         access_token="tok",
         device_id="dev-contract",
@@ -302,6 +317,9 @@ def test_every_contract_is_sent(
         lon=2.17,
     )
     assert created["id"] == "item123"
+    edited = edit_listing("item123", price_eur=49.0)
+    assert edited["edited"] is True
+    assert edited["price_eur"] == 49.0
     delete_listing("item123", client=rec)
 
     item_parts = [

{walla_cli-0.1.11 → walla_cli-0.1.13}/walla/__init__.py

@@ -4,4 +4,4 @@ from __future__ import annotations
 
 __all__ = ("__version__",)
 
-__version__ = "0.1.11"
+__version__ = "0.1.13"

{walla_cli-0.1.11 → walla_cli-0.1.13}/walla/account/sell.py

@@ -16,6 +16,7 @@ from walla.account.sell_steps import (
     poll_suggested,
     post_step,
 )
+from walla.account.sell_upload import IMAGE_TYPES, upload_pictures
 from walla.account.sell_wire import build_item_body
 from walla.core.exceptions import (
     WallaHTTPError,
@@ -33,45 +34,11 @@ __all__ = (
     "create_listing",
     "delete_listing",
     "publish_listing",
+    "publish_prepared",
     "upload_pictures",
 )
 
 _UPLOAD_ACCEPT = "application/vnd.upload-v2+json"
-_IMAGE_TYPES = {
-    ".jpg": "image/jpeg",
-    ".jpeg": "image/jpeg",
-    ".png": "image/png",
-    ".webp": "image/webp",
-}
-
-
-def upload_pictures(upload_id: str, photos: list[Path]) -> int:
-    """POST each photo to /api/v3/upload/{id}/pictures (HTTP 204)."""
-    if not photos:
-        raise ValueError("at least one photo required")
-    headers = {k: v for k, v in auth_headers().items() if k.lower() != "content-type"}
-    session: Any = requests.Session()
-    for path in photos:
-        data = path.read_bytes()
-        ctype = _IMAGE_TYPES.get(path.suffix.lower(), "image/jpeg")
-        wait_turn()
-        mp = CurlMime()
-        mp.addpart(name="file", content_type=ctype, filename=path.name, data=data)
-        resp: Any = session.request(
-            "POST",
-            f"{API_BASE}/api/v3/upload/{upload_id}/pictures",
-            headers=headers,
-            multipart=mp,
-            impersonate="chrome",
-            timeout=60,
-        )
-        mp.close()
-        if resp.status_code not in (200, 201, 204):
-            raise WallaHTTPError(
-                f"picture upload HTTP {resp.status_code}: {(resp.text or '')[:200]}",
-                status_code=resp.status_code,
-            )
-    return len(photos)
 
 
 def create_listing(item: dict[str, Any], first_photo: Path) -> dict[str, Any]:
@@ -79,7 +46,7 @@ def create_listing(item: dict[str, Any], first_photo: Path) -> dict[str, Any]:
     headers = {k: v for k, v in auth_headers().items() if k.lower() != "content-type"}
     headers["Accept"] = _UPLOAD_ACCEPT
     data = first_photo.read_bytes()
-    ctype = _IMAGE_TYPES.get(first_photo.suffix.lower(), "image/jpeg")
+    ctype = IMAGE_TYPES.get(first_photo.suffix.lower(), "image/jpeg")
     wait_turn()
     mp = CurlMime()
     mp.addpart(name="image", content_type=ctype, filename=first_photo.name, data=data)
@@ -110,6 +77,54 @@ def delete_listing(item_id: str, *, client: HttpClient | None = None) -> dict[st
     return {"id": item_id, "deleted": True}
 
 
+def publish_prepared(
+    photos: list[Path],
+    *,
+    upload_id: str,
+    title: str,
+    description: str,
+    price_eur: float,
+    category_leaf_id: str,
+    lat: float,
+    lon: float,
+    condition: str = "good",
+    shipping: bool = False,
+    weight_kg: float | None = None,
+    wire_draft: dict[str, str] | None = None,
+) -> dict[str, Any]:
+    """Create item from an upload_id already walked through loading."""
+    paths = [Path(p) for p in photos]
+    for p in paths:
+        if not p.is_file():
+            raise ValueError(f"photo not found: {p}")
+    if not upload_id.strip():
+        raise ValueError("upload_id required")
+    item = build_item_body(
+        upload_id=upload_id,
+        title=title,
+        description=description,
+        price_eur=price_eur,
+        category_leaf_id=category_leaf_id,
+        lat=lat,
+        lon=lon,
+        condition=condition,
+        shipping=shipping,
+        max_weight_kg=weight_kg,
+    )
+    created = create_listing(item, paths[0])
+    if len(paths) > 1:
+        _upload_extra_pictures(created["id"], paths[1:])
+    return {
+        **created,
+        "upload_id": upload_id,
+        "title": title.strip()[:50],
+        "url": _public_item_url(str(created["id"])),
+        "photos": len(paths),
+        "wire_draft": wire_draft or {},
+        "reused_suggest": True,
+    }
+
+
 def publish_listing(
     photos: list[Path],
     *,
@@ -143,7 +158,8 @@ def publish_listing(
     post_step(http, upload_id, current="category", draft=draft)
     poll_suggested(http, upload_id)
     post_step(http, upload_id, current="loading", draft=draft)
-    item = build_item_body(
+    out = publish_prepared(
+        paths,
         upload_id=upload_id,
         title=title,
         description=description,
@@ -153,19 +169,11 @@ def publish_listing(
         lon=lon,
         condition=condition,
         shipping=shipping,
-        max_weight_kg=weight_kg,
+        weight_kg=weight_kg,
+        wire_draft=wire,
     )
-    created = create_listing(item, paths[0])
-    if len(paths) > 1:
-        _upload_extra_pictures(created["id"], paths[1:])
-    return {
-        **created,
-        "upload_id": upload_id,
-        "title": title.strip()[:50],
-        "url": _public_item_url(str(created["id"])),
-        "photos": len(paths),
-        "wire_draft": wire,
-    }
+    out["reused_suggest"] = False
+    return out
 
 
 def _public_item_url(item_id: str) -> str:
@@ -194,7 +202,7 @@ def _upload_extra_pictures(item_id: str, photos: list[Path]) -> None:
     session: Any = requests.Session()
     for idx, path in enumerate(photos, start=1):
         data = path.read_bytes()
-        ctype = _IMAGE_TYPES.get(path.suffix.lower(), "image/jpeg")
+        ctype = IMAGE_TYPES.get(path.suffix.lower(), "image/jpeg")
         wait_turn()
         mp = CurlMime()
         mp.addpart(name="image", content_type=ctype, filename=path.name, data=data)