vmware-storage 2.4.1__tar.gz → 2.4.2__tar.gz

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/.claude-plugin/plugin.json

@@ -2,7 +2,7 @@
   "$schema": "https://anthropic.com/claude-code/plugin.schema.json",
   "name": "vmware-storage",
   "displayName": "VMware Storage",
-  "version": "2.4.1",
+  "version": "2.4.2",
   "description": "VMware vSphere storage with 15 MCP tools: datastores, iSCSI, vSAN, FC multipath.",
   "author": {
     "name": "Wei Zhou",

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/.mcp.json

@@ -5,7 +5,7 @@
       "command": "uvx",
       "args": [
         "--from",
-        "vmware-storage==2.4.1",
+        "vmware-storage==2.4.2",
         "vmware-storage-mcp"
       ]
     }

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: vmware-storage
-Version: 2.4.1
+Version: 2.4.2
 Summary: VMware vSphere storage management: datastores, iSCSI, vSAN. Domain-focused MCP skill.
 Project-URL: Homepage, https://github.com/vmware-skills/VMware-Storage
 Project-URL: Repository, https://github.com/vmware-skills/VMware-Storage
@@ -10,7 +10,7 @@ Author-email: Wei Zhou <wei-wz.zhou@broadcom.com>
 License-Expression: MIT
 License-File: LICENSE
 Requires-Python: >=3.10
-Requires-Dist: mcp[cli]<2.0,>=1.28
+Requires-Dist: mcp[cli]<2.0,>=1.30
 Requires-Dist: pyaml<27.0,>=24.0
 Requires-Dist: python-dotenv<2.0,>=1.0
 Requires-Dist: pyvmomi<10.0,>=8.0.3.0

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/README-CN.md

@@ -115,7 +115,7 @@ targets:
 - `list_all_datastores` — 列出所有数据存储，含容量、使用率、可达性
 - `browse_datastore` — 浏览数据存储目录下的文件（支持 glob 过滤）
 - `scan_datastore_images` — 扫描可部署镜像（OVA、ISO、OVF、VMDK）
-- `list_cached_images` — 查询本地镜像注册表（支持按类型/数据存储过滤）
+- `list_cached_images` — 查询本地镜像注册表（支持按类型/数据存储/target 过滤）
 
 **iSCSI**
 - `enable_iscsi` — 在 ESXi 主机上启用软件 iSCSI 适配器

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/RELEASE_NOTES.md

@@ -1,3 +1,19 @@
+## v2.4.2 — a login refused for lack of a vSphere role says so (2026-10-19)
+
+* **A login vCenter refuses with `NoPermission` gets the role error, not the raw fault.** Found on a vCenter 8.0.3
+  lab (follow-up to AIops#47): for an SSO account with no permission anywhere, vCenter refuses the login itself
+  (`System.View` on the root folder), so the post-login no-role check never ran and `doctor` and every tool showed
+  the raw fault with a connectivity hint. It now raises the no-role error: the "no vSphere role / Global
+  Permissions" remedy only for a vCenter target and `System.View`; an ESXi target or another privilege gets a
+  neutral text naming the (sanitized) privilege. A wrong password (`InvalidLogin`) is unchanged. Same text as
+  vmware-monitor.
+
+## Unreleased — follow-ups to the 2.4.1 review
+
+* **`list_cached_images(target=...)`** returns one target's cached images; without it, nothing changes.
+* The cache write takes a lock across processes, so a CLI and an MCP scan at the same time keep both sides' rows; a
+  lock held for more than 10 s is reported in `cache_note` with the lock file's path.
+
 ## v2.4.1 — fixes from real-hardware testing (2026-10-17)
 
 * **`list_cached_images` returns what was scanned.** Nothing ever wrote the cache it reads, so it was always empty.

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/openclaw.plugin.json

@@ -11,7 +11,7 @@
       "command": "uvx",
       "args": [
         "--from",
-        "vmware-storage==2.4.1",
+        "vmware-storage==2.4.2",
         "vmware-storage-mcp"
       ]
     }

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zw008/vmware-storage",
-  "version": "2.4.1",
+  "version": "2.4.2",
   "description": "VMware vSphere storage with 15 MCP tools: datastores, iSCSI, vSAN, FC multipath.",
   "private": true,
   "license": "MIT",

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "vmware-storage"
-version = "2.4.1"
+version = "2.4.2"
 description = "VMware vSphere storage management: datastores, iSCSI, vSAN. Domain-focused MCP skill."
 readme = "README.md"
 license = "MIT"
@@ -16,7 +16,7 @@ dependencies = [
     "typer>=0.12,<1.0",
     "rich>=13.0,<15.0",
     "python-dotenv>=1.0,<2.0",
-    "mcp[cli]>=1.28,<2.0",
+    "mcp[cli]>=1.30,<2.0",
     "vmware-policy>=1.23.0,<2.0",
 ]
 

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/server.json

@@ -7,12 +7,12 @@
     "url": "https://github.com/vmware-skills/VMware-Storage",
     "source": "github"
   },
-  "version": "2.4.1",
+  "version": "2.4.2",
   "packages": [
     {
       "registryType": "pypi",
       "identifier": "vmware-storage",
-      "version": "2.4.1",
+      "version": "2.4.2",
       "runtimeHint": "uvx",
       "packageArguments": [
         {

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/skills/vmware-storage/SKILL.md

@@ -40,7 +40,7 @@ VMware vSphere storage management — 15 MCP tools for datastores, iSCSI, vSAN,
 ## Quick Install
 
 ```bash
-uv tool install vmware-storage==2.4.1
+uv tool install vmware-storage==2.4.2
 vmware-storage init      # guided setup: writes config + .env (chmod 600, password grep-safe), then verifies
 vmware-storage doctor
 ```
@@ -103,7 +103,7 @@ vmware-storage doctor
 4. `datastore browse <ds> --pattern "*.iso"` for ad-hoc searches; pattern is glob, not regex
 5. **If datastore not found**: name is case-sensitive. `datastore list --target <vc>` to verify exact spelling.
 
-For filtered queries against the cache: use `list_cached_images` MCP tool with `image_type` and `datastore` parameters — avoids re-scanning.
+For filtered queries against the cache: use `list_cached_images` MCP tool with `image_type`, `datastore` and `target` parameters — avoids re-scanning.
 
 ### vSAN Health Assessment
 
@@ -158,7 +158,7 @@ The four Datastore read tools return the family list envelope — `{items, retur
 | Datastore | `list_all_datastores` | Read | List datastores with capacity, usage %, VM count |
 | | `browse_datastore` | Read | Browse files with optional path and glob pattern |
 | | `scan_datastore_images` | Read | Find OVA/ISO/OVF/VMDK in a datastore |
-| | `list_cached_images` | Read | Query local image registry with type/datastore filters |
+| | `list_cached_images` | Read | Query local image registry with type/datastore/target filters |
 | iSCSI | `get_iscsi_status` | Read | Show adapter status, HBA device, IQN, send targets |
 | | `enable_iscsi` | Write | Enable software iSCSI adapter on a host |
 | | `add_iscsi_target` | Write | Add iSCSI send target (IP + port) and rescan |
@@ -271,7 +271,7 @@ Corporate TLS proxies inject certificates that uv's bundled CA store doesn't tru
 ## Setup
 
 ```bash
-uv tool install vmware-storage==2.4.1
+uv tool install vmware-storage==2.4.2
 mkdir -p ~/.vmware-storage
 cp config.example.yaml ~/.vmware-storage/config.yaml
 # Edit config.yaml with your vCenter/ESXi targets

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/skills/vmware-storage/references/capabilities.md

@@ -26,7 +26,7 @@ Each operation is classified by autonomy level per the Enterprise Harness Engine
 | `list_all_datastores` | List datastores with capacity, usage %, VM count | `target` (string, optional), `limit` (int, optional; omit for all) | Low | No |
 | `browse_datastore` | Browse files with optional path and glob pattern | `datastore_name` (string, **required**), `path` (string, optional), `pattern` (string, optional), `target` (string, optional) | Low | No |
 | `scan_datastore_images` | Find OVA/ISO/OVF/VMDK deployable images in a datastore | `datastore_name` (string, **required**), `target` (string, optional) | Low | No |
-| `list_cached_images` | Query local image registry with type/datastore filters | `image_type` (string, optional), `datastore` (string, optional) | Low | No |
+| `list_cached_images` | Query local image registry with type/datastore/target filters | `image_type` (string, optional), `datastore` (string, optional), `target` (string, optional) | Low | No |
 
 **List envelope**: all four return `{items, returned, limit, total, truncated, hint}` instead of a bare array, so an agent can tell a complete answer from a first page rather than inferring it (VMware-AIops issue #31). Each enumerates its collection in full — a PropertyCollector walk, a datastore browse task, or the on-disk registry — so `total` is the real count and `truncated` is always `false`. On error the tools return `{error, hint}` (a dict, not a one-element list).
 

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/skills/vmware-storage/references/setup-guide.md

@@ -13,19 +13,19 @@ Complete setup and security guide for `vmware-storage`.
 ### Via uv (recommended)
 
 ```bash
-uv tool install vmware-storage==2.4.1
+uv tool install vmware-storage==2.4.2
 ```
 
 ### Via pip
 
 ```bash
-pip install vmware-storage==2.4.1
+pip install vmware-storage==2.4.2
 ```
 
 ### From source
 
 ```bash
-git clone --branch v2.4.1 https://github.com/vmware-skills/VMware-Storage.git
+git clone --branch v2.4.2 https://github.com/vmware-skills/VMware-Storage.git
 cd VMware-Storage
 pip install -e .
 ```

vmware_storage-2.4.2/tests/eval/regression/test_image_registry_cross_process.py

@@ -0,0 +1,149 @@
+"""Two processes scanning at once must not drop each other's cached images.
+
+Review 2026-10-18: the registry's read-modify-write was guarded by a
+``threading.Lock``, which only serialises one process. A CLI scan and an MCP
+server scan running side by side each read the old file, and the last
+``os.replace`` wrote the other's rows away. The atomic replace stops a reader
+seeing half a file; it does nothing for a lost update.
+"""
+
+from __future__ import annotations
+
+import json
+import os
+import subprocess
+import sys
+import textwrap
+import time
+from pathlib import Path
+
+import pytest
+
+from vmware_storage.ops import datastore_browser as dsb
+
+_WRITERS = 4
+
+_CHILD = textwrap.dedent(
+    """
+    import sys, time
+    from pathlib import Path
+    from vmware_storage.ops import datastore_browser as dsb
+
+    reg, target = Path(sys.argv[1]), sys.argv[2]
+    dsb.IMAGE_REGISTRY_FILE = reg
+    dsb.CONFIG_DIR = reg.parent
+    real_load = dsb._load_registry
+
+    def slow_load():
+        # Widen the read-modify-write window so the race is not left to luck.
+        data = real_load()
+        time.sleep(0.3)
+        return data
+
+    dsb._load_registry = slow_load
+    (reg.parent / f"ready-{target}").touch()
+    go = reg.parent / "go"
+    deadline = time.monotonic() + 60
+    while not go.exists():
+        if time.monotonic() > deadline:
+            sys.exit("parent never said go")
+        time.sleep(0.01)
+    img = {"name": f"{target}.iso", "ds_path": f"[datastore1] {target}.iso",
+           "size_mb": 1.0, "type": "File", "modified": ""}
+    dsb._record_scan("datastore1", "", [img], target)
+    """
+)
+
+
+def _child_env() -> dict[str, str]:
+    env = dict(os.environ)
+    # The children must import exactly the code this test process imported.
+    env["PYTHONPATH"] = os.pathsep.join(p for p in sys.path if p)
+    return env
+
+
+def _run_writers(reg: Path, script: str, targets: list[str]) -> None:
+    procs = [
+        subprocess.Popen([sys.executable, "-c", script, str(reg), t], env=_child_env())
+        for t in targets
+    ]
+    try:
+        deadline = time.monotonic() + 60
+        while not all((reg.parent / f"ready-{t}").exists() for t in targets):
+            assert time.monotonic() < deadline, "writers never became ready"
+            assert all(p.poll() is None for p in procs), "a writer exited early"
+            time.sleep(0.02)
+        (reg.parent / "go").touch()
+        for p in procs:
+            assert p.wait(timeout=60) == 0
+    finally:
+        for p in procs:
+            if p.poll() is None:
+                p.kill()
+
+
+@pytest.mark.unit
+def test_concurrent_scans_in_separate_processes_keep_every_row(tmp_path) -> None:
+    reg = tmp_path / "image_registry.json"
+    targets = [f"t{i}" for i in range(_WRITERS)]
+
+    _run_writers(reg, _CHILD, targets)
+
+    rows = json.loads(reg.read_text(encoding="utf-8"))["images"]
+    assert sorted(r["target"] for r in rows) == targets
+
+
+@pytest.fixture
+def registry(tmp_path, monkeypatch):
+    path = tmp_path / "image_registry.json"
+    monkeypatch.setattr(dsb, "IMAGE_REGISTRY_FILE", path)
+    monkeypatch.setattr(dsb, "CONFIG_DIR", tmp_path)
+    return path
+
+
+def _hold_lock(reg: Path):
+    fcntl = pytest.importorskip("fcntl")
+    fh = open(reg.with_name(reg.name + ".lock"), "a+b")  # noqa: SIM115
+    fcntl.flock(fh.fileno(), fcntl.LOCK_EX | fcntl.LOCK_NB)
+    return fh
+
+
+_IMG = {"name": "x.iso", "ds_path": "[ds1] x.iso", "size_mb": 1.0,
+        "type": "File", "modified": ""}
+
+
+@pytest.mark.unit
+def test_a_held_lock_is_a_bounded_wait_that_names_the_lock_file(registry, monkeypatch) -> None:
+    monkeypatch.setattr(dsb, "REGISTRY_LOCK_TIMEOUT_S", 0.3, raising=False)
+    holder = _hold_lock(registry)
+    try:
+        started = time.monotonic()
+        with pytest.raises(dsb.DatastoreBrowseError, match=r"image_registry\.json\.lock"):
+            dsb._record_scan("ds1", "", [_IMG], "vc")
+        assert time.monotonic() - started < 5
+    finally:
+        holder.close()
+    assert not registry.exists(), "nothing may be written without the lock"
+
+
+@pytest.mark.unit
+def test_scan_reports_the_held_lock_in_cache_note(registry, monkeypatch) -> None:
+    monkeypatch.setattr(dsb, "REGISTRY_LOCK_TIMEOUT_S", 0.3, raising=False)
+    monkeypatch.setattr(
+        dsb, "browse_datastore",
+        lambda si, ds, path="", pattern="*": {"items": [_IMG] if pattern == "*.iso" else []},
+    )
+    holder = _hold_lock(registry)
+    try:
+        result = dsb.scan_images(object(), "ds1", target="vc")
+    finally:
+        holder.close()
+    assert [i["name"] for i in result["items"]] == ["x.iso"]
+    assert "image_registry.json.lock" in result.get("cache_note", "")
+
+
+@pytest.mark.unit
+def test_the_lock_is_released_after_a_write(registry) -> None:
+    dsb._record_scan("ds1", "", [_IMG], "vc")
+    holder = _hold_lock(registry)  # would raise BlockingIOError if still held
+    holder.close()

vmware_storage-2.4.2/tests/eval/regression/test_list_cached_images_target.py

@@ -0,0 +1,82 @@
+"""list_cached_images can answer for one target (review 2026-10-18).
+
+Rows carry ``target`` since 2026-10-17 so two hosts' "datastore1" stay apart,
+but the tool had no way to ask for one target's rows: a caller saw every
+target's images mixed together and had to filter by hand.
+"""
+
+from __future__ import annotations
+
+import json
+
+import pytest
+
+from vmware_storage.config import AppConfig, TargetConfig
+from vmware_storage.connection import ConnectionManager
+from vmware_storage.mcp_server import server
+from vmware_storage.ops import datastore_browser as dsb
+
+_ROWS = [
+    {"target": "vc", "datastore": "datastore1", "name": "a.iso",
+     "ds_path": "[datastore1] a.iso", "size_mb": 1.0, "type": "File", "modified": ""},
+    {"target": "esx", "datastore": "datastore1", "name": "b.ova",
+     "ds_path": "[datastore1] b.ova", "size_mb": 1.0, "type": "File", "modified": ""},
+    # Written before targets were recorded: it cannot be attributed to either.
+    {"datastore": "datastore1", "name": "old.iso", "ds_path": "[datastore1] old.iso",
+     "size_mb": 1.0, "type": "File", "modified": ""},
+]
+
+
+@pytest.fixture
+def registry(tmp_path, monkeypatch):
+    path = tmp_path / "image_registry.json"
+    path.write_text(json.dumps({"images": _ROWS, "last_scan": None}), encoding="utf-8")
+    monkeypatch.setattr(dsb, "IMAGE_REGISTRY_FILE", path)
+    monkeypatch.setattr(dsb, "CONFIG_DIR", tmp_path)
+    return path
+
+
+def _with_targets(monkeypatch, *names: str) -> None:
+    cfg = AppConfig(targets=tuple(
+        TargetConfig(name=n, host=f"{n}.example.com", config_username="u") for n in names))
+    mgr = ConnectionManager(cfg)
+    monkeypatch.setattr(server, "_get_conn_mgr", lambda: mgr)
+
+
+@pytest.mark.unit
+def test_ops_filter_returns_only_that_targets_rows(registry) -> None:
+    out = dsb.list_images(target="esx")
+    assert [i["name"] for i in out["items"]] == ["b.ova"]
+    assert out["total"] == 1
+
+
+@pytest.mark.unit
+def test_ops_filter_combines_with_the_other_filters(registry) -> None:
+    assert dsb.list_images(target="vc", image_type="ova")["items"] == []
+    assert [i["name"] for i in dsb.list_images(target="vc", datastore="datastore1")["items"]] == [
+        "a.iso"]
+
+
+@pytest.mark.unit
+def test_tool_with_target_returns_only_that_target(registry, monkeypatch) -> None:
+    _with_targets(monkeypatch, "vc", "esx")
+    out = server.list_cached_images(target="vc")
+    assert [i["name"] for i in out["items"]] == ["a.iso"]
+
+
+@pytest.mark.unit
+def test_tool_without_target_is_unchanged_and_needs_no_config(registry, monkeypatch) -> None:
+    def no_config():
+        raise AssertionError("an unfiltered cache read must not load config.yaml")
+
+    monkeypatch.setattr(server, "_get_conn_mgr", no_config)
+    out = server.list_cached_images()
+    assert sorted(i["name"] for i in out["items"]) == ["a.iso", "b.ova", "old.iso"]
+
+
+@pytest.mark.unit
+def test_tool_with_an_unknown_target_names_the_configured_ones(registry, monkeypatch) -> None:
+    _with_targets(monkeypatch, "vc", "esx")
+    out = server.list_cached_images(target="nope")
+    assert "error" in out
+    assert "nope" in out["error"] and "vc" in out["error"]

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/tests/eval/regression/test_login_without_a_role.py

@@ -213,3 +213,68 @@ def test_doctor_row_is_not_a_class_name(fake_login, monkeypatch):
     with connect, disconnect:
         _, row = doctor._check_auth()
     assert "NoVsphereRoleError" not in row
+
+
+# 2026-10-18, lab vCenter 8.0.3, SSO account with no permission anywhere:
+# vCenter refuses the *login itself* with NoPermission (System.View on the root
+# folder). Before the fix that raw fault reached doctor and every tool.
+def _login_refused(exc: Exception, monkeypatch: pytest.MonkeyPatch):
+    monkeypatch.setenv("VMWARE_LAB_PASSWORD", "pw")
+    mgr = ConnectionManager(_config())
+    with patch("pyVim.connect.SmartConnect", side_effect=exc):
+        try:
+            mgr.connect("lab")
+        except Exception as e:  # noqa: BLE001 — the test inspects whatever is raised
+            return e
+    raise AssertionError("connect did not raise")
+
+
+def test_login_refused_with_no_permission_names_the_missing_role(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    fault = vim.fault.NoPermission(
+        privilegeId="System.View", msg="Permission to perform this operation was denied."
+    )
+    err = _login_refused(fault, monkeypatch)
+    assert isinstance(err, NoVsphereRoleError)
+    msg = str(err)
+    assert "no vSphere role" in msg and "Read-Only" in msg and "'lab'" in msg
+    assert "dynamicType" not in msg and "operation failed" not in msg
+    assert len(msg) <= 300
+    assert err.__cause__ is fault
+
+
+def test_wrong_password_is_not_reported_as_a_missing_role(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    err = _login_refused(vim.fault.InvalidLogin(), monkeypatch)
+    assert not isinstance(err, NoVsphereRoleError)
+    assert isinstance(err, vim.fault.InvalidLogin)
+
+
+@pytest.mark.parametrize(
+    ("privilege", "esxi"),
+    [("System.View", True), ("Sessions.ValidateSession", False), (None, False)],
+)
+def test_other_login_refusals_get_a_neutral_remedy(
+    privilege, esxi, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    # Review 2026-10-18 (M3): an ESXi host (lockdown mode, host permissions) or
+    # another privilege must not be sent to vCenter Global Permissions.
+    from dataclasses import replace
+
+    fault = vim.fault.NoPermission(privilegeId=privilege)
+    mgr = ConnectionManager(_config())
+    if esxi:
+        esxi_targets = tuple(replace(t, type="esxi") for t in mgr._config.targets)
+        mgr._config = replace(mgr._config, targets=esxi_targets)
+    monkeypatch.setenv("VMWARE_LAB_PASSWORD", "pw")
+    monkeypatch.setenv("VMWARE_PRIVATEAI_LAB_PASSWORD", "pw")
+    with patch("pyVim.connect.SmartConnect", side_effect=fault):
+        with pytest.raises(Exception) as info:
+            mgr.connect("lab")
+    msg = str(info.value)
+    assert "Global Permissions" not in msg and "lockdown mode" in msg
+    if privilege:
+        assert f"({privilege})" in msg
+    assert info.value.__cause__ is fault and len(msg) <= 300

vmware_storage-2.4.2/tests/test_filelock.py

@@ -0,0 +1,81 @@
+"""The inter-process registry lock: Windows branch and bounded wait.
+
+The family runs on Windows, where ``fcntl`` does not exist. That branch cannot
+run on the POSIX CI host, so it is driven here with a stand-in ``msvcrt`` that
+records the calls and reports the lock as busy a set number of times.
+"""
+
+from __future__ import annotations
+
+import errno
+import types
+
+import pytest
+
+from vmware_storage import _filelock
+
+
+class _FakeMsvcrt(types.SimpleNamespace):
+    LK_NBLCK = 2
+    LK_UNLCK = 0
+
+    def __init__(self, busy: int) -> None:
+        super().__init__(calls=[], busy=busy)
+
+    def locking(self, fd: int, mode: int, nbytes: int) -> None:
+        self.calls.append((mode, nbytes))
+        if mode == self.LK_NBLCK and self.busy > 0:
+            self.busy -= 1
+            raise OSError(errno.EACCES, "Permission denied")  # msvcrt: busy
+
+
+@pytest.mark.unit
+def test_windows_branch_retries_then_locks_and_unlocks(tmp_path, monkeypatch) -> None:
+    fake = _FakeMsvcrt(busy=2)
+    monkeypatch.setattr(_filelock, "msvcrt", fake)
+    monkeypatch.setattr(_filelock, "fcntl", None)
+
+    with _filelock.locked(tmp_path / "reg.json.lock", timeout=5, poll=0.01):
+        pass
+
+    assert fake.calls == [(2, 1), (2, 1), (2, 1), (0, 1)]
+
+
+@pytest.mark.unit
+def test_windows_branch_gives_up_and_names_the_file(tmp_path, monkeypatch) -> None:
+    monkeypatch.setattr(_filelock, "msvcrt", _FakeMsvcrt(busy=10**9))
+    monkeypatch.setattr(_filelock, "fcntl", None)
+    lock = tmp_path / "reg.json.lock"
+
+    with pytest.raises(_filelock.FileLockTimeoutError, match="reg.json.lock"):
+        with _filelock.locked(lock, timeout=0.1, poll=0.01):
+            pytest.fail("entered the block without the lock")
+
+
+@pytest.mark.unit
+def test_the_lock_file_is_owner_only(tmp_path) -> None:
+    import os
+    import stat
+
+    lock = tmp_path / "sub" / "reg.json.lock"
+    with _filelock.locked(lock, timeout=1):
+        pass
+    if os.name == "posix":
+        assert stat.S_IMODE(lock.stat().st_mode) == 0o600
+
+
+@pytest.mark.unit
+def test_a_lock_error_that_is_not_busy_is_raised_at_once(tmp_path, monkeypatch) -> None:
+    """No flock on this filesystem is not "another process holds it" (review 2026-10-18)."""
+    if _filelock.fcntl is None:
+        pytest.skip("POSIX branch")
+
+    def no_locks(fd, op):
+        raise OSError(errno.ENOLCK, "No locks available")
+
+    monkeypatch.setattr(_filelock.fcntl, "flock", no_locks)
+    with pytest.raises(OSError) as info:
+        with _filelock.locked(tmp_path / "r.lock", timeout=5.0, poll=0.01):
+            pass
+    assert info.value.errno == errno.ENOLCK
+    assert not isinstance(info.value, _filelock.FileLockTimeoutError)

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/uv.lock

@@ -1162,21 +1162,21 @@ wheels = [
 
 [[package]]
 name = "vmware-policy"
-version = "1.24.0"
+version = "1.24.2"
 source = { registry = "https://pypi.org/simple" }
 dependencies = [
     { name = "pyyaml" },
     { name = "rich" },
     { name = "typer" },
 ]
-sdist = { url = "https://files.pythonhosted.org/packages/4a/62/3a3cb83af77e3dd3c8fc92cb3b7968bfda04a2f71bf0d6f9b72ee3198441/vmware_policy-1.24.0.tar.gz", hash = "sha256:fba12732ccbd4371232c15d9fd014f9f5d697497210aedff2515d1d205ed3577", size = 361302, upload-time = "2026-10-16T07:18:28.317Z" }
+sdist = { url = "https://files.pythonhosted.org/packages/15/8d/b9867ea1c0112caa481841c290c3fe718c0dbd738757db7877836f46267a/vmware_policy-1.24.2.tar.gz", hash = "sha256:6c816174fcd0b490bcd1f9ebaaa18b80fcb26b0eccb614e938938bb2e8452a40", size = 369315, upload-time = "2026-10-18T03:43:52.753Z" }
 wheels = [
-    { url = "https://files.pythonhosted.org/packages/3d/f2/fe3d9d384712023916e2cacddc385f14b095509c5e00aea417d1a9550e98/vmware_policy-1.24.0-py3-none-any.whl", hash = "sha256:cf615d0256134f01fb84c39b083649281a66d2c064c2eaa28786a0fa95ec6e58", size = 131460, upload-time = "2026-10-16T07:18:26.907Z" },
+    { url = "https://files.pythonhosted.org/packages/20/01/bc5f984a420d22514d8c3a627f332891f2008213d455c2f682f311e355f1/vmware_policy-1.24.2-py3-none-any.whl", hash = "sha256:2734ab49a76474fd74beb221a2d6535caab1f91a477668484c145dc2802ae072", size = 134565, upload-time = "2026-10-18T03:43:50.856Z" },
 ]
 
 [[package]]
 name = "vmware-storage"
-version = "2.4.1"
+version = "2.4.2"
 source = { editable = "." }
 dependencies = [
     { name = "mcp", extra = ["cli"] },
@@ -1197,7 +1197,7 @@ dev = [
 
 [package.metadata]
 requires-dist = [
-    { name = "mcp", extras = ["cli"], specifier = ">=1.28,<2.0" },
+    { name = "mcp", extras = ["cli"], specifier = ">=1.30,<2.0" },
     { name = "pyaml", specifier = ">=24.0,<27.0" },
     { name = "python-dotenv", specifier = ">=1.0,<2.0" },
     { name = "pyvmomi", specifier = ">=8.0.3.0,<10.0" },

{vmware_storage-2.4.1 → vmware_storage-2.4.2}/vmware_storage/__init__.py

@@ -1,3 +1,3 @@
 """VMware Storage — vSphere datastore, iSCSI, and vSAN management."""
 
-__version__ = "2.4.1"
+__version__ = "2.4.2"