vis-agent 0.3.5.dev8276__tar.gz → 0.4.3.dev8313__tar.gz

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: vis-agent
-Version: 0.3.5.dev8276
+Version: 0.4.3.dev8313
 Summary: The Vis Python SDK — author extensions and control local or remote engines.
 Project-URL: Homepage, https://vis.blockether.com
 Project-URL: Documentation, https://vis.blockether.com

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/contracts/schema/agents.json

@@ -638,16 +638,12 @@
                 "type": "integer",
                 "minimum": 1
               },
-              "kind": {
-                "type": "string"
-              },
               "content": {
                 "type": "string"
               }
             },
             "required": [
               "entry_id",
-              "kind",
               "content"
             ],
             "additionalProperties": false

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/contracts/schema/view.json

@@ -1493,6 +1493,14 @@
               ],
               "default": "activate"
             },
+            "variant": {
+              "enum": [
+                "primary",
+                "secondary",
+                "destructive"
+              ],
+              "default": "secondary"
+            },
             "is_disabled": {
               "type": "boolean"
             },

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/pyproject.toml

@@ -8,7 +8,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "vis-agent"
-version = "0.3.5.dev8276"
+version = "0.4.3.dev8313"
 description = "The Vis Python SDK — author extensions and control local or remote engines."
 readme = "README.md"
 requires-python = ">=3.12"

vis_agent-0.4.3.dev8313/release-tag

@@ -0,0 +1 @@
+beta-6c75eae554a843314b4614ffb130645993e96acb

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/src/blockether/vis/_contracts.py

@@ -61,6 +61,22 @@ def live_items(key: str, items: list[dict[str, Any]]) -> list[dict[str, Any]]:
     return result
 
 
+def _button_branch() -> dict[str, Any]:
+    return next(
+        branch
+        for branch in definition("view", "component")["oneOf"]
+        if branch["properties"]["type"].get("const") == "button"
+    )
+
+
+def button_variant_error(variant: Any) -> str | None:
+    """Answer why a declared button variant is invalid, or None when it is valid."""
+    allowed = _button_branch()["properties"]["variant"]["enum"]
+    if variant is None or variant in allowed:
+        return None
+    return f"button variant must be one of {', '.join(allowed)}, not {variant!r}"
+
+
 def _defaults(key: str) -> dict[str, Any]:
     properties = definition("view", key)["properties"]
     return {

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/src/blockether/vis/_outside.py

@@ -1076,6 +1076,10 @@ def _live_check_node(node, seen, *, is_declaration=True):
             return f"a {kind} input has no value: only the host holds its handle"
     node_id = node.get("id")
     if not isinstance(node_id, str) or not node_id.strip():
+        if is_group:
+            from .extension import _LIVE_GROUP_NEEDS_ID
+
+            return _LIVE_GROUP_NEEDS_ID
         return f"a {kind} node needs an id"
     if node_id in seen:
         return f"two nodes answer to {node_id!r}"
@@ -1129,6 +1133,9 @@ def _live_check_node(node, seen, *, is_declaration=True):
             return "a button needs a label"
         if is_declaration and "clicks" in node:
             return "button clicks are stamped by the engine"
+        complaint = _contracts.button_variant_error(node.get("variant"))
+        if complaint:
+            return complaint
         node.setdefault("clicks", 0)
         node.setdefault("is_disabled", False)
         if type(node["clicks"]) is not int or node["clicks"] < 0:

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/src/blockether/vis/engine/_client.py

@@ -1578,7 +1578,7 @@ class ExecutionLayer(ABC):
     def get_session_fs_file(
         self, sid: str, *, query: Query | None = None, timeout: float | None = None
     ) -> JSONValue:
-        """GET /v1/sessions/:sid/fs/file — read one workspace file as text."""
+        """GET /v1/sessions/:sid/fs/file — preview one workspace file by its kind."""
         response = self._request(
             "GET",
             "/v1/sessions/:sid/fs/file",

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/src/blockether/vis/extension.py

@@ -6277,6 +6277,12 @@ def live(title, nodes, placement=None, key=None, on_event=None, **options):
 
 # -- Extension live-view test harness -----------------------------------------
 
+# The refusal of a live group without an id, in the recorder and the outside host.
+_LIVE_GROUP_NEEDS_ID = (
+    "a live view group needs an id, because patches and after= name it: "
+    "write vis.ui.group('actions', ...) or vis.ui.wrap('actions', ...)"
+)
+
 
 class _LiveRecorder:
     """An isolated in-memory live host for testing any extension live view.
@@ -6366,6 +6372,12 @@ class _LiveRecorder:
                 node.setdefault("variant", "braille")
                 node.setdefault("is_active", True)
             elif kind == "button":
+                from blockether.vis import _contracts
+
+                complaint = _contracts.button_variant_error(node.get("variant"))
+                if complaint:
+                    # Vis raises VisToolError, a RuntimeError, so the recorder does too.
+                    raise RuntimeError(f"button {node.get('id')}: {complaint}")
                 node["clicks"] = 0
                 node.setdefault("is_disabled", False)
             elif kind == "card" and node.get("is_selectable"):
@@ -6568,12 +6580,9 @@ class _LiveRecorder:
         if action == "open":
             for node in self._nodes(envelope["view"].get("nodes")):
                 # The engine refuses a live group without an id, so a test must too.
+                # Vis raises VisToolError, a RuntimeError, so the recorder does too.
                 if node.get("type") == "group" and not node.get("id"):
-                    raise AssertionError(
-                        "a live view group needs an id, because patches and "
-                        "after= name it: write vis.ui.group('actions', ...) "
-                        "or vis.ui.wrap('actions', ...)"
-                    )
+                    raise RuntimeError(_LIVE_GROUP_NEEDS_ID)
             self._view = self._materialize(envelope["view"])
             self._declared = set(envelope.get("validators") or [])
             self._verdicts = {}
@@ -7077,14 +7086,22 @@ def _ui_spinner(node_id, text="Working", *, variant="braille", is_active=True, *
     )
 
 
-def _ui_button(node_id, label, *, is_disabled=False, **spec):
+def _ui_button(node_id, label, *, is_disabled=False, variant=None, **spec):
     """An operator action. Accepted presses increment ``clicks`` in ``view.state()``.
 
-    No callback or code crosses the wire. The producer decides how to respond.
+    ``variant`` is ``"primary"``, ``"secondary"`` (the default) or ``"destructive"``.
+    Give one primary action per group. No callback or code crosses the wire.
     Disabled buttons and completed receipts cannot be activated.
     """
+    from blockether.vis import _contracts
+
+    complaint = _contracts.button_variant_error(variant)
+    if complaint:
+        raise ValueError(f"button {node_id}: {complaint}")
     return _live_node(
-        "button", node_id, dict(spec, label=str(label), is_disabled=is_disabled)
+        "button",
+        node_id,
+        dict(spec, label=str(label), is_disabled=is_disabled, variant=variant),
     )
 
 

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/src/blockether/vis/extension_package.py

@@ -43,6 +43,8 @@ LATEST = "latest"
 LOCK_WAIT_S = 300
 MAX_METADATA = 128 * 1024
 _EXCLUDED = {".git", ".venv", "venv", "__pycache__", "node_modules", ".DS_Store"}
+# `.env*` holds secrets. `.venv-*` is an environment that Vis prepares for one interpreter.
+_EXCLUDED_PREFIXES = (".env", ".venv-")
 
 
 def _relative(value):
@@ -51,7 +53,7 @@ def _relative(value):
     if len(value) > 512 or any(ord(c) < 32 or ord(c) == 127 for c in value):
         raise ValueError("Project paths are too long or contain control characters")
     if any(
-        p in {"", ".", ".."} or p in _EXCLUDED or p.startswith(".env")
+        p in {"", ".", ".."} or p in _EXCLUDED or p.startswith(_EXCLUDED_PREFIXES)
         for p in value.split("/")
     ):
         raise ValueError("Project contains an unsafe or excluded path")
@@ -346,7 +348,11 @@ def _checkout(repository, directory, revision):
 
 def _copy_project(source, destination):
     def excluded(_directory, names):
-        return {name for name in names if name in _EXCLUDED or name.startswith(".env")}
+        return {
+            name
+            for name in names
+            if name in _EXCLUDED or name.startswith(_EXCLUDED_PREFIXES)
+        }
 
     count, size = 0, 0
     for base, directories, files in os.walk(source):

{vis_agent-0.3.5.dev8276 → vis_agent-0.4.3.dev8313}/tests/test_live_primitives.py

@@ -241,16 +241,44 @@ def test_table_builder_refuses_text_columns():
         vis.ui.table("chats", columns=[vis.ui.table_column("chat", "Chat"), "Category"])
 
 
+def test_button_variant_is_kept_and_a_typo_names_the_variants():
+    # #430: a button had no hierarchy, and a misspelled variant reached the host.
+    assert vis.ui.button("save", "Save", variant="primary")["variant"] == "primary"
+    assert "variant" not in vis.ui.button("save", "Save")
+    with pytest.raises(ValueError, match=r"primary, secondary, destructive.*'danger'"):
+        vis.ui.button("drop", "Drop", variant="danger")
+
+
+def test_outside_refuses_an_unknown_button_variant():
+    # #430: outside Vis a raw button with a typo variant was accepted.
+    button = {"id": "drop", "type": "button", "label": "Drop", "variant": "danger"}
+    view = {"title": "Rows", "nodes": [button]}
+    with pytest.raises(RuntimeError, match=r"primary, secondary, destructive"):
+        _outside.live(json.dumps({"op": "open", "view": view}))
+
+
 def test_recorder_refuses_a_live_group_without_an_id(monkeypatch):
     # #428: the recorder hid the buttons of an unnamed group; the engine refuses it.
+    # Vis raises VisToolError, a RuntimeError, so the recorder must raise one too.
     monkeypatch.setattr(vis, "_host", vis.testing.LiveRecorder(vis._host))
-    with pytest.raises(AssertionError, match="group needs an id"):
+    with pytest.raises(
+        RuntimeError, match=r"group needs an id.*vis\.ui\.group\('actions'"
+    ):
         with vis.live(
             "Chats", [vis.ui.wrap(vis.ui.button("save", "Save"))], flush_ms=0
         ):
             pass
 
 
+def test_outside_refuses_a_live_group_without_an_id_with_the_fix():
+    # #428: outside Vis the refusal named no fix for an unnamed group.
+    view = {"title": "Chats", "nodes": [vis.ui.wrap(vis.ui.button("save", "Save"))]}
+    with pytest.raises(
+        RuntimeError, match=r"group needs an id.*vis\.ui\.group\('actions'"
+    ):
+        _outside.live(json.dumps({"op": "open", "view": view}))
+
+
 def test_outside_refused_patch_leaves_state_unchanged():
     opened = json.loads(
         _outside.live(

vis_agent-0.3.5.dev8276/release-tag

@@ -1 +0,0 @@
-beta-809a2a6395ced27be7bf360ccf2673c39bf8cf6f