violet-poolController-api 0.0.38__tar.gz → 0.0.39__tar.gz

{violet_poolcontroller_api-0.0.38/violet_poolController_api.egg-info → violet_poolcontroller_api-0.0.39}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: violet-poolController-api
-Version: 0.0.38
+Version: 0.0.39
 Summary: Asynchronous Python client for the Violet Pool Controller.
 Author-email: "Basti (Xerolux)" <git@xerolux.de>
 License-Expression: AGPL-3.0-or-later
@@ -20,7 +20,7 @@ Classifier: Topic :: Home Automation
 Requires-Python: >=3.12
 Description-Content-Type: text/markdown
 License-File: LICENSE
-Requires-Dist: aiohttp<3.15,>=3.11.0
+Requires-Dist: aiohttp>=3.11.0
 Provides-Extra: test
 Requires-Dist: aioresponses>=0.7.9; extra == "test"
 Requires-Dist: mypy>=1.15; extra == "test"
@@ -40,7 +40,7 @@ Dynamic: license-file
 
 An asynchronous Python client for interacting with the **Violet Pool Controller**.
 
-This library is primarily designed to power the official [Violet Pool Controller Home Assistant Integration](https://github.com/Xerolux/violet-hass), but it can be used independently for any Python project that needs to fetch readings or control a Violet Pool system.
+This library is primarily designed to power the [Violet Pool Controller Home Assistant Integration](https://github.com/Xerolux/violet-hass), but it can be used independently for any Python project that needs to fetch readings or control a Violet Pool system.
 
 > **📖 Documentation:**
 > - GitHub Pages: https://xerolux.github.io/violet-poolController-api/
@@ -117,7 +117,7 @@ The API client includes many more functions tailored to the Violet Controller:
 - `set_pv_surplus(active=True)`: Enable the PV-Surplus mode.
 - `manual_dosing(dosing_type="Chlor", duration=120)`: Trigger manual chemical dosing.
 
-For a full list of available commands and more detailed examples, please refer to the [Wiki](https://github.com/Xerolux/violet-poolController-api/wiki) or the source code in `api.py`.
+For a full list of available commands and more detailed examples, please refer to the [Wiki](https://github.com/Xerolux/violet-poolController-api/wiki) or the `_api_*.py` mixins, which hold the public methods.
 
 ## Violet Dosing Standalone Mode
 
@@ -136,7 +136,7 @@ api = VioletPoolAPI(
 In this mode, dosing functions (for example `manual_dosing` and dosing parameter/target updates) stay available, while base-module-only switch functions (for example pump/light/backwash) are blocked with a clear error message.
 
 **Note on getReadings format:**
-As of version `0.0.7`, the API client automatically detects and normalizes the payload output from the controller. Whether your Violet Controller returns the classic base-module `dict` structure (`{"PUMPSTATE": "2", "PH": 7.2}`) or the new standalone `list` structure, the `get_readings()` and `get_specific_readings()` functions will always return a seamless, flattened key-value dictionary. Your Home Assistant integration or downstream application will work uniformly with both formats without requiring any extra code!
+As of version `0.0.7`, the API client automatically detects and normalizes the payload output from the controller. Whether your Violet Controller returns the classic base-module `dict` structure (`{"PUMPSTATE": "2", "PH": 7.2}`) or the new standalone `list` structure, the `get_readings()` and `get_specific_readings()` functions always return a flattened key-value view. `get_readings()` returns a `VioletReadings`, a read-only `Mapping` with typed accessors on top; use `dict(readings)` where a plain `dict` is required, for example before JSON serialization. Your Home Assistant integration or downstream application will work uniformly with both formats without requiring any extra code!
 
 **Hardware Profile Detection:**
 As of the latest release, the API client provides a method to detect the specific hardware configuration of your Violet Controller.
@@ -152,7 +152,7 @@ print(profile)
 #     "extension_module_2": False,
 # }
 ```
-This detection parses `get_readings()` to check for the presence of certain internal status parameters (`SYSTEM_dosagemodule_cpu_temperature`, `EXT1_1`, `EXT2_1`), allowing your application to dynamically adapt to the connected modules (Base Module, Dosing Module, Relay Extension 1 and 2). By utilizing this detection, developers and integrations can accurately filter out features for missing hardware, ensuring that only supported options are exposed to the user.
+This detection reads the controller's own module counters (`SYSTEM_dosagemodule_alive_count`, `SYSTEM_ext1module_alive_count`, `SYSTEM_ext2module_alive_count`), allowing your application to dynamically adapt to the connected modules (Base Module, Dosing Module, Relay Extension 1 and 2). By utilizing this detection, developers and integrations can accurately filter out features for missing hardware, ensuring that only supported options are exposed to the user.
 
 ## Mock Server (Testing Without Hardware)
 
@@ -229,7 +229,7 @@ GNU Affero General Public License v3.0 or later (AGPLv3+)
 
 The **VIOLET Pool Controller** by [PoolDigital GmbH & Co. KG](https://www.pooldigital.de/) is a premium smart pool automation system developed in Germany, featuring a JSON API for seamless Home Assistant integration.
 
-- **Offizieller Shop:** [pooldigital.de](https://www.pooldigital.de/)
+- **Official shop:** [pooldigital.de](https://www.pooldigital.de/)
 - **Community:** [PoolDigital Forum](http://forum.pooldigital.de/)
 
 **Disclaimer:**

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39}/README.md

@@ -10,7 +10,7 @@
 
 An asynchronous Python client for interacting with the **Violet Pool Controller**.
 
-This library is primarily designed to power the official [Violet Pool Controller Home Assistant Integration](https://github.com/Xerolux/violet-hass), but it can be used independently for any Python project that needs to fetch readings or control a Violet Pool system.
+This library is primarily designed to power the [Violet Pool Controller Home Assistant Integration](https://github.com/Xerolux/violet-hass), but it can be used independently for any Python project that needs to fetch readings or control a Violet Pool system.
 
 > **📖 Documentation:**
 > - GitHub Pages: https://xerolux.github.io/violet-poolController-api/
@@ -87,7 +87,7 @@ The API client includes many more functions tailored to the Violet Controller:
 - `set_pv_surplus(active=True)`: Enable the PV-Surplus mode.
 - `manual_dosing(dosing_type="Chlor", duration=120)`: Trigger manual chemical dosing.
 
-For a full list of available commands and more detailed examples, please refer to the [Wiki](https://github.com/Xerolux/violet-poolController-api/wiki) or the source code in `api.py`.
+For a full list of available commands and more detailed examples, please refer to the [Wiki](https://github.com/Xerolux/violet-poolController-api/wiki) or the `_api_*.py` mixins, which hold the public methods.
 
 ## Violet Dosing Standalone Mode
 
@@ -106,7 +106,7 @@ api = VioletPoolAPI(
 In this mode, dosing functions (for example `manual_dosing` and dosing parameter/target updates) stay available, while base-module-only switch functions (for example pump/light/backwash) are blocked with a clear error message.
 
 **Note on getReadings format:**
-As of version `0.0.7`, the API client automatically detects and normalizes the payload output from the controller. Whether your Violet Controller returns the classic base-module `dict` structure (`{"PUMPSTATE": "2", "PH": 7.2}`) or the new standalone `list` structure, the `get_readings()` and `get_specific_readings()` functions will always return a seamless, flattened key-value dictionary. Your Home Assistant integration or downstream application will work uniformly with both formats without requiring any extra code!
+As of version `0.0.7`, the API client automatically detects and normalizes the payload output from the controller. Whether your Violet Controller returns the classic base-module `dict` structure (`{"PUMPSTATE": "2", "PH": 7.2}`) or the new standalone `list` structure, the `get_readings()` and `get_specific_readings()` functions always return a flattened key-value view. `get_readings()` returns a `VioletReadings`, a read-only `Mapping` with typed accessors on top; use `dict(readings)` where a plain `dict` is required, for example before JSON serialization. Your Home Assistant integration or downstream application will work uniformly with both formats without requiring any extra code!
 
 **Hardware Profile Detection:**
 As of the latest release, the API client provides a method to detect the specific hardware configuration of your Violet Controller.
@@ -122,7 +122,7 @@ print(profile)
 #     "extension_module_2": False,
 # }
 ```
-This detection parses `get_readings()` to check for the presence of certain internal status parameters (`SYSTEM_dosagemodule_cpu_temperature`, `EXT1_1`, `EXT2_1`), allowing your application to dynamically adapt to the connected modules (Base Module, Dosing Module, Relay Extension 1 and 2). By utilizing this detection, developers and integrations can accurately filter out features for missing hardware, ensuring that only supported options are exposed to the user.
+This detection reads the controller's own module counters (`SYSTEM_dosagemodule_alive_count`, `SYSTEM_ext1module_alive_count`, `SYSTEM_ext2module_alive_count`), allowing your application to dynamically adapt to the connected modules (Base Module, Dosing Module, Relay Extension 1 and 2). By utilizing this detection, developers and integrations can accurately filter out features for missing hardware, ensuring that only supported options are exposed to the user.
 
 ## Mock Server (Testing Without Hardware)
 
@@ -199,7 +199,7 @@ GNU Affero General Public License v3.0 or later (AGPLv3+)
 
 The **VIOLET Pool Controller** by [PoolDigital GmbH & Co. KG](https://www.pooldigital.de/) is a premium smart pool automation system developed in Germany, featuring a JSON API for seamless Home Assistant integration.
 
-- **Offizieller Shop:** [pooldigital.de](https://www.pooldigital.de/)
+- **Official shop:** [pooldigital.de](https://www.pooldigital.de/)
 - **Community:** [PoolDigital Forum](http://forum.pooldigital.de/)
 
 **Disclaimer:**

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "violet-poolController-api"
-version = "0.0.38"
+version = "0.0.39"
 authors = [
   { name="Basti (Xerolux)", email="git@xerolux.de" },
 ]
@@ -25,7 +25,11 @@ classifiers = [
     "Topic :: Home Automation",
 ]
 dependencies = [
-    "aiohttp>=3.11.0,<3.15",
+    # No upper bound on purpose: Home Assistant installs this package into
+    # its own environment and follows aiohttp closely.  A "<3.15" cap made pip
+    # refuse the install the day HA moved past it, taking the integration down
+    # with it.  Compatibility with newer aiohttp is handled in the test shim.
+    "aiohttp>=3.11.0",
 ]
 
 [project.optional-dependencies]

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39}/tests/test_api.py

@@ -274,11 +274,56 @@ async def test_set_config_sanitizes_payload_before_request(
 
     monkeypatch.setattr(api_client, "_request", fake_request)
 
-    result = await api_client.set_config({"pool mode": "A<mode>", "speed": 3.7})
+    result = await api_client.set_config({"POOL_MODE": "A<mode>", "speed": 3.7})
 
     assert result["success"] is True
     assert result["response"] == "OK"
-    assert captured["data"] == {"poolmode": "A<mode>", "speed": 3.7}
+    assert captured["data"] == {"POOL_MODE": "A<mode>", "speed": 3.7}
+
+
+@pytest.mark.asyncio
+async def test_set_config_rejects_invalid_key_instead_of_rewriting_it(
+    api_client: VioletPoolAPI,
+    monkeypatch: pytest.Monkeypatch,
+) -> None:
+    """A malformed key is an error, never a silent write to a different key.
+
+    ``"pool mode"`` used to be rewritten to ``"poolmode"`` and sent, so a typo
+    in a configuration key changed a setting the caller never named.
+    """
+    sent = False
+
+    async def fake_request(_endpoint: str, **_kwargs: Any) -> str:  # noqa: ANN401
+        nonlocal sent
+        sent = True
+        return "OK"
+
+    monkeypatch.setattr(api_client, "_request", fake_request)
+
+    with pytest.raises(VioletPoolAPIError, match="Invalid configuration parameter"):
+        await api_client.set_config({"pool mode": "A"})
+
+    assert sent is False
+
+
+@pytest.mark.asyncio
+async def test_set_config_rejects_unsupported_value_types(
+    api_client: VioletPoolAPI,
+    monkeypatch: pytest.Monkeypatch,
+) -> None:
+    """None and containers must not reach the controller as "None" or "1 2"."""
+
+    async def fake_request(_endpoint: str, **_kwargs: Any) -> str:  # noqa: ANN401
+        return "OK"
+
+    monkeypatch.setattr(api_client, "_request", fake_request)
+
+    for bad_value in (None, [1, 2], {"a": 1}):
+        with pytest.raises(VioletPoolAPIError):
+            await api_client.set_config({"SOME_KEY": bad_value})
+
+    with pytest.raises(VioletPoolAPIError, match="Non-finite"):
+        await api_client.set_config({"SOME_KEY": float("nan")})
 
 
 @pytest.mark.asyncio
@@ -1383,14 +1428,20 @@ async def test_command_result_dosing_started(
 
 
 @pytest.mark.asyncio
-async def test_command_result_dict_passthrough(
+async def test_command_result_normalizes_dict_input(
     api_client: VioletPoolAPI,
 ) -> None:
-    """Test _command_result passes dict through unchanged."""
+    """A dict body is normalized, so ``success`` is always present.
+
+    The old passthrough returned the dict unchanged, so a caller reading
+    ``result["success"]`` got a KeyError instead of a result.
+    """
     data = {"key": "value", "nested": {"a": 1}}
     result = VioletPoolAPI._command_result(data)
 
-    assert result is data
+    assert result["success"] is True
+    assert result["key"] == "value"
+    assert result["nested"] == {"a": 1}
 
 
 @pytest.mark.asyncio
@@ -2130,3 +2181,163 @@ def test_input_sanitizer_no_duplicate_validate_duration() -> None:
 
     assert not hasattr(InputSanitizer, "validate_duration")
     assert not hasattr(InputSanitizer, "validate_speed")
+
+
+def _request_count(mocked: aioresponses, method: str, path: str) -> int:
+    """Count recorded requests to *path*, ignoring query-string normalization.
+
+    yarl rewrites a value-less query (``?PUMP,ON,0,0``) by appending ``=``, so
+    the recorded key never equals the URL that was requested.
+    """
+    return sum(
+        len(calls)
+        for (recorded_method, url), calls in mocked.requests.items()
+        if recorded_method == method and url.path == path
+    )
+
+
+# ---------------------------------------------------------------------------
+# Regression: state-changing commands are sent exactly once (0.0.39)
+# ---------------------------------------------------------------------------
+
+
+@pytest.mark.asyncio
+async def test_switch_command_is_not_retried(
+    mock_aioresponse: aioresponses,
+) -> None:
+    """A failed switch command must not be repeated.
+
+    The controller applies state changes through GET, and a request that
+    timed out may well have been applied.  Repeating it can toggle the output
+    back or apply it a second time.
+    """
+    url = "http://192.168.1.100/setFunctionManually?PUMP,ON,0,0"
+    mock_aioresponse.get(url, status=500, body="boom")
+
+    async with aiohttp.ClientSession() as session:
+        api = VioletPoolAPI(host="192.168.1.100", session=session, max_retries=3)
+        with pytest.raises(VioletPoolAPIError):
+            await api.set_switch_state("PUMP", "ON")
+
+    assert _request_count(mock_aioresponse, "GET", "/setFunctionManually") == 1
+
+
+@pytest.mark.asyncio
+async def test_digital_rule_trigger_is_not_retried(
+    mock_aioresponse: aioresponses,
+) -> None:
+    """PUSH is a toggle: a retry would undo the change it just made."""
+    url = "http://192.168.1.100/setFunctionManually?DIRULE_1,PUSH,0,0"
+    mock_aioresponse.get(url, status=500, body="boom")
+
+    async with aiohttp.ClientSession() as session:
+        api = VioletPoolAPI(host="192.168.1.100", session=session, max_retries=3)
+        with pytest.raises(VioletPoolAPIError):
+            await api.trigger_digital_input_rule("DIRULE_1")
+
+    assert _request_count(mock_aioresponse, "GET", "/setFunctionManually") == 1
+
+
+@pytest.mark.asyncio
+async def test_init_update_is_not_retried(
+    mock_aioresponse: aioresponses,
+) -> None:
+    """Starting a firmware update twice is not harmless."""
+    url = "http://192.168.1.100/initUpdate"
+    mock_aioresponse.get(url, status=503, body="busy")
+
+    async with aiohttp.ClientSession() as session:
+        api = VioletPoolAPI(host="192.168.1.100", session=session, max_retries=3)
+        with pytest.raises(VioletPoolAPIError):
+            await api.init_update()
+
+    assert _request_count(mock_aioresponse, "GET", "/initUpdate") == 1
+
+
+@pytest.mark.asyncio
+async def test_reads_are_still_retried(
+    mock_aioresponse: aioresponses,
+) -> None:
+    """The read path keeps its retries; repeating a read costs nothing."""
+    url = "http://192.168.1.100/getReadings?ALL"
+    mock_aioresponse.get(url, status=500, body="boom")
+    mock_aioresponse.get(url, status=500, body="boom")
+    mock_aioresponse.get(url, payload={"getReadings": {"PUMP": "1"}}, status=200)
+
+    async with aiohttp.ClientSession() as session:
+        api = VioletPoolAPI(host="192.168.1.100", session=session, max_retries=3)
+        readings = await api.get_readings()
+
+    assert readings["PUMP"] == "1"
+    assert _request_count(mock_aioresponse, "GET", "/getReadings") == 3
+
+
+@pytest.mark.asyncio
+async def test_rate_limit_wait_timeout_fails_instead_of_bypassing(
+    mock_aioresponse: aioresponses,
+    monkeypatch: pytest.Monkeypatch,
+) -> None:
+    """A limiter timeout must fail the request, not send it without a token.
+
+    Sending anyway let every caller that waited out the timeout hit the
+    controller at once, which is the pile-up the limiter exists to prevent.
+    """
+    url = "http://192.168.1.100/getReadings?ALL"
+    mock_aioresponse.get(url, payload={"getReadings": {}}, status=200)
+
+    async with aiohttp.ClientSession() as session:
+        api = VioletPoolAPI(host="192.168.1.100", session=session, max_retries=1)
+
+        async def always_timeout(**_kwargs: Any) -> None:
+            raise TimeoutError
+
+        monkeypatch.setattr(api._rate_limiter, "wait_if_needed", always_timeout)
+
+        with pytest.raises(VioletPoolAPIError, match="Rate limit wait"):
+            await api.get_readings()
+
+    assert _request_count(mock_aioresponse, "GET", "/getReadings") == 0
+
+
+@pytest.mark.asyncio
+async def test_html_login_page_does_not_open_the_circuit_breaker(
+    mock_aioresponse: aioresponses,
+) -> None:
+    """A captive portal answers 200 with HTML every time, deterministically.
+
+    Counting those as transient failures opened the breaker and replaced the
+    payload error that explains the actual problem.
+    """
+    url = "http://192.168.1.100/getReadings?ALL"
+    for _ in range(8):
+        mock_aioresponse.get(url, body="<html>login</html>", status=200)
+
+    async with aiohttp.ClientSession() as session:
+        api = VioletPoolAPI(host="192.168.1.100", session=session, max_retries=1)
+        for _ in range(8):
+            with pytest.raises(VioletPoolAPIError) as excinfo:
+                await api.get_readings()
+            assert "Invalid JSON payload" in str(excinfo.value)
+
+
+def test_hostname_error_never_echoes_credentials() -> None:
+    """The message reaches config-flow errors and logs; it must stay clean."""
+    with pytest.raises(ValueError, match="must not contain credentials") as excinfo:
+        VioletPoolAPI._build_secure_base_url(
+            VioletPoolAPI,
+            "http://admin:s3cret@192.168.1.5",
+            use_ssl=False,
+        )
+
+    assert "s3cret" not in str(excinfo.value)
+
+
+def test_hostname_accepts_underscores() -> None:
+    """mDNS and router-assigned names use underscores."""
+    url = VioletPoolAPI._build_secure_base_url(
+        VioletPoolAPI,
+        "violet_pool.local",
+        use_ssl=False,
+    )
+
+    assert url == "http://violet_pool.local"

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39}/tests/test_language_policy.py

@@ -64,6 +64,24 @@ GERMAN_WORDS = (
     "dieser",
     "keine",
     "sollte",
+    # Added after 0.0.38 shipped with ~20 German docstrings and log lines in
+    # utils_sanitizer.py and utils_rate_limiter.py that this list did not see.
+    "einen",
+    "eine",
+    "verwende",
+    "ungültig",
+    "ungültige",
+    "ungültigen",
+    "ungültiger",
+    "verfügbar",
+    "gefährlich",
+    "gefährliche",
+    "erlaubt",
+    "erlaubter",
+    "zurückgesetzt",
+    "initialisiert",
+    "unbekannter",
+    "warte",
 )
 _GERMAN = re.compile(r"\b(" + "|".join(GERMAN_WORDS) + r")\b", re.IGNORECASE)
 

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39/violet_poolController_api.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: violet-poolController-api
-Version: 0.0.38
+Version: 0.0.39
 Summary: Asynchronous Python client for the Violet Pool Controller.
 Author-email: "Basti (Xerolux)" <git@xerolux.de>
 License-Expression: AGPL-3.0-or-later
@@ -20,7 +20,7 @@ Classifier: Topic :: Home Automation
 Requires-Python: >=3.12
 Description-Content-Type: text/markdown
 License-File: LICENSE
-Requires-Dist: aiohttp<3.15,>=3.11.0
+Requires-Dist: aiohttp>=3.11.0
 Provides-Extra: test
 Requires-Dist: aioresponses>=0.7.9; extra == "test"
 Requires-Dist: mypy>=1.15; extra == "test"
@@ -40,7 +40,7 @@ Dynamic: license-file
 
 An asynchronous Python client for interacting with the **Violet Pool Controller**.
 
-This library is primarily designed to power the official [Violet Pool Controller Home Assistant Integration](https://github.com/Xerolux/violet-hass), but it can be used independently for any Python project that needs to fetch readings or control a Violet Pool system.
+This library is primarily designed to power the [Violet Pool Controller Home Assistant Integration](https://github.com/Xerolux/violet-hass), but it can be used independently for any Python project that needs to fetch readings or control a Violet Pool system.
 
 > **📖 Documentation:**
 > - GitHub Pages: https://xerolux.github.io/violet-poolController-api/
@@ -117,7 +117,7 @@ The API client includes many more functions tailored to the Violet Controller:
 - `set_pv_surplus(active=True)`: Enable the PV-Surplus mode.
 - `manual_dosing(dosing_type="Chlor", duration=120)`: Trigger manual chemical dosing.
 
-For a full list of available commands and more detailed examples, please refer to the [Wiki](https://github.com/Xerolux/violet-poolController-api/wiki) or the source code in `api.py`.
+For a full list of available commands and more detailed examples, please refer to the [Wiki](https://github.com/Xerolux/violet-poolController-api/wiki) or the `_api_*.py` mixins, which hold the public methods.
 
 ## Violet Dosing Standalone Mode
 
@@ -136,7 +136,7 @@ api = VioletPoolAPI(
 In this mode, dosing functions (for example `manual_dosing` and dosing parameter/target updates) stay available, while base-module-only switch functions (for example pump/light/backwash) are blocked with a clear error message.
 
 **Note on getReadings format:**
-As of version `0.0.7`, the API client automatically detects and normalizes the payload output from the controller. Whether your Violet Controller returns the classic base-module `dict` structure (`{"PUMPSTATE": "2", "PH": 7.2}`) or the new standalone `list` structure, the `get_readings()` and `get_specific_readings()` functions will always return a seamless, flattened key-value dictionary. Your Home Assistant integration or downstream application will work uniformly with both formats without requiring any extra code!
+As of version `0.0.7`, the API client automatically detects and normalizes the payload output from the controller. Whether your Violet Controller returns the classic base-module `dict` structure (`{"PUMPSTATE": "2", "PH": 7.2}`) or the new standalone `list` structure, the `get_readings()` and `get_specific_readings()` functions always return a flattened key-value view. `get_readings()` returns a `VioletReadings`, a read-only `Mapping` with typed accessors on top; use `dict(readings)` where a plain `dict` is required, for example before JSON serialization. Your Home Assistant integration or downstream application will work uniformly with both formats without requiring any extra code!
 
 **Hardware Profile Detection:**
 As of the latest release, the API client provides a method to detect the specific hardware configuration of your Violet Controller.
@@ -152,7 +152,7 @@ print(profile)
 #     "extension_module_2": False,
 # }
 ```
-This detection parses `get_readings()` to check for the presence of certain internal status parameters (`SYSTEM_dosagemodule_cpu_temperature`, `EXT1_1`, `EXT2_1`), allowing your application to dynamically adapt to the connected modules (Base Module, Dosing Module, Relay Extension 1 and 2). By utilizing this detection, developers and integrations can accurately filter out features for missing hardware, ensuring that only supported options are exposed to the user.
+This detection reads the controller's own module counters (`SYSTEM_dosagemodule_alive_count`, `SYSTEM_ext1module_alive_count`, `SYSTEM_ext2module_alive_count`), allowing your application to dynamically adapt to the connected modules (Base Module, Dosing Module, Relay Extension 1 and 2). By utilizing this detection, developers and integrations can accurately filter out features for missing hardware, ensuring that only supported options are exposed to the user.
 
 ## Mock Server (Testing Without Hardware)
 
@@ -229,7 +229,7 @@ GNU Affero General Public License v3.0 or later (AGPLv3+)
 
 The **VIOLET Pool Controller** by [PoolDigital GmbH & Co. KG](https://www.pooldigital.de/) is a premium smart pool automation system developed in Germany, featuring a JSON API for seamless Home Assistant integration.
 
-- **Offizieller Shop:** [pooldigital.de](https://www.pooldigital.de/)
+- **Official shop:** [pooldigital.de](https://www.pooldigital.de/)
 - **Community:** [PoolDigital Forum](http://forum.pooldigital.de/)
 
 **Disclaimer:**

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39}/violet_poolController_api.egg-info/requires.txt

@@ -1,4 +1,4 @@
-aiohttp<3.15,>=3.11.0
+aiohttp>=3.11.0
 
 [test]
 aioresponses>=0.7.9

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39}/violet_poolcontroller_api/__init__.py

@@ -25,9 +25,10 @@ from .api import (
     VioletSetpointError,
     VioletTimeoutError,
     VioletUnsafeOperationError,
+    validate_duration,
     validate_setpoint,
 )
-from .circuit_breaker import CircuitBreaker, CircuitBreakerOpenError
+from .circuit_breaker import CircuitBreaker, CircuitBreakerOpenError, CircuitBreakerState
 from .const_api import (  # noqa: F401
     ACTION_ALLAUTO,
     ACTION_ALLOFF,
@@ -39,16 +40,39 @@ from .const_api import (  # noqa: F401
     ACTION_ON,
     ACTION_PUSH,
     ACTION_UNLOCK,
+    API_PRIORITY_CRITICAL,
+    API_PRIORITY_HIGH,
+    API_PRIORITY_LOW,
+    API_PRIORITY_NORMAL,
+    DOSING_CANISTER_ID,
+    DOSING_CONFIG_PREFIX,
+    DOSING_FUNCTIONS,
+    DOSING_OUTPUT_INDEX,
     ERROR_CODES,
     ERROR_SEVERITY_ALARM,
     ERROR_SEVERITY_INFO,
     ERROR_SEVERITY_REMINDER,
     ERROR_SEVERITY_WARNING,
+    LOG_TYPE_ACTIONS,
+    LOG_TYPE_ONEWIRE,
+    LOG_TYPE_SWITCHING,
+    LOG_TYPES,
+    NON_RETRYABLE_ENDPOINTS,
+    OMNI_POSITIONS,
+    RS485_PUMP_MODES,
+    RS485_PUMP_NAMES,
+    SPECIFIC_READING_GROUPS,
+    SWITCH_FUNCTIONS,
+    SYSTEM_SERVICES,
+    TARGET_MIN_CHLORINE,
+    TARGET_ORP,
+    TARGET_PH,
 )
 from .const_devices import (  # noqa: F401
     COVER_FUNCTIONS,
     COVER_STATE_MAP,
     DEVICE_PARAMETERS,
+    DEVICE_STATE_MAPPING,
     STATE_TRANSLATIONS,
     CoverState,
     DmxSceneState,
@@ -57,6 +81,8 @@ from .const_devices import (  # noqa: F401
     PvSurplusState,
     RuleState,
     VioletState,
+    get_device_mode_from_state,
+    get_device_state_info,
     get_state_translation_language,
     set_state_translation_language,
 )
@@ -82,12 +108,14 @@ __all__ = [
     "VioletPayloadError",
     "VioletSetpointError",
     "VioletUnsafeOperationError",
-    # Setpoint validation
+    # Setpoint and duration validation
     "SETPOINT_RANGES",
     "validate_setpoint",
+    "validate_duration",
     # Circuit breaker
     "CircuitBreaker",
     "CircuitBreakerOpenError",
+    "CircuitBreakerState",
     # Enums
     "OutputState",
     "DmxSceneState",
@@ -97,6 +125,9 @@ __all__ = [
     "PvSurplusState",
     # State helpers
     "VioletState",
+    "DEVICE_STATE_MAPPING",
+    "get_device_state_info",
+    "get_device_mode_from_state",
     "STATE_TRANSLATIONS",
     "get_state_translation_language",
     "set_state_translation_language",
@@ -124,10 +155,32 @@ __all__ = [
     "ACTION_ON",
     "ACTION_PUSH",
     "ACTION_UNLOCK",
-    # Device constants
+    # Device and API constants
     "COVER_FUNCTIONS",
     "COVER_STATE_MAP",
     "DEVICE_PARAMETERS",
+    "SWITCH_FUNCTIONS",
+    "DOSING_FUNCTIONS",
+    "DOSING_OUTPUT_INDEX",
+    "DOSING_CONFIG_PREFIX",
+    "DOSING_CANISTER_ID",
+    "OMNI_POSITIONS",
+    "SYSTEM_SERVICES",
+    "RS485_PUMP_NAMES",
+    "RS485_PUMP_MODES",
+    "LOG_TYPES",
+    "LOG_TYPE_ACTIONS",
+    "LOG_TYPE_SWITCHING",
+    "LOG_TYPE_ONEWIRE",
+    "SPECIFIC_READING_GROUPS",
+    "NON_RETRYABLE_ENDPOINTS",
+    "TARGET_PH",
+    "TARGET_ORP",
+    "TARGET_MIN_CHLORINE",
+    "API_PRIORITY_CRITICAL",
+    "API_PRIORITY_HIGH",
+    "API_PRIORITY_NORMAL",
+    "API_PRIORITY_LOW",
     # Error codes
     "ERROR_CODES",
     "ERROR_SEVERITY_ALARM",

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39}/violet_poolcontroller_api/_api_dosing.py

@@ -54,6 +54,7 @@ class DosingMixin(APIClientMixin):
         action: str,
         *,
         duration: int | None = None,
+        source: int = 1,
     ) -> dict[str, Any]:
         """Trigger or stop a manual dosing run via /triggerManualDosing.
 
@@ -67,6 +68,9 @@ class DosingMixin(APIClientMixin):
             action: ON/START → DOSSTART; OFF/STOP/AUTO → DOSSTOP
                 (stopping a run returns the channel to automatic mode).
             duration: Duration in seconds (whole number).
+            source: Value of the firmware's ``from`` form field, which selects
+                the chemical on channels shared by more than one agent.  The
+                default (1) addresses the channel's primary agent.
 
         Returns:
             A dictionary with the command result.
@@ -103,7 +107,7 @@ class DosingMixin(APIClientMixin):
             "action": dos_action,
             "output": str(output_index),
             "runtime": str(dos_duration),
-            "from": "1",
+            "from": str(int(source)),
             "runtime_formatted": f"{dos_duration // 60:02d}:{dos_duration % 60:02d}",
         }
         body = await self._request(
@@ -111,6 +115,7 @@ class DosingMixin(APIClientMixin):
             method="POST",
             data=form_data,
             priority=API_PRIORITY_CRITICAL,
+            retryable=False,
         )
         return self._command_result(body)
 
@@ -133,6 +138,10 @@ class DosingMixin(APIClientMixin):
             msg = f"Unknown dosing type: {dosing_type}"
             raise VioletPoolAPIError(msg)
 
+        # Validate before comparing: a non-numeric duration used to raise a
+        # bare TypeError from the ``duration <= 0`` test below.
+        duration = validate_duration(duration, minimum=0)
+
         # /triggerManualDosing requires an explicit runtime; duration <= 0
         # stops a running manual dosing instead (documented behavior).
         if duration <= 0:
@@ -219,7 +228,9 @@ class DosingMixin(APIClientMixin):
         """
         numeric_value = _to_float(key, value)
         validate_setpoint(key, numeric_value)
-        return await self.set_config({key: value})
+        # Send the validated number, not the original: a string like " 28.5 "
+        # would otherwise reach the controller unparsed.
+        return await self.set_config({key: numeric_value})
 
     async def set_dosing_parameters(
         self,

{violet_poolcontroller_api-0.0.38 → violet_poolcontroller_api-0.0.39}/violet_poolcontroller_api/_api_mixin.py

@@ -4,6 +4,8 @@ from __future__ import annotations
 
 from typing import TYPE_CHECKING, Any
 
+from .const_api import API_PRIORITY_NORMAL
+
 if TYPE_CHECKING:
     from collections.abc import Iterable, Mapping
 
@@ -35,6 +37,7 @@ class APIClientMixin:
         params: Mapping[str, Any] | None = None,
         query: str | None = None,
         payload_name: str,
+        priority: int = API_PRIORITY_NORMAL,
     ) -> dict[str, Any]:
         raise NotImplementedError