violet-poolController-api 0.0.34__tar.gz → 0.0.35__tar.gz

{violet_poolcontroller_api-0.0.34/violet_poolController_api.egg-info → violet_poolcontroller_api-0.0.35}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: violet-poolController-api
-Version: 0.0.34
+Version: 0.0.35
 Summary: Asynchronous Python client for the Violet Pool Controller.
 Author-email: "Basti (Xerolux)" <git@xerolux.de>
 License: AGPL-3.0-or-later

{violet_poolcontroller_api-0.0.34 → violet_poolcontroller_api-0.0.35}/pyproject.toml

@@ -10,7 +10,7 @@ violet_poolcontroller_api = ["py.typed"]
 
 [project]
 name = "violet-poolController-api"
-version = "0.0.34"
+version = "0.0.35"
 authors = [
   { name="Basti (Xerolux)", email="git@xerolux.de" },
 ]

{violet_poolcontroller_api-0.0.34 → violet_poolcontroller_api-0.0.35}/tests/test_api.py

@@ -96,6 +96,47 @@ async def test_get_readings_success(
     assert dict(result) == mock_data
 
 
+@pytest.mark.asyncio
+async def test_get_output_runtimes_success(
+    mock_aioresponse: aioresponses,
+    api_client: VioletPoolAPI,
+) -> None:
+    """Test get_output_runtimes parses a JSON dict response.
+
+    Regression: previously the endpoint was requested without expect_json,
+    so the raw text body was returned and the method logged a warning
+    ("Unexpected non-dict response for get_output_runtimes: str") and
+    returned an empty dict.
+    """
+    url = "http://192.168.1.100/getOutputruntimes"
+    mock_data = {
+        "PUMP_RUNTIME": "04h 33m 12s",
+        "PUMP_LAST_ON": 1700000000,
+        "PUMP_LAST_OFF": 1699996800,
+        "CPU_UPTIME": "12d 4h 30m",
+        "LOAD_AVG": "0.42",
+    }
+    mock_aioresponse.get(url, payload=mock_data, status=200)
+
+    result = await api_client.get_output_runtimes()
+
+    assert isinstance(result, dict)
+    assert result == mock_data
+
+
+@pytest.mark.asyncio
+async def test_get_output_runtimes_non_dict_raises(
+    mock_aioresponse: aioresponses,
+    api_client: VioletPoolAPI,
+) -> None:
+    """Test get_output_runtimes raises when the controller returns a non-dict."""
+    url = "http://192.168.1.100/getOutputruntimes"
+    mock_aioresponse.get(url, body="not-json", status=200)
+
+    with pytest.raises(VioletPoolAPIError):
+        await api_client.get_output_runtimes()
+
+
 @pytest.mark.asyncio
 async def test_set_pump_speed_success(
     mock_aioresponse: aioresponses,

{violet_poolcontroller_api-0.0.34 → violet_poolcontroller_api-0.0.35/violet_poolController_api.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: violet-poolController-api
-Version: 0.0.34
+Version: 0.0.35
 Summary: Asynchronous Python client for the Violet Pool Controller.
 Author-email: "Basti (Xerolux)" <git@xerolux.de>
 License: AGPL-3.0-or-later

{violet_poolcontroller_api-0.0.34 → violet_poolcontroller_api-0.0.35}/violet_poolcontroller_api/api.py

@@ -2205,23 +2205,18 @@ class VioletPoolAPI:
 
         Returns a flat dict with runtime (HH:MM:SS format) and last-on/off
         (ISO datetime strings) for all outputs: PUMP, SOLAR, HEATER, BACKWASH,
-        REFILL, LIGHT, ECO, all dosing outputs, OMNI_DC channels, and extension
+        REFILL, LIGHT, ECO, all dosing outputs, OMNIDC channels, and extension
         relay channels.  Also includes CPU_UPTIME, LOAD_AVG, and version fields.
 
         Returns:
-            Dict with runtime/timestamp strings for all outputs, or empty dict
-            on error.
+            Dict with runtime/timestamp strings for all outputs.
 
         Raises:
-            VioletPoolAPIError: If the API call fails.
+            VioletPoolAPIError: If the API call fails or the response is not a
+                JSON object.
 
         """
-        resp = await self._request(
+        return await self._request_json_dict(
             API_GET_OUTPUT_RUNTIMES,
-            method="GET",
-            priority=API_PRIORITY_NORMAL,
+            payload_name="getOutputruntimes",
         )
-        if isinstance(resp, dict):
-            return resp
-        _LOGGER.warning("Unexpected non-dict response for get_output_runtimes: %s", type(resp).__name__)
-        return {}