velopack 1.0.1__tar.gz → 1.0.9.dev49442__tar.gz

{velopack-1.0.1 → velopack-1.0.9.dev49442}/Cargo.lock

@@ -4057,7 +4057,7 @@ dependencies = [
 
 [[package]]
 name = "velopack"
-version = "1.0.1"
+version = "1.0.9-gc12205f"
 dependencies = [
  "anyhow",
  "bitflags 2.11.1",
@@ -4091,7 +4091,7 @@ dependencies = [
 
 [[package]]
 name = "velopack_bins"
-version = "1.0.1"
+version = "1.0.9-gc12205f"
 dependencies = [
  "anyhow",
  "bitflags 2.11.1",
@@ -4143,7 +4143,7 @@ dependencies = [
 
 [[package]]
 name = "velopack_l18n"
-version = "1.0.1"
+version = "1.0.9-gc12205f"
 dependencies = [
  "anyhow",
  "fluent",
@@ -4159,7 +4159,7 @@ dependencies = [
 
 [[package]]
 name = "velopack_libc"
-version = "1.0.1"
+version = "1.0.9-gc12205f"
 dependencies = [
  "anyhow",
  "cbindgen",
@@ -4176,7 +4176,7 @@ dependencies = [
 
 [[package]]
 name = "velopack_nodeffi"
-version = "1.0.1"
+version = "1.0.9-gc12205f"
 dependencies = [
  "lazy_static",
  "log",
@@ -4200,7 +4200,7 @@ dependencies = [
 
 [[package]]
 name = "velopack_wix"
-version = "1.0.1"
+version = "1.0.9-gc12205f"
 dependencies = [
  "anyhow",
  "remove_dir_all",

{velopack-1.0.1 → velopack-1.0.9.dev49442}/Cargo.toml

@@ -6,7 +6,7 @@ exclude = [
 ]
 
 [workspace.package]
-version = "1.0.1"
+version = "1.0.9-gc12205f"
 authors = ["Velopack Ltd, Caelan Sayler <git@caesay.com>"]
 homepage = "https://velopack.io"
 repository = "https://github.com/velopack/velopack"

{velopack-1.0.1 → velopack-1.0.9.dev49442}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: velopack
-Version: 1.0.1
+Version: 1.0.9.dev49442
 Summary: Installer and automatic update framework for cross-platform desktop applications
 Home-Page: https://velopack.io
 Author: Velopack Ltd, Caelan Sayler <git@caesay.com>

{velopack-1.0.1 → velopack-1.0.9.dev49442}/pyproject.toml

@@ -2,7 +2,7 @@
 dynamic = ["description", "authors", "license"]
 name = "velopack"
 requires-python = ">=3.8"
-version = "1.0.1"
+version = "1.0.9.dev49442"
 
 [build-system]
 requires = ["maturin>=1.0,<2.0"]

{velopack-1.0.1 → velopack-1.0.9.dev49442}/src/lib-python/src/manager.rs

@@ -54,46 +54,35 @@ impl UpdateManagerWrapper {
 
     #[pyo3(signature = (update_info, progress_callback = None))]
     pub fn download_updates(&mut self, py: Python, update_info: PyUpdateInfo, progress_callback: Option<Py<PyAny>>) -> Result<()> {
-        // Convert PyUpdateInfo back to rust UpdateInfo
         let rust_update_info: UpdateInfo = update_info.into();
+        let inner = self.inner.clone();
 
-        if let Some(callback) = progress_callback {
-            // Create a channel for progress updates
-            let (sender, receiver) = mpsc::channel::<i16>();
-
-            // Clone the callback for the thread
-            let callback_clone = callback.clone_ref(py);
-
-            // Release the GIL before starting the download
-            py.detach(|| {
-                // Spawn a thread to handle progress updates
-                let progress_thread = thread::spawn(move || {
-                    while let Ok(progress) = receiver.recv() {
-                        // Acquire GIL only when needed to call the callback
-                        Python::try_attach(|py| {
-                            if let Err(e) = callback_clone.call1(py, (progress,)) {
-                                // Log error but continue - don't break the download
-                                eprintln!("Progress callback error: {}", e);
-                            }
-                        });
-                    }
-                });
-
-                // Call download with the sender
-                let result = self.inner.download_updates(&rust_update_info, Some(sender));
-
-                // Wait for the progress thread to finish
-                let _ = progress_thread.join();
-
-                result
-            })?;
-
-            Ok(())
+        let (sender, receiver) = if progress_callback.is_some() {
+            let (s, r) = mpsc::channel::<i16>();
+            (Some(s), Some(r))
         } else {
-            // No progress callback provided - still release GIL for the download
-            py.detach(|| self.inner.download_updates(&rust_update_info, None))?;
-            Ok(())
-        }
+            (None, None)
+        };
+
+        py.detach(|| {
+            let handle = thread::spawn(move || inner.download_updates(&rust_update_info, sender));
+
+            if let (Some(callback), Some(receiver)) = (progress_callback, receiver) {
+                while let Ok(progress) = receiver.recv() {
+                    Python::try_attach(|py| {
+                        if let Err(e) = callback.call1(py, (progress,)) {
+                            eprintln!("Progress callback error: {}", e);
+                        }
+                    });
+                }
+            }
+
+            handle
+                .join()
+                .unwrap_or_else(|_| Err(std::io::Error::other("Download thread panicked").into()))
+        })?;
+
+        Ok(())
     }
 
     pub fn apply_updates_and_restart(&mut self, update: PyUpdateInfoOrAsset) -> Result<()> {

{velopack-1.0.1 → velopack-1.0.9.dev49442}/src/lib-rust/src/misc.rs

@@ -52,7 +52,7 @@ pub fn calculate_sha1_sha256<P: AsRef<Path>>(file: P) -> Result<(String, String)
     let mut sha256 = sha2::Sha256::new();
     let mut sha1 = sha1::Sha1::new();
 
-    let mut buffer = [0u8; 1024 * 1024]; // 1MB buffer
+    let mut buffer = [0u8; 64 * 1024];
     loop {
         let bytes_read = reader.read(&mut buffer)?;
         if bytes_read == 0 {