velocity-python 0.2.7__tar.gz → 0.2.8__tar.gz

{velocity_python-0.2.7/src/velocity_python.egg-info → velocity_python-0.2.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: velocity-python
-Version: 0.2.7
+Version: 0.2.8
 Summary: A rapid application development library for interfacing with data storage
 Author-email: Velocity Team <info@codeclubs.org>
 License-Expression: MIT
@@ -267,7 +267,6 @@ What changed in each release, and what callers must do before upgrading, is in
 | Testing Guide | `docs/TESTING.md` | Running tests, markers, coverage |
 | Security | `docs/SECURITY.md` | Pre-commit hooks, credential scanning |
 | Changelog | `CHANGELOG.md` | Per-release breaking changes, deploy ordering, additions and fixes |
-| Improvement Backlog | `docs/IMPROVEMENT_BACKLOG.md` | Proposed and deferred library improvements |
 
 ---
 

{velocity_python-0.2.7 → velocity_python-0.2.8}/README.md

@@ -174,7 +174,6 @@ What changed in each release, and what callers must do before upgrading, is in
 | Testing Guide | `docs/TESTING.md` | Running tests, markers, coverage |
 | Security | `docs/SECURITY.md` | Pre-commit hooks, credential scanning |
 | Changelog | `CHANGELOG.md` | Per-release breaking changes, deploy ordering, additions and fixes |
-| Improvement Backlog | `docs/IMPROVEMENT_BACKLOG.md` | Proposed and deferred library improvements |
 
 ---
 

{velocity_python-0.2.7 → velocity_python-0.2.8}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "velocity-python"
-version = "0.2.7"
+version = "0.2.8"
 authors = [
   { name="Velocity Team", email="info@codeclubs.org" },
 ]

{velocity_python-0.2.7 → velocity_python-0.2.8}/src/velocity/__init__.py

@@ -1,4 +1,4 @@
-__version__ = version = "0.2.7"
+__version__ = version = "0.2.8"
 
 import importlib as _importlib
 

{velocity_python-0.2.7 → velocity_python-0.2.8}/src/velocity/payment/braintree_adapter.py

@@ -113,6 +113,24 @@ def parse_braintree_environment(value: Any = None) -> str:
     return name
 
 
+def _decline_details(transaction: Any) -> Dict[str, Any]:
+    """The processor's own verdict on a declined sale, for callers that decide
+    whether to try the card again: ``processor_response_code``,
+    ``processor_response_text`` and ``processor_response_type``
+    (``approved`` / ``soft_declined`` / ``hard_declined`` -- Braintree's
+    classification; a hard decline will not be approved on retry). Only the
+    keys Braintree set; empty without a transaction (gateway rejection or
+    validation failure)."""
+    if transaction is None:
+        return {}
+    details = {
+        "processor_response_code": _attr(transaction, "processor_response_code"),
+        "processor_response_text": _attr(transaction, "processor_response_text"),
+        "processor_response_type": _attr(transaction, "processor_response_type"),
+    }
+    return {key: value for key, value in details.items() if value not in (None, "")}
+
+
 def _deep_errors(result: Any) -> List[str]:
     errors = getattr(getattr(result, "errors", None), "deep_errors", None) or []
     return [scrub(f"{error.code}: {error.message}") for error in errors]
@@ -556,7 +574,11 @@ class BraintreeAdapter(PaymentProcessorAdapter):
             "expires_at": None,
             "error_message": error_message,
             "metadata": _with_reference(
-                {"braintree_errors": _deep_errors(result)}, order_id
+                {
+                    "braintree_errors": _deep_errors(result),
+                    **_decline_details(result.transaction),
+                },
+                order_id,
             ),
         }
 
@@ -674,7 +696,12 @@ class BraintreeAdapter(PaymentProcessorAdapter):
             )
             error_message = scrub(result.transaction.processor_response_text)
         return failure(
-            "failed", error_message, {"braintree_errors": _deep_errors(result)}
+            "failed",
+            error_message,
+            {
+                "braintree_errors": _deep_errors(result),
+                **_decline_details(result.transaction),
+            },
         )
 
     def find_charge_by_reference(

{velocity_python-0.2.7 → velocity_python-0.2.8}/src/velocity/payment/stripe_adapter.py

@@ -139,6 +139,16 @@ def _amount_captured(payment_intent: Any, charge: Any, requested: Optional[int])
     return 0
 
 
+def _decline_details(error: Any) -> Dict[str, Any]:
+    """``decline_code`` of a card decline (``CardError``): the issuer's reason
+    (``insufficient_funds``, ``lost_card``, ``expired_card`` ...), for callers
+    that decide whether to try the card again. Empty when Stripe gave none."""
+    decline_code = getattr(error, "decline_code", None) or getattr(
+        getattr(error, "error", None), "decline_code", None
+    )
+    return {"decline_code": decline_code} if decline_code else {}
+
+
 class StripeAdapter(PaymentProcessorAdapter):
     """
     Stripe Connect adapter for payment processing.
@@ -664,6 +674,7 @@ class StripeAdapter(PaymentProcessorAdapter):
                     "error_code": e.code,
                     "error_type": type(e).__name__,
                     "idempotency_key": idempotency_key,
+                    **_decline_details(e),
                 },
             }
             if reference:
@@ -824,6 +835,7 @@ class StripeAdapter(PaymentProcessorAdapter):
                     "error_code": e.code,
                     "error_type": type(e).__name__,
                     "idempotency_key": idempotency_key,
+                    **_decline_details(e),
                 },
             }
             if reference:

{velocity_python-0.2.7 → velocity_python-0.2.8/src/velocity_python.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: velocity-python
-Version: 0.2.7
+Version: 0.2.8
 Summary: A rapid application development library for interfacing with data storage
 Author-email: Velocity Team <info@codeclubs.org>
 License-Expression: MIT
@@ -267,7 +267,6 @@ What changed in each release, and what callers must do before upgrading, is in
 | Testing Guide | `docs/TESTING.md` | Running tests, markers, coverage |
 | Security | `docs/SECURITY.md` | Pre-commit hooks, credential scanning |
 | Changelog | `CHANGELOG.md` | Per-release breaking changes, deploy ordering, additions and fixes |
-| Improvement Backlog | `docs/IMPROVEMENT_BACKLOG.md` | Proposed and deferred library improvements |
 
 ---
 

{velocity_python-0.2.7 → velocity_python-0.2.8}/tests/test_payment_braintree_adapter.py

@@ -299,3 +299,70 @@ def test_generate_client_token_exhausted_raises_processor_error(monkeypatch):
     with pytest.raises(ProcessorError) as err:
         adapter.generate_client_token(attempts=2)
     assert "after 2 attempts" in str(err.value)
+
+
+def _declined_sale(**transaction):
+    return lambda params: SimpleNamespace(
+        is_success=False,
+        message="generic error",
+        transaction=SimpleNamespace(**transaction) if transaction else None,
+        errors=SimpleNamespace(deep_errors=[]),
+    )
+
+
+def test_charge_failure_carries_the_processor_verdict(monkeypatch):
+    """A hard decline will not be approved on retry; callers (recurring
+    billing) read Braintree's own processor_response_type instead of
+    guessing from the response text."""
+    adapter = build_adapter()
+    monkeypatch.setattr(
+        adapter.gateway.transaction,
+        "sale",
+        _declined_sale(
+            processor_response_text="Closed Card",
+            processor_response_code="2004",
+            processor_response_type="hard_declined",
+        ),
+    )
+
+    result = adapter.charge_stored_payment_method(
+        None, {"amount": 1050, "payment_method": "token_123"}
+    )
+
+    assert result["error_message"] == "Closed Card"
+    assert result["metadata"]["processor_response_type"] == "hard_declined"
+    assert result["metadata"]["processor_response_code"] == "2004"
+    assert result["metadata"]["processor_response_text"] == "Closed Card"
+
+
+def test_gateway_rejection_has_no_processor_verdict(monkeypatch):
+    adapter = build_adapter()
+    monkeypatch.setattr(adapter.gateway.transaction, "sale", _declined_sale())
+
+    result = adapter.charge_stored_payment_method(
+        None, {"amount": 1050, "payment_method": "token_123"}
+    )
+
+    assert result["success"] is False
+    assert "processor_response_type" not in result["metadata"]
+    assert result["metadata"]["braintree_errors"] == []
+
+
+def test_authorize_failure_carries_the_processor_verdict(monkeypatch):
+    adapter = build_adapter()
+    monkeypatch.setattr(
+        adapter.gateway.transaction,
+        "sale",
+        _declined_sale(
+            processor_response_text="Insufficient Funds",
+            processor_response_type="soft_declined",
+        ),
+    )
+
+    result = adapter.authorize_payment(
+        None, {"amount": 1050, "payment_method": "token_123"}
+    )
+
+    assert result["status"] == "failed"
+    assert result["metadata"]["processor_response_type"] == "soft_declined"
+    assert "processor_response_code" not in result["metadata"]

{velocity_python-0.2.7 → velocity_python-0.2.8}/tests/test_payment_stripe_adapter.py

@@ -797,3 +797,46 @@ def test_get_account_status_takes_owner_id_and_touches_no_app_table(
     mirrored.clear()
     adapter.get_account_status(NoAppTablesTx(), "acct_7")
     assert mirrored[0][1]["client_id"] is None
+
+
+def _card_error(decline_code):
+    return stripe.error.CardError(
+        "Your card was declined.",
+        None,
+        "card_declined",
+        json_body={
+            "error": {
+                "type": "card_error",
+                "code": "card_declined",
+                "decline_code": decline_code,
+                "message": "Your card was declined.",
+            }
+        },
+    )
+
+
+def test_charge_card_decline_carries_the_decline_code(adapter, monkeypatch):
+    """Recurring billing decides whether to retry a card from Stripe's
+    decline_code (lost_card, expired_card ... are never retried)."""
+
+    def decline(**kwargs):
+        raise _card_error("lost_card")
+
+    monkeypatch.setattr(
+        "velocity.payment.stripe_adapter.stripe.PaymentIntent.create", decline
+    )
+
+    result = adapter.charge_stored_payment_method(
+        None,
+        {
+            "amount": 1050,
+            "payment_method": "pm_123",
+            "customer_profile_id": "cus_123",
+            "processor_account_id": "acct_123",
+            "client_id": "client_1",
+        },
+    )
+
+    assert result["success"] is False
+    assert result["metadata"]["error_type"] == "CardError"
+    assert result["metadata"]["decline_code"] == "lost_card"