velocity-python 0.1.78__tar.gz → 0.1.79__tar.gz

{velocity_python-0.1.78 → velocity_python-0.1.79}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: velocity-python
-Version: 0.1.78
+Version: 0.1.79
 Summary: A rapid application development library for interfacing with data storage
 Author-email: Velocity Team <info@codeclubs.org>
 License-Expression: MIT

{velocity_python-0.1.78 → velocity_python-0.1.79}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "velocity-python"
-version = "0.1.78"
+version = "0.1.79"
 authors = [
   { name="Velocity Team", email="info@codeclubs.org" },
 ]

{velocity_python-0.1.78 → velocity_python-0.1.79}/src/velocity/__init__.py

@@ -1,4 +1,4 @@
-__version__ = version = "0.1.78"
+__version__ = version = "0.1.79"
 
 import importlib as _importlib
 

{velocity_python-0.1.78 → velocity_python-0.1.79}/src/velocity/payment/braintree_mirror.py

@@ -114,7 +114,10 @@ def _filtered_payload_for_table(table, payload: Dict[str, Any]) -> Dict[str, Any
 
 def _upsert(tx, table_name: str, payload: Dict[str, Any], key: Dict[str, Any]):
     table = _table(tx, table_name)
-    if not table:
+    # `is None`, NOT falsy: a velocity Table's truthiness is its row count
+    # (__len__), so `if not table` is True for an EMPTY table -- which would
+    # silently skip the first write to an empty mirror table (chicken-and-egg).
+    if table is None:
         return None
     payload = _filtered_payload_for_table(table, payload)
     table.upsert(payload, key)

{velocity_python-0.1.78 → velocity_python-0.1.79}/src/velocity/payment/stripe_mirror.py

@@ -50,7 +50,10 @@ def _table(tx, table_name: str):
 
 def _upsert(tx, table_name: str, payload: Dict[str, Any], key: Dict[str, Any]):
     table = _table(tx, table_name)
-    if not table:
+    # `is None`, NOT falsy: a velocity Table's truthiness is its row count
+    # (__len__), so `if not table` is True for an EMPTY table -- which would
+    # silently skip the first write to any empty mirror table (chicken-and-egg).
+    if table is None:
         return None
     table.upsert(payload, key)
     return payload
@@ -99,7 +102,10 @@ def sync_customer_from_stripe_account(tx, account: Any, client_id: Any):
     if not client_id:
         return None
     table = _table(tx, "customers")
-    if not table:
+    # `is None`, NOT falsy: a velocity Table's truthiness is its row count
+    # (__len__), so `if not table` is True for an EMPTY table -- which would
+    # silently skip the first write to any empty mirror table (chicken-and-egg).
+    if table is None:
         return None
     row = table.find({"client_id": client_id})
     if not row:

{velocity_python-0.1.78 → velocity_python-0.1.79}/src/velocity_python.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: velocity-python
-Version: 0.1.78
+Version: 0.1.79
 Summary: A rapid application development library for interfacing with data storage
 Author-email: Velocity Team <info@codeclubs.org>
 License-Expression: MIT

{velocity_python-0.1.78 → velocity_python-0.1.79}/src/velocity_python.egg-info/SOURCES.txt

@@ -184,6 +184,7 @@ tests/test_observability.py
 tests/test_payment_authorizenet_adapter.py
 tests/test_payment_braintree_adapter.py
 tests/test_payment_braintree_mirror.py
+tests/test_payment_mirror_empty_table.py
 tests/test_payment_profile_sorting.py
 tests/test_payment_stripe_adapter.py
 tests/test_pdf.py

velocity_python-0.1.79/tests/test_payment_mirror_empty_table.py

@@ -0,0 +1,58 @@
+"""Regression: mirror `_upsert` must write to an EMPTY table.
+
+A velocity ``Table``'s truthiness is its row count (``__len__``), so an empty
+table is falsy. The mirror guards must therefore test ``table is None``, not
+``if not table`` -- otherwise the FIRST write to any empty mirror table silently
+no-ops (chicken-and-egg: the table stays empty forever, so it never becomes
+truthy and never gets written). This bit the Stripe client-account sync: an
+empty ``stripe_accounts`` / ``client_payment_accounts`` could never be seeded.
+
+The prior FakeTable in the mirror tests did not implement ``__len__``, so it was
+always truthy and never exercised this path.
+"""
+from velocity.payment import braintree_mirror, stripe_mirror
+
+
+class EmptyTable:
+    """Models a real velocity Table whose truthiness is its row count: 0 -> falsy."""
+
+    def __init__(self):
+        self.upserts = []
+
+    def __len__(self):
+        return 0  # empty table -> bool(table) is False
+
+    def exists(self):
+        return True
+
+    def sys_columns(self):
+        return ["stripe_id", "client_id", "id", "amount", "status"]
+
+    def upsert(self, payload, key):
+        self.upserts.append((payload, key))
+
+
+class FakeTx:
+    def __init__(self, table):
+        self._table = table
+
+    def table(self, _name):
+        return self._table
+
+
+def test_stripe_mirror_upsert_writes_to_empty_table():
+    t = EmptyTable()
+    result = stripe_mirror._upsert(
+        FakeTx(t), "stripe_accounts", {"stripe_id": "acct_x"}, {"stripe_id": "acct_x"}
+    )
+    assert result is not None, "write to an empty table silently no-op'd"
+    assert len(t.upserts) == 1
+
+
+def test_braintree_mirror_upsert_writes_to_empty_table():
+    t = EmptyTable()
+    result = braintree_mirror._upsert(
+        FakeTx(t), "braintree_transaction", {"id": "txn_x", "amount": "1.00"}, {"id": "txn_x"}
+    )
+    assert result is not None, "write to an empty table silently no-op'd"
+    assert len(t.upserts) == 1